measured 2.4.0 → 2.5.0

data/test/support/always_true_cache.rb

@@ -0,0 +1,13 @@
+class AlwaysTrueCache
+  def exist?
+    true
+  end
+
+  def read
+    {}
+  end
+
+  def write(*)
+    nil
+  end
+end

data/test/support/subclasses.rb

@@ -0,0 +1,6 @@
+# Extract the subclasses that exist early on because other classes will get added by tests
+#   later on in execution and in an unpredictable order.
+class ActiveSupport::TestCase
+  cattr_accessor :measurable_subclasses
+  self.measurable_subclasses = Measured::Measurable.subclasses
+end

data/test/test_helper.rb

@@ -1,17 +1,18 @@
+require "pry" unless ENV["CI"]
 require "measured"
 require "minitest/reporters"
 require "minitest/autorun"
 require "mocha/setup"
-require "pry" unless ENV["CI"]
 
 ActiveSupport.test_order = :random
 
 Minitest::Reporters.use! [Minitest::Reporters::ProgressReporter.new(color: true)]
 
+require "support/subclasses"
 require "support/fake_system"
+require "support/always_true_cache"
 
 class ActiveSupport::TestCase
-
   protected
 
   def assert_close_bigdecimal exp, act, delta = BigDecimal('0.000001')

data/test/unit_system_builder_test.rb

@@ -54,7 +54,7 @@ class Measured::UnitSystemBuilderTest < ActiveSupport::TestCase
     end
 
     prefixes = Measured::UnitSystemBuilder::SI_PREFIXES.map { |short, _, _| "#{short}ft" }
-    prefixes += %w(in ft) 
+    prefixes += %w(in ft)
     assert_equal prefixes.sort, measurable.unit_names
   end
 
@@ -109,4 +109,24 @@ class Measured::UnitSystemBuilderTest < ActiveSupport::TestCase
     assert_equal (2240), measurable.unit_system.unit_for!(:long_ton).conversion_amount
     assert_equal "lb", measurable.unit_system.unit_for!(:long_ton).conversion_unit
   end
+
+  test "#cache sets no cache by default" do
+    measurable = Measured.build do
+      unit :m
+      unit :km, value: "1000 m"
+    end
+
+    refute_predicate measurable.unit_system, :cached?
+  end
+
+  test "#cache sets the class and args" do
+    measurable = Measured.build do
+      unit :m
+      unit :km, value: "1000 m"
+
+      cache AlwaysTrueCache
+    end
+
+    assert_predicate measurable.unit_system, :cached?
+  end
 end

data/test/unit_system_test.rb

@@ -99,4 +99,18 @@ class Measured::UnitSystemTest < ActiveSupport::TestCase
   test "#convert handles the same unit" do
     assert_equal 2, @conversion.convert(2, from: @unit_in, to: @unit_in)
   end
+
+  test "#update_cache calls the builder" do
+    Measured::ConversionTableBuilder.any_instance.expects(:update_cache)
+    @conversion.update_cache
+  end
+
+  test "#cached? calls the builder and is false" do
+    refute_predicate @conversion, :cached?
+  end
+
+  test "#cached? calls the builder and is true" do
+    conversion = Measured::UnitSystem.new([@unit_m, @unit_in, @unit_ft], cache: { class: AlwaysTrueCache })
+    assert_predicate conversion, :cached?
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: measured
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.5.0
 platform: ruby
 authors:
 - Kevin McPhillips
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-24 00:00:00.000000000 Z
+date: 2019-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -110,11 +110,20 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- cache/.keep
+- cache/length.json
+- cache/volume.json
+- cache/weight.json
 - dev.yml
-- gemfiles/activesupport-4.2.gemfile
+- gemfiles/activesupport-5.0.gemfile
+- gemfiles/activesupport-5.1.gemfile
+- gemfiles/activesupport-6.0.gemfile
 - lib/measured.rb
 - lib/measured/arithmetic.rb
 - lib/measured/base.rb
+- lib/measured/cache/json.rb
+- lib/measured/cache/json_writer.rb
+- lib/measured/cache/null.rb
 - lib/measured/conversion_table_builder.rb
 - lib/measured/measurable.rb
 - lib/measured/parser.rb
@@ -128,10 +137,16 @@ files:
 - measured.gemspec
 - shipit.rubygems.yml
 - test/arithmetic_test.rb
+- test/cache/json_test.rb
+- test/cache/json_writer_test.rb
+- test/cache/null_test.rb
+- test/cache_consistency_test.rb
 - test/conversion_table_builder_test.rb
 - test/measurable_test.rb
 - test/parser_test.rb
+- test/support/always_true_cache.rb
 - test/support/fake_system.rb
+- test/support/subclasses.rb
 - test/test_helper.rb
 - test/unit_error_test.rb
 - test/unit_system_builder_test.rb
@@ -160,16 +175,22 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Encapsulate measurements with their units in Ruby
 test_files:
 - test/arithmetic_test.rb
+- test/cache/json_test.rb
+- test/cache/json_writer_test.rb
+- test/cache/null_test.rb
+- test/cache_consistency_test.rb
 - test/conversion_table_builder_test.rb
 - test/measurable_test.rb
 - test/parser_test.rb
+- test/support/always_true_cache.rb
 - test/support/fake_system.rb
+- test/support/subclasses.rb
 - test/test_helper.rb
 - test/unit_error_test.rb
 - test/unit_system_builder_test.rb