mdarby-restful_acl 2.0 → 2.0.1

data/README.textile

@@ -73,7 +73,7 @@ Define a parent resource (if one exists) by using the <b>my_mom</b> method, and
   end
 </pre>
 
-H4. View Helpers
+h4. View Helpers
 
 There are five view helpers also included in RESTful_ACL: #indexable, #creatable, #readable, #updatable, and #deletable. These enable you to do nifty things like:
 <pre>

data/lib/restful_acl_controller.rb

@@ -19,6 +19,7 @@ module RestfulAclController
           object = klass.find(params[:id])
           parent = object.get_mom rescue nil
         else
+          # No object was requested, so we need to go to the URI to figure out the parent
           object = nil
           parent = get_parent_from_request_uri(klass) if klass.has_parent?
         end
@@ -33,6 +34,9 @@ module RestfulAclController
           else object.is_readable_by(current_user, parent)
         end
 
+      rescue NoMethodError => e
+        # Misconfiguration: A RESTful_ACL specific method is missing.
+        raise_error(klass, e)
       rescue
         # Failsafe: If any funny business is going on, log and redirect
         routing_error
@@ -41,6 +45,20 @@ module RestfulAclController
 
     private
 
+      def get_method_from_error(error)
+        error.message.gsub('`', "'").split("'").at(1)
+      end
+
+      def raise_error(klass, error)
+        method = get_method_from_error(error)
+        message = (is_class_method?(method)) ? "#{klass}#self.#{method}" : "#{klass}##{method}"
+        raise NoMethodError, "[RESTful_ACL] #{message}(user, parent = nil) seems to be missing?"
+      end
+
+      def is_class_method?(method)
+        method =~ /(indexable|creatable)/
+      end
+
       def get_parent_from_request_uri(child_klass)
         parent_klass = child_klass.mom.to_s
         bits         = request.request_uri.split('/')
@@ -54,14 +72,14 @@ module RestfulAclController
       end
 
       def permission_denied
-        logger.info("[ACL] Permission denied to %s at %s for %s" %
+        logger.info("[RESTful_ACL] Permission denied to %s at %s for %s" %
         [(logged_in? ? current_user.login : 'guest'), Time.now, request.request_uri])
 
         redirect_to denied_url
       end
 
       def routing_error
-        logger.info("[ACL] Routing error by %s at %s for %s" %
+        logger.info("[RESTful_ACL] Routing error by %s at %s for %s" %
         [(logged_in? ? current_user.login : 'guest'), Time.now, request.request_uri])
 
         redirect_to error_url

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: mdarby-restful_acl
 version: !ruby/object:Gem::Version 
-  version: "2.0"
+  version: 2.0.1
 platform: ruby
 authors: 
 - Matt Darby