mcollective-client 2.9.1 → 2.10.0

data/spec/unit/mcollective/connector/activemq_spec.rb

@@ -65,6 +65,7 @@ module MCollective
         Activemq.any_instance.stubs(:get_option).with("activemq.initial_reconnect_delay", 0.01).returns(0.01)
         Activemq.any_instance.stubs(:get_option).with("activemq.back_off_multiplier", 2).returns(2)
         Activemq.any_instance.stubs(:get_option).with("activemq.max_reconnect_delay", 30.0).returns(30.0)
+        Activemq.any_instance.stubs(:get_bool_option).with("activemq.agents_multiplex", "false").returns(true)
         c = Activemq.new
         c.instance_variable_set("@subscriptions", subscription)
         c.instance_variable_set("@connection", connection)
@@ -665,8 +666,13 @@ module MCollective
       end
 
       describe "#make_target" do
-        it "should create correct targets" do
+        it "should create correct targets if agents_multiplex is false" do
+          # realize the connector let so that we can unstub it
+          connector
+          Activemq.any_instance.unstub(:get_bool_option)
+          Activemq.any_instance.stubs(:get_bool_option).with("activemq.agents_multiplex", "false").returns(false)
           Client.stubs(:request_sequence).returns(42)
+
           connector.make_target("test", :reply, "mcollective").should == {
             :name => "/queue/mcollective.reply.rspec_#{$$}.42",
             :headers => {},
@@ -700,6 +706,46 @@ module MCollective
           }
         end
 
+        it "should create correct targets if agents_multiplex is true" do
+          # realize the connector let so that we can unstub it
+          connector
+          Activemq.any_instance.unstub(:get_bool_option)
+          Activemq.any_instance.stubs(:get_bool_option).with("activemq.agents_multiplex", "false").returns(true)
+          Client.stubs(:request_sequence).returns(42)
+
+          connector.make_target("test", :reply, "mcollective").should == {
+            :name => "/queue/mcollective.reply.rspec_#{$$}.42",
+            :headers => {},
+            :id => "/queue/mcollective.reply.rspec_#{$$}.42",
+          }
+
+          connector.make_target("test", :broadcast, "mcollective").should == {
+            :name => "/topic/mcollective.agents",
+            :headers => {},
+            :id => "/topic/mcollective.agents",
+          }
+
+          connector.make_target("test", :request, "mcollective").should == {
+            :name => "/topic/mcollective.agents",
+            :headers => {},
+            :id => "/topic/mcollective.agents",
+          }
+
+          connector.make_target("test", :direct_request, "mcollective").should == {
+            :name => "/queue/mcollective.nodes",
+            :headers => {},
+            :id => "/queue/mcollective.nodes",
+          }
+
+          connector.make_target("test", :directed, "mcollective").should == {
+            :name => "/queue/mcollective.nodes",
+            :headers => {
+              "selector" => "mc_identity = 'rspec'",
+            },
+            :id => "mcollective_directed_to_identity",
+          }
+        end
+
         it "should raise an error for unknown collectives" do
           expect {
             connector.make_target("test", :broadcast, "foo")

data/spec/unit/mcollective/connector/rabbitmq_spec.rb

@@ -79,6 +79,7 @@ module MCollective
         logger
         Config.stubs(:instance).returns(config)
         Rabbitmq.any_instance.stubs(:get_bool_option).with("rabbitmq.use_reply_exchange", false).returns(false)
+        Rabbitmq.any_instance.stubs(:get_bool_option).with("rabbitmq.agents_multiplex", "false").returns(false)
       end
 
       describe "#initialize" do
@@ -617,7 +618,12 @@ module MCollective
 
       describe "#make_target" do
         context 'rabbitmq.use_reply_exchange' do
-          context 'default (false)' do
+          context 'default (false) default (false)' do
+            before :each do
+              Rabbitmq.any_instance.stubs(:get_bool_option).with("rabbitmq.use_reply_exchange", false).returns(false)
+              Rabbitmq.any_instance.stubs(:get_bool_option).with("rabbitmq.agents_multiplex", "false").returns(false)
+            end
+
             it "should create correct targets" do
               connector.make_target("test", :reply, "mcollective").should eq({
                 :name => "/temp-queue/mcollective_reply_test",
@@ -652,9 +658,10 @@ module MCollective
             end
           end
 
-          context 'true' do
+          context 'true false' do
             before :each do
               Rabbitmq.any_instance.stubs(:get_bool_option).with("rabbitmq.use_reply_exchange", false).returns(true)
+              Rabbitmq.any_instance.stubs(:get_bool_option).with("rabbitmq.agents_multiplex", "false").returns(false)
             end
 
             it "should create correct targets" do
@@ -691,6 +698,86 @@ module MCollective
               })
             end
           end
+
+          context 'true true' do
+            before :each do
+              Rabbitmq.any_instance.stubs(:get_bool_option).with("rabbitmq.use_reply_exchange", false).returns(true)
+              Rabbitmq.any_instance.stubs(:get_bool_option).with("rabbitmq.agents_multiplex", "false").returns(true)
+            end
+
+            it "should create correct targets" do
+              Client.stubs(:request_sequence).returns(42)
+              connector.make_target("test", :reply, "mcollective").should eq({
+                :name => "/exchange/mcollective_reply/rspec_#{$$}_42",
+                :headers => {},
+                :id => "mcollective_test_replies",
+              })
+              connector.make_target("test", :broadcast, "mcollective").should eq({
+                :name => "/exchange/mcollective_broadcast",
+                :headers => { "reply-to" => "/exchange/mcollective_reply/rspec_#{$$}_42" },
+                :id => "mcollective_broadcast"
+              })
+              connector.make_target("test", :request, "mcollective").should eq({
+                :name => "/exchange/mcollective_broadcast",
+                :headers => { "reply-to" => "/exchange/mcollective_reply/rspec_#{$$}_42" },
+                :id => "mcollective_broadcast",
+              })
+              connector.make_target("test", :direct_request, "mcollective", nil, "rspec").should eq({
+                :headers => { "reply-to" => "/exchange/mcollective_reply/rspec_#{$$}_42" },
+                :name => "/exchange/mcollective_directed/rspec",
+                :id => nil
+              })
+              connector.make_target("test", :directed, "mcollective").should eq({
+                :name => "/exchange/mcollective_directed/rspec",
+                :headers => {},
+                :id => "mcollective_rspec_directed_to_identity",
+              })
+              connector.make_target("test", :request, "mcollective", "/topic/rspec", "rspec").should eq({
+                :headers => { "reply-to" => "/topic/rspec" },
+                :name => "/exchange/mcollective_broadcast",
+                :id => "mcollective_broadcast",
+              })
+            end
+          end
+
+          context 'false (default) true' do
+            before :each do
+              Rabbitmq.any_instance.stubs(:get_bool_option).with("rabbitmq.use_reply_exchange", false).returns(false)
+              Rabbitmq.any_instance.stubs(:get_bool_option).with("rabbitmq.agents_multiplex", "false").returns(true)
+            end
+            it "should create correct targets" do
+              connector.make_target("test", :reply, "mcollective").should eq({
+                :name => "/temp-queue/mcollective_reply_test",
+                :headers => {},
+                :id => "mcollective_test_replies",
+              })
+              connector.make_target("test", :broadcast, "mcollective").should eq({
+                :name => "/exchange/mcollective_broadcast",
+                :headers => { "reply-to" => "/temp-queue/mcollective_reply_test" },
+                :id => "mcollective_broadcast"
+              })
+              connector.make_target("test", :request, "mcollective").should eq({
+                :name => "/exchange/mcollective_broadcast",
+                :headers => { "reply-to" => "/temp-queue/mcollective_reply_test" },
+                :id => "mcollective_broadcast",
+              })
+              connector.make_target("test", :direct_request, "mcollective", nil, "rspec").should eq({
+                :headers => { "reply-to" => "/temp-queue/mcollective_reply_test" },
+                :name => "/exchange/mcollective_directed/rspec",
+                :id => nil
+              })
+              connector.make_target("test", :directed, "mcollective").should eq({
+                :name => "/exchange/mcollective_directed/rspec",
+                :headers => {},
+                :id => "mcollective_rspec_directed_to_identity",
+              })
+              connector.make_target("test", :request, "mcollective", "/topic/rspec", "rspec").should eq({
+                :headers => { "reply-to" => "/topic/rspec" },
+                :name => "/exchange/mcollective_broadcast",
+                :id => "mcollective_broadcast",
+              })
+            end
+          end
         end
 
         it "should raise an error for unknown collectives" do

data/spec/unit/mcollective/rpc/client_spec.rb

@@ -33,11 +33,48 @@ module MCollective
 
         @stderr = StringIO.new
         @stdout = StringIO.new
+        @stdin = StringIO.new
 
         @client = Client.new("foo", {:options => {:filter => Util.empty_filter, :config => "/nonexisting"}})
         @client.stubs(:ddl).returns(ddl)
       end
 
+      describe "#detect_and_set_stdin_discovery" do
+        before(:each) do
+          @client = Client.new("foo", {:options => {:filter => Util.empty_filter, :config => "/nonexisting", :stdin => @stdin}})
+        end
+
+        it "should do nothing when a specific discovery method is set" do
+          @client.stubs(:default_discovery_method).returns(false)
+          @client.expects(:discovery_method).never
+          @client.detect_and_set_stdin_discovery
+        end
+
+        it "should set the stdin method when something is on STDIN" do
+          @client.stubs(:default_discovery_method).returns(true)
+          @stdin.expects(:tty?).returns(false)
+          @stdin.expects(:eof?).returns(false)
+          @client.detect_and_set_stdin_discovery
+          expect(@client.discovery_method).to eq("stdin")
+          expect(@client.discovery_options).to eq(["auto"])
+        end
+
+        it "should not set STDIN discovery when interactive" do
+          @client.stubs(:default_discovery_method).returns(true)
+          @stdin.expects(:tty?).returns(true)
+          @client.detect_and_set_stdin_discovery
+          expect(@client.discovery_method).to eq("mc")
+        end
+
+        it "should not set STDIN discovery when nothing on STDIN" do
+          @client.stubs(:default_discovery_method).returns(true)
+          @stdin.expects(:tty?).returns(false)
+          @stdin.expects(:eof?).returns(true)
+          @client.detect_and_set_stdin_discovery
+          expect(@client.discovery_method).to eq("mc")
+        end
+      end
+
       describe "#initialize" do
         it "should fail for missing DDLs" do
           DDL.stubs(:new).raises("DDL failure")
@@ -737,7 +774,7 @@ module MCollective
           msg.expects(:create_reqid).returns("823a3419a0975c3facbde121f72ab61f")
           msg.expects(:requestid=).with("823a3419a0975c3facbde121f72ab61f").times(10)
 
-          stats = {:noresponsefrom => [], :responses => 0, :blocktime => 0, :totaltime => 0, :discoverytime => 0, :requestid => "823a3419a0975c3facbde121f72ab61f"}
+          stats = {:noresponsefrom => [], :unexpectedresponsefrom => [], :responses => 0, :blocktime => 0, :totaltime => 0, :discoverytime => 0, :requestid => "823a3419a0975c3facbde121f72ab61f"}
 
           Message.expects(:new).with('req', nil, {:type => :direct_request, :agent => 'foo', :filter => nil, :options => {}, :collective => 'mcollective'}).returns(msg).times(10)
           client.expects(:new_request).returns("req")
@@ -765,7 +802,7 @@ module MCollective
           msg.expects(:create_reqid).returns("823a3419a0975c3facbde121f72ab61f")
           msg.expects(:requestid=).with("823a3419a0975c3facbde121f72ab61f").times(10)
 
-          stats = {:noresponsefrom => [], :responses => 0, :blocktime => 0, :totaltime => 0, :discoverytime => 0, :requestid => "823a3419a0975c3facbde121f72ab61f"}
+          stats = {:noresponsefrom => [], :unexpectedresponsefrom => [], :responses => 0, :blocktime => 0, :totaltime => 0, :discoverytime => 0, :requestid => "823a3419a0975c3facbde121f72ab61f"}
 
           Progress.expects(:new).never
 

data/spec/unit/mcollective/rpc/helpers_spec.rb

@@ -33,6 +33,12 @@ module MCollective
 
           Helpers.extract_hosts_from_json(senders).should == ["sender1", "sender3"]
         end
+
+        it "should support puppet query output" do
+          senders = [{"certname" => "sender1"}, {"certname" => "sender3"}, {"certname" => "sender1"}].to_json
+
+          Helpers.extract_hosts_from_json(senders).should == ["sender1", "sender3"]
+        end
       end
 
       describe "#extract_hosts_from_array" do

data/spec/unit/mcollective/rpc/stats_spec.rb

@@ -11,6 +11,7 @@ module MCollective
                      :blocktime => 0,
                      :failcount => 0,
                      :noresponsefrom => [],
+                     :unexpectedresponsefrom => [],
                      :responses => 0,
                      :totaltime => 0,
                      :discovered => 0,
@@ -113,7 +114,7 @@ module MCollective
       describe "#client_stats=" do
         it "should store stats correctly" do
           data = {}
-          keys = [:noresponsefrom, :responses, :starttime, :blocktime, :totaltime, :discoverytime]
+          keys = [:noresponsefrom, :unexpectedresponsefrom, :responses, :starttime, :blocktime, :totaltime, :discoverytime]
           keys.each {|k| data[k] = k}
 
           @stats.client_stats = data
@@ -125,7 +126,7 @@ module MCollective
 
         it "should not store discovery time if it was already stored" do
           data = {}
-          keys = [:noresponsefrom, :responses, :starttime, :blocktime, :totaltime, :discoverytime]
+          keys = [:noresponsefrom, :unexpectedresponsefrom, :responses, :starttime, :blocktime, :totaltime, :discoverytime]
           keys.each {|k| data[k] = k}
 
           Time.stubs(:now).returns(Time.at(1300031826))
@@ -231,6 +232,29 @@ module MCollective
           @stats.noresponsefrom.should == ["three"]
         end
 
+        it "should calculate unexpected responses correctly" do
+          Time.stubs(:now).returns(Time.at(1300031824))
+          @stats.time_discovery(:start)
+
+          Time.stubs(:now).returns(Time.at(1300031825))
+          @stats.time_discovery(:end)
+
+          Time.stubs(:now).returns(Time.at(1300031826))
+          @stats.time_block_execution(:start)
+
+          Time.stubs(:now).returns(Time.at(1300031827))
+          @stats.time_block_execution(:end)
+
+          @stats.discovered_agents(["one", "two"])
+          @stats.node_responded("three")
+          @stats.node_responded("one")
+          @stats.node_responded("two")
+
+          @stats.finish_request
+
+          @stats.unexpectedresponsefrom.should == ["three"]
+        end
+
         it "should recover from failure correctly" do
           Time.stubs(:now).returns(Time.at(1300031824))
           @stats.time_discovery(:start)
@@ -249,6 +273,7 @@ module MCollective
           @stats.finish_request
 
           @stats.noresponsefrom.should == []
+          @stats.unexpectedresponsefrom.should == []
           @stats.totaltime.should == 0
         end
       end
@@ -285,6 +310,25 @@ module MCollective
         end
       end
 
+      describe "#unexpected_response_report" do
+        it "should create an empty report if all responding nodes were discovered" do
+          @stats.discovered_agents ["foo"]
+          @stats.node_responded "foo"
+          @stats.finish_request
+
+          @stats.unexpected_response_report.should == ""
+        end
+
+        it "should list all nodes that did not respond" do
+          @stats.discovered_agents []
+          @stats.node_responded "foo"
+          @stats.node_responded "bar"
+          @stats.finish_request
+
+          @stats.unexpected_response_report.should match(Regexp.new(/Unexpected response from.+bar\s+foo/m))
+        end
+      end
+
       describe "#text_for_aggregates" do
         let(:aggregate){mock()}
 

metadata

@@ -1,20 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: mcollective-client
 version: !ruby/object:Gem::Version
-  version: 2.9.1
-  prerelease: 
+  version: 2.10.0
 platform: ruby
 authors:
 - Puppet Labs
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-02 00:00:00.000000000 Z
+date: 2017-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: systemu
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -30,7 +27,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -38,7 +34,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -46,7 +41,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: stomp
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -54,7 +48,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -66,268 +59,269 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- lib/mcollective/rpc.rb
-- lib/mcollective/monkey_patches.rb
-- lib/mcollective/connector.rb
-- lib/mcollective/pluginmanager.rb
-- lib/mcollective/client.rb
-- lib/mcollective/rpc/helpers.rb
-- lib/mcollective/rpc/client.rb
-- lib/mcollective/rpc/progress.rb
-- lib/mcollective/rpc/reply.rb
-- lib/mcollective/rpc/audit.rb
-- lib/mcollective/rpc/result.rb
-- lib/mcollective/rpc/agent.rb
-- lib/mcollective/rpc/request.rb
-- lib/mcollective/rpc/stats.rb
-- lib/mcollective/rpc/actionrunner.rb
-- lib/mcollective/facts/yaml_facts.rb
-- lib/mcollective/facts/base.rb
-- lib/mcollective/security.rb
-- lib/mcollective/log.rb
-- lib/mcollective/matcher.rb
-- lib/mcollective/unix_daemon.rb
-- lib/mcollective/application/rpc.rb
-- lib/mcollective/application/plugin.rb
-- lib/mcollective/application/ping.rb
-- lib/mcollective/application/completion.rb
-- lib/mcollective/application/describe_filter.rb
-- lib/mcollective/application/facts.rb
-- lib/mcollective/application/help.rb
-- lib/mcollective/application/inventory.rb
-- lib/mcollective/application/find.rb
-- lib/mcollective/validator/regex_validator.ddl
-- lib/mcollective/validator/typecheck_validator.ddl
-- lib/mcollective/validator/shellsafe_validator.ddl
-- lib/mcollective/validator/ipv6address_validator.ddl
-- lib/mcollective/validator/length_validator.ddl
-- lib/mcollective/validator/shellsafe_validator.rb
-- lib/mcollective/validator/ipv4address_validator.ddl
-- lib/mcollective/validator/ipv4address_validator.rb
-- lib/mcollective/validator/array_validator.ddl
-- lib/mcollective/validator/length_validator.rb
-- lib/mcollective/validator/regex_validator.rb
-- lib/mcollective/validator/ipv6address_validator.rb
-- lib/mcollective/validator/array_validator.rb
-- lib/mcollective/validator/typecheck_validator.rb
-- lib/mcollective/windows_daemon.rb
-- lib/mcollective/aggregate/sum.ddl
+- bin/mco
+- lib/mcollective.rb
+- lib/mcollective/agent.rb
+- lib/mcollective/agent/discovery.rb
+- lib/mcollective/agent/rpcutil.ddl
+- lib/mcollective/agent/rpcutil.rb
+- lib/mcollective/agents.rb
+- lib/mcollective/aggregate.rb
 - lib/mcollective/aggregate/average.ddl
-- lib/mcollective/aggregate/summary.ddl
+- lib/mcollective/aggregate/average.rb
+- lib/mcollective/aggregate/base.rb
+- lib/mcollective/aggregate/result.rb
+- lib/mcollective/aggregate/result/base.rb
 - lib/mcollective/aggregate/result/collection_result.rb
 - lib/mcollective/aggregate/result/numeric_result.rb
-- lib/mcollective/aggregate/result/base.rb
+- lib/mcollective/aggregate/sum.ddl
 - lib/mcollective/aggregate/sum.rb
-- lib/mcollective/aggregate/result.rb
-- lib/mcollective/aggregate/average.rb
+- lib/mcollective/aggregate/summary.ddl
 - lib/mcollective/aggregate/summary.rb
-- lib/mcollective/aggregate/base.rb
-- lib/mcollective/optionparser.rb
-- lib/mcollective/ssl.rb
-- lib/mcollective/runnerstats.rb
-- lib/mcollective/shell.rb
-- lib/mcollective/validator.rb
-- lib/mcollective/vendor/require_vendored.rb
-- lib/mcollective/matcher/parser.rb
-- lib/mcollective/matcher/scanner.rb
-- lib/mcollective/audit/logfile.rb
-- lib/mcollective/config.rb
-- lib/mcollective/message.rb
 - lib/mcollective/application.rb
-- lib/mcollective/pluginpackager.rb
-- lib/mcollective/facts.rb
-- lib/mcollective/aggregate.rb
-- lib/mcollective/cache.rb
-- lib/mcollective/exceptions.rb
-- lib/mcollective/registration/agentlist.rb
-- lib/mcollective/registration/base.rb
-- lib/mcollective/discovery/mc.rb
-- lib/mcollective/discovery/mc.ddl
-- lib/mcollective/discovery/flatfile.ddl
-- lib/mcollective/discovery/stdin.ddl
-- lib/mcollective/discovery/stdin.rb
-- lib/mcollective/discovery/flatfile.rb
+- lib/mcollective/application/completion.rb
+- lib/mcollective/application/describe_filter.rb
+- lib/mcollective/application/facts.rb
+- lib/mcollective/application/find.rb
+- lib/mcollective/application/help.rb
+- lib/mcollective/application/inventory.rb
+- lib/mcollective/application/ping.rb
+- lib/mcollective/application/plugin.rb
+- lib/mcollective/application/rpc.rb
 - lib/mcollective/applications.rb
-- lib/mcollective/generators.rb
-- lib/mcollective/data/fact_data.ddl
-- lib/mcollective/data/agent_data.rb
-- lib/mcollective/data/collective_data.rb
+- lib/mcollective/audit/logfile.rb
+- lib/mcollective/cache.rb
+- lib/mcollective/client.rb
+- lib/mcollective/config.rb
+- lib/mcollective/connector.rb
+- lib/mcollective/connector/activemq.ddl
+- lib/mcollective/connector/activemq.rb
+- lib/mcollective/connector/base.rb
+- lib/mcollective/connector/rabbitmq.ddl
+- lib/mcollective/connector/rabbitmq.rb
+- lib/mcollective/data.rb
 - lib/mcollective/data/agent_data.ddl
-- lib/mcollective/data/result.rb
+- lib/mcollective/data/agent_data.rb
+- lib/mcollective/data/base.rb
 - lib/mcollective/data/collective_data.ddl
+- lib/mcollective/data/collective_data.rb
+- lib/mcollective/data/fact_data.ddl
 - lib/mcollective/data/fact_data.rb
 - lib/mcollective/data/fstat_data.ddl
 - lib/mcollective/data/fstat_data.rb
-- lib/mcollective/data/base.rb
+- lib/mcollective/data/result.rb
+- lib/mcollective/ddl.rb
+- lib/mcollective/ddl/agentddl.rb
+- lib/mcollective/ddl/base.rb
 - lib/mcollective/ddl/dataddl.rb
 - lib/mcollective/ddl/discoveryddl.rb
 - lib/mcollective/ddl/validatorddl.rb
-- lib/mcollective/ddl/agentddl.rb
-- lib/mcollective/ddl/base.rb
-- lib/mcollective/data.rb
-- lib/mcollective/logger/file_logger.rb
-- lib/mcollective/logger/console_logger.rb
-- lib/mcollective/logger/syslog_logger.rb
-- lib/mcollective/logger/base.rb
-- lib/mcollective/registration.rb
 - lib/mcollective/discovery.rb
-- lib/mcollective/util.rb
+- lib/mcollective/discovery/flatfile.ddl
+- lib/mcollective/discovery/flatfile.rb
+- lib/mcollective/discovery/mc.ddl
+- lib/mcollective/discovery/mc.rb
+- lib/mcollective/discovery/stdin.ddl
+- lib/mcollective/discovery/stdin.rb
+- lib/mcollective/exceptions.rb
+- lib/mcollective/facts.rb
+- lib/mcollective/facts/base.rb
+- lib/mcollective/facts/yaml_facts.rb
+- lib/mcollective/generators.rb
+- lib/mcollective/generators/agent_generator.rb
+- lib/mcollective/generators/base.rb
+- lib/mcollective/generators/data_generator.rb
+- lib/mcollective/generators/templates/action_snippet.erb
+- lib/mcollective/generators/templates/data_input_snippet.erb
+- lib/mcollective/generators/templates/ddl.erb
+- lib/mcollective/generators/templates/plugin.erb
+- lib/mcollective/log.rb
 - lib/mcollective/logger.rb
+- lib/mcollective/logger/base.rb
+- lib/mcollective/logger/console_logger.rb
+- lib/mcollective/logger/file_logger.rb
+- lib/mcollective/logger/syslog_logger.rb
+- lib/mcollective/matcher.rb
+- lib/mcollective/matcher/parser.rb
+- lib/mcollective/matcher/scanner.rb
+- lib/mcollective/message.rb
+- lib/mcollective/monkey_patches.rb
+- lib/mcollective/optionparser.rb
+- lib/mcollective/pluginmanager.rb
+- lib/mcollective/pluginpackager.rb
 - lib/mcollective/pluginpackager/agent_definition.rb
+- lib/mcollective/pluginpackager/debpackage_packager.rb
+- lib/mcollective/pluginpackager/modulepackage_packager.rb
+- lib/mcollective/pluginpackager/ospackage_packager.rb
+- lib/mcollective/pluginpackager/rpmpackage_packager.rb
+- lib/mcollective/pluginpackager/standard_definition.rb
+- lib/mcollective/pluginpackager/templates/debian/Makefile.erb
+- lib/mcollective/pluginpackager/templates/debian/changelog.erb
 - lib/mcollective/pluginpackager/templates/debian/compat.erb
 - lib/mcollective/pluginpackager/templates/debian/control.erb
-- lib/mcollective/pluginpackager/templates/debian/rules.erb
-- lib/mcollective/pluginpackager/templates/debian/changelog.erb
-- lib/mcollective/pluginpackager/templates/debian/Makefile.erb
 - lib/mcollective/pluginpackager/templates/debian/copyright.erb
+- lib/mcollective/pluginpackager/templates/debian/rules.erb
+- lib/mcollective/pluginpackager/templates/module/Modulefile.erb
 - lib/mcollective/pluginpackager/templates/module/README.md.erb
 - lib/mcollective/pluginpackager/templates/module/_manifest.pp.erb
-- lib/mcollective/pluginpackager/templates/module/Modulefile.erb
 - lib/mcollective/pluginpackager/templates/redhat/rpm_spec.erb
-- lib/mcollective/pluginpackager/standard_definition.rb
-- lib/mcollective/pluginpackager/rpmpackage_packager.rb
-- lib/mcollective/pluginpackager/debpackage_packager.rb
-- lib/mcollective/pluginpackager/ospackage_packager.rb
-- lib/mcollective/pluginpackager/modulepackage_packager.rb
-- lib/mcollective/agent.rb
-- lib/mcollective/agents.rb
-- lib/mcollective/agent/discovery.rb
-- lib/mcollective/agent/rpcutil.rb
-- lib/mcollective/agent/rpcutil.ddl
-- lib/mcollective/ddl.rb
-- lib/mcollective/connector/activemq.rb
-- lib/mcollective/connector/rabbitmq.rb
-- lib/mcollective/connector/rabbitmq.ddl
-- lib/mcollective/connector/activemq.ddl
-- lib/mcollective/connector/base.rb
-- lib/mcollective/generators/agent_generator.rb
-- lib/mcollective/generators/templates/action_snippet.erb
-- lib/mcollective/generators/templates/ddl.erb
-- lib/mcollective/generators/templates/data_input_snippet.erb
-- lib/mcollective/generators/templates/plugin.erb
-- lib/mcollective/generators/data_generator.rb
-- lib/mcollective/generators/base.rb
-- lib/mcollective/vendor.rb
-- lib/mcollective/security/ssl.rb
+- lib/mcollective/registration.rb
+- lib/mcollective/registration/agentlist.rb
+- lib/mcollective/registration/base.rb
+- lib/mcollective/rpc.rb
+- lib/mcollective/rpc/actionrunner.rb
+- lib/mcollective/rpc/agent.rb
+- lib/mcollective/rpc/audit.rb
+- lib/mcollective/rpc/client.rb
+- lib/mcollective/rpc/helpers.rb
+- lib/mcollective/rpc/progress.rb
+- lib/mcollective/rpc/reply.rb
+- lib/mcollective/rpc/request.rb
+- lib/mcollective/rpc/result.rb
+- lib/mcollective/rpc/stats.rb
+- lib/mcollective/runnerstats.rb
+- lib/mcollective/security.rb
 - lib/mcollective/security/aes_security.rb
-- lib/mcollective/security/psk.rb
 - lib/mcollective/security/base.rb
-- lib/mcollective.rb
-- bin/mco
-- spec/fixtures/util/3.out
+- lib/mcollective/security/psk.rb
+- lib/mcollective/security/ssl.rb
+- lib/mcollective/shell.rb
+- lib/mcollective/ssl.rb
+- lib/mcollective/unix_daemon.rb
+- lib/mcollective/util.rb
+- lib/mcollective/validator.rb
+- lib/mcollective/validator/array_validator.ddl
+- lib/mcollective/validator/array_validator.rb
+- lib/mcollective/validator/ipv4address_validator.ddl
+- lib/mcollective/validator/ipv4address_validator.rb
+- lib/mcollective/validator/ipv6address_validator.ddl
+- lib/mcollective/validator/ipv6address_validator.rb
+- lib/mcollective/validator/length_validator.ddl
+- lib/mcollective/validator/length_validator.rb
+- lib/mcollective/validator/regex_validator.ddl
+- lib/mcollective/validator/regex_validator.rb
+- lib/mcollective/validator/shellsafe_validator.ddl
+- lib/mcollective/validator/shellsafe_validator.rb
+- lib/mcollective/validator/typecheck_validator.ddl
+- lib/mcollective/validator/typecheck_validator.rb
+- lib/mcollective/vendor.rb
+- lib/mcollective/vendor/require_vendored.rb
+- lib/mcollective/windows_daemon.rb
+- spec/Rakefile
+- spec/fixtures/application/test.rb
+- spec/fixtures/test-cert.pem
+- spec/fixtures/test-private.pem
+- spec/fixtures/test-public.pem
 - spec/fixtures/util/1.in
-- spec/fixtures/util/4.in
 - spec/fixtures/util/1.out
-- spec/fixtures/util/3.in
-- spec/fixtures/util/4.out
 - spec/fixtures/util/2.in
 - spec/fixtures/util/2.out
-- spec/fixtures/application/test.rb
-- spec/fixtures/test-cert.pem
-- spec/fixtures/test-public.pem
-- spec/fixtures/test-private.pem
+- spec/fixtures/util/3.in
+- spec/fixtures/util/3.out
+- spec/fixtures/util/4.in
+- spec/fixtures/util/4.out
 - spec/monkey_patches/instance_variable_defined.rb
 - spec/spec.opts
-- spec/Rakefile
-- spec/unit/mcollective/application_spec.rb
-- spec/unit/mcollective/runnerstats_spec.rb
-- spec/unit/mcollective/validator_spec.rb
-- spec/unit/mcollective/rpc/agent_spec.rb
-- spec/unit/mcollective/rpc/helpers_spec.rb
-- spec/unit/mcollective/rpc/stats_spec.rb
-- spec/unit/mcollective/rpc/actionrunner_spec.rb
-- spec/unit/mcollective/rpc/request_spec.rb
-- spec/unit/mcollective/rpc/result_spec.rb
-- spec/unit/mcollective/rpc/client_spec.rb
-- spec/unit/mcollective/rpc/reply_spec.rb
-- spec/unit/mcollective/facts/base_spec.rb
-- spec/unit/mcollective/facts/yaml_facts_spec.rb
-- spec/unit/mcollective/vendor_spec.rb
-- spec/unit/mcollective/ssl_spec.rb
-- spec/unit/mcollective/application/plugin_spec.rb
-- spec/unit/mcollective/validator/ipv6address_validator_spec.rb
-- spec/unit/mcollective/validator/ipv4address_validator_spec.rb
-- spec/unit/mcollective/validator/regex_validator_spec.rb
-- spec/unit/mcollective/validator/array_validator_spec.rb
-- spec/unit/mcollective/validator/length_validator_spec.rb
-- spec/unit/mcollective/validator/typecheck_validator_spec.rb
-- spec/unit/mcollective/validator/shellsafe_validator_spec.rb
-- spec/unit/mcollective/aggregate/base_spec.rb
+- spec/spec_helper.rb
+- spec/unit/mcollective/agent/rpcutil_spec.rb
+- spec/unit/mcollective/agents_spec.rb
 - spec/unit/mcollective/aggregate/average_spec.rb
+- spec/unit/mcollective/aggregate/base_spec.rb
 - spec/unit/mcollective/aggregate/result/base_spec.rb
 - spec/unit/mcollective/aggregate/result/collection_result_spec.rb
 - spec/unit/mcollective/aggregate/result/numeric_result_spec.rb
 - spec/unit/mcollective/aggregate/sum_spec.rb
 - spec/unit/mcollective/aggregate/summary_spec.rb
-- spec/unit/mcollective/matcher_spec.rb
-- spec/unit/mcollective/windows_daemon_spec.rb
-- spec/unit/mcollective/config_spec.rb
+- spec/unit/mcollective/aggregate_spec.rb
+- spec/unit/mcollective/application/plugin_spec.rb
+- spec/unit/mcollective/application_spec.rb
 - spec/unit/mcollective/applications_spec.rb
-- spec/unit/mcollective/cache_spec.rb
-- spec/unit/mcollective/matcher/scanner_spec.rb
-- spec/unit/mcollective/matcher/parser_spec.rb
+- spec/unit/mcollective/array_spec.rb
 - spec/unit/mcollective/audit/logfile_spec.rb
-- spec/unit/mcollective/string_spec.rb
-- spec/unit/mcollective/ddl_spec.rb
-- spec/unit/mcollective/log_spec.rb
-- spec/unit/mcollective/pluginmanager_spec.rb
-- spec/unit/mcollective/registration/base_spec.rb
-- spec/unit/mcollective/discovery/flatfile_spec.rb
-- spec/unit/mcollective/discovery/stdin_spec.rb
-- spec/unit/mcollective/discovery/mc_spec.rb
-- spec/unit/mcollective/data/collective_data_spec.rb
-- spec/unit/mcollective/data/base_spec.rb
+- spec/unit/mcollective/cache_spec.rb
+- spec/unit/mcollective/client_spec.rb
+- spec/unit/mcollective/config_spec.rb
+- spec/unit/mcollective/connector/activemq_spec.rb
+- spec/unit/mcollective/connector/base_spec.rb
+- spec/unit/mcollective/connector/rabbitmq_spec.rb
 - spec/unit/mcollective/data/agent_data_spec.rb
-- spec/unit/mcollective/data/result_spec.rb
-- spec/unit/mcollective/data/fstat_data_spec.rb
+- spec/unit/mcollective/data/base_spec.rb
+- spec/unit/mcollective/data/collective_data_spec.rb
 - spec/unit/mcollective/data/fact_data_spec.rb
+- spec/unit/mcollective/data/fstat_data_spec.rb
+- spec/unit/mcollective/data/result_spec.rb
+- spec/unit/mcollective/data_spec.rb
+- spec/unit/mcollective/ddl/agentddl_spec.rb
 - spec/unit/mcollective/ddl/base_spec.rb
 - spec/unit/mcollective/ddl/dataddl_spec.rb
 - spec/unit/mcollective/ddl/discoveryddl_spec.rb
-- spec/unit/mcollective/ddl/agentddl_spec.rb
+- spec/unit/mcollective/ddl_spec.rb
+- spec/unit/mcollective/discovery/flatfile_spec.rb
+- spec/unit/mcollective/discovery/mc_spec.rb
+- spec/unit/mcollective/discovery/stdin_spec.rb
 - spec/unit/mcollective/discovery_spec.rb
+- spec/unit/mcollective/facts/base_spec.rb
+- spec/unit/mcollective/facts/yaml_facts_spec.rb
+- spec/unit/mcollective/facts_spec.rb
+- spec/unit/mcollective/generators/agent_generator_spec.rb
+- spec/unit/mcollective/generators/base_spec.rb
+- spec/unit/mcollective/generators/data_generator_spec.rb
+- spec/unit/mcollective/generators/snippets/agent_ddl
+- spec/unit/mcollective/generators/snippets/data_ddl
+- spec/unit/mcollective/log_spec.rb
 - spec/unit/mcollective/logger/base_spec.rb
 - spec/unit/mcollective/logger/console_logger_spec.rb
 - spec/unit/mcollective/logger/file_logger_spec.rb
 - spec/unit/mcollective/logger/syslog_logger_spec.rb
-- spec/unit/mcollective/shell_spec.rb
-- spec/unit/mcollective/data_spec.rb
-- spec/unit/mcollective/packagers/modulepackage_packager_spec.rb
+- spec/unit/mcollective/matcher/parser_spec.rb
+- spec/unit/mcollective/matcher/scanner_spec.rb
+- spec/unit/mcollective/matcher_spec.rb
+- spec/unit/mcollective/message_spec.rb
+- spec/unit/mcollective/monkey_patches_spec.rb
+- spec/unit/mcollective/optionparser_spec.rb
 - spec/unit/mcollective/packagers/debpackage_packager_spec.rb
+- spec/unit/mcollective/packagers/modulepackage_packager_spec.rb
 - spec/unit/mcollective/packagers/ospackage_spec.rb
 - spec/unit/mcollective/packagers/rpmpackage_packager_spec.rb
-- spec/unit/mcollective/client_spec.rb
-- spec/unit/mcollective/pluginpackager/standard_definition_spec.rb
+- spec/unit/mcollective/pluginmanager_spec.rb
 - spec/unit/mcollective/pluginpackager/agent_definition_spec.rb
-- spec/unit/mcollective/agent/rpcutil_spec.rb
-- spec/unit/mcollective/aggregate_spec.rb
-- spec/unit/mcollective/array_spec.rb
-- spec/unit/mcollective/optionparser_spec.rb
-- spec/unit/mcollective/message_spec.rb
+- spec/unit/mcollective/pluginpackager/standard_definition_spec.rb
 - spec/unit/mcollective/pluginpackager_spec.rb
-- spec/unit/mcollective/connector/rabbitmq_spec.rb
-- spec/unit/mcollective/connector/base_spec.rb
-- spec/unit/mcollective/connector/activemq_spec.rb
-- spec/unit/mcollective/generators/snippets/data_ddl
-- spec/unit/mcollective/generators/snippets/agent_ddl
-- spec/unit/mcollective/generators/base_spec.rb
-- spec/unit/mcollective/generators/data_generator_spec.rb
-- spec/unit/mcollective/generators/agent_generator_spec.rb
-- spec/unit/mcollective/runner_spec.rb
-- spec/unit/mcollective/util_spec.rb
-- spec/unit/mcollective/agents_spec.rb
-- spec/unit/mcollective/monkey_patches_spec.rb
-- spec/unit/mcollective/unix_daemon_spec.rb
+- spec/unit/mcollective/registration/base_spec.rb
+- spec/unit/mcollective/rpc/actionrunner_spec.rb
+- spec/unit/mcollective/rpc/agent_spec.rb
+- spec/unit/mcollective/rpc/client_spec.rb
+- spec/unit/mcollective/rpc/helpers_spec.rb
+- spec/unit/mcollective/rpc/reply_spec.rb
+- spec/unit/mcollective/rpc/request_spec.rb
+- spec/unit/mcollective/rpc/result_spec.rb
+- spec/unit/mcollective/rpc/stats_spec.rb
 - spec/unit/mcollective/rpc_spec.rb
-- spec/unit/mcollective/facts_spec.rb
-- spec/unit/mcollective/symbol_spec.rb
+- spec/unit/mcollective/runner_spec.rb
+- spec/unit/mcollective/runnerstats_spec.rb
 - spec/unit/mcollective/security/aes_security_spec.rb
 - spec/unit/mcollective/security/base_spec.rb
 - spec/unit/mcollective/security/psk_spec.rb
-- spec/spec_helper.rb
+- spec/unit/mcollective/shell_spec.rb
+- spec/unit/mcollective/ssl_spec.rb
+- spec/unit/mcollective/string_spec.rb
+- spec/unit/mcollective/symbol_spec.rb
+- spec/unit/mcollective/unix_daemon_spec.rb
+- spec/unit/mcollective/util_spec.rb
+- spec/unit/mcollective/validator/array_validator_spec.rb
+- spec/unit/mcollective/validator/ipv4address_validator_spec.rb
+- spec/unit/mcollective/validator/ipv6address_validator_spec.rb
+- spec/unit/mcollective/validator/length_validator_spec.rb
+- spec/unit/mcollective/validator/regex_validator_spec.rb
+- spec/unit/mcollective/validator/shellsafe_validator_spec.rb
+- spec/unit/mcollective/validator/typecheck_validator_spec.rb
+- spec/unit/mcollective/validator_spec.rb
+- spec/unit/mcollective/vendor_spec.rb
+- spec/unit/mcollective/windows_daemon_spec.rb
 - spec/windows_spec.opts
 homepage: https://docs.puppetlabs.com/mcollective/
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options:
 - --line-numbers
@@ -346,22 +340,20 @@ rdoc_options:
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.4.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Client libraries for the Mcollective Application Server
 test_files:
 - spec/fixtures/util/3.out