mcollective-client 2.2.4 → 2.4.0

data/spec/unit/util_spec.rb

@@ -395,7 +395,6 @@ module MCollective
       end
 
       it "should return the correct dimensions if ENV columns and lines are set" do
-
         stdout = mock()
         stdout.expects(:tty?).returns(true)
         Util.expects(:windows?).returns(false)
@@ -452,6 +451,36 @@ module MCollective
       end
     end
 
+    describe "#absolute_path?" do
+      it "should work correctly validate the path" do
+        Util.absolute_path?('.', '/', '\\').should == false
+        Util.absolute_path?('foo/foo', '/', '\\').should == false
+        Util.absolute_path?('foo\\bar', '/', '\\').should == false
+        Util.absolute_path?('../foo/bar', '/', '\\').should == false
+
+        Util.absolute_path?('\\foo/foo', '/', '\\').should == true
+        Util.absolute_path?('\\', '/', '\\').should == true
+        Util.absolute_path?('/foo', '/', '\\').should == true
+        Util.absolute_path?('/foo/foo', '/', '\\').should == true
+
+        Util.absolute_path?('.', '/', nil).should == false
+        Util.absolute_path?('foo/foo', '/', nil).should == false
+        Util.absolute_path?('foo\\bar', '/', nil).should == false
+        Util.absolute_path?('../foo/bar', '/', nil).should == false
+
+        Util.absolute_path?('\\foo/foo', '/', nil).should == false
+        Util.absolute_path?('\\', '/', nil).should == false
+        Util.absolute_path?('/foo', '/', nil).should == true
+        Util.absolute_path?('/foo/foo', '/', nil).should == true
+      end
+
+      it "should correctly validate paths on Windows" do
+        ['C:\foo', '\foo\bar', '\C\FOO\Bar', '/C/FOO/Bar'].each do |path|
+          Util.absolute_path?(path, '/', '\\').should be_true
+        end
+      end
+    end
+
     describe "#versioncmp" do
       it "should be able to sort a long set of various unordered versions" do
         ary = %w{ 1.1.6 2.3 1.1a 3.0 1.5 1 2.4 1.1-4 2.3.1 1.2 2.3.0 1.1-3 2.4b 2.4 2.40.2 2.3a.1 3.1 0002 1.1-5 1.1.a 1.06 1.2.10 1.2.8}
@@ -461,5 +490,44 @@ module MCollective
         newary.should == ["0002", "1", "1.06", "1.1-3", "1.1-4", "1.1-5", "1.1.6", "1.1.a", "1.1a", "1.2", "1.2.8", "1.2.10", "1.5", "2.3", "2.3.0", "2.3.1", "2.3a.1", "2.4", "2.4", "2.4b", "2.40.2", "3.0", "3.1"]
       end
     end
+
+    describe "str_to_bool" do
+      it "should transform true like strings into TrueClass" do
+        ["1", "y", "yes", "Y", "YES", "t", "true", "T", "TRUE", true].each do |val|
+          Util.str_to_bool(val).should be_true
+        end
+      end
+
+      it "should transform false like strings into FalseClass" do
+        ["0", "n", "no", "N", "NO", "f", "false", "F", "FALSE", false].each do |val|
+          Util.str_to_bool(val).should be_false
+        end
+      end
+
+      it "should raise an exception if the string does not match the boolean pattern" do
+        ["yep", "nope", "yess", "noway", "rspec", "YES!", "NO?"].each do |val|
+          expect { Util.str_to_bool(val) }.to raise_error("Cannot convert string value '#{val}' into a boolean.")
+        end
+      end
+    end
+
+    describe "#templatepath" do
+      before do
+        config = mock
+        config.stubs(:configfile).returns("/rspec/server.cfg")
+        Config.stubs(:instance).returns(config)
+      end
+      it "should look for a template in the config dir" do
+        File.stubs(:exists?).with("/rspec/test-help.erb").returns(true)
+        Util.templatepath("test-help.erb").should == "/rspec/test-help.erb"
+      end
+
+      it "should look for a template in the default dir" do
+        File.stubs(:exists?).with("/rspec/test-help.erb").returns(false)
+        File.stubs(:exists?).with("/etc/mcollective/test-help.erb").returns(true)
+        Util.templatepath("test-help.erb").should == "/etc/mcollective/test-help.erb"
+
+      end
+    end
   end
 end

data/spec/unit/windows_daemon_spec.rb

@@ -18,23 +18,44 @@ module MCollective
         end
 
         it "should start the mainloop" do
+          Util.stubs(:windows?).returns(true)
           WindowsDaemon.expects(:mainloop)
           WindowsDaemon.daemonize_runner
         end
       end
 
-      describe "#service_stop" do
-        it "should disconnect and exit" do
-          Log.expects(:info)
-
-          connector = mock
-          connector.expects(:disconnect).once
-
-          PluginManager.expects("[]").with("connector_plugin").returns(connector)
+      describe "#service_main" do
+        it "should start the runner" do
+          runner = mock
+          Runner.stubs(:new).returns(runner)
+          d = WindowsDaemon.new
+          d.stubs(:running?).returns(true,false)
+          d.stubs(:state).returns(WindowsDaemon::RUNNING)
+          runner.expects(:run)
+          d.service_main
+        end
 
+        it "should kill any other living threads on exit" do
           d = WindowsDaemon.new
-          d.expects("exit!").once
+          d.stubs(:running?).returns(false)
+          other = mock
+          Thread.stubs(:list).returns([Thread.current, other])
+          Thread.current.expects(:kill).never
+          other.expects(:kill)
+          d.service_main
+        end
+      end
 
+      describe "#service_stop" do
+        it "should log, disconnect, stop the runner and exit" do
+          runner = mock
+          connector = mock
+          connector.expects(:disconnect)
+          Log.expects(:info)
+          PluginManager.stubs(:[]).with("connector_plugin").returns(connector)
+          d = WindowsDaemon.new
+          d.instance_variable_set(:@runner, runner)
+          runner.expects(:stop)
           d.service_stop
         end
       end

metadata

@@ -1,75 +1,78 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: mcollective-client
-version: !ruby/object:Gem::Version 
-  hash: 15
-  prerelease: 
-  segments: 
-  - 2
-  - 2
-  - 4
-  version: 2.2.4
+version: !ruby/object:Gem::Version
+  version: 2.4.0
 platform: ruby
-authors: 
-- R.I.Pienaar
+authors:
+- Puppet Labs
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2013-05-20 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2014-01-23 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: systemu
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: json
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: json
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: stomp
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: i18n
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id003
-description: Client libraries for the mcollective Application Server
-email: rip@puppetlabs.com
-executables: 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Client libraries for the Mcollective Application Server
+email: info@puppetlabs.com
+executables:
 - mco
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
-- bin/mc-call-agent
-- bin/mco
+files:
 - lib/mcollective.rb
 - lib/mcollective/agent.rb
 - lib/mcollective/agents.rb
@@ -146,6 +149,8 @@ files:
 - lib/mcollective/vendor.rb
 - lib/mcollective/vendor/require_vendored.rb
 - lib/mcollective/windows_daemon.rb
+- bin/mc-call-agent
+- bin/mco
 - spec/Rakefile
 - spec/fixtures/application/test.rb
 - spec/fixtures/test-cert.pem
@@ -203,22 +208,25 @@ files:
 - spec/unit/pluginpackager/agent_definition_spec.rb
 - spec/unit/pluginpackager/standard_definition_spec.rb
 - spec/unit/pluginpackager_spec.rb
+- spec/unit/plugins/mcollective/agent/rpcutil_spec.rb
 - spec/unit/plugins/mcollective/aggregate/average_spec.rb
 - spec/unit/plugins/mcollective/aggregate/sum_spec.rb
 - spec/unit/plugins/mcollective/aggregate/summary_spec.rb
+- spec/unit/plugins/mcollective/application/plugin_spec.rb
+- spec/unit/plugins/mcollective/audit/logfile_spec.rb
 - spec/unit/plugins/mcollective/connector/activemq_spec.rb
 - spec/unit/plugins/mcollective/connector/rabbitmq_spec.rb
-- spec/unit/plugins/mcollective/connector/stomp/eventlogger_spec.rb
-- spec/unit/plugins/mcollective/connector/stomp_spec.rb
 - spec/unit/plugins/mcollective/data/agent_data_spec.rb
 - spec/unit/plugins/mcollective/data/fstat_data_spec.rb
 - spec/unit/plugins/mcollective/discovery/flatfile_spec.rb
 - spec/unit/plugins/mcollective/discovery/mc_spec.rb
+- spec/unit/plugins/mcollective/discovery/stdin_spec.rb
+- spec/unit/plugins/mcollective/facts/yaml_facts_spec.rb
 - spec/unit/plugins/mcollective/packagers/debpackage_packager_spec.rb
+- spec/unit/plugins/mcollective/packagers/modulepackage_packager_spec.rb
 - spec/unit/plugins/mcollective/packagers/ospackage_spec.rb
 - spec/unit/plugins/mcollective/packagers/rpmpackage_packager_spec.rb
 - spec/unit/plugins/mcollective/security/psk_spec.rb
-- spec/unit/plugins/mcollective/validator/any_validator_spec.rb
 - spec/unit/plugins/mcollective/validator/array_validator_spec.rb
 - spec/unit/plugins/mcollective/validator/ipv4address_validator_spec.rb
 - spec/unit/plugins/mcollective/validator/ipv6address_validator_spec.rb
@@ -250,38 +258,41 @@ files:
 - spec/windows_spec.opts
 homepage: https://docs.puppetlabs.com/mcollective/
 licenses: []
-
+metadata: {}
 post_install_message: 
-rdoc_options: []
-
-require_paths: 
+rdoc_options:
+- --line-numbers
+- --main
+- Mcollective
+- --exclude
+- mcollective/vendor
+- --exclude
+- spec
+- --exclude
+- ext
+- --exclude
+- website
+- --exclude
+- plugins
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.8.11
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
-summary: Client libraries for The Marionette Collective
-test_files: 
+specification_version: 4
+summary: Client libraries for the Mcollective Application Server
+test_files:
 - spec/Rakefile
 - spec/fixtures/application/test.rb
 - spec/fixtures/test-cert.pem
@@ -339,22 +350,25 @@ test_files:
 - spec/unit/pluginpackager/agent_definition_spec.rb
 - spec/unit/pluginpackager/standard_definition_spec.rb
 - spec/unit/pluginpackager_spec.rb
+- spec/unit/plugins/mcollective/agent/rpcutil_spec.rb
 - spec/unit/plugins/mcollective/aggregate/average_spec.rb
 - spec/unit/plugins/mcollective/aggregate/sum_spec.rb
 - spec/unit/plugins/mcollective/aggregate/summary_spec.rb
+- spec/unit/plugins/mcollective/application/plugin_spec.rb
+- spec/unit/plugins/mcollective/audit/logfile_spec.rb
 - spec/unit/plugins/mcollective/connector/activemq_spec.rb
 - spec/unit/plugins/mcollective/connector/rabbitmq_spec.rb
-- spec/unit/plugins/mcollective/connector/stomp/eventlogger_spec.rb
-- spec/unit/plugins/mcollective/connector/stomp_spec.rb
 - spec/unit/plugins/mcollective/data/agent_data_spec.rb
 - spec/unit/plugins/mcollective/data/fstat_data_spec.rb
 - spec/unit/plugins/mcollective/discovery/flatfile_spec.rb
 - spec/unit/plugins/mcollective/discovery/mc_spec.rb
+- spec/unit/plugins/mcollective/discovery/stdin_spec.rb
+- spec/unit/plugins/mcollective/facts/yaml_facts_spec.rb
 - spec/unit/plugins/mcollective/packagers/debpackage_packager_spec.rb
+- spec/unit/plugins/mcollective/packagers/modulepackage_packager_spec.rb
 - spec/unit/plugins/mcollective/packagers/ospackage_spec.rb
 - spec/unit/plugins/mcollective/packagers/rpmpackage_packager_spec.rb
 - spec/unit/plugins/mcollective/security/psk_spec.rb
-- spec/unit/plugins/mcollective/validator/any_validator_spec.rb
 - spec/unit/plugins/mcollective/validator/array_validator_spec.rb
 - spec/unit/plugins/mcollective/validator/ipv4address_validator_spec.rb
 - spec/unit/plugins/mcollective/validator/ipv6address_validator_spec.rb

data/spec/unit/plugins/mcollective/connector/stomp/eventlogger_spec.rb

@@ -1,34 +0,0 @@
-#!/usr/bin/env rspec
-
-require 'spec_helper'
-
-MCollective::PluginManager.clear
-
-require File.dirname(__FILE__) + '/../../../../../../plugins/mcollective/connector/stomp.rb'
-
-module MCollective
-  module Connector
-    class Stomp
-      describe EventLogger do
-        before do
-        end
-
-        it "should have valid call back methods" do
-          plugin = EventLogger.new
-
-          [:on_miscerr, :on_connecting, :on_connected, :on_disconnect, :on_connectfail, :on_ssl_connecting, :on_ssl_connected].each do |meth|
-            plugin.respond_to?(meth).should == true
-          end
-        end
-
-        describe "#stomp_url" do
-          it "should create valid stomp urls" do
-            EventLogger.new.stomp_url({:cur_login => "rspec", :cur_host => "localhost", :cur_port => 123}).should == "stomp://rspec@localhost:123"
-            EventLogger.new.stomp_url({:cur_login => "rspec", :cur_host => "localhost", :cur_port => 123, :cur_ssl => false}).should == "stomp://rspec@localhost:123"
-            EventLogger.new.stomp_url({:cur_login => "rspec", :cur_host => "localhost", :cur_port => 123, :cur_ssl => true}).should == "stomp+ssl://rspec@localhost:123"
-          end
-        end
-      end
-    end
-  end
-end

data/spec/unit/plugins/mcollective/connector/stomp_spec.rb

@@ -1,424 +0,0 @@
-#!/usr/bin/env rspec
-
-require 'spec_helper'
-
-MCollective::PluginManager.clear
-
-require File.dirname(__FILE__) + '/../../../../../plugins/mcollective/connector/stomp.rb'
-
-module MCollective
-  module Connector
-    describe Stomp do
-      before do
-        unless ::Stomp::Error.constants.map{|c| c.to_s}.include?("NoCurrentConnection")
-          class ::Stomp::Error::NoCurrentConnection < RuntimeError ; end
-        end
-
-        @config = mock
-        @config.stubs(:configured).returns(true)
-        @config.stubs(:identity).returns("rspec")
-        @config.stubs(:collectives).returns(["mcollective"])
-        @config.stubs(:topicprefix).returns("/topic/")
-        @config.stubs(:topicsep).returns(".")
-
-        logger = mock
-        logger.stubs(:log)
-        logger.stubs(:start)
-        Log.configure(logger)
-
-        Config.stubs(:instance).returns(@config)
-
-        @msg = mock
-        @msg.stubs(:base64_encode!)
-        @msg.stubs(:payload).returns("msg")
-        @msg.stubs(:agent).returns("agent")
-        @msg.stubs(:type).returns(:reply)
-        @msg.stubs(:collective).returns("mcollective")
-
-        @subscription = mock
-        @subscription.stubs("<<").returns(true)
-        @subscription.stubs("include?").returns(false)
-        @subscription.stubs("delete").returns(false)
-
-        @connection = mock
-        @connection.stubs(:subscribe).returns(true)
-        @connection.stubs(:unsubscribe).returns(true)
-
-        @c = Stomp.new
-        @c.instance_variable_set("@subscriptions", @subscription)
-        @c.instance_variable_set("@connection", @connection)
-      end
-
-      describe "#initialize" do
-        it "should be deprecated" do
-          Log.expects(:info).with(regexp_matches(/please migrate to the/))
-          Stomp.new
-        end
-
-        it "should set the @config variable" do
-          c = Stomp.new
-          c.instance_variable_get("@config").should == @config
-        end
-
-        it "should set @subscriptions to an empty list" do
-          c = Stomp.new
-          c.instance_variable_get("@subscriptions").should == []
-        end
-      end
-
-      describe "#connect" do
-        it "should not try to reconnect if already connected" do
-          Log.expects(:debug).with("Already connection, not re-initializing connection").once
-          @c.connect
-        end
-
-        it "should support old style config" do
-          @config.expects(:pluginconf).returns({}).at_least_once
-          @c.expects(:get_bool_option).with("stomp.base64", false)
-          @c.expects(:get_option).with("stomp.priority", 0)
-          @c.expects(:get_env_or_option).with("STOMP_SERVER", "stomp.host").returns("host")
-          @c.expects(:get_env_or_option).with("STOMP_PORT", "stomp.port", 6163).returns(6163)
-          @c.expects(:get_env_or_option).with("STOMP_USER", "stomp.user").returns("test_user")
-          @c.expects(:get_env_or_option).with("STOMP_PASSWORD", "stomp.password").returns("test_password")
-
-          connector = mock
-          connector.expects(:new).with("test_user", "test_password", "host", 6163, true)
-
-          @c.instance_variable_set("@connection", nil)
-          @c.connect(connector)
-        end
-
-        it "should support new style config" do
-          pluginconf = {"stomp.pool.size" => "2",
-                        "stomp.pool.host1" => "host1",
-                        "stomp.pool.port1" => "6163",
-                        "stomp.pool.user1" => "user1",
-                        "stomp.pool.password1" => "password1",
-                        "stomp.pool.ssl1" => "false",
-                        "stomp.pool.host2" => "host2",
-                        "stomp.pool.port2" => "6164",
-                        "stomp.pool.user2" => "user2",
-                        "stomp.pool.password2" => "password2",
-                        "stomp.pool.ssl2" => "true",
-                        "stomp.pool.initial_reconnect_delay" => "0.02",
-                        "stomp.pool.max_reconnect_delay" => "40",
-                        "stomp.pool.use_exponential_back_off" => "false",
-                        "stomp.pool.back_off_multiplier" => "3",
-                        "stomp.pool.max_reconnect_attempts" => "5",
-                        "stomp.pool.randomize" => "true",
-                        "stomp.pool.backup" => "true",
-                        "stomp.pool.connect_timeout" => 30,
-                        "stomp.pool.timeout" => "1"}
-
-
-          ENV.delete("STOMP_USER")
-          ENV.delete("STOMP_PASSWORD")
-
-          @config.expects(:pluginconf).returns(pluginconf).at_least_once
-
-          Stomp::EventLogger.expects(:new).returns("logger")
-
-          connector = mock
-          connector.expects(:new).with(:backup => true,
-                                       :back_off_multiplier => 2,
-                                       :max_reconnect_delay => 40.0,
-                                       :timeout => 1,
-                                       :use_exponential_back_off => false,
-                                       :max_reconnect_attempts => 5,
-                                       :initial_reconnect_delay => 0.02,
-                                       :connect_timeout => 30,
-                                       :randomize => true,
-                                       :reliable => true,
-                                       :logger => "logger",
-                                       :hosts => [{:passcode => 'password1',
-                                                   :host => 'host1',
-                                                   :port => 6163,
-                                                   :ssl => false,
-                                                   :login => 'user1'},
-                                                  {:passcode => 'password2',
-                                                   :host => 'host2',
-                                                   :port => 6164,
-                                                   :ssl => true,
-                                                   :login => 'user2'}
-                                                 ])
-
-          @c.instance_variable_set("@connection", nil)
-          @c.connect(connector)
-        end
-      end
-
-      describe "#receive" do
-        it "should receive from the middleware" do
-          payload = mock
-          payload.stubs(:body).returns("msg")
-          payload.stubs(:headers).returns("headers")
-
-          @connection.expects(:receive).returns(payload)
-
-          Message.expects(:new).with("msg", payload, :base64 => true, :headers => "headers").returns("message")
-          @c.instance_variable_set("@base64", true)
-
-          received = @c.receive
-          received.should == "message"
-        end
-
-        it "should sleep and retry if recieving while disconnected" do
-          payload = mock
-          payload.stubs(:body).returns("msg")
-          payload.stubs(:headers).returns("headers")
-
-          Message.stubs(:new).returns("rspec")
-          @connection.expects(:receive).raises(::Stomp::Error::NoCurrentConnection).returns(payload).twice
-          @c.expects(:sleep).with(1)
-
-          @c.receive.should == "rspec"
-        end
-      end
-
-      describe "#publish" do
-        before do
-          @connection.stubs("respond_to?").with("publish").returns(true)
-          @connection.stubs(:publish).with("test", "msg", {}).returns(true)
-        end
-
-        it "should base64 encode a message if configured to do so" do
-          @c.instance_variable_set("@base64", true)
-          @c.expects(:msgheaders).returns({})
-          @c.expects(:make_target).returns("test")
-          @connection.expects(:publish).with("test", "msg", {})
-
-          @msg.stubs(:reply_to)
-
-          @c.publish(@msg)
-        end
-
-        it "should not base64 encode if not configured to do so" do
-          @c.instance_variable_set("@base64", false)
-          @c.expects(:msgheaders).returns({})
-          @c.expects(:make_target).returns("test")
-
-          @connection.expects(:publish).with("test", "msg", {})
-
-          @msg.stubs(:reply_to)
-
-          @c.publish(@msg)
-        end
-
-        it "should publish direct requests for each discovered host" do
-          @msg.expects(:type).returns(:direct_request).times(3)
-          @msg.expects(:discovered_hosts).returns(["one", "two"])
-
-          @c.expects(:make_target).with("agent", :direct_request, "mcollective", "one").returns("target_one")
-          @c.expects(:make_target).with("agent", :direct_request, "mcollective", "two").returns("target_two")
-
-          @c.expects(:publish_msg).with("target_one", "msg")
-          @c.expects(:publish_msg).with("target_two", "msg")
-
-          @msg.stubs(:reply_to)
-
-          @c.publish(@msg)
-        end
-
-        it "should raise an error if specific reply targets are requested" do
-          @c.instance_variable_set("@base64", false)
-
-          @msg.expects(:reply_to).returns(:foo)
-
-          expect { @c.publish(@msg) }.to raise_error("Cannot set specific reply to targets with the STOMP plugin")
-        end
-      end
-
-      describe "#publish_msg" do
-        it "should use the publish method if it exists" do
-          @connection.expects("respond_to?").with("publish").returns(true)
-          @connection.expects(:publish).with("test", "msg", {}).once
-          @c.stubs(:msgheaders).returns({})
-
-          @c.publish_msg("test", "msg")
-        end
-
-        it "should use the send method if publish does not exist" do
-          @connection.expects("respond_to?").with('publish').returns(false)
-          @connection.expects(:send).with("test", "msg", {}).once
-          @c.stubs(:msgheaders).returns({})
-
-          @c.publish_msg("test", "msg")
-        end
-
-        it "should publish the correct message to the correct target with msgheaders" do
-          @connection.expects("respond_to?").with("publish").returns(true)
-          @connection.expects(:publish).with("test", "msg", {"test" => "test"}).once
-          @c.expects(:msgheaders).returns({"test" => "test"})
-
-          @c.publish_msg("test", "msg")
-        end
-
-      end
-
-      describe "#make_target" do
-        it "should create correct targets" do
-          @config.expects(:queueprefix).returns("/queue/").twice
-
-          @c.make_target("test", :broadcast, "mcollective").should == "/topic/mcollective.test.command"
-          @c.make_target("test", :directed, "mcollective").should == "/queue/mcollective.2bc84dc69b73db9383b9c6711d2011b7"
-          @c.make_target("test", :direct_request, "mcollective", "rspec").should == "/queue/mcollective.2bc84dc69b73db9383b9c6711d2011b7"
-          @c.make_target("test", :reply, "mcollective").should == "/topic/mcollective.test.reply"
-          @c.make_target("test", :request, "mcollective").should == "/topic/mcollective.test.command"
-        end
-
-        it "should raise an error for unknown collectives" do
-          expect {
-            @c.make_target("test", :broadcast, "foo")
-          }.to raise_error("Unknown collective 'foo' known collectives are 'mcollective'")
-        end
-
-        it "should raise an error for unknown types" do
-          expect {
-            @c.make_target("test", :test, "mcollective")
-          }.to raise_error("Unknown target type test")
-        end
-      end
-
-      describe "#unsubscribe" do
-        it "should use make_target correctly" do
-          @c.expects("make_target").with("test", :broadcast, "mcollective").returns({:target => "test", :headers => {}})
-          @c.unsubscribe("test", :broadcast, "mcollective")
-        end
-
-        it "should unsubscribe from the target" do
-          @c.expects("make_target").with("test", :broadcast, "mcollective").returns("test")
-          @connection.expects(:unsubscribe).with("test").once
-
-          @c.unsubscribe("test", :broadcast, "mcollective")
-        end
-
-        it "should delete the source from subscriptions" do
-          @c.expects("make_target").with("test", :broadcast, "mcollective").returns({:target => "test", :headers => {}})
-          @subscription.expects(:delete).with({:target => "test", :headers => {}}).once
-
-          @c.unsubscribe("test", :broadcast, "mcollective")
-        end
-      end
-
-      describe "#subscribe" do
-        it "should use the make_target correctly" do
-          @c.expects("make_target").with("test", :broadcast, "mcollective").returns("test")
-          @c.subscribe("test", :broadcast, "mcollective")
-        end
-
-        it "should check for existing subscriptions" do
-          @c.expects("make_target").returns("test").once
-          @subscription.expects("include?").with("test").returns(false)
-          @connection.expects(:subscribe).never
-
-          @c.subscribe("test", :broadcast, "mcollective")
-        end
-
-        it "should subscribe to the middleware" do
-          @c.expects("make_target").returns("test")
-          @connection.expects(:subscribe).with("test").once
-          @c.subscribe("test", :broadcast, "mcollective")
-        end
-
-        it "should add to the list of subscriptions" do
-          @c.expects("make_target").returns("test")
-          @subscription.expects("<<").with("test")
-          @c.subscribe("test", :broadcast, "mcollective")
-        end
-      end
-
-      describe "#disconnect" do
-        it "should disconnect from the stomp connection" do
-          @connection.expects(:disconnect)
-          @c.disconnect
-        end
-      end
-
-      describe "#msgheaders" do
-        it "should return empty headers if priority is 0" do
-          @c.instance_variable_set("@msgpriority", 0)
-          @c.msgheaders.should == {}
-        end
-
-        it "should return a priority if prioritu is non 0" do
-          @c.instance_variable_set("@msgpriority", 1)
-          @c.msgheaders.should == {"priority" => 1}
-        end
-      end
-
-      describe "#get_env_or_option" do
-        it "should return the environment variable if set" do
-          ENV["test"] = "rspec_env_test"
-
-          @c.get_env_or_option("test", nil, nil).should == "rspec_env_test"
-
-          ENV.delete("test")
-        end
-
-        it "should return the config option if set" do
-          @config.expects(:pluginconf).returns({"test" => "rspec_test"}).twice
-          @c.get_env_or_option("test", "test", "test").should == "rspec_test"
-        end
-
-        it "should return default if nothing else matched" do
-          @config.expects(:pluginconf).returns({}).once
-          @c.get_env_or_option("test", "test", "test").should == "test"
-        end
-
-        it "should raise an error if no default is supplied" do
-          @config.expects(:pluginconf).returns({}).once
-
-          expect {
-            @c.get_env_or_option("test", "test")
-          }.to raise_error("No test environment or plugin.test configuration option given")
-        end
-      end
-
-      describe "#get_option" do
-        it "should return the config option if set" do
-          @config.expects(:pluginconf).returns({"test" => "rspec_test"}).twice
-          @c.get_option("test").should == "rspec_test"
-        end
-
-        it "should return default option was not found" do
-          @config.expects(:pluginconf).returns({}).once
-          @c.get_option("test", "test").should == "test"
-        end
-
-        it "should raise an error if no default is supplied" do
-          @config.expects(:pluginconf).returns({}).once
-
-          expect {
-            @c.get_option("test")
-          }.to raise_error("No plugin.test configuration option given")
-        end
-      end
-
-      describe "#get_bool_option" do
-        it "should return the default if option isnt set" do
-          @config.expects(:pluginconf).returns({}).once
-          @c.get_bool_option("test", "default").should == "default"
-        end
-
-        ["1", "yes", "true"].each do |boolean|
-          it "should map options to true correctly" do
-            @config.expects(:pluginconf).returns({"test" => boolean}).twice
-            @c.get_bool_option("test", "default").should == true
-          end
-        end
-
-        ["0", "no", "false"].each do |boolean|
-          it "should map options to false correctly" do
-            @config.expects(:pluginconf).returns({"test" => boolean}).twice
-            @c.get_bool_option("test", "default").should == false
-          end
-        end
-
-        it "should return default for non boolean options" do
-          @config.expects(:pluginconf).returns({"test" => "foo"}).twice
-          @c.get_bool_option("test", "default").should == "default"
-        end
-      end
-    end
-  end
-end