mcollective-client 1.3.3 → 2.0.0

data/spec/unit/plugins/mcollective/packagers/rpmpackage_packager_spec.rb

@@ -0,0 +1,183 @@
+#!/usr/bin/env rspec
+require 'spec_helper'
+require File.dirname(__FILE__) + '/../../../../../plugins/mcollective/pluginpackager/rpmpackage_packager.rb'
+
+module MCollective
+  module PluginPackager
+    describe RpmpackagePackager do
+      let(:maketmpdir) do
+        tmpdir = Dir.mktmpdir("mc-test")
+        @tmpdirs << tmpdir
+        tmpdir
+      end
+
+      before :all do
+        @tmpdirs = []
+      end
+
+      before :each do
+        PluginPackager.stubs(:build_tool?).with("rpmbuild").returns(true)
+        @plugin = mock()
+        @plugin.stubs(:iteration).returns("1")
+        @plugin.stubs(:metadata).returns({:name => "test", :version => "1"})
+      end
+
+      after :all do
+        @tmpdirs.each{|tmpdir| FileUtils.rm_rf tmpdir if File.directory? tmpdir}
+      end
+
+      describe "#initialize" do
+
+        it "should raise and exception if rpm-build is not present" do
+          PluginPackager.expects(:build_tool?).with("rpmbuild").returns(false)
+          expect{
+            RpmpackagePackager.new("plugin")
+          }.to raise_exception RuntimeError, "package 'rpm-build' is not installed"
+        end
+
+        it "should set the correct libdir" do
+          packager = RpmpackagePackager.new("plugin")
+          packager.libdir.should == "/usr/libexec/mcollective/mcollective/"
+
+          packager = RpmpackagePackager.new("plugin", "/tmp/")
+          packager.libdir.should == "/tmp/"
+        end
+
+      end
+
+      describe "#create_packages" do
+        before :each do
+          @packager = RpmpackagePackager.new(@plugin)
+          @packager.tmpdir = maketmpdir
+          @packager.stubs(:create_package)
+          @packager.stubs(:cleanup_tmpdirs)
+          @plugin.stubs(:packagedata).returns(:test => {:files => ["test.rb"]})
+          @packager.stubs(:prepare_tmpdirs)
+          Dir.stubs(:mktmpdir)
+        end
+
+        it "should set the package instance variables" do
+          @packager.create_packages
+          @packager.current_package_type.should == :test
+          @packager.current_package_data.should == {:files => ["test.rb"]}
+          @packager.current_package_name.should == "mcollective-test-test"
+        end
+
+        it "should create the build dir" do
+          @packager.expects(:prepare_tmpdirs)
+          @packager.create_packages
+        end
+
+        it "should create packages" do
+          @packager.expects(:create_package)
+          @packager.create_packages
+        end
+
+      end
+
+      describe "#create_package" do
+        before :each do
+          @packager = RpmpackagePackager.new(@plugin)
+        end
+
+        it "should create the package" do
+          PluginPackager.expects(:safe_system).with("rpmbuild -bb   /tmp/SPECS/test.spec --buildroot /tmp/BUILD")
+          FileUtils.expects(:cp)
+          @packager.tmpdir = "/tmp"
+          @packager.verbose = "true"
+          @packager.expects(:make_spec_file)
+          @packager.current_package_name = "mcollective-testplugin-test"
+          @packager.expects(:puts).with("Created package mcollective-testplugin-test")
+          @packager.create_package(:test, {:files => ["foo.rb"]})
+        end
+
+        it "should sign the package if a signature is given" do
+          PluginPackager.expects(:safe_system).with("rpmbuild -bb  --sign /tmp/SPECS/test.spec --buildroot /tmp/BUILD")
+          FileUtils.expects(:cp)
+          @packager.signature = true
+          @packager.tmpdir = "/tmp"
+          @packager.verbose = "true"
+          @packager.expects(:make_spec_file)
+          @packager.current_package_name = "mcollective-testplugin-test"
+          @packager.expects(:puts).with("Created package mcollective-testplugin-test")
+          @packager.create_package(:test, {:files => ["foo.rb"]})
+        end
+
+        it "should raise an error if the package can't be built" do
+          @packager = RpmpackagePackager.new(@plugin)
+          @packager.expects(:make_spec_file)
+          PluginPackager.stubs(:do_quietly?).raises("foo")
+          expect{
+            @packager.create_package("", "")
+          }.to raise_error RuntimeError, "Could not build package. Reason - foo"
+        end
+      end
+
+      describe "#make_spec_file" do
+        before :each do
+          @packager = RpmpackagePackager.new("package")
+        end
+
+        it "should raise an exception if specfile cannot be built" do
+          File.expects(:dirname).raises("test error")
+          expect{
+            @packager.make_spec_file
+          }.to raise_error RuntimeError, "Could not create specfile - test error"
+        end
+
+        it "should create the specfile from the erb" do
+          File.stubs(:read).returns("specfile")
+          @packager.current_package_type = "test"
+          @packager.tmpdir = maketmpdir
+          Dir.mkdir(File.join(@packager.tmpdir, "SPECS"))
+          @packager.make_spec_file
+          File.read(File.join(@packager.tmpdir, "SPECS", "test.spec")).should == "specfile"
+        end
+      end
+
+      describe "#prepare_tmpdirs" do
+        it "should create the tmp dirs and cp the package files" do
+          @plugin.stubs(:target_path).returns("")
+          packager = RpmpackagePackager.new(@plugin)
+          packager.expects(:make_rpm_dirs)
+          FileUtils.expects(:mkdir_p)
+          File.stubs(:join).returns("/target")
+          FileUtils.expects(:cp_r).with("test.rb", "/target")
+          packager.prepare_tmpdirs({:files => ["test.rb"]})
+        end
+      end
+
+      describe "#make_rpm_dirs" do
+        before :each do
+          @packager = RpmpackagePackager.new("package")
+        end
+
+        it "should raise an exception if a directory can't be created" do
+          File.expects(:join).raises("test error")
+          expect{
+            @packager.make_rpm_dirs
+          }.to raise_error RuntimeError, "Could not create BUILD directory - test error"
+        end
+
+        it "should create the correct RPM build directories" do
+          @packager.tmpdir = maketmpdir
+          @packager.make_rpm_dirs
+          File.directory?(File.join(@packager.tmpdir, "SPECS")).should == true
+          File.directory?(File.join(@packager.tmpdir, "SOURCES")).should == true
+          File.directory?(File.join(@packager.tmpdir, "SRPMS")).should == true
+          File.directory?(File.join(@packager.tmpdir, "BUILD")).should == true
+          File.directory?(File.join(@packager.tmpdir, "RPMS")).should == true
+        end
+      end
+
+      describe "#cleanup_tmpdirs" do
+        it "should remove the temp directories" do
+          packager = RpmpackagePackager.new("package")
+          packager.tmpdir = maketmpdir
+          packager.cleanup_tmpdirs
+          File.directory?(packager.tmpdir).should == false
+        end
+      end
+    end
+  end
+end

data/spec/unit/rpc/client_spec.rb

@@ -159,9 +159,9 @@ module MCollective
         end
 
         it "should not invalid limits to be set" do
-          expect { @client.limit_targets = "a" }.to raise_error /Invalid/
-          expect { @client.limit_targets = "%1" }.to raise_error /Invalid/
-          expect { @client.limit_targets = "1.1" }.to raise_error /Invalid/
+          expect { @client.limit_targets = "a" }.to raise_error(/Invalid/)
+          expect { @client.limit_targets = "%1" }.to raise_error(/Invalid/)
+          expect { @client.limit_targets = "1.1" }.to raise_error(/Invalid/)
         end
       end
 

data/spec/unit/rpc/helpers_spec.rb

@@ -9,7 +9,7 @@ module MCollective
         it "should fail for non array data" do
           expect {
             Helpers.extract_hosts_from_json("{}")
-          }.to raise_error "JSON hosts list is not an array"
+          }.to raise_error("JSON hosts list is not an array")
         end
 
         it "should fail for non hash array members" do
@@ -17,7 +17,7 @@ module MCollective
 
           expect {
             Helpers.extract_hosts_from_json(senders)
-          }.to raise_error "JSON host list is not an array of Hashes"
+          }.to raise_error("JSON host list is not an array of Hashes")
         end
 
         it "should fail for hashes without senders" do
@@ -25,7 +25,7 @@ module MCollective
 
           expect {
             Helpers.extract_hosts_from_json(senders)
-          }.to raise_error "JSON host list does not have senders in it"
+          }.to raise_error("JSON host list does not have senders in it")
         end
 
         it "should return all found unique senders" do

data/spec/unit/security/base_spec.rb

@@ -35,7 +35,7 @@ module MCollective
 
           expect {
             @plugin.should_process_msg?(m, "fail").should == true
-          }.to raise_error MsgDoesNotMatchRequestID
+          }.to raise_error(MsgDoesNotMatchRequestID)
         end
 
         it "should not test messages without expected_msgid" do

data/spec/unit/ssl_spec.rb

@@ -93,7 +93,7 @@ module MCollective
       end
 
       it "should read the public key from a certificate" do
-        @ssl.read_key(:public, "#{@rootdir}/../fixtures/test-cert.pem").to_s.should match /.+BEGIN.+PUBLIC KEY.+END.+PUBLIC KEY.+/m
+        @ssl.read_key(:public, "#{@rootdir}/../fixtures/test-cert.pem").to_s.should match(/.+BEGIN.+PUBLIC KEY.+END.+PUBLIC KEY.+/m)
       end
 
       it "should return nil if no key was given" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: mcollective-client
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 15
   prerelease: 
   segments: 
-  - 1
-  - 3
-  - 3
-  version: 1.3.3
+  - 2
+  - 0
+  - 0
+  version: 2.0.0
 platform: ruby
 authors: 
 - R.I.Pienaar
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-04-05 00:00:00 Z
+date: 2012-04-30 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: systemu
@@ -45,7 +45,7 @@ dependencies:
         version: "0"
   type: :runtime
   version_requirements: *id002
-description: Client tools for the mcollective Application Server
+description: Client libraries for the mcollective Application Server
 email: rip@puppetlabs.com
 executables: 
 - mco
@@ -111,9 +111,10 @@ files:
 - spec/fixtures/application/test.rb
 - spec/fixtures/test-private.pem
 - spec/fixtures/test-cert.pem
-- spec/unit/windows_daemon.rb
 - spec/unit/application_spec.rb
+- spec/unit/unix_daemon_spec.rb
 - spec/unit/facts/base_spec.rb
+- spec/unit/array_spec.rb
 - spec/unit/rpc/reply_spec.rb
 - spec/unit/rpc/ddl_spec.rb
 - spec/unit/rpc/client_spec.rb
@@ -123,6 +124,7 @@ files:
 - spec/unit/rpc/result_spec.rb
 - spec/unit/rpc/actionrunner_spec.rb
 - spec/unit/rpc/stats_spec.rb
+- spec/unit/windows_daemon_spec.rb
 - spec/unit/optionparser_spec.rb
 - spec/unit/pluginpackager/agent_definition_spec.rb
 - spec/unit/pluginpackager/standard_definition_spec.rb
@@ -135,15 +137,14 @@ files:
 - spec/unit/plugins/mcollective/connector/activemq_spec.rb
 - spec/unit/plugins/mcollective/connector/stomp/eventlogger_spec.rb
 - spec/unit/plugins/mcollective/connector/stomp_spec.rb
+- spec/unit/plugins/mcollective/packagers/debpackage_packager_spec.rb
 - spec/unit/plugins/mcollective/packagers/ospackage_spec.rb
+- spec/unit/plugins/mcollective/packagers/rpmpackage_packager_spec.rb
 - spec/unit/plugins/mcollective/security/psk_spec.rb
 - spec/unit/registration/base_spec.rb
-- spec/unit/symbol.rb
 - spec/unit/agents_spec.rb
 - spec/unit/security/base_spec.rb
-- spec/unit/array.rb
 - spec/unit/vendor_spec.rb
-- spec/unit/unix_daemon.rb
 - spec/unit/message_spec.rb
 - spec/unit/log_spec.rb
 - spec/unit/facts_spec.rb
@@ -151,6 +152,7 @@ files:
 - spec/unit/pluginmanager_spec.rb
 - spec/unit/matcher/parser_spec.rb
 - spec/unit/matcher/scanner_spec.rb
+- spec/unit/symbol_spec.rb
 - spec/unit/util_spec.rb
 - spec/windows_spec.opts
 - spec/spec_helper.rb
@@ -188,16 +190,17 @@ rubyforge_project:
 rubygems_version: 1.8.11
 signing_key: 
 specification_version: 3
-summary: Client for The Marionette Collective
+summary: Client libraries for The Marionette Collective
 test_files: 
 - spec/spec.opts
 - spec/fixtures/test-public.pem
 - spec/fixtures/application/test.rb
 - spec/fixtures/test-private.pem
 - spec/fixtures/test-cert.pem
-- spec/unit/windows_daemon.rb
 - spec/unit/application_spec.rb
+- spec/unit/unix_daemon_spec.rb
 - spec/unit/facts/base_spec.rb
+- spec/unit/array_spec.rb
 - spec/unit/rpc/reply_spec.rb
 - spec/unit/rpc/ddl_spec.rb
 - spec/unit/rpc/client_spec.rb
@@ -207,6 +210,7 @@ test_files:
 - spec/unit/rpc/result_spec.rb
 - spec/unit/rpc/actionrunner_spec.rb
 - spec/unit/rpc/stats_spec.rb
+- spec/unit/windows_daemon_spec.rb
 - spec/unit/optionparser_spec.rb
 - spec/unit/pluginpackager/agent_definition_spec.rb
 - spec/unit/pluginpackager/standard_definition_spec.rb
@@ -219,15 +223,14 @@ test_files:
 - spec/unit/plugins/mcollective/connector/activemq_spec.rb
 - spec/unit/plugins/mcollective/connector/stomp/eventlogger_spec.rb
 - spec/unit/plugins/mcollective/connector/stomp_spec.rb
+- spec/unit/plugins/mcollective/packagers/debpackage_packager_spec.rb
 - spec/unit/plugins/mcollective/packagers/ospackage_spec.rb
+- spec/unit/plugins/mcollective/packagers/rpmpackage_packager_spec.rb
 - spec/unit/plugins/mcollective/security/psk_spec.rb
 - spec/unit/registration/base_spec.rb
-- spec/unit/symbol.rb
 - spec/unit/agents_spec.rb
 - spec/unit/security/base_spec.rb
-- spec/unit/array.rb
 - spec/unit/vendor_spec.rb
-- spec/unit/unix_daemon.rb
 - spec/unit/message_spec.rb
 - spec/unit/log_spec.rb
 - spec/unit/facts_spec.rb
@@ -235,6 +238,7 @@ test_files:
 - spec/unit/pluginmanager_spec.rb
 - spec/unit/matcher/parser_spec.rb
 - spec/unit/matcher/scanner_spec.rb
+- spec/unit/symbol_spec.rb
 - spec/unit/util_spec.rb
 - spec/windows_spec.opts
 - spec/spec_helper.rb