mcoin 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea7433590b7f0979f367b292a76590eacd5db058
-  data.tar.gz: d42319799e8e2248f12c1a52a2eeeed85ee69aca
+  metadata.gz: 49ab57d9100eb27a91c752e1ca71d72571d31cfa
+  data.tar.gz: e66056a6d6595342fb59062de0929bbe38710e7d
 SHA512:
-  metadata.gz: 1d7b9d7616dcf7b429098dc2657da4e577eeec167c6ef7f84fbd78fa54d8f4a35a0cff8dcea9ce4a91b18f916538c5b2621bbdaa1580d258c02ab7d4cbb2a5a8
-  data.tar.gz: 698c2c86862ea27a2e4a32f60168a04d0423a4102fd27f3b9e47a7ececde1b5ad6fd57e08d2ffddfe5adc85f0733f0b9169375652e41b7cc877f4bffc7fd07e8
+  metadata.gz: b82b09b1360b95b54af7db305522c35280e680928a2c6418235c7616493f752799b34ee160dbc845081819127249cf0046966e55a1163a0ae1f747ba18022684
+  data.tar.gz: 366117743778be55ca0c074e34df2d88d5e520837aeb969ba286a1610bfd5836a49e9751712a5d74d8436181eec2bc29d1a24416fcf0342fdc609e08d2ee3b05

data/.gitignore

@@ -6,3 +6,5 @@
 /pkg/
 /spec/reports/
 /tmp/
+
+Gemfile.lock

data/README.md

@@ -58,7 +58,7 @@ Please note, the ticker is async pull data from market, the timestamp may not to
 * [x] Fetch ticker
   * [x] Fetch in parallels
   * [x] Fetch from multiple market
-  * [ ] Fetch multiple coin type via specify `pair`
+  * [x] Fetch multiple coin type via specify `pair`
 * [ ] Support more public API command
 * [ ] Improve printer
 * [ ] Generalize database save interface

data/lib/mcoin/command.rb

@@ -12,7 +12,7 @@ module Mcoin
     autoload :Ticker, 'mcoin/command/ticker'
 
     autoload :HasMarket, 'mcoin/command/ext/has_market'
-    autoload :HasType, 'mcoin/command/ext/has_type'
+    autoload :HasPair, 'mcoin/command/ext/has_pair'
     autoload :Saveable, 'mcoin/command/ext/saveable'
 
     class << self

data/lib/mcoin/command/ext/has_pair.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module Mcoin
+  module Command
+    # :nodoc:
+    module HasPair
+      def self.included(base)
+        base.option(:multiple, :pair, '-P', '--pair BTC-USD')
+      end
+    end
+  end
+end

data/lib/mcoin/command/ticker.rb

@@ -5,7 +5,7 @@ module Mcoin
     # :nodoc:
     class Ticker < Base
       include HasMarket
-      include HasType
+      include HasPair
       include Saveable
 
       attr_reader :option
@@ -19,7 +19,7 @@ module Mcoin
       end
 
       def print
-        tickers = Parallel.map(markets, :fetch).map(&:to_ticker)
+        tickers = Parallel.map(markets, :fetch).compact.map(&:to_ticker)
         Printer.new(tickers).print
       end
 
@@ -29,9 +29,17 @@ module Mcoin
 
       def markets
         @markets ||= option.market.map do |name|
-          Market
-            .pick(name)
-            .new(option.type, option.currency)
+          pairs.map do |pair|
+            Market
+              .pick(name)
+              .new(*pair)
+          end
+        end.flatten
+      end
+
+      def pairs
+        @pairs ||= (option.pair || ['BTC-USD']).uniq.map do |pair|
+          pair.split('-').map(&:to_sym)
         end
       end
 
@@ -39,8 +47,7 @@ module Mcoin
 
       def prepare
         super
-        option.type = :BTC
-        option.currency = :USD
+        option.pair ||= []
       end
     end
   end

data/lib/mcoin/market/base.rb

@@ -22,7 +22,7 @@ module Mcoin
         @data ||= JSON.parse(Net::HTTP.get(uri))
         self
       rescue JSON::ParserError
-        raise if @retries >= 3
+        return nil if @retries >= 3
         @retries += 1
         retry
       end

data/lib/mcoin/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Mcoin
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mcoin
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - 蒼時弦也
@@ -50,7 +50,6 @@ files:
 - ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
-- Gemfile.lock
 - README.md
 - Rakefile
 - bin/console
@@ -61,7 +60,7 @@ files:
 - lib/mcoin/command/base.rb
 - lib/mcoin/command/common.rb
 - lib/mcoin/command/ext/has_market.rb
-- lib/mcoin/command/ext/has_type.rb
+- lib/mcoin/command/ext/has_pair.rb
 - lib/mcoin/command/ext/saveable.rb
 - lib/mcoin/command/ticker.rb
 - lib/mcoin/data.rb

data/Gemfile.lock

@@ -1,26 +0,0 @@
-PATH
-  remote: .
-  specs:
-    mcoin (0.3.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    coderay (1.1.2)
-    method_source (0.9.0)
-    pry (0.11.3)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    rake (10.5.0)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  bundler (~> 1.16)
-  mcoin!
-  pry
-  rake (~> 10.0)
-
-BUNDLED WITH
-   1.16.1

data/lib/mcoin/command/ext/has_type.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-module Mcoin
-  module Command
-    # :nodoc:
-    module HasType
-      def self.included(base)
-        base.option(:single, :type, '-t', '--type TYPE',
-                    Mcoin::TYPES, "Available: #{Mcoin::TYPES.join(', ')}")
-        base.option(:single, :currency, '-c', '--currency CURRENCY',
-                    Mcoin::CURRENCY, "Available: #{Mcoin::CURRENCY.join(', ')}")
-      end
-    end
-  end
-end