mbsy 1.0.6 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 55400f2d1afda10b24c6174770194ff84a3030ab
-  data.tar.gz: c1c98554bbfe9a9597367d6b43d4cf36c0e0e731
+  metadata.gz: 4f1f8275167e9967a1cad50454e034743065d6c1
+  data.tar.gz: 1a9f59b52bb3f4c4bd378840077e2b7794726d62
 SHA512:
-  metadata.gz: 953a40b70cb6fb328bc92c4549ea47dfd8b6b9ad2f8b6fd3c055469c21e0a88146334ab390fe60c37d1ed00d93bfcae56309728842907e55b09220ab6467d493
-  data.tar.gz: 156977a400f638f63fc516f0e5ff56d3146cacaa0bb7208a4a9cfd23c056e9cf69d670b6d8ae177d11d2c4a994cae039687c0ab7e49cb4662c4ee727ed14b779
+  metadata.gz: d2e6c864174d070fc0cc532c8ff76f124aba6bcc6d460c21791ee08842bb81264fd05677b251bf2b5736f2e9f80890b327fc44000290c36f12a68f91eef18f02
+  data.tar.gz: 26777be50499700a53b554bbc30179e38277fb633a4ecda46146beceeeb557504578ab2d5e285cd0740a2e6291e750baa2b77cd8aada6059fbf360304e8d28e6

data/.gitignore

@@ -12,6 +12,10 @@ doc
 # bundler
 .bundle
 
+# ruby config
+.ruby-version
+.ruby-gemset
+
 # jeweler generated
 pkg
 

data/Gemfile

@@ -1,3 +1,8 @@
-source :rubygems
+source 'https://rubygems.org'
 
-gemspec
+gemspec
+
+group :debug do
+  gem 'debugger', :platforms => [:mri_19]
+  gem 'byebug', :platforms => [:mri_20, :mri_21]
+end

data/Gemfile.lock

@@ -1,63 +1,71 @@
 PATH
   remote: .
   specs:
-    mbsy (1.0.1)
+    mbsy (1.0.4)
+      httparty (>= 0.8.3)
+      json (>= 1.7.3)
 
 GEM
-  remote: http://rubygems.org/
+  remote: https://rubygems.org/
   specs:
-    activesupport (3.2.6)
-      i18n (~> 0.6)
-      multi_json (~> 1.0)
-    columnize (0.3.6)
-    debugger (1.5.0)
+    activesupport (4.1.1)
+      i18n (~> 0.6, >= 0.6.9)
+      json (~> 1.7, >= 1.7.7)
+      minitest (~> 5.1)
+      thread_safe (~> 0.1)
+      tzinfo (~> 1.1)
+    addressable (2.3.6)
+    byebug (3.1.2)
+      columnize (~> 0.8)
+      debugger-linecache (~> 1.2)
+    columnize (0.8.9)
+    crack (0.4.2)
+      safe_yaml (~> 1.0.0)
+    debugger (1.6.6)
       columnize (>= 0.3.1)
       debugger-linecache (~> 1.2.0)
-      debugger-ruby_core_source (~> 1.2.0)
+      debugger-ruby_core_source (~> 1.3.2)
     debugger-linecache (1.2.0)
-    debugger-ruby_core_source (1.2.0)
-    diff-lcs (1.1.3)
-    factory_girl (2.1.2)
-      activesupport
-    faker (1.0.1)
-      i18n (~> 0.4)
-    fakeweb (1.3.0)
-    httparty (0.8.3)
-      multi_json (~> 1.0)
-      multi_xml
-    i18n (0.6.0)
-    json (1.7.3)
-    multi_json (1.3.6)
-    multi_xml (0.5.1)
-    rake (0.9.2.2)
-    rb-fsevent (0.9.3)
-    rspec (2.7.0)
-      rspec-core (~> 2.7.0)
-      rspec-expectations (~> 2.7.0)
-      rspec-mocks (~> 2.7.0)
-    rspec-core (2.7.1)
-    rspec-expectations (2.7.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.7.0)
-    shoulda (3.0.1)
-      shoulda-context (~> 1.0.0)
-      shoulda-matchers (~> 1.0.0)
-    shoulda-context (1.0.0)
-    shoulda-matchers (1.0.0)
+    debugger-ruby_core_source (1.3.4)
+    diff-lcs (1.2.5)
+    faker (1.3.0)
+      i18n (~> 0.5)
+    httparty (0.13.1)
+      json (~> 1.8)
+      multi_xml (>= 0.5.2)
+    i18n (0.6.9)
+    json (1.8.1)
+    minitest (5.3.3)
+    multi_xml (0.5.5)
+    rake (10.3.1)
+    rspec (2.14.1)
+      rspec-core (~> 2.14.0)
+      rspec-expectations (~> 2.14.0)
+      rspec-mocks (~> 2.14.0)
+    rspec-core (2.14.8)
+    rspec-expectations (2.14.5)
+      diff-lcs (>= 1.1.3, < 2.0)
+    rspec-mocks (2.14.6)
+    safe_yaml (1.0.3)
+    shoulda-matchers (2.6.1)
+      activesupport (>= 3.0.0)
+    thread_safe (0.3.3)
+    tzinfo (1.1.0)
+      thread_safe (~> 0.1)
+    webmock (1.17.4)
+      addressable (>= 2.2.7)
+      crack (>= 0.3.2)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 1.1.1)
+  activesupport (>= 3.2.18)
+  byebug
   debugger
-  factory_girl (~> 2.1.0)
-  faker (~> 1.0.1)
-  fakeweb (~> 1.3.0)
-  httparty (~> 0.8.3)
-  json (~> 1.7.3)
+  faker (~> 1.3.0)
   mbsy!
-  rake (~> 0.9.2)
-  rb-fsevent (~> 0.9.3)
-  rspec (~> 2.7.0)
-  shoulda
+  rake (>= 0.9.2)
+  rspec (~> 2.14.1)
+  shoulda-matchers (= 2.6.1)
+  webmock (~> 1.17.4)

data/README.md

@@ -1,55 +1,51 @@
-# mbsy
+# mbsy [![Gem Version](https://badge.fury.io/rb/mbsy.svg)](http://badge.fury.io/rb/mbsy)
 
 Ambassador API wrapper for Ruby.
 
 This is a lightweight Ruby wrapper for the [Ambassador](http://getambassador.com) API.
 
-### Installation
+## Installation
 
-This library can be installed as a gem. It is hosted on [Rubygems](https://rubygems.org/gems/mbsy).
+Add this line to your application's Gemfile:
 
-You can install this library as a gem using the following command:
-
-$ gem install mbsy
-
-### Usage
+```
+gem 'mbsy'
+```
 
-Simply require this library before you use it:
+And then execute:
 
-```ruby
-require 'mbsy'
+```
+$ bundle
 ```
 
-If you're using Rails 3.x, you could include this gem in your Gemfile.
+Or install it yourself as:
 
-```ruby
-gem 'mbsy'
 ```
-
-Install the gem using the following command:
-$ bundle install
+$ gem install mbsy
+```
 
 If you're using Rails 2 you could include this gem in your configuration, i.e. in `environment.rb`
 
 ```ruby
 config.gem 'mbsy'
 ```
-### Initialise
+
+## Usage
 
 Make sure you include your api credentials in an initialiser.
 
 ```ruby
 Mbsy.configure do |c|
-	c.api_key = 'MY_API_KEY'
-	c.user_name = 'MY_USER_NAME'
+  c.api_key = 'MY_API_KEY'
+  c.user_name = 'MY_USER_NAME'
 end
 ```
 
 The mbsy gem will give you access to classes such as:
 
-* `Mbsy::Company`  
-* `Mbsy::Ambassador`  
-* `Mbsy::Shortcode`
+- `Mbsy::Company`  
+- `Mbsy::Ambassador`  
+- `Mbsy::Shortcode`
 
 Some examples:
 
@@ -80,26 +76,23 @@ Mbsy::Shortcode.find({ :short_code => YOURCAMPAIGNUID })
 
 # Shortcode in a sandbox campaign
 Mbsy::Shortcode.find({ :short_code => YOURCAMPAIGNUID, :sandbox => 1 })
-
-
 ```
 
-### Contributing to mbsy
+## Contributing to mbsy
  
-* Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet.
-* Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it.
-* Fork the project.
-* Start a feature/bugfix branch.
-* Commit and push until you are happy with your contribution.
-* Make sure to add tests for it. This is important so we don't break it in a future version unintentionally.
-* Please try not to mess with the Rakefile, version, or history. If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so I can cherry-pick around it.
+- Check out the latest master to make sure the feature hasn't been implemented or the bug hasn't been fixed yet.
+- Check out the issue tracker to make sure someone already hasn't requested it and/or contributed it.
+- Fork the project.
+- Start a feature/bugfix branch.
+- Commit and push until you are happy with your contribution.
+- Make sure to add tests for it. This is important so we don't break it in a future version unintentionally.
+- Please try not to mess with the Rakefile, version, or history. If you want to have your own version, or is otherwise necessary, that is fine, but please isolate to its own commit so I can cherry-pick around it.
 
-### To Do
+## To Do
 
-Finish of test suite.
+- [ ] Finish off test suite.
 
-### Copyright
+## Copyright
 
-Copyright (c) 2012 Tom Mullen. See LICENSE.txt for
-further details.
+Copyright (c) 2014 ZFERRAL, INC. See LICENSE for further details.
 

data/Rakefile

@@ -1,4 +1,6 @@
 # encoding: utf-8
-require 'bundler'
+require "bundler/gem_tasks"
+
 require 'rspec/core/rake_task'
-RSpec::Core::RakeTask.new('spec')
+RSpec::Core::RakeTask.new(:spec)
+task :default => :spec

data/lib/mbsy/resources/ambassador.rb

@@ -1,19 +1,17 @@
 module Mbsy
   class Ambassador < Base
-    
     def self.find(params={})
       raise ArgumentError, "You must include :email" unless params[:email]
       call('get', params)
     end
-    
+
     def self.all(params={})
       call('all', params)
     end
-    
+
     def self.stats(params={})
       raise ArgumentError, "You must include :email" unless params[:email]
       call('stats', params)
     end
-    
   end
-end
+end

data/lib/mbsy/resources/balance.rb

@@ -1,16 +1,26 @@
 module Mbsy
   class Balance < Base
-    
     def self.update(mode, params={})
-      raise ArgumentError, "You must include :email" unless params[:email]
-      raise ArgumentError, "You must include :amount" unless params[:amount]
       case mode
       when :add
-        call('add', params)
+        add(params)
       when :deduct
-        call('deduct', params)
+        deduct(params)
       end
     end
-    
+
+    def self.add(params = {})
+      raise ArgumentError, "You must include :email" unless params[:email]
+      raise ArgumentError, "You must include :amount" unless params[:amount]
+
+      call('add', params)
+    end
+
+    def self.deduct(params = {})
+      raise ArgumentError, "You must include :email" unless params[:email]
+      raise ArgumentError, "You must include :amount" unless params[:amount]
+
+      call('deduct', params)
+    end
   end
-end
+end

data/lib/mbsy/resources/base.rb

@@ -1,24 +1,37 @@
 module Mbsy
-  class RecordNotFound < StandardError; end
-  class BadResponse < StandardError; end
+  class MbsyError < StandardError; end
+  class BadRequestError < MbsyError; end
+  class UnauthorizedError < MbsyError; end
+  class RecordNotFound < MbsyError; end
+  class ServerError < MbsyError; end
+  class BadResponse < MbsyError; end
+
   class Base
     include HTTParty
     format :json
     default_timeout 30
     default_params :output => 'json'
-    
+
     def self.element_name
       name.split(/::/).last.underscore
     end
+
+    def self.api_url(method)
+      Mbsy.site_uri + self.element_name + '/' + method
+    end
  
     def self.call(method, params = {})
-      api_url = Mbsy.site_uri + self.element_name + '/' + method
-      
-      response = JSON.parse(self.get(api_url, :query => params).body)['response']
+      response = JSON.parse(self.get(api_url(method), :query => params).body)['response']
       case response['code']
-      when "200" # Nothing to do here...
-      when "404"
-        raise RecordNotFound.new(response["errors"]["error"])
+      when '200' # Nothing to do here...
+      when '400'
+        raise BadRequestError.new(response['errors']['error'])
+      when '401'
+        raise UnauthorizedError.new(response['errors']['error'])
+      when '404'
+        raise RecordNotFound.new(response['errors']['error'])
+      when '500'
+        raise ServerError.new(response['errors']['error'])
       else
         raise BadResponse.new(response: response)
       end
@@ -26,4 +39,4 @@ module Mbsy
       response['data']
     end
   end
-end
+end

data/lib/mbsy/resources/commission.rb

@@ -1,10 +1,8 @@
 module Mbsy
   class Commission < Base
-    
     def self.update(params={})
       raise ArgumentError, "You must include either :commission_id or :transaction_uid" unless params[:commission_id] or params[:transaction_uid]
       call('update', params)
     end
-    
   end
-end
+end

data/lib/mbsy/resources/company.rb

@@ -1,13 +1,11 @@
 module Mbsy
   class Company < Base
-        
     def self.get_details
       call('get')
     end
-    
+
     def self.stats
       call('stats')
     end
-    
   end
-end
+end

data/lib/mbsy/resources/event.rb

@@ -1,11 +1,9 @@
 module Mbsy
   class Event < Base
-    
     def self.create(params={})
       raise ArgumentError, "You must include :campaign_uid" unless params[:campaign_uid]
       raise ArgumentError, "You must include :email" unless params[:email]
       call('record', params)
     end
-    
   end
-end
+end

data/lib/mbsy/resources/group.rb

@@ -1,14 +1,12 @@
 module Mbsy
   class Group < Base
-    
     def self.find(params={})
       raise ArgumentError, "You must include :group_id" unless params[:group_id]
       call('get', params)
     end
-    
+
     def self.all(params={})
       call('all', params)
     end
-    
   end
 end

data/lib/mbsy/resources/shortcode.rb

@@ -1,10 +1,8 @@
 module Mbsy
   class Shortcode < Base
-    
     def self.find(params={})
       raise ArgumentError, "You must include :short_code" unless params[:short_code]
       call('get', params)
     end
-    
   end
-end
+end

data/lib/mbsy/resources/social.rb

@@ -1,10 +1,8 @@
 module Mbsy
   class Social < Base
-    
     def self.find(params={})
       raise ArgumentError, "You must include :email" unless params[:email]
       call('addthis', params)
     end
-    
   end
-end
+end

data/lib/mbsy/version.rb

@@ -0,0 +1,3 @@
+module Mbsy
+  VERSION = '1.1.0'
+end

data/lib/mbsy.rb

@@ -12,12 +12,18 @@ require 'mbsy/resources/social'
 
 module Mbsy
   class << self
+    BASE_URI = "https://getambassador.com/api/v2"
+
     attr_accessor :api_key, :user_name
+
+    def site_uri
+      raise 'Mbsy not configured!' if user_name.nil? || api_key.nil?
+
+      "#{BASE_URI}/#{user_name}/#{api_key}/json/"
+    end
+
     def configure
       yield self
-      def self.site_uri
-        "https://getambassador.com/api/v2/#{user_name}/#{api_key}/json/"
-      end
     end
   end
 end

data/mbsy.gemspec

@@ -1,14 +1,18 @@
+# coding: utf-8
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'mbsy/version'
+
 Gem::Specification.new do |s|
   s.name    = 'mbsy'
-  s.version = '1.0.6'
-  s.date    = '2014-05-14'
+  s.version = Mbsy::VERSION
   s.summary = 'A Ruby wrapper for the Ambassador API'
   s.description = ''
   s.author = 'Tom Mullen, Chase Lee'
   s.email = 'support@getambassador.com'
   s.homepage = 'http://github.com/GetAmbassador/mbsy'
   s.license = 'MIT'
-  
+
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.require_paths = ["lib"]
@@ -18,13 +22,10 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency('httparty', '>= 0.8.3')
   s.add_runtime_dependency('json', '>= 1.7.3')
 
-  s.add_development_dependency('rake', '~> 0.9.2')
-  s.add_development_dependency('rspec', '~> 2.7.0')
-  s.add_development_dependency('factory_girl', '~> 2.1.0')
-  s.add_development_dependency('fakeweb', '~> 1.3.0')
-  s.add_development_dependency('faker', '~> 1.0.1')
-  s.add_development_dependency('rb-fsevent', '~> 0.9.3')
-  s.add_development_dependency("shoulda", ">= 0")
-  s.add_development_dependency("bundler", "~> 1.1.1")
-  s.add_development_dependency('debugger', '~> 1.5.0')
+  s.add_development_dependency('rake', '>= 0.9.2')
+  s.add_development_dependency('rspec', '~> 2.14.1')
+  s.add_development_dependency('webmock', '~> 1.17.4')
+  s.add_development_dependency('faker', '~> 1.3.0')
+  s.add_development_dependency('shoulda-matchers', '2.6.1')
+  s.add_development_dependency('activesupport', '>= 3.2.18')
 end

data/spec/mbsy_spec.rb

@@ -2,15 +2,15 @@ require 'spec_helper'
 
 describe Mbsy do
   context 'configuration setup' do
-  
-    it "builds the url correctly" do
+    after { configure_mbsy! }
+
+    it 'builds the url correctly' do
       expect {
         Mbsy.configure do |c|
           c.api_key = "API-123"
           c.user_name = "tester"
         end
-      }.to change { Mbsy.site_uri.to_s }.to("https://getambassador.com/api/v2/tester/API-123/json/")
+      }.to change { Mbsy.site_uri.to_s }.to('https://getambassador.com/api/v2/tester/API-123/json/')
     end
-
   end
-end
+end

data/spec/resources/ambassador_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+describe Mbsy::Ambassador do
+  let(:response) { double(:response) }
+  before { allow(Mbsy::Ambassador).to receive(:call).and_return(response) }
+
+  describe '.find' do
+    it 'raises ArgumentError when missing email param' do
+      expect { Mbsy::Ambassador.find }.to raise_error(ArgumentError, 'You must include :email')
+      expect(Mbsy::Ambassador).to_not have_received(:call)
+    end
+
+    it 'calls #call' do
+      expect(Mbsy::Ambassador.find(email: 'a@example.com')).to eq response
+      expect(Mbsy::Ambassador).to have_received(:call).with('get', email: 'a@example.com')
+    end
+  end
+
+  describe '.all' do
+    it 'calls #call' do
+      expect(Mbsy::Ambassador.all(is_active: 1)).to eq response
+      expect(Mbsy::Ambassador).to have_received(:call).with('all', is_active: 1)
+    end
+  end
+
+  describe '.stats' do
+    it 'raises ArgumentError when missing email' do
+      expect { Mbsy::Ambassador.stats }.to raise_error(ArgumentError, 'You must include :email')
+      expect(Mbsy::Ambassador).to_not have_received(:call)
+    end
+
+    it 'calls #call' do
+      expect(Mbsy::Ambassador.stats(email: 'a@example.com')).to eq response
+      expect(Mbsy::Ambassador).to have_received(:call).with('stats', email: 'a@example.com')
+    end
+  end
+end

data/spec/resources/balance_spec.rb

@@ -0,0 +1,56 @@
+require 'spec_helper'
+
+describe Mbsy::Balance do
+  let(:response) { double(:response) }
+
+  describe '.add' do
+    before { allow(Mbsy::Balance).to receive(:call).and_return(response) }
+
+    it 'raises ArgumentError when missing email' do
+      expect { Mbsy::Balance.add }.to raise_error(ArgumentError, 'You must include :email')
+      expect(Mbsy::Balance).to_not have_received(:call)
+    end
+
+    it 'raises ArgumentError when missing amount' do
+      expect { Mbsy::Balance.add(email: 'a@example.com') }.to raise_error(ArgumentError, 'You must include :amount')
+      expect(Mbsy::Balance).to_not have_received(:call)
+    end
+
+    it 'calls #call' do
+      expect(Mbsy::Balance.add(email: 'a@example.com', amount: 1)).to eq response
+      expect(Mbsy::Balance).to have_received(:call).with('add', email: 'a@example.com', amount: 1)
+    end
+  end
+
+  describe '.deduct' do
+    before { allow(Mbsy::Balance).to receive(:call).and_return(response) }
+
+    it 'raises ArgumentError when missing email' do
+      expect { Mbsy::Balance.deduct }.to raise_error(ArgumentError, 'You must include :email')
+      expect(Mbsy::Balance).to_not have_received(:call)
+    end
+
+    it 'raises ArgumentError when missing amount' do
+      expect { Mbsy::Balance.deduct(email: 'a@example.com') }.to raise_error(ArgumentError, 'You must include :amount')
+      expect(Mbsy::Balance).to_not have_received(:call)
+    end
+
+    it 'calls #call' do
+      expect(Mbsy::Balance.deduct(email: 'a@example.com', amount: 1)).to eq response
+      expect(Mbsy::Balance).to have_received(:call).with('deduct', email: 'a@example.com', amount: 1)
+    end
+  end
+
+  describe '.update' do
+    let(:params) { double(:params) }
+    it 'calls .add' do
+      expect(Mbsy::Balance).to receive(:add).with(params).and_return(response)
+      expect(Mbsy::Balance.update(:add, params)).to eq response
+    end
+
+    it 'calls .deduct' do
+      expect(Mbsy::Balance).to receive(:deduct).with(params).and_return(response)
+      expect(Mbsy::Balance.update(:deduct, params)).to eq response
+    end
+  end
+end

data/spec/resources/base_spec.rb

@@ -0,0 +1,117 @@
+require 'spec_helper'
+
+describe Mbsy::Base do
+  describe '.element_name' do
+    it 'returns element names' do
+      allow(Mbsy::Base).to receive(:name).and_return("Test::Namespace::ElementName")
+      expect(Mbsy::Base.element_name).to eql('element_name')
+    end
+  end
+
+  describe '.api_url' do
+    it 'returns a fully formed api url' do
+      allow(Mbsy::Base).to receive(:element_name).and_return('test_element')
+      expect(Mbsy::Base.api_url('get')).to eq "https://getambassador.com/api/v2/testuser/testapikey/json/test_element/get"
+    end
+  end
+
+  describe '.call' do
+    context 'with a 200 response' do
+      let(:response) do
+        {
+          response: {
+            code: '200',
+            message: 'OK',
+            data: {
+              test: {
+                foo: :bar
+              }
+            }
+          }
+        }.to_json
+      end
+
+      it 'returns response data' do
+        allow(Mbsy::Base).to receive(:element_name).and_return('test_element')
+        stub_request(:get, Mbsy::Base.api_url('get')).
+          with(query: {campaign_uid: 123, email: 'a@example.com', output: :json}).
+          to_return(body: response)
+        expect(Mbsy::Base.call('get', {campaign_uid: 123, email: 'a@example.com'})).
+          to eq({'test' => {'foo' => 'bar'}})
+      end
+    end
+
+    def error_response(code)
+      message = case code
+                when '400'
+                  'BAD REQUEST'
+                when '401'
+                  'UNAUTHORIZED'
+                when '404'
+                  'NOT FOUND'
+                when '500'
+                  'SERVER ERROR'
+                end
+
+      {
+        response: {
+          code: code,
+          message: message,
+          errors: {
+            error: [
+              'boom.'
+            ]
+          }
+        }
+      }.to_json
+    end
+
+    context 'error responses' do
+      before do
+        stub_request(:get, Mbsy::Base.api_url('get')).
+          with(query: {output: :json}).
+          to_return(body: response)
+      end
+
+      context 'with a 400 response' do
+        let(:response) { error_response('400') }
+
+        it 'raises BadRequestError' do
+          expect { Mbsy::Base.call('get') }.to raise_error(Mbsy::BadRequestError)
+        end
+      end
+
+      context 'with a 401 response' do
+        let(:response) { error_response('401') }
+
+        it 'raises UnauthorizedError' do
+          expect { Mbsy::Base.call('get') }.to raise_error(Mbsy::UnauthorizedError)
+        end
+      end
+
+      context 'with a 404 response' do
+        let(:response) { error_response('404') }
+
+        it 'raises a RecordNotFound' do
+          expect { Mbsy::Base.call('get') }.to raise_error(Mbsy::RecordNotFound)
+        end
+      end
+
+      context 'with a 500 response' do
+        let(:response) { error_response('500') }
+
+        it 'raises ServerError' do
+          expect { Mbsy::Base.call('get') }.to raise_error(Mbsy::ServerError)
+        end
+      end
+
+      context 'with another response' do
+        let(:response) { error_response('300') }
+
+        it 'raises a BadResponse' do
+          expect { Mbsy::Base.call('get') }.to raise_error(Mbsy::BadResponse)
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,30 +1,31 @@
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# Require this file using `require "spec_helper.rb"` to ensure that it is only
+# Require this file using `require "spec_helper"` to ensure that it is only
 # loaded once.
 #
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 
 require 'mbsy'
-require 'rspec'
-require 'fakeweb'
-require 'factory_girl'
-require 'faker'
-require 'factories'
-
-FakeWeb.allow_net_connect = false
+require 'active_support/core_ext/string/inflections'
+require 'webmock/rspec'
+WebMock.disable_net_connect! allow_localhost: true
 
-Mbsy.configure do |c|
-  c.api_key = 'test'
-  c.user_name = 'test'
+def configure_mbsy!
+  Mbsy.configure do |c|
+    c.api_key = 'testapikey'
+    c.user_name = 'testuser'
+  end
 end
+configure_mbsy!
 
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
-end
 
-def fake_domain
-  "#{Mbsy.site_uri}/"
-end
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = 'random'
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mbsy
 version: !ruby/object:Gem::Version
-  version: 1.0.6
+  version: 1.1.0
 platform: ruby
 authors:
 - Tom Mullen, Chase Lee
@@ -42,14 +42,14 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.9.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.9.2
 - !ruby/object:Gem::Dependency
@@ -58,30 +58,30 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.7.0
+        version: 2.14.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.7.0
+        version: 2.14.1
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: 1.17.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: 1.17.4
 - !ruby/object:Gem::Dependency
-  name: fakeweb
+  name: faker
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
@@ -95,75 +95,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.3.0
 - !ruby/object:Gem::Dependency
-  name: faker
+  name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: 2.6.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: 2.6.1
 - !ruby/object:Gem::Dependency
-  name: rb-fsevent
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.9.3
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.9.3
-- !ruby/object:Gem::Dependency
-  name: shoulda
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.2.18
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.1.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.1.1
-- !ruby/object:Gem::Dependency
-  name: debugger
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.5.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.5.0
+        version: 3.2.18
 description: ''
 email: support@getambassador.com
 executables: []
@@ -189,11 +147,12 @@ files:
 - lib/mbsy/resources/group.rb
 - lib/mbsy/resources/shortcode.rb
 - lib/mbsy/resources/social.rb
+- lib/mbsy/version.rb
 - mbsy.gemspec
-- spec/ambassador_spec.rb
-- spec/base_spec.rb
-- spec/factories.rb
 - spec/mbsy_spec.rb
+- spec/resources/ambassador_spec.rb
+- spec/resources/balance_spec.rb
+- spec/resources/base_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/GetAmbassador/mbsy
 licenses:
@@ -220,8 +179,8 @@ signing_key:
 specification_version: 4
 summary: A Ruby wrapper for the Ambassador API
 test_files:
-- spec/ambassador_spec.rb
-- spec/base_spec.rb
-- spec/factories.rb
 - spec/mbsy_spec.rb
+- spec/resources/ambassador_spec.rb
+- spec/resources/balance_spec.rb
+- spec/resources/base_spec.rb
 - spec/spec_helper.rb

data/spec/ambassador_spec.rb

@@ -1,57 +0,0 @@
-require 'spec_helper'
-require 'ruby-debug'
-
-describe Mbsy::Ambassador do
-  
-  let(:resource_prefix) { "#{fake_domain}/ambassadors" }
-  before do
-    @existing_ambassador_response =  Mbsy::Ambassador.find(email: 'ambassador@mbsy.co', first_name: 'sigma')
-  end
-
-  context 'find existing ambassador' do
-    subject { Mbsy::Ambassador.find(email: 'ambassador@mbsy.co') }
-    pending 'is an instance of Mbsy::Ambassador' do
-      ambassador.should be_instance_of(Mbsy::Ambassador)
-    end
-    it { should be_instance_of(Hash) }
-    it { should have_key('ambassador') }
-    it { should == @existing_ambassador_response }
-
-    it 'should return an ambassador with the same email' do
-      subject['ambassador']['email'].should == @existing_ambassador_response['ambassador']['email']
-    end
-  end
-  context 'existing ambassador not found' do
-    before do
-      # Stub out creation call since this is hitting a live service
-      FakeWeb.register_uri(:get, "#{resource_prefix}/get/", query: {email: 'new_ambassador@mbsy.co', first_name: 'tester'}, response: File.expand_path('spec/fixtures/ambassador_response_v2.json') )
-    end
-    pending 'creates the ambassador if you cannot find one' do
-      # Need a proper stubbed response before this can work
-      ambassador = Mbsy::Ambassador.find(email: 'new_ambassador@mbsy.co', first_name: 'tester')
-      ambassador['ambassador']['first_name'].should eq('tester')
-    end
-    context 'failed lookup without auto-create' do
-      it "should raise a RecordNotFound error " do
-        lambda{
-          Mbsy::Ambassador.find(email: 'not_found@mbsy.co', auto_create: 0)
-        }.should raise_error(Mbsy::RecordNotFound)
-      end
-    end
-  end
-  
-  it 'returns a list of all ambassadors' do
-    all_response = Mbsy::Ambassador.all
-    ambassadors = all_response['ambassadors']
-    ambassadors.length.should > 0
-    existing_ambassador_in_response = ambassadors.detect{|a| a['email'] == @existing_ambassador_response['ambassador']['email'] }
-    existing_ambassador_in_response.should_not be_nil
-    existing_ambassador_in_response['first_name'].should == 'sigma'
-  end
-  
-  it 'returns stats on an existing ambassador' do
-    ambassador = Mbsy::Ambassador.stats(email: 'ambassador@mbsy.co')
-    ambassador['ambassador']['email'].should eq(@existing_ambassador_response['ambassador']['email'])
-  end
-   
-end

data/spec/base_spec.rb

@@ -1,10 +0,0 @@
-require 'spec_helper'
-
-describe Mbsy::Base do
-  
-  it 'parses element names' do
-    Mbsy::Base.stub!(:name).and_return("Test::Namespace::ElementName")
-    Mbsy::Base.element_name.should eql('element_name')
-  end
-
-end