mblox 0.2.0 → 0.2.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MThhODgzMTYwYWZmMTdjNDJmNDAyZjY0MjUxMmE0Mzk3YzdmYjRiYw==
+    NTE2NzFlOTIxYjBiYjA5YWJhNjEyYzk1ZjcwYzQxZDY3NDVhOTFiNw==
   data.tar.gz: !binary |-
-    YjgyYzE4MGMzNmU4ZDExOGI4NTgzNWE4YWEyODVjOTJlMmY4OTc2Yg==
+    ZDZmNDc0YmVlMzdjM2M4ZGRmNjA5OTFlNzc3YjViNGIzZDRhNGZhNA==
 SHA512:
   metadata.gz: !binary |-
-    OTFmODUwMmRhYmUyNGI1ODY4ZDQ4MTU4YzM1OTgyNmZlYmYxZGY3NWIyMzc0
-    Mjc1Y2I3YzNmZGI2Y2I5NzBjNDdjYWViNTM2OTVkOGZhMzBhYzRiNjVjZWYx
-    NjgxNzJlNTc0Mzc0YmU1ODM0NDJjMjhlZGY3Nzk3NGYzOGJmZjk=
+    YjdjZDA1YWNjZjg4MDZjN2Y4YmI0NzkwOTk4ODM1Y2ZkNjNlN2FjODliZWQ1
+    MTliNzIyN2VhMGRkZGY0M2JhYWM0YjU1OTU4ZWM4ZTIzODEzYTQ0MzgzMjYw
+    N2NlMmM2Zjc0ZDE5ZDVhZDIwM2EwODY5MjU3ODU4ZWQ2NTAxNWI=
   data.tar.gz: !binary |-
-    NGFkYTc4MGIyZmQyYWI3YjRlM2M5YjQ1MjE4OWJiOGMzNzM5ZjBkODlhMGRm
-    YWU5ODQ2ZjU0MGYxNWQ2ODBjODIzNDhiYTY3NTA3MDM0ZWUzNDE2NGI4OTRl
-    OTg3NmZkYjAxMzUxNmJkMjI5Yzc3ZDdjMjIyMzJjZGNlODMzYjA=
+    OWEzYmNjOTU0MjBkYTZiYmRiODBiNTAxMmQyNjlhNzFlOGY3MjRiNmQ3ZTYw
+    MWFlYTEyYWQ4ZmJiYjQ2Y2QzZGY2ZmIxNjNmZDNkNTVhYmQ3ZDk3OGRiMDA3
+    MmQ0NDNjMGUyNmFiZWYyNmJiMzJmZjc5MmFjNTU5NGJmNDBjNjk=

data/lib/mblox/sms.rb

@@ -21,7 +21,7 @@ module Mblox
       :split => Proc.new { |message| split_message(message) }
     }
 
-    def initialize(phone,message)
+    def initialize(phone, message, batch_id=nil)
       phone = phone.to_s
       raise InvalidPhoneNumberError, "Phone number must be ten digits" unless /\A[0-9]{10}\z/.match(phone)
       raise InvalidPhoneNumberError, "Phone number cannot begin with 0 or 1" if ['0','1'].include?(phone[0].to_s)
@@ -31,6 +31,7 @@ module Mblox
       Mblox.log "WARNING: Some characters may be lost because the message must be broken into at least 1000 sections" if message.size > (999 * MAX_SECTION_LENGTH)
       @message = (message.size > MAX_LENGTH) ? ON_MESSAGE_TOO_LONG_HANDLER[Mblox.config.on_message_too_long].call(message) : [message.dup]
       @phone = "1#{phone}"
+      @batch_id = batch_id.to_i unless batch_id.blank?
     end
 
     def send
@@ -54,7 +55,7 @@ module Mblox
 	    nh.PartnerName(Mblox.config.partner_name)
 	    nh.PartnerPassword(Mblox.config.password)
 	  end
-	  nr.NotificationList(:BatchID => 1) do |nl|
+	  nr.NotificationList(:BatchID => @batch_id || 1) do |nl|
 	    nl.Notification(:SequenceNumber => 1, :MessageType => :SMS, :Format => :UTF8) do |n|
 	      n.Message do |m|
                 m.cdata!(message)

data/lib/mblox/version.rb

@@ -1,3 +1,3 @@
 module Mblox
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/sms_spec.rb

@@ -1,6 +1,14 @@
 # encoding: UTF-8
 require "spec_helper"
 
+module Mblox
+  class Sms
+    def build_for_test(message)
+      build(message)
+    end
+  end
+end
+
 describe Mblox::Sms do
   def the_message
     "Mblox gem test sent at #{Time.now}"
@@ -134,4 +142,26 @@ describe Mblox::Sms do
       end
     end
   end
+
+  describe "batch_id" do
+    it "can be specified" do
+      batch_id = 12345
+      sms = Mblox::Sms.new(LANDLINE,the_message, batch_id)
+      content = Hash.from_xml(sms.build_for_test(the_message))
+      content['NotificationRequest']['NotificationList']['BatchID'].should eq("#{batch_id}")
+    end
+
+    it "get converted to a Fixnum" do
+      batch_id = 12345
+      sms = Mblox::Sms.new(LANDLINE,the_message, "#{batch_id}ab")
+      content = Hash.from_xml(sms.build_for_test(the_message))
+      content['NotificationRequest']['NotificationList']['BatchID'].should eq("#{batch_id}")
+    end
+
+    it "defaults to 1" do
+      sms = Mblox::Sms.new(LANDLINE,the_message)
+      content = Hash.from_xml(sms.build_for_test(the_message))
+      content['NotificationRequest']['NotificationList']['BatchID'].should eq('1')
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mblox
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Isaac Betesh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-09 00:00:00.000000000 Z
+date: 2013-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler