mblox 0.1.0 → 0.2.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MmIxY2E0ZmM4NmU1ZWMwZmYwNGFmMDMyZGJkNDY4ZmQ2ZjhmNTM4Mw==
+    MThhODgzMTYwYWZmMTdjNDJmNDAyZjY0MjUxMmE0Mzk3YzdmYjRiYw==
   data.tar.gz: !binary |-
-    ZTExZGY3ODg3Mzg2M2RkNmQwMTUxNzI5YzRmMGMzYzc3ZjA1NzhlZg==
+    YjgyYzE4MGMzNmU4ZDExOGI4NTgzNWE4YWEyODVjOTJlMmY4OTc2Yg==
 SHA512:
   metadata.gz: !binary |-
-    MGQ2MjM0YjY0MDk0MWU1MmIzNTRlZDQwZGIyZjhiNGQ2ZDQ3YjI1ODJmMjk1
-    YmVlZWViMGIxMjNhY2U1OGI4OGY3YzNlNWM4MGRkNTNjNDdjMzI0NjcxMDZi
-    YjMwY2MxMjk2ZjU1OThkMjM5MWQ2ZTBhNjQ1NTllZjE2MjJmNDg=
+    OTFmODUwMmRhYmUyNGI1ODY4ZDQ4MTU4YzM1OTgyNmZlYmYxZGY3NWIyMzc0
+    Mjc1Y2I3YzNmZGI2Y2I5NzBjNDdjYWViNTM2OTVkOGZhMzBhYzRiNjVjZWYx
+    NjgxNzJlNTc0Mzc0YmU1ODM0NDJjMjhlZGY3Nzk3NGYzOGJmZjk=
   data.tar.gz: !binary |-
-    OTI0ZGM4YTlhNzZmMGU4ZTVkNjg0MjQ5NmUzZTBiZjNlNzBkNDY2Mjg4N2Y1
-    ZDQyNDUzMjMwMzk0MjI3YTIxM2UzN2FiYWM4YzkxMTg0ZGM2ZTQ0NzE1ZWI3
-    NmIwMjRjMzk4MmY4NTRiZmIyZjMxYTY3MzE1Y2FjODA1YTY4YmQ=
+    NGFkYTc4MGIyZmQyYWI3YjRlM2M5YjQ1MjE4OWJiOGMzNzM5ZjBkODlhMGRm
+    YWU5ODQ2ZjU0MGYxNWQ2ODBjODIzNDhiYTY3NTA3MDM0ZWUzNDE2NGI4OTRl
+    OTg3NmZkYjAxMzUxNmJkMjI5Yzc3ZDdjMjIyMzJjZGNlODMzYjA=

data/lib/mblox/sms_response.rb

@@ -21,7 +21,7 @@ module Mblox
         @code, @text = (code.to_i.to_s == code ? code.to_i : code), text
       end
 
-      def is_ok?
+      def ok?
         0 == @code
       end
 
@@ -50,7 +50,7 @@ module Mblox
       @result = Result.new(result_list['NotificationResultCode'], result_list['NotificationResultText'])
       @result = nil unless @result.valid?
 
-      if @result.is_ok?
+      if @result.ok?
         result_list = result_list['SubscriberResult']
         raise MissingExpectedXmlContentError, "Xml should have contained a 'NotificationRequestResult' -> 'NotificationResultList' => 'NotificationResult' -> 'SubscriberResult' node, but was #{xml}" if result_list.blank?
         @subscriber_result = Result.new(result_list['SubscriberResultCode'], result_list['SubscriberResultText'])
@@ -58,12 +58,12 @@ module Mblox
       end
     end
 
-    def is_ok?
-      @request.is_ok? && @result.is_ok? && @subscriber_result.is_ok?
+    def ok?
+      @request.ok? && @result.ok? && @subscriber_result.ok?
     end
 
-    def is_unroutable?
-      @request.is_ok? && @result.is_ok? && Result::UNROUTABLE == @subscriber_result
+    def unroutable?
+      @request.ok? && @result.ok? && Result::UNROUTABLE == @subscriber_result
     end
   end
 end

data/lib/mblox/version.rb

@@ -1,3 +1,3 @@
 module Mblox
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/sms_response_result_spec.rb

@@ -29,14 +29,14 @@ describe Mblox::SmsResponse::Result do
     end
   end
 
-  describe "is_ok?" do
+  describe "ok?" do
     it "is true for code 0" do
-      described_class.new(0, "123").is_ok?.should be_true
+      described_class.new(0, "123").ok?.should be_true
     end
 
     10.times do |i|
       it "is false for code #{i+1}" do
-        described_class.new(i+1, "123").is_ok?.should be_false
+        described_class.new(i+1, "123").ok?.should be_false
       end
     end
   end

data/spec/sms_spec.rb

@@ -57,7 +57,7 @@ describe Mblox::Sms do
       @mblox.message.should eq(["(MSG 1/4): #{message[0,145]}", "(MSG 2/4): #{message[145,145]}", "(MSG 3/4): #{message[290,145]}", "(MSG 4/4): #{message[435,145]}"])
       response = @mblox.send
       response.count.should eq(4)
-      response.each { |r| r.is_unroutable?.should be_true }
+      response.each { |r| r.unroutable?.should be_true }
     end
 
     it "should be split into multiple messages when longer than 160 characters if configured to split and not even split" do
@@ -67,7 +67,7 @@ describe Mblox::Sms do
       @mblox.message.should eq(["(MSG 1/3): #{message[0,145]}", "(MSG 2/3): #{message[145,145]}", "(MSG 3/3): #{message[290..-1]}"])
       response = @mblox.send
       response.count.should eq(3)
-      response.each { |r| r.is_unroutable?.should be_true }
+      response.each { |r| r.unroutable?.should be_true }
     end
 
     it "should be safe from changing when short" do
@@ -96,8 +96,8 @@ describe Mblox::Sms do
 
   describe "SMS messages" do
     def expect_ok_response(response)
-      response.is_ok?.should be_true
-      response.is_unroutable?.should be_false
+      response.ok?.should be_true
+      response.unroutable?.should be_false
     end
 
     it "should be sent when the phone number is a Fixnum" do
@@ -121,16 +121,16 @@ describe Mblox::Sms do
     it "should be unroutable when sent to a landline" do
       response = Mblox::Sms.new(LANDLINE,the_message).send
       response.size.should eq(1)
-      response.first.is_unroutable?.should be_true, "#{response.first.inspect} should have been unroutable"
-      response.first.is_ok?.should be_false
+      response.first.unroutable?.should be_true, "#{response.first.inspect} should have been unroutable"
+      response.first.ok?.should be_false
     end
 
     "\r\n!\"#$\%&'\(\)*+,-.\/:;<=>?@_£¤¥§¿iÄÅÆÇÉÑÖØÜßáäåæèéìñòöøùü\tí¡ ".each_char do |i|
       it "allows the special char #{i}, correctly escaping illegal XML characters where necessary" do
         response = Mblox::Sms.new(LANDLINE,"#{the_message}#{i}#{the_message}").send
         response.size.should eq(1)
-        response.first.is_ok?.should be_false
-        response.first.is_unroutable?.should be_true
+        response.first.ok?.should be_false
+        response.first.unroutable?.should be_true
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mblox
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Isaac Betesh