mbeditor 0.13.0 → 0.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b65424322b66f78929de0629db6e4644a76467e889adaee77121b8c52e0e50de
-  data.tar.gz: 53cd7724f2a80011d474a9616bdb35d88859ddf797a0fa51d3657740038624bd
+  metadata.gz: fe5dce956e01ff66387b9ccf99fc8b163ce131a226158eda7b6cf2c8513eaa09
+  data.tar.gz: 37e4f12f4ccd1ca7d209e7fe134a25d813bbe175862d53a470a5042aff9d7797
 SHA512:
-  metadata.gz: f4470580292e46d6de7eb2e3687193452bfbcbee5d478e48c6460e22739fd2942d1a525b04e6d3f7877175db5d18da86c3241032dfc748ca91bf62f0f008cd90
-  data.tar.gz: 05e4226ce7151a7e72d18f34018c30acc04adfbaea235a891afe12ecadb52170b1b598820ea7de326068eae7bb7811cce13ec5cf42b0c69fd6c77683c3b7c819
+  metadata.gz: 60c74bb23b92719d4273d720af42813e2ecd3d639281901d47037e332697819cbe58c338eea9aeff334f3533d48d2e62c994b2122fb36fbded4bef94bd225b36
+  data.tar.gz: 1451f3b2effb5d9cffd9811b41ea72b07d174702af9e6dc9993d5fbc92d990109dbf834e957c1eced22e8d77b815173d14bf6465b51072002a0e1c482745dc69

data/CHANGELOG.md

@@ -5,7 +5,72 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased]
+## [0.13.1] - 2026-08-26
+
+### Removed
+- **The whole-suite test run is gone** — the status-bar "Tests" button, the
+  Test Run drawer, `POST /test_all`, and the `test_all_command` /
+  `test_all_timeout` settings. It was one blocking request holding a
+  development-server thread for the length of the suite, with no way to cancel
+  it and the runner's output buffered whole in the server process; on a real
+  host app that is twenty minutes of a frozen-looking button for a result the
+  terminal gives you faster and interruptibly. The per-file (and per-line) test
+  run stays — that one is scoped, finishes in seconds and is why the editor
+  runs tests at all. **A host app setting `test_all_command` or
+  `test_all_timeout` in its initializer must drop those lines.**
+- **The ruby-lsp status-bar chip is gone**, along with its 10-second health
+  poll. ruby-lsp itself is untouched — definitions, hover, completion,
+  diagnostics and the rest all still run through it.
+
+### Added
+- `rake mbeditor:scan_duplicates` — scans the workspace for files that contain a
+  duplicated copy of themselves, for finding files damaged before the seeding fix below.
+  Set `MBEDITOR_WORKSPACE_ROOT` to scan a tree other than the resolved workspace.
+
+### Fixed
+- **Data loss: a saved file could contain two copies of itself.** When two editor
+  clients attached to a collaborative room the server had no state for — a fresh
+  room, or one evicted while both sat idle — each one seeded the shared document
+  from disk, and Yjs merged both inserts at offset 0 into two concatenated copies.
+  Saving then wrote the doubled buffer. The server now grants the right to seed a
+  room to exactly one client (`CollaborationDocStore.claim_seed`), never evicts a
+  room that still has subscribers, and a client whose cable reconnects re-publishes
+  its snapshot so a server that lost its state cannot hand out a second seed.
+- **Status bar alignment.** Every item now sits in the same 8px cell instead of
+  carrying its own padding on top of the bar's (the branch, the offline chip
+  and the version each had a different one), the branch drops from 13px to the
+  bar's 11px, and `line-height: 1` on the bar *and* on its buttons puts an icon
+  and the number beside it in identical line boxes — Pico gives `<button>` its
+  own 1.5, so the problem counts sat in a 16.5px box next to an 11px icon.
+- **The Problems panel's Fix button did nothing visible.** `rubocop -a` writes
+  its corrections to disk, but reports the offenses it just fixed alongside the
+  ones it left — each flagged both `corrected` and `correctable` — so the list
+  after a fix was byte-identical to the list before it and the button stayed
+  lit. Corrected offenses are now dropped from the response, open buffers are
+  re-read after the run, and clearing stale diagnostics now clears the React
+  marker map as well as Monaco's, which is what had left the panel, the tab
+  badges and the status-bar tallies disagreeing.
+- **Quick Open matches loosely again.** MiniSearch was configured `fuzzy: false`,
+  so a single typo found nothing; fuzziness is now scaled per term. Folders sort
+  after files instead of ahead of every match, and the dialog and its text are
+  larger.
+- **Search results read like VS Code's.** Hits group under a collapsible row per
+  file with a match count, the matched text is tinted with the accent colour and
+  is kept on screen at any panel width (eliding left and right around it), and
+  clicking a hit selects the match and leaves the cursor at its end.
+- **Bulk import no longer opens on the previous import's folder** — the folder
+  you actually acted on is offered first — and it now reports what it wrote and
+  reveals the destination in the tree.
+- `ReactRailsUJS` no longer reports as undefined; it ships inside the react-rails
+  gem, outside the workspace, so no static scan of the tree could ever find it.
+- `<<~JSX` heredocs highlight as JavaScript (as do `<<~TSX`/`<<~TS`).
+- The Open Editors list no longer runs its filenames underneath the split and
+  close buttons.
+
+### Changed
+- **The activity bar is a third narrower** (60px to 40px), and the editor
+  toolbar's per-file Test button is gone; running the test under the cursor is
+  unaffected.
 
 ## [0.13.0] - 2026-08-20
 

data/app/assets/javascripts/mbeditor/application.js

@@ -27,7 +27,6 @@
 //= require mbeditor/components/TestResultsPanel
 //= require mbeditor/components/LogPanel
 //= require mbeditor/components/ProblemsPanel
-//= require mbeditor/components/TestRunPanel
 //= require mbeditor/components/CodeReviewPanel
 //= require mbeditor/components/EditorPanel
 //= require mbeditor/components/FileTree

data/app/assets/javascripts/mbeditor/collaboration_service.js

@@ -225,6 +225,9 @@ var CollaborationService = (function () {
       binding: null,
       undoManager: null,
       lateJoin: false,
+      // Set from the sync handshake: the server grants the right to seed an empty
+      // room's shared doc from disk to exactly one client (see claim_seed).
+      seedGranted: false,
       onSeeded: null,
       attachRequested: false,
       degraded: false,
@@ -280,10 +283,14 @@ var CollaborationService = (function () {
           if (d) window.Y.applyUpdate(room.doc, _b64ToU8(d), REMOTE);
         });
       }
+      room.seedGranted = !!data.seed;
       room.synced = true;
       _maybeAttach(room);
     } else if (data.type === 'doc_update') {
       if (data.update) window.Y.applyUpdate(room.doc, _b64ToU8(data.update), REMOTE);
+      // A client that deferred attaching (empty room, seed granted to someone
+      // else) is waiting for exactly this: the seeder's content has landed.
+      _maybeAttach(room);
     } else if (data.type === 'awareness') {
       if (data.awareness && room.awareness && window.awarenessProtocol) {
         // REMOTE origin keeps the outbound handler from echoing peer state back.
@@ -312,7 +319,13 @@ var CollaborationService = (function () {
       room.subscription = WebSocketService.subscribeCollaboration(path, {
         // Awareness is never server-persisted, so peers lost our caret with the
         // connection and would not see it again until we happened to move.
-        connected: function () { _sendLocalAwareness(room); },
+        // The server may have lost the room entirely (restart): re-publish our
+        // content so the next opener late-joins instead of being granted a seed
+        // that would merge a second copy into what we still hold.
+        connected: function () {
+          _sendLocalAwareness(room);
+          if (room.binding) pushSnapshot(path);
+        },
         received: function (data) { _onMessage(room, data); }
       });
     });
@@ -346,6 +359,11 @@ var CollaborationService = (function () {
 
   function _maybeAttach(room) {
     if (room.binding || !room.synced || !room.attachRequested || !room.model) return;
+    // Shared doc still empty and the seed was granted to another client: its
+    // content is on its way. Binding now would hand the model to an empty Y.Text
+    // and wipe the buffer, so wait for the first doc_update (or the fallback
+    // timer, which lets the natively-loaded content stand).
+    if (room.text.length === 0 && !room.seedGranted && room.model.getValue().length > 0) return;
     _doAttach(room);
   }
 
@@ -353,10 +371,12 @@ var CollaborationService = (function () {
     var model = room.model;
     room.lateJoin = room.text.length > 0; // server already had shared state
 
-    if (!room.lateJoin && model.getValue().length > 0) {
+    if (!room.lateJoin && room.seedGranted && model.getValue().length > 0) {
       // First opener whose disk content is already in the model: seed the shared
       // doc from it before constructing the binding, otherwise the binding would
       // overwrite the model to match the (empty) Y.Text and wipe the content.
+      // Only ever the client the SERVER picked — two clients each seeding an
+      // empty room merge into two concatenated copies of the file.
       room.doc.transact(function () { room.text.insert(0, model.getValue()); });
     }
 

data/app/assets/javascripts/mbeditor/components/EditorPanel.js

@@ -24,16 +24,13 @@ var EditorPanel = function EditorPanel(_ref) {
   var onContentChange = _ref.onContentChange;
   var markers = _ref.markers;
   var gitAvailable = _ref.gitAvailable === true;
-  var testAvailable = _ref.testAvailable === true;
   var onFormat = _ref.onFormat;
   var onSave = _ref.onSave;
-  var onRunTest = _ref.onRunTest;
   var onRunTestAtCursor = _ref.onRunTestAtCursor;
   var onShowHistory = _ref.onShowHistory;
   var treeData = _ref.treeData || [];
   var testResult = _ref.testResult;
   var testPanelFile = _ref.testPanelFile;
-  var testLoading = _ref.testLoading;
   var testInlineVisible = _ref.testInlineVisible;
   var editorPrefs = _ref.editorPrefs || {};
   var monacoReady = _ref.monacoReady !== false; // undefined means Monaco already loaded (legacy callers)
@@ -1323,9 +1320,18 @@ var EditorPanel = function EditorPanel(_ref) {
       var column = tab.gotoCol || 1;
       var maxColumn = model.getLineMaxColumn(line);
       if (column > maxColumn) column = maxColumn;
+      // With both bounds the match itself is selected and the cursor ends up
+      // just past it — where you'd start typing. With only gotoCol the
+      // selection is empty, which is exactly setPosition.
+      var endColumn = Math.min(tab.gotoEndCol || column, maxColumn);
 
       editor.revealLineInCenter(line);
-      editor.setPosition({ lineNumber: line, column: column });
+      // setSelection(IRange) parks the cursor at the range's end, so no
+      // setPosition afterwards — that would collapse the selection again.
+      editor.setSelection({
+        startLineNumber: line, startColumn: column,
+        endLineNumber: line, endColumn: endColumn
+      });
       editor.focus();
 
       TabManager.saveTabViewState(tab.id, editor.saveViewState());
@@ -1333,7 +1339,7 @@ var EditorPanel = function EditorPanel(_ref) {
     }, 50);
 
     return function () { clearTimeout(timer); };
-  }, [tab.gotoLine, tab.gotoCol, tab.content, tab.loading]);
+  }, [tab.gotoLine, tab.gotoCol, tab.gotoEndCol, tab.content, tab.loading]);
 
   // Apply RuboCop markers
   useEffect(function () {
@@ -1803,74 +1809,6 @@ var EditorPanel = function EditorPanel(_ref) {
     return src === derived;
   };
 
-  var testFileCandidates = function(relativePath) {
-    if (!relativePath || !relativePath.endsWith('.rb')) return [];
-
-    var basename = relativePath.slice(0, -3);
-    var dirParts = relativePath.split('/');
-    var leafName = basename.split('/').pop();
-    var candidates = [];
-
-    if (dirParts[0] === 'app' && dirParts.length > 1) {
-      var subPath = dirParts.slice(1).join('/');
-      var subDir = subPath.indexOf('/') !== -1 ? subPath.slice(0, subPath.lastIndexOf('/')) : '';
-      candidates.push('test/' + (subDir ? subDir + '/' : '') + leafName + '_test.rb');
-      candidates.push('spec/' + (subDir ? subDir + '/' : '') + leafName + '_spec.rb');
-    }
-
-    if (dirParts[0] === 'lib') {
-      var libSubPath = dirParts.slice(1).join('/');
-      var libSubDir = libSubPath.indexOf('/') !== -1 ? libSubPath.slice(0, libSubPath.lastIndexOf('/')) : '';
-      candidates.push('test/lib/' + (libSubDir ? libSubDir + '/' : '') + leafName + '_test.rb');
-      candidates.push('test/' + (libSubDir ? libSubDir + '/' : '') + leafName + '_test.rb');
-      candidates.push('spec/lib/' + (libSubDir ? libSubDir + '/' : '') + leafName + '_spec.rb');
-    }
-
-    candidates.push('test/' + leafName + '_test.rb');
-    candidates.push('spec/' + leafName + '_spec.rb');
-
-    return candidates.filter(function(candidate, index, list) {
-      return list.indexOf(candidate) === index;
-    });
-  };
-
-  var treeHasPath = function(nodes, targetPath) {
-    if (!targetPath) return false;
-    var stack = (nodes || []).slice();
-
-    while (stack.length) {
-      var node = stack.pop();
-      if (!node) continue;
-      if (node.path === targetPath) return true;
-      if (node.children && node.children.length) {
-        stack.push.apply(stack, node.children);
-      }
-    }
-
-    return false;
-  };
-
-  var matchingTestFilePath = function(sourcePath) {
-    var normalized = (sourcePath || '').replace(/^\/+/, '');
-    if (!normalized || !normalized.endsWith('.rb')) return null;
-    if (/^(test|spec)\//.test(normalized) && /_(test|spec)\.rb$/.test(normalized)) return normalized;
-
-    var candidates = testFileCandidates(normalized);
-    for (var i = 0; i < candidates.length; i += 1) {
-      if (treeHasPath(treeData, candidates[i])) return candidates[i];
-    }
-
-    return null;
-  };
-
-  // treeHasPath walks the whole file tree once per candidate, and the Test
-  // button asked for this on every render — so once per keystroke. treeData is
-  // deliberately outside the React.memo comparator below, so it can only change
-  // on a render this component was going to do anyway.
-  var testFileForTab = useMemo(function () {
-    return matchingTestFilePath(tab.path);
-  }, [tab.path, treeData]);
-
   // Map a test method name to the best-matching line in the source file.
   // Extracts keywords from the test name and scores each source line.
   var mapTestToSourceLine = function(testName, sourceContent) {
@@ -2330,18 +2268,6 @@ var EditorPanel = function EditorPanel(_ref) {
         React.createElement('i', { className: 'fas fa-shoe-prints', style: { marginRight: editorPrefs.toolbarIconOnly ? 0 : '5px', flexShrink: 0 } }),
         !editorPrefs.toolbarIconOnly && React.createElement('span', { className: 'ide-toolbar-label' }, isBlameLoading ? 'Loading...' : 'Blame')
       ),
-      testAvailable && testFileForTab && React.createElement(
-        'button',
-        {
-          className: 'ide-icon-btn',
-          onClick: function() { if (onRunTest) onRunTest(); },
-          disabled: testLoading,
-          'aria-busy': !!testLoading,
-          title: 'Run Tests'
-        },
-        !testLoading && React.createElement('i', { className: 'fas fa-flask', style: { marginRight: editorPrefs.toolbarIconOnly ? 0 : '5px', flexShrink: 0 } }),
-        !editorPrefs.toolbarIconOnly && !testLoading && React.createElement('span', { className: 'ide-toolbar-label' }, 'Test')
-      )
     ),
     conflictCount > 0 && React.createElement(
       'div', { className: 'mb-conflict-banner' },
@@ -2612,10 +2538,8 @@ window.EditorPanel = React.memo(EditorPanel, function(prev, next) {
     prev.paneId === next.paneId &&
     (prev.markers === next.markers || (prev.markers.length === 0 && next.markers.length === 0)) &&
     prev.gitAvailable === next.gitAvailable &&
-    prev.testAvailable === next.testAvailable &&
     prev.testResult === next.testResult &&
     prev.testPanelFile === next.testPanelFile &&
-    prev.testLoading === next.testLoading &&
     prev.testInlineVisible === next.testInlineVisible &&
     prev.editorPrefs === next.editorPrefs &&
     prev.monacoReady === next.monacoReady;

data/app/assets/javascripts/mbeditor/components/ImportDialog.js

@@ -88,7 +88,15 @@ var ImportDialog = function ImportDialog(_ref) {
     options.push(destOption(prefix, label, hint));
   };
 
-  if (initialFolder) offer(initialFolder, initialFolder, 'selected folder');
+  // The folder this upload was started from is always first and always the
+  // active one. Offering it after the suggestions meant that once you had
+  // imported a folder anywhere, that same folder scored top of the suggestion
+  // list next time and sat at the head of the options — so the dialog read as
+  // "it remembered where I last put things". With nothing selected it was
+  // worse: the previous destination was the first option and the actually
+  // chosen one ("Workspace root") was last.
+  offer(initialFolder, initialFolder || 'Workspace root',
+    initialFolder ? 'selected folder' : 'create the folders from the root');
   suggestions.forEach(function (s) {
     var bits = [];
     if (s.files) bits.push(s.files + ' matching file' + (s.files === 1 ? '' : 's'));