mbeditor 0.13.0 → 0.13.1

data/app/assets/stylesheets/mbeditor/editor.css

@@ -205,8 +205,8 @@ html, body, #mbeditor-root {
 
 /* ── Activity Bar (VSCode-style, always visible) ───────── */
 .ide-activity-bar {
-  width: 60px;
-  min-width: 60px;
+  width: 40px;
+  min-width: 40px;
   flex-shrink: 0;
   background: var(--ide-panel-bg);
   border-right: 1px solid var(--ide-border);
@@ -240,7 +240,7 @@ html, body, #mbeditor-root {
    than a bare class and was silently winning. */
 .ide-activity-bar .ide-activity-btn {
   width: 100%;
-  height: 60px;
+  height: 40px;
   background: transparent;
   border: none;
   /* Always reserve the indicator's width so the glyph does not shift sideways
@@ -252,7 +252,7 @@ html, body, #mbeditor-root {
   align-items: center;
   justify-content: center;
   cursor: pointer;
-  font-size: 25px;
+  font-size: 17px;
   transition: color 0.12s ease;
 }
 
@@ -876,23 +876,33 @@ html, body, #mbeditor-root {
 }
 
 /* ── Status Bar ──────────────────────────────────────────── */
+/* line-height: 1 is what keeps an icon and the number beside it on the same
+ * centre line. Pico's inherited 1.5 gave every text span a 16.5px line box
+ * inside a 22px bar while the icons' box was 11px, so the two were centred on
+ * different half-leadings; with 1 both boxes are the font's own content box
+ * and flex centres them together. */
 .ide-statusbar {
   display: flex;
   align-items: center;
   background: var(--ide-accent);
   height: 22px;
-  padding: 0 8px;
-  gap: 4px;
+  padding: 0;
+  gap: 0;
   flex-shrink: 0;
   font-size: 11px;
+  line-height: 1;
   color: var(--ide-accent-text);
 }
 
+/* One cell rhythm for every item, button or not. The branch, the message and
+ * the chips each carried their own padding on top of the bar's, so the gaps
+ * between them were all different widths. */
+.ide-statusbar > * { padding: 0 8px; }
+
 .statusbar-branch {
   display: flex;
   align-items: center;
-  gap: 6px;
-  font-size: 13px;
+  gap: 4px;
   font-weight: 600;
   color: var(--ide-accent-text);
 }
@@ -926,7 +936,6 @@ html, body, #mbeditor-root {
   font-size: 12px;
   font-weight: 600;
   color: var(--ide-danger);
-  padding: 0 10px;
   animation: statusbar-pulse 2s ease-in-out infinite;
 }
 
@@ -1026,7 +1035,6 @@ html, body, #mbeditor-root {
   color: color-mix(in srgb, var(--ide-accent-text) 45%, transparent);
   font-size: 10px;
   white-space: nowrap;
-  padding-left: 8px;
   cursor: pointer;
 }
 .statusbar-version:hover {
@@ -1039,7 +1047,6 @@ html, body, #mbeditor-root {
   font-weight: 600;
   letter-spacing: 0.04em;
   opacity: 0.85;
-  padding: 0 6px;
 }
 
 .statusbar-zen-btn {
@@ -1225,52 +1232,88 @@ html, body, #mbeditor-root {
   to { transform: rotate(360deg); }
 }
 
+/* Tree rows. Both kinds are pinned to the same 22px because MbeditorApp
+   windows them by index * SEARCH_ROW_HEIGHT — change one and change both. */
+.search-result-file-row,
 .search-result-item {
-  height: 40px;
-  padding: 4px 6px;
+  height: 22px;
   cursor: pointer;
-  border-radius: 3px;
   transition: background 0.1s;
-  border-bottom: 1px solid var(--ide-input-bg);
   display: flex;
   align-items: center;
-  gap: 8px;
+  gap: 6px;
   overflow: hidden;
   box-sizing: border-box;
   flex-shrink: 0;
 }
 
+.search-result-file-row { padding: 0 6px; }
+/* Indented under its file header, the way the explorer nests children. */
+.search-result-item { padding: 0 6px 0 24px; }
+
+.search-result-file-row:hover,
 .search-result-item:hover { background: var(--ide-hover-bg); }
 
+.search-result-chevron {
+  flex-shrink: 0;
+  width: 12px;
+  font-size: 12px;
+  color: var(--ide-text-muted);
+}
+
 .search-result-icon {
   flex-shrink: 0;
   width: 16px;
-  margin-top: 2px;
   text-align: center;
   color: #78b4e0;
 }
 
-.search-result-body {
-  min-width: 0;
-  flex: 1;
+.search-result-file-name {
+  font-size: 12px;
+  color: var(--ide-text);
+  white-space: nowrap;
+  flex-shrink: 0;
+  max-width: 60%;
+  overflow: hidden;
+  text-overflow: ellipsis;
 }
 
-.search-result-file {
-  font-size: 11px;
-  color: var(--ide-accent-fg);
-  font-weight: 500;
+.search-result-file-dir {
+  font-size: 10px;
+  color: var(--ide-text-muted);
   white-space: nowrap;
   overflow: hidden;
   text-overflow: ellipsis;
+  flex: 1;
+  min-width: 0;
+}
+
+/* Match count, VS Code's little pill on the right of the file row. */
+.search-result-count {
+  flex-shrink: 0;
+  margin-left: auto;
+  min-width: 16px;
+  padding: 0 5px;
+  border-radius: 9px;
+  background: var(--ide-input-bg);
+  color: var(--ide-text-muted);
+  font-size: 10px;
+  line-height: 15px;
+  text-align: center;
 }
 
 .search-result-line-num {
+  flex-shrink: 0;
   font-size: 10px;
   color: var(--ide-text-muted);
-  margin-left: 4px;
+  font-family: monospace;
+  min-width: 28px;
+  text-align: right;
 }
 
 .search-result-text {
+  flex: 1;
+  min-width: 0;
   font-size: 11px;
   color: var(--ide-text-muted);
   font-family: monospace;
@@ -1279,6 +1322,47 @@ html, body, #mbeditor-root {
   text-overflow: ellipsis;
 }
 
+/* The match has to stay on screen at any panel width, so a hit line is three
+   boxes rather than one ellipsised string. Shrink order is what does the work:
+   the text BEFORE the match gives way first, then the text after it, and the
+   match itself only as a last resort — so it can never be the part that scrolls
+   out of view. `direction: rtl` is what moves the leading ellipsis to the start
+   of .search-result-pre; searchMatchParts() prefixes a U+200E so an all-symbol
+   segment can't be reordered by it. */
+.search-result-text-split {
+  display: flex;
+  align-items: center;
+  text-overflow: clip;
+}
+
+.search-result-pre,
+.search-result-post,
+.search-result-match {
+  overflow: hidden;
+  text-overflow: ellipsis;
+  white-space: pre;
+}
+
+.search-result-pre {
+  flex: 0 100 auto;
+  direction: rtl;
+  text-align: left;
+}
+
+.search-result-post { flex: 0 10 auto; }
+
+/* Never shrinks: flex distributes overflow across every shrinkable box in
+   proportion to its size, so even shrink:1 against a long tail cost the match a
+   character or two of ellipsis. max-width is what still bounds a match wider
+   than the panel — it clips instead of overflowing. */
+.search-result-match {
+  flex: 0 0 auto;
+  max-width: 100%;
+  background: color-mix(in srgb, var(--ide-accent) 40%, transparent);
+  color: var(--ide-text);
+  border-radius: 2px;
+}
+
 .search-results-loading-more {
   padding: 8px 10px;
   font-size: 11px;
@@ -2534,7 +2618,7 @@ html, body, #mbeditor-root {
   display: flex;
   align-items: flex-start;
   justify-content: center;
-  padding-top: 15vh;
+  padding-top: 12vh;
   z-index: 9999;
 }
 
@@ -2542,8 +2626,9 @@ html, body, #mbeditor-root {
   background: var(--ide-panel-bg);
   border: 1px solid var(--ide-border-input);
   border-radius: 8px;
-  width: 500px;
-  max-height: 400px;
+  /* vw/vh caps keep the larger dialog inside a phone-sized viewport */
+  width: min(760px, 94vw);
+  max-height: min(620px, 72vh);
   display: flex;
   flex-direction: column;
   box-shadow: 0 16px 48px rgba(0,0,0,0.7);
@@ -2559,8 +2644,8 @@ html, body, #mbeditor-root {
   border: none;
   border-bottom: 1px solid var(--ide-border);
   color: var(--ide-text);
-  padding: 12px 34px 12px 16px;
-  font-size: 14px;
+  padding: 14px 40px 14px 18px;
+  font-size: 16px;
   outline: none;
   width: 100%;
   box-sizing: border-box;
@@ -2569,11 +2654,11 @@ html, body, #mbeditor-root {
 
 .quick-open-clear-btn {
   position: absolute;
-  right: 6px;
+  right: 8px;
   top: 50%;
   transform: translateY(-50%);
-  width: 22px;
-  height: 22px;
+  width: 26px;
+  height: 26px;
   border: none;
   border-radius: 4px;
   background: transparent;
@@ -2595,18 +2680,18 @@ html, body, #mbeditor-root {
 }
 
 .quick-open-result {
-  padding: 6px 16px;
+  padding: 8px 18px;
   cursor: pointer;
   display: flex;
   align-items: center;
-  gap: 8px;
-  font-size: 12px;
+  gap: 10px;
+  font-size: 14px;
   transition: background 0.1s;
 }
 
 .quick-open-result-icon {
   flex-shrink: 0;
-  width: 16px;
+  width: 18px;
   text-align: center;
   color: #78b4e0;
 }
@@ -2620,10 +2705,10 @@ html, body, #mbeditor-root {
 .quick-open-result.selected { background: var(--ide-active-bg); }
 
 .quick-open-result-name { color: var(--ide-text); }
-.quick-open-result-path { color: var(--ide-text-muted); font-size: 11px; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; }
+.quick-open-result-path { color: var(--ide-text-muted); font-size: 12px; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; }
 
 .quick-open-section { margin-bottom: 4px; }
-.quick-open-section-header { padding: 6px 14px 4px; font-size: 10px; text-transform: uppercase; letter-spacing: 0.08em; color: var(--ide-text-muted); font-weight: 600; }
+.quick-open-section-header { padding: 8px 18px 4px; font-size: 11px; text-transform: uppercase; letter-spacing: 0.08em; color: var(--ide-text-muted); font-weight: 600; }
 
 .quick-open-star-btn {
   flex-shrink: 0;
@@ -2632,7 +2717,7 @@ html, body, #mbeditor-root {
   cursor: pointer;
   padding: 2px 6px;
   color: var(--ide-text-muted);
-  font-size: 12px;
+  font-size: 14px;
   line-height: 1;
   opacity: 0;
   transition: opacity 0.1s, color 0.1s;
@@ -2646,9 +2731,9 @@ html, body, #mbeditor-root {
 .quick-open-result-dir .quick-open-result-name { color: #dcb67a; }
 
 .quick-open-empty-hint {
-  padding: 20px 16px;
+  padding: 24px 18px;
   color: var(--ide-text-muted);
-  font-size: 12px;
+  font-size: 13px;
   text-align: center;
   line-height: 1.6;
 }
@@ -2881,7 +2966,11 @@ textarea {
   margin-bottom: 0;
 }
 
-/* Status bar buttons override (22px tall, full-bleed) */
+/* Status bar buttons override (22px tall, full-bleed).
+ * line-height must be set here too, not just on .ide-statusbar: Pico gives
+ * <button> its own line-height, so it does not inherit the bar's, and the
+ * count next to an icon ended up in a 16.5px line box beside the icon's 11px
+ * one. */
 .ide-statusbar button,
 .statusbar-btn {
   --pico-form-element-spacing-vertical: 0;
@@ -2889,6 +2978,7 @@ textarea {
   height: 22px;
   padding: 0 8px;
   font-size: 11px;
+  line-height: 1;
   border-radius: 2px;
   border: none;
   background: transparent;
@@ -3251,19 +3341,6 @@ button:not(.pico-btn) { margin-bottom: 0; }
 .ide-problems-actions { display: flex; gap: 2px; }
 .ide-problems-actions .ide-problems-btn { white-space: nowrap; }
 .ide-problems-btn.is-on { color: var(--ide-accent, #0a84ff); }
-.ide-testrun-stat { font-size: 11px; color: var(--ide-text-muted, #858585); }
-.ide-testrun-pass { color: #4ec9b0; }
-.ide-testrun-fail { color: #f14c4c; }
-.ide-testrun-raw {
-  margin: 0;
-  padding: 8px 14px;
-  font-family: var(--ide-mono, monospace);
-  font-size: 11px;
-  line-height: 1.5;
-  white-space: pre;
-  overflow-x: auto;
-  color: var(--ide-fg, #eee);
-}
 .ide-problems-body { flex: 1; overflow: auto; padding: 4px 0; font-size: 12px; }
 .ide-problems-empty {
   padding: 10px 14px;
@@ -3496,18 +3573,12 @@ button:not(.pico-btn) { margin-bottom: 0; }
 .ide-problems-frame { padding-left: 28px; }
 .ide-problems-frame .ide-problems-code { opacity: 1; }
 
-/* Status-bar ruby-lsp indicator. Healthy is a dim icon you can ignore;
-   degraded/off is amber with a label, because that one you should read. */
-.statusbar-lsp { display: inline-flex; align-items: center; gap: 4px; }
-.statusbar-lsp-ok { opacity: 0.45; }
-.statusbar-lsp-ok:hover { opacity: 1; }
-.statusbar-lsp-degraded,
-.statusbar-lsp-off { color: var(--ide-warning); }
-
-/* Status-bar problems indicator: bug count then warning count, VS Code style. */
-.statusbar-problems { display: inline-flex; align-items: center; gap: 4px; }
+/* Status-bar problems indicator: bug count then warning count, VS Code style.
+   The gap is the icon-to-its-own-number spacing; the warning icon opens the
+   second pair, so it gets the wider separator. */
+.statusbar-problems { gap: 4px; }
 .statusbar-problems-error-icon { color: var(--ide-danger); }
-.statusbar-problems-warning-icon { color: var(--ide-warning); }
+.statusbar-problems-warning-icon { color: var(--ide-warning); margin-left: 8px; }
 .statusbar-problems-count { font-variant-numeric: tabular-nums; }
 
 /* Search decorations off across engines — Chrome/Safari draw their own

data/app/channels/mbeditor/collaboration_channel.rb

@@ -21,11 +21,14 @@ module Mbeditor
       return reject if @path.empty? && respond_to?(:reject, true)
 
       stream_from stream_name if respond_to?(:stream_from)
+      CollaborationDocStore.join(room_key)
+      @joined = true
       transmit_initial_state
     end
 
     def unsubscribed
-      # no-op
+      CollaborationDocStore.leave(room_key) if @joined
+      @joined = false
     end
 
     def doc_update(data)
@@ -66,7 +69,10 @@ module Mbeditor
       return unless respond_to?(:transmit, true)
 
       state = CollaborationDocStore.state_for(room_key)
-      transmit({ "type" => "sync", "snapshot" => state[:snapshot], "deltas" => state[:deltas] })
+      # Exactly one client per empty room is told to seed it from disk; see
+      # CollaborationDocStore.claim_seed. Everyone else waits for that content.
+      transmit({ "type" => "sync", "snapshot" => state[:snapshot], "deltas" => state[:deltas],
+                 "seed" => CollaborationDocStore.claim_seed(room_key) })
     end
 
     # A room is identified by workspace *and* relative path. Keying on the path

data/app/controllers/mbeditor/editors_controller.rb

@@ -96,12 +96,11 @@ module Mbeditor
         blameAvailable: AvailabilityProbe.git(workspace_root),
         redmineEnabled: Mbeditor.configuration.redmine_enabled == true,
         testAvailable: test_available?,
-        # The client derives its request timeouts from these. Two independently
+        # The client derives its request timeout from this. Two independently
         # hard-coded numbers is how you get the browser aborting a run the
         # server is still happily executing, reported as a generic network
         # error instead of the server's own message.
         testTimeout: (Mbeditor.configuration.test_timeout || 180).to_i,
-        testAllTimeout: (Mbeditor.configuration.test_all_timeout || 1800).to_i,
         actionCableEnabled: action_cable_enabled?,
         jsSyntaxCheckAvailable: JsSyntaxCheckService.available?,
         rubyLspAvailable: AvailabilityProbe.ruby_lsp(workspace_root),
@@ -1122,25 +1121,6 @@ module Mbeditor
       render json: { ok: false, error: e.message, files: [] }, status: :unprocessable_content
     end
 
-    # POST /mbeditor/test_all — run the whole suite
-    #
-    # No path: the framework's own default target applies. Deliberately a plain
-    # blocking request like /test, just with the suite ceiling — streaming would
-    # need a channel, a buffer and a cancel protocol for a button most people
-    # press a handful of times a day.
-    def run_all_tests
-      config = Mbeditor.configuration
-      result = TestRunnerService.run_all(
-        workspace_root.to_s,
-        framework: config.test_framework&.to_sym,
-        command: config.test_all_command,
-        timeout: (config.test_all_timeout || 1800).to_i
-      )
-      render json: result
-    rescue StandardError => e
-      render json: { ok: false, error: e.message }, status: :unprocessable_content
-    end
-
     # POST /mbeditor/test — run tests for the given file
     def run_test
       path = resolve_path(params[:path])
@@ -1222,11 +1202,13 @@ module Mbeditor
     def model_schema
       model_name = params[:model].to_s.strip
       return render json: { error: "model required" }, status: :bad_request if model_name.blank?
-      # SchemaService derives a file path from this name, so it is validated the
-      # same way #module_members validates its own: a constant name, nothing that
-      # could carry a "..".
-      return render json: { error: "Invalid model" }, status: :bad_request \
-        unless model_name.match?(/\A[A-Z][A-Za-z0-9_:]*\z/)
+      # SchemaService interpolates the underscored name into app/models/<x>.rb,
+      # and Inflector.underscore leaves "../" intact. Same guard as
+      # module_members, widened to the "::" a namespaced model needs. Spaces
+      # are allowed because SchemaService strips them ("Order Item" → OrderItem).
+      unless model_name.delete(" ").match?(RUBY_CONSTANT_PATH)
+        return render json: { error: "Invalid model name" }, status: :bad_request
+      end
 
       schema = SchemaService.new(model_name, workspace_root.to_s).call
       if schema

data/app/services/mbeditor/collaboration_doc_store.rb

@@ -33,6 +33,44 @@ module Mbeditor
     # snapshot instead of syncing from the buffer.
     MAX_DELTAS = 500
 
+    # Grant the right to seed a room's shared document from disk, to exactly one
+    # client. Without this every client that finds the room empty inserts the whole
+    # file at offset 0, and Yjs merges those inserts into two concatenated copies —
+    # the file appended to itself. That happens whenever two editor tabs attach to
+    # a room the server has no state for: a fresh room, or one that was evicted
+    # while both were idle. The claim is per room, so the loser waits for the
+    # winner's content instead of inventing its own.
+    def claim_seed(path, now: monotonic)
+      MUTEX.synchronize do
+        room = touch(path, now)
+        next false if room[:seed_claimed] || room[:snapshot] || !room[:deltas].empty?
+
+        room[:seed_claimed] = true
+      end
+    end
+
+    # Subscriber accounting. A room with a live subscriber must never be evicted:
+    # eviction empties the server's copy while clients still hold content, and the
+    # next client to attach would be granted a seed it must not perform.
+    def join(path, now: monotonic)
+      MUTEX.synchronize { touch(path, now)[:subscribers] += 1 }
+      nil
+    end
+
+    def leave(path, now: monotonic)
+      MUTEX.synchronize do
+        room = rooms[path]
+        next unless room
+
+        room[:subscribers] -= 1 if room[:subscribers] > 0
+        # The claimer can leave before it ever seeds (a tab closed during the
+        # handshake). Releasing the claim on an empty, empty-handed room keeps the
+        # next opener from deferring to content that will never arrive.
+        room[:seed_claimed] = false if room[:subscribers].zero? && room[:snapshot].nil? && room[:deltas].empty?
+      end
+      nil
+    end
+
     def record_update(path, bytes, now: monotonic)
       MUTEX.synchronize do
         room = touch(path, now)
@@ -85,7 +123,7 @@ module Mbeditor
 
     def touch(path, now)
       new_room = !rooms.key?(path)
-      room = (rooms[path] ||= { snapshot: nil, deltas: [] })
+      room = (rooms[path] ||= { snapshot: nil, deltas: [], subscribers: 0, seed_claimed: false })
       room[:last_activity] = now
       maybe_sweep(now)
       evict_lru if new_room && rooms.size > ROOM_CAP
@@ -105,12 +143,13 @@ module Mbeditor
     private_class_method :maybe_sweep
 
     def evict_idle(now, grace)
-      rooms.delete_if { |_path, room| (now - room[:last_activity]) > grace }
+      rooms.delete_if { |_path, room| room[:subscribers].zero? && (now - room[:last_activity]) > grace }
     end
     private_class_method :evict_idle
 
     def evict_lru
-      oldest = rooms.min_by { |_path, room| room[:last_activity] }
+      idle = rooms.reject { |_path, room| room[:subscribers].positive? }
+      oldest = (idle.empty? ? rooms : idle).min_by { |_path, room| room[:last_activity] }
       rooms.delete(oldest.first) if oldest
     end
     private_class_method :evict_lru

data/app/services/mbeditor/duplicate_content_scanner.rb

@@ -0,0 +1,105 @@
+# frozen_string_literal: true
+
+require "find"
+
+module Mbeditor
+  # Finds files that look like they were written back to disk with their own
+  # content appended to themselves.
+  #
+  # The corruption this detects came from the collaborative buffer: two clients
+  # that each found an empty shared document seeded it from disk, and Yjs merged
+  # both inserts at offset 0 into two concatenated copies. That bug is fixed
+  # (CollaborationDocStore.claim_seed), but files saved while it was live are
+  # still on disk, so there has to be a way to find them.
+  #
+  # Two signals, cheapest first:
+  #
+  #   * :exact          — the file is byte-for-byte X + X. What a duplicated save
+  #                       produces before anyone edits it again.
+  #   * :repeated_block — the first ANCHOR_LINES lines of the file occur again
+  #                       later, verbatim. Survives edits made after the
+  #                       corruption, which is the common case for a file noticed
+  #                       days later.
+  #
+  # Report-only. Nothing here writes.
+  class DuplicateContentScanner
+    ANCHOR_LINES  = 10
+    MIN_LINES     = 20 # below this, a repeat is unremarkable
+    MAX_FILE_SIZE = 5 * 1024 * 1024
+
+    Finding = Struct.new(:path, :reason, :line, :lines, keyword_init: true)
+
+    def self.check(content)
+      return nil if content.nil? || content.empty?
+
+      lines = content.lines
+      return nil if lines.size < MIN_LINES
+
+      half = content.bytesize / 2
+      if content.bytesize.even? && content.byteslice(0, half) == content.byteslice(half, half)
+        return { reason: :exact, line: (lines.size / 2) + 1 }
+      end
+
+      at = repeated_anchor_line(lines)
+      at ? { reason: :repeated_block, line: at } : nil
+    end
+
+    # Line number (1-based) of a later verbatim recurrence of the file's opening
+    # block, or nil. The anchor starts at the first non-blank line so a leading
+    # blank does not shift it out of alignment with its copy.
+    def self.repeated_anchor_line(lines)
+      start = lines.index { |l| !l.strip.empty? }
+      return nil if start.nil? || (start + ANCHOR_LINES) > lines.size
+
+      anchor = lines[start, ANCHOR_LINES]
+      # A block of identical lines (padding, a long table) repeats for boring
+      # reasons; require the anchor itself to carry some variety.
+      return nil if anchor.uniq.size < 3
+
+      idx = ((start + 1)..(lines.size - ANCHOR_LINES)).find { |i| lines[i, ANCHOR_LINES] == anchor }
+      idx && (idx + 1)
+    end
+    private_class_method :repeated_anchor_line
+
+    def initialize(root, excluded: Mbeditor.configuration.excluded_paths)
+      @root = File.expand_path(root.to_s)
+      @matcher = ExclusionMatcher.new(excluded, root: @root)
+    end
+
+    def call
+      findings = []
+      Find.find(@root) do |path|
+        rel = path == @root ? "" : path.delete_prefix("#{@root}/")
+        if File.directory?(path)
+          Find.prune if !rel.empty? && @matcher.excluded?(rel)
+          next
+        end
+        next if @matcher.excluded?(rel)
+        next unless File.file?(path) && File.size(path).between?(1, MAX_FILE_SIZE)
+
+        content = read_text(path)
+        next unless content
+
+        hit = self.class.check(content)
+        next unless hit
+
+        findings << Finding.new(path: rel, reason: hit[:reason], line: hit[:line], lines: content.lines.size)
+      end
+      findings.sort_by { |f| [f.reason == :exact ? 0 : 1, f.path] }
+    end
+
+    private
+
+    # nil for anything that is not readable UTF-8 text — a NUL byte is the same
+    # binary test the rest of the editor uses.
+    def read_text(path)
+      content = File.read(path, encoding: "UTF-8")
+      return nil unless content.valid_encoding?
+      return nil if content.include?("\0")
+
+      content
+    rescue SystemCallError
+      nil
+    end
+  end
+end