mbeditor 0.3.8 → 0.3.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: caf178914c2be95307a23ee24744dabd50f12c8597c69eddf814f63895e17433
-  data.tar.gz: 0353fc7e791cf1fff4c739fddf59d0a1ba8259353a4147b738824275c4bca55f
+  metadata.gz: 3e496861ff75f2bb3c09388afbc609c07230ad8a914de28040b867ccb922a04d
+  data.tar.gz: f5825193b830cca72f626a86a15483eb46ccb4cd335388a6ccaed088841ff313
 SHA512:
-  metadata.gz: 772a81a73df9b7ca2bd517193ee0178fb9843ea934c7bbc05157e84794596c62b98f34dbfa50004e2c8ee1abeda1e121e8936350826b1a213031952c1ef10563
-  data.tar.gz: 705bc59cb210934c909b35819d41c98ecd3e858a153a25efa6587e530c51faa0821aa39932c155c4860c7335a0c70d7f06302e4c6a5b7cb7f1214911bb1f7fbe
+  metadata.gz: dd1ed23cefc9609ca7d99d77410104b63107dc0e72f80e72279adc4a01cba1a6da3fe2d6e0467ec23b7db1166d3ccbdfcf380d4057c5644008ab4a9fa87e5092
+  data.tar.gz: 0b6bc8dcec6f206fc3867c19bc7ffe028230b8503109dc8473e10997abe41c56db0fd3970f88c23bbf6fd69873c1d905cc0ce11a2010c6205cccc891ee511982

data/CHANGELOG.md

@@ -5,6 +5,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.3.9] - 2026-04-21
+
+### Added
+- Search responses now include a total result count; background counting runs for the first page to populate it without blocking.
+- Editor preferences expanded with line height, letter spacing, cursor style, and auto-closing bracket/quote settings.
+
+### Fixed
+- Multi-line tab indentation corrected; added regression test to prevent recurrence.
+- 8 correctness, security, and reliability fixes surfaced by ultrareview.
+
 ## [0.3.8] - 2026-04-16
 
 ### Fixed

data/app/assets/javascripts/mbeditor/application_iife_head.js

@@ -1,4 +1,11 @@
 // Mbeditor app IIFE — React and ReactDOM are injected from window.MbeditorRuntime
 // so that mbeditor never reads from or writes to window.React / window.ReactDOM,
 // protecting the host application's globals.
+
+// Shared helper — returns the engine mount path with no trailing slash.
+// All service modules and components use this instead of inlining the lookup.
+window.mbeditorBasePath = function() {
+  return (window.MBEDITOR_BASE_PATH || '/mbeditor').replace(/\/$/, '');
+};
+
 (function(React, ReactDOM) {

data/app/assets/javascripts/mbeditor/components/CodeReviewPanel.js

@@ -27,7 +27,7 @@ var CodeReviewPanel = function CodeReviewPanel(_ref) {
     setIsRedmineLoading(true);
 
     // Call the redmine endpoint. It will 503 if disabled via config.
-    axios.get((window.MBEDITOR_BASE_PATH || '/mbeditor' ) + '/redmine/issue/' + issueId)
+    axios.get(window.mbeditorBasePath() + '/redmine/issue/' + issueId)
       .then(function (res) {
         setRedmineIssue(res.data);
         setIsRedmineLoading(false);

data/app/assets/javascripts/mbeditor/components/EditorPanel.js

@@ -480,24 +480,34 @@ var EditorPanel = function EditorPanel(_ref) {
       theme: editorPrefs.theme || 'vs-dark',
       automaticLayout: true,
       minimap: { enabled: !!(editorPrefs.minimap) },
-      renderLineHighlight: 'none',
+      renderLineHighlight: editorPrefs.renderLineHighlight || 'none',
       bracketPairColorization: { enabled: editorPrefs.bracketPairColorization !== false },
       fontFamily: editorPrefs.fontFamily || "'JetBrains Mono', 'Fira Code', Consolas, 'Courier New', monospace",
       fontSize: editorPrefs.fontSize || 13,
+      lineHeight: editorPrefs.lineHeight || 0,
+      letterSpacing: editorPrefs.letterSpacing || 0,
       tabSize: editorPrefs.tabSize || 4,
       insertSpaces: typeof editorPrefs.insertSpaces === 'boolean' ? editorPrefs.insertSpaces : false,
       wordWrap: editorPrefs.wordWrap || 'off',
       lineNumbers: editorPrefs.lineNumbers || 'on',
       renderWhitespace: editorPrefs.renderWhitespace || 'none',
       scrollBeyondLastLine: !!(editorPrefs.scrollBeyondLastLine),
-      linkedEditing: true, // Enables Auto-Rename Tag natively!
+      cursorStyle: editorPrefs.cursorStyle || 'line',
+      cursorBlinking: editorPrefs.cursorBlinking || 'blink',
+      folding: editorPrefs.folding !== false,
+      smoothScrolling: !!(editorPrefs.smoothScrolling),
+      mouseWheelZoom: !!(editorPrefs.mouseWheelZoom),
+      autoClosingBrackets: editorPrefs.autoClosingBrackets || 'always',
+      autoClosingQuotes: editorPrefs.autoClosingQuotes || 'always',
+      autoIndent: editorPrefs.autoIndent || 'full',
+      formatOnPaste: editorPrefs.formatOnPaste !== false,
+      formatOnType: editorPrefs.formatOnType !== false,
+      quickSuggestions: editorPrefs.quickSuggestions !== false,
+      wordBasedSuggestions: editorPrefs.wordBasedSuggestions || 'matchingDocuments',
+      acceptSuggestionOnEnter: editorPrefs.acceptSuggestionOnEnter || 'on',
+      linkedEditing: true,
       fixedOverflowWidgets: true,
-      hover: { above: false },
-      autoClosingBrackets: 'always',
-      autoClosingQuotes: 'always',
-      autoIndent: 'full',
-      formatOnPaste: true,
-      formatOnType: true
+      hover: { above: false }
     });
 
     if (tab.viewState) {
@@ -700,6 +710,8 @@ var EditorPanel = function EditorPanel(_ref) {
       monacoRef.current.updateOptions({
         fontSize: editorPrefs.fontSize || 13,
         fontFamily: editorPrefs.fontFamily || "'JetBrains Mono', 'Fira Code', Consolas, 'Courier New', monospace",
+        lineHeight: editorPrefs.lineHeight || 0,
+        letterSpacing: editorPrefs.letterSpacing || 0,
         tabSize: editorPrefs.tabSize || 4,
         insertSpaces: typeof editorPrefs.insertSpaces === 'boolean' ? editorPrefs.insertSpaces : false,
         wordWrap: editorPrefs.wordWrap || 'off',
@@ -707,7 +719,21 @@ var EditorPanel = function EditorPanel(_ref) {
         renderWhitespace: editorPrefs.renderWhitespace || 'none',
         minimap: { enabled: !!(editorPrefs.minimap) },
         scrollBeyondLastLine: !!(editorPrefs.scrollBeyondLastLine),
-        bracketPairColorization: { enabled: editorPrefs.bracketPairColorization !== false }
+        bracketPairColorization: { enabled: editorPrefs.bracketPairColorization !== false },
+        renderLineHighlight: editorPrefs.renderLineHighlight || 'none',
+        cursorStyle: editorPrefs.cursorStyle || 'line',
+        cursorBlinking: editorPrefs.cursorBlinking || 'blink',
+        folding: editorPrefs.folding !== false,
+        smoothScrolling: !!(editorPrefs.smoothScrolling),
+        mouseWheelZoom: !!(editorPrefs.mouseWheelZoom),
+        autoClosingBrackets: editorPrefs.autoClosingBrackets || 'always',
+        autoClosingQuotes: editorPrefs.autoClosingQuotes || 'always',
+        autoIndent: editorPrefs.autoIndent || 'full',
+        formatOnPaste: editorPrefs.formatOnPaste !== false,
+        formatOnType: editorPrefs.formatOnType !== false,
+        quickSuggestions: editorPrefs.quickSuggestions !== false,
+        wordBasedSuggestions: editorPrefs.wordBasedSuggestions || 'matchingDocuments',
+        acceptSuggestionOnEnter: editorPrefs.acceptSuggestionOnEnter || 'on'
       });
     }
   }, [editorPrefs]);
@@ -1157,6 +1183,22 @@ var EditorPanel = function EditorPanel(_ref) {
         renderer.html = function (token) {
           return '<pre>' + escapeHtml(typeof token === 'object' ? token.text : token) + '</pre>';
         };
+        // Sanitize link/image hrefs to block javascript: and data: schemes.
+        var _origLink = renderer.link.bind(renderer);
+        var _origImage = renderer.image.bind(renderer);
+        var SAFE_HREF_SCHEME = /^(https?:|mailto:|#|\/)/i;
+        var safeHref = function(href) {
+          if (!href) return href;
+          return SAFE_HREF_SCHEME.test(href.trim()) ? href : '#';
+        };
+        renderer.link = function(token) {
+          if (token && typeof token === 'object') { token = Object.assign({}, token, { href: safeHref(token.href) }); }
+          return _origLink(token);
+        };
+        renderer.image = function(token) {
+          if (token && typeof token === 'object') { token = Object.assign({}, token, { href: safeHref(token.href) }); }
+          return _origImage(token);
+        };
         setMarkup(window.marked.parse(markdownContent, { renderer: renderer }));
       })();
     }
@@ -1192,11 +1234,10 @@ var EditorPanel = function EditorPanel(_ref) {
   }
 
   if (isImage) {
-    var basePath = (window.MBEDITOR_BASE_PATH || '/mbeditor').replace(/\/$/, '');
     return React.createElement(
       'div',
       { className: 'monaco-container', style: { display: 'flex', alignItems: 'center', justifyContent: 'center', background: '#1e1e1e' } },
-      React.createElement('img', { src: basePath + '/raw?path=' + encodeURIComponent(tab.path), style: { maxWidth: '90%', maxHeight: '90%', objectFit: 'contain' }, alt: tab.name })
+      React.createElement('img', { src: window.mbeditorBasePath() + '/raw?path=' + encodeURIComponent(tab.path), style: { maxWidth: '90%', maxHeight: '90%', objectFit: 'contain' }, alt: tab.name })
     );
   }
 

data/app/assets/javascripts/mbeditor/components/GitPanel.js

@@ -14,8 +14,19 @@ var GitPanel = function GitPanel(_ref) {
   var _s1 = useState(true);  var localExpanded  = _s1[0]; var setLocalExpanded  = _s1[1];
   var _s2 = useState(true);  var branchExpanded = _s2[0]; var setBranchExpanded = _s2[1];
   var _s3 = useState(true);  var historyExpanded= _s3[0]; var setHistoryExpanded= _s3[1];
-  // { [hash]: true|false }
-  var _s4 = useState({});    var expandedCommits = _s4[0]; var setExpandedCommits = _s4[1];
+
+  // { [hash]: true|false } — persisted to localStorage keyed by root path so
+  // users don't need to re-expand commits on every page load.
+  var _lsKey = 'mbeditor_expanded_commits_' + (window.MBEDITOR_BASE_PATH || '');
+  var _lsInitial = (function() {
+    try { return JSON.parse(localStorage.getItem(_lsKey)) || {}; } catch(e) { return {}; }
+  })();
+  var _s4 = useState(_lsInitial); var expandedCommits = _s4[0]; var setExpandedCommits = _s4[1];
+
+  // Persist expandedCommits whenever it changes.
+  useEffect(function() {
+    try { localStorage.setItem(_lsKey, JSON.stringify(expandedCommits)); } catch(e) {}
+  }, [expandedCommits]);
   // { [hash]: { loading, files: [{status,path}], error } }
   var _s5 = useState({});    var commitFiles = _s5[0]; var setCommitFiles = _s5[1];
   var _s6 = useState(false); var refreshing = _s6[0]; var setRefreshing = _s6[1];
@@ -55,8 +66,7 @@ var GitPanel = function GitPanel(_ref) {
     setRedmineLoading(true);
     setRedmineIssue(null);
     setRedmineError(null);
-    var basePath = (window.MBEDITOR_BASE_PATH || '/mbeditor').replace(/\/$/, '');
-    axios.get(basePath + '/redmine/issue/' + redmineTicketId)
+    axios.get(window.mbeditorBasePath() + '/redmine/issue/' + redmineTicketId)
       .then(function (res) {
         setRedmineIssue(res.data);
         setRedmineLoading(false);