mbeditor 0.13.0 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b65424322b66f78929de0629db6e4644a76467e889adaee77121b8c52e0e50de
-  data.tar.gz: 53cd7724f2a80011d474a9616bdb35d88859ddf797a0fa51d3657740038624bd
+  metadata.gz: 89b467923bfe67c35d68e57b667357c96c4217c39fff779f5ff98911eed59f25
+  data.tar.gz: e1b82cc6eddeaec6d31f00f83eff3b3e56abba423411304c9025b68dd9efbd81
 SHA512:
-  metadata.gz: f4470580292e46d6de7eb2e3687193452bfbcbee5d478e48c6460e22739fd2942d1a525b04e6d3f7877175db5d18da86c3241032dfc748ca91bf62f0f008cd90
-  data.tar.gz: 05e4226ce7151a7e72d18f34018c30acc04adfbaea235a891afe12ecadb52170b1b598820ea7de326068eae7bb7811cce13ec5cf42b0c69fd6c77683c3b7c819
+  metadata.gz: 1e15d0215eba919681e9a435de8aeadcd3d24bbc1c9dc72f95f9036c2a39a89e39b28461d2acce844b4a9b5c2b1507318d84da3cdae62b08162f6412daa4dd8c
+  data.tar.gz: 611f9efe9f06536eb81ecf2b8f09d2da282958a17131b56baca6b47c07d10c2508a7797cba2f5469df457c2647b052a26f97a281fa8f44d7e574a2d89fe12d83

data/CHANGELOG.md

@@ -5,7 +5,163 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased]
+## [0.14.0] - 2026-09-21
+
+### Added
+- **Liquid Glass chrome, opt-in** (Settings → Appearance). Translucent, blurred
+  panels layered over whichever theme is active — it is a layer, not a twelfth
+  theme, so every colour is derived from the existing `--ide-*` tokens. Monaco
+  itself stays solid: legibility beats the effect, and a blurred backdrop under
+  a text editor costs a re-composite per repaint. The default chrome is the new
+  Modern one, matching VS Code's Dark Modern.
+- **Drag-to-open gutters.** One `Gutter` component owns every draggable gap.
+  Drag the strip above the status bar to open Problems, the right edge to open
+  the git panel, and the collapsed sidebar's gutter rightwards to snap the
+  explorer back open.
+- **Settings is a searchable modal**, not an editor tab, so it no longer takes a
+  pane or persists into your tab list.
+- **The model graph opens as its own view**, not a tab: the activity-bar icon
+  toggles it, it takes the whole centre column, and both side panels hide with
+  it. A layered graph is inherently wide and the tab gave it whatever was left
+  beside the explorer.
+- **A downloadable audit log** (Settings → Diagnostics) that structurally cannot
+  carry a file name, path or URL — every field is a number, boolean or authored
+  Symbol.
+- **Quick Open as a frosted palette** over the title bar, with a chevron
+  breadcrumb and VS Code-style Open Editors rows.
+- Auto-close tags in ERB and multi-line JSX, linked tag pairs, and `props.x`
+  completion.
+- Multi-select download in the explorer.
+- A `toolbarLabels` preference: toolbar button labels are now opt-in.
+- Accessibility: a focus-visible ring throughout, a real tab-close button, a
+  higher-contrast version chip, and the offline pulse respects reduced-motion.
+
+### Changed
+- **The pending-migration warning is no longer a banner.** It sat above
+  everything and pushed the editor down the page every time it appeared. The
+  status bar turns amber instead and carries a "Migrations pending" item. Both
+  halves of that colour are per-theme, because `--ide-warning` is authored as a
+  foreground colour and several themes pick an ochre that is unreadable as a
+  background; measured contrast is 4.87:1 to 14.97:1 across the eleven themes.
+- **Peer presence is an avatar stack**, not one chip per peer. Eight people used
+  to mean eight buttons across the title bar; it is now three overlapping dots
+  and a `+N`, fixed width whatever the roster size. Hovering a dot opens the
+  usual card, clicking follows or unfollows, and the `+N` opens a list of
+  everyone else with a follow toggle per row.
+- The title bar says "Mbeditor" rather than the full window title; the host and
+  port are in the browser's own address bar.
+- The file-tree section header has no chevron. Collapsing it left an empty
+  sidebar, so there was nothing to collapse to.
+- Tabs are rounded chips on the strip, the Problems panel wears VS Code chrome,
+  and problem counts are neutral rather than alarming.
+- `.scss` files open as scss and `.less` files as less, instead of css and
+  plaintext.
+- Audit recording moved off the subprocess critical path.
+
+### Fixed
+- **The pending-migration warning stuck after `rails db:migrate`**, and
+  flickered before that. The header announcing it was only *set* when a
+  migration was pending, and those responses are conditional-GET cacheable: a
+  304 updates the stored headers of the cached 200 but never removes one it
+  omits, so the browser replayed "pending" for as long as the cache entry
+  lived. It is now always sent, `1` or `0`, and an absent header counts as no
+  evidence either way.
+- **The model graph was unusable on a large app.** The cost was in click and
+  hover, not pan and zoom: `focused` was a dependency of the scene memo, so
+  every click-to-centre rebuilt every SVG element inside the click handler;
+  node hover scanned the whole scene per mouseenter; and the hover card and
+  edge tooltip each read `getBoundingClientRect` per pointer move, right after
+  hover had dirtied the style, forcing a full-scene layout. Measured on a
+  420-model, 1,249-association app: click-to-centre 20.4 ms → 7.9 ms median,
+  hover 45.7 ms → 33.2 ms.
+- Collaboration data-loss paths, and the per-keystroke buffer work that went
+  with them.
+- Undo tracking starts after the file load, not before, so the first undo no
+  longer empties a freshly opened file.
+- Ruby hover skips comments and the route-hint decoration space, and
+  go-to-definition starts the Ripper fallback alongside ruby-lsp rather than
+  after it.
+- Closing a markdown file closes its preview, and source and preview scroll in
+  sync.
+- Markdown anchor links, upload UX, the conflict chip and the cursor readout.
+- `RubyLspClient` performs its handshake outside the state lock, bounds the
+  document-lock wait, and keeps an LRU of documents.
+- `JsSyntaxCheckService` remembers a broken babel bundle instead of retrying it,
+  and bounds its lock wait.
+- The test-result `localStorage` cache is capped, and failed draft backups are
+  surfaced rather than silently dropped.
+- `json` is pinned below 3 so the suite runs.
+
+### Removed
+- Stale agent docs, the dead `build_js` rake task and a set of duplicated
+  helpers — about 1,100 lines.
+
+## [0.13.1] - 2026-08-26
+
+### Removed
+- **The whole-suite test run is gone** — the status-bar "Tests" button, the
+  Test Run drawer, `POST /test_all`, and the `test_all_command` /
+  `test_all_timeout` settings. It was one blocking request holding a
+  development-server thread for the length of the suite, with no way to cancel
+  it and the runner's output buffered whole in the server process; on a real
+  host app that is twenty minutes of a frozen-looking button for a result the
+  terminal gives you faster and interruptibly. The per-file (and per-line) test
+  run stays — that one is scoped, finishes in seconds and is why the editor
+  runs tests at all. **A host app setting `test_all_command` or
+  `test_all_timeout` in its initializer must drop those lines.**
+- **The ruby-lsp status-bar chip is gone**, along with its 10-second health
+  poll. ruby-lsp itself is untouched — definitions, hover, completion,
+  diagnostics and the rest all still run through it.
+
+### Added
+- `rake mbeditor:scan_duplicates` — scans the workspace for files that contain a
+  duplicated copy of themselves, for finding files damaged before the seeding fix below.
+  Set `MBEDITOR_WORKSPACE_ROOT` to scan a tree other than the resolved workspace.
+
+### Fixed
+- **Data loss: a saved file could contain two copies of itself.** When two editor
+  clients attached to a collaborative room the server had no state for — a fresh
+  room, or one evicted while both sat idle — each one seeded the shared document
+  from disk, and Yjs merged both inserts at offset 0 into two concatenated copies.
+  Saving then wrote the doubled buffer. The server now grants the right to seed a
+  room to exactly one client (`CollaborationDocStore.claim_seed`), never evicts a
+  room that still has subscribers, and a client whose cable reconnects re-publishes
+  its snapshot so a server that lost its state cannot hand out a second seed.
+- **Status bar alignment.** Every item now sits in the same 8px cell instead of
+  carrying its own padding on top of the bar's (the branch, the offline chip
+  and the version each had a different one), the branch drops from 13px to the
+  bar's 11px, and `line-height: 1` on the bar *and* on its buttons puts an icon
+  and the number beside it in identical line boxes — Pico gives `<button>` its
+  own 1.5, so the problem counts sat in a 16.5px box next to an 11px icon.
+- **The Problems panel's Fix button did nothing visible.** `rubocop -a` writes
+  its corrections to disk, but reports the offenses it just fixed alongside the
+  ones it left — each flagged both `corrected` and `correctable` — so the list
+  after a fix was byte-identical to the list before it and the button stayed
+  lit. Corrected offenses are now dropped from the response, open buffers are
+  re-read after the run, and clearing stale diagnostics now clears the React
+  marker map as well as Monaco's, which is what had left the panel, the tab
+  badges and the status-bar tallies disagreeing.
+- **Quick Open matches loosely again.** MiniSearch was configured `fuzzy: false`,
+  so a single typo found nothing; fuzziness is now scaled per term. Folders sort
+  after files instead of ahead of every match, and the dialog and its text are
+  larger.
+- **Search results read like VS Code's.** Hits group under a collapsible row per
+  file with a match count, the matched text is tinted with the accent colour and
+  is kept on screen at any panel width (eliding left and right around it), and
+  clicking a hit selects the match and leaves the cursor at its end.
+- **Bulk import no longer opens on the previous import's folder** — the folder
+  you actually acted on is offered first — and it now reports what it wrote and
+  reveals the destination in the tree.
+- `ReactRailsUJS` no longer reports as undefined; it ships inside the react-rails
+  gem, outside the workspace, so no static scan of the tree could ever find it.
+- `<<~JSX` heredocs highlight as JavaScript (as do `<<~TSX`/`<<~TS`).
+- The Open Editors list no longer runs its filenames underneath the split and
+  close buttons.
+
+### Changed
+- **The activity bar is a third narrower** (60px to 40px), and the editor
+  toolbar's per-file Test button is gone; running the test under the cursor is
+  unaffected.
 
 ## [0.13.0] - 2026-08-20
 

data/app/assets/javascripts/mbeditor/application.js

@@ -1,4 +1,5 @@
 //= require mbeditor/application_iife_head
+//= require mbeditor/audit_log
 //= require mbeditor/editor_store
 //= require mbeditor/file_icon
 //= require mbeditor/file_service
@@ -17,6 +18,8 @@
 //= require mbeditor/ruby_outline
 //= require mbeditor/js_outline
 //= require mbeditor/components/CollapsibleSection
+//= require mbeditor/components/SettingsModal
+//= require mbeditor/components/Gutter
 //= require mbeditor/components/ShortcutHelp
 //= require mbeditor/components/DiffViewer
 //= require mbeditor/components/CombinedDiffViewer
@@ -27,7 +30,6 @@
 //= require mbeditor/components/TestResultsPanel
 //= require mbeditor/components/LogPanel
 //= require mbeditor/components/ProblemsPanel
-//= require mbeditor/components/TestRunPanel
 //= require mbeditor/components/CodeReviewPanel
 //= require mbeditor/components/EditorPanel
 //= require mbeditor/components/FileTree

data/app/assets/javascripts/mbeditor/audit_log.js

@@ -0,0 +1,165 @@
+// Audit/telemetry ring the developer can download and hand to an AI to analyse.
+//
+// The privacy guarantee is structural, not a scrubber: rec() is the only way
+// in, and it drops any argument whose typeof is not 'number'. A path, a file
+// name, a URL or a line of source cannot be represented at all. Enumerated
+// dimensions (file extension, search backend tier, LSP method, collab phase)
+// travel as small integers whose meaning lives in LEGEND. LEGEND stays here and
+// is merged into the file at download time: sending it to the server would be
+// the one path in this module that carries an arbitrary string, which is
+// exactly the property the rest of it exists to deny.
+window.MbeditorAudit = (function () {
+  var CAPACITY = 512;
+  var FLUSH_AT = CAPACITY / 2;
+
+  var EV = Object.freeze({
+    BOOT: 1,
+    OPEN: 2,
+    SAVE: 3,
+    SEARCH: 4,
+    TREE_POLL: 5,
+    GIT_POLL: 6,
+    LINT: 7,
+    FORMAT: 8,
+    LSP: 9,
+    COLLAB: 10,
+    LONGTASK: 11,
+    ERR: 12
+  });
+
+  var LEGEND = {
+    ev: {},
+    // What a, b and c mean per event. A field named after one of the
+    // enumerated dimensions below carries an index into that table.
+    fields: {
+      BOOT:      ['msToReady', '', ''],
+      OPEN:      ['ext', 'bytes', 'ms'],
+      SAVE:      ['ext', 'bytes', 'ms'],
+      SEARCH:    ['searchBackend', 'ms', 'hits'],
+      TREE_POLL: ['ms', 'changed', ''],
+      GIT_POLL:  ['ms', 'changedFiles', ''],
+      LINT:      ['ext', 'ms', 'markers'],
+      FORMAT:    ['ext', 'ms', 'bytes'],
+      LSP:       ['lspMethod', 'ms', 'ok'],
+      COLLAB:    ['collabPhase', 'peers', 'ms'],
+      LONGTASK:  ['ms', '', ''],
+      ERR:       ['ev', '', '']
+    },
+    // Index 0 is always "other", so an unrecognised name still records.
+    ext: ['other', 'rb', 'js', 'jsx', 'erb', 'haml', 'css', 'scss', 'html', 'md', 'json', 'yml', 'ts', 'tsx'],
+    searchBackend: ['other', 'rg', 'git', 'grep'],
+    lspMethod: ['other', 'definition', 'hover', 'completion', 'diagnostics', 'references', 'rename',
+                'format', 'signatureHelp', 'documentSymbol', 'foldingRange', 'documentHighlight',
+                'selectionRange', 'codeAction'],
+    collabPhase: ['other', 'join', 'seed', 'attach', 'defer', 'update', 'reconnect', 'leave', 'degrade']
+  };
+  Object.keys(EV).forEach(function (name) { LEGEND.ev[EV[name]] = name; });
+
+  // Preallocated: rec() reuses the slot, so recording allocates nothing.
+  var ring = new Array(CAPACITY);
+  for (var i = 0; i < CAPACITY; i++) ring[i] = [0, 0, 0, 0, 0];
+
+  var write = 0;
+  var count = 0;
+  var enabled = false;
+  var scheduled = false;
+  var observing = false;
+
+  // The whole privacy guarantee in one line.
+  function num(v) { return typeof v === 'number' && isFinite(v) ? v : 0; }
+
+  function rec(ev, a, b, c) {
+    if (!enabled) return;
+    var e = ring[write];
+    e[0] = performance.now() | 0;
+    e[1] = num(ev);
+    e[2] = num(a);
+    e[3] = num(b);
+    e[4] = num(c);
+    write = write + 1 === CAPACITY ? 0 : write + 1;
+    if (count < CAPACITY) count++;
+    if (count >= FLUSH_AT) schedule();
+  }
+
+  function code(dimension, name) {
+    var table = LEGEND[dimension];
+    var index = table ? table.indexOf(name) : -1;
+    return index < 0 ? 0 : index;
+  }
+
+  function drain() {
+    var out = new Array(count);
+    var start = (write - count + CAPACITY) % CAPACITY;
+    for (var i = 0; i < count; i++) {
+      var e = ring[(start + i) % CAPACITY];
+      out[i] = [e[0], e[1], e[2], e[3], e[4]];
+    }
+    count = 0;
+    write = 0;
+    return out;
+  }
+
+  // keepalive rather than navigator.sendBeacon: the CSRF guard needs the
+  // X-Mbeditor-Client header and sendBeacon cannot set one.
+  function flush() {
+    scheduled = false;
+    if (!enabled || count === 0) return Promise.resolve();
+    var body = JSON.stringify({ events: drain() });
+    return fetch(window.mbeditorBasePath() + '/audit_log', {
+      method: 'POST',
+      keepalive: true,
+      headers: { 'X-Mbeditor-Client': '1', 'Content-Type': 'application/json' },
+      body: body
+    })['catch'](function () {});
+  }
+
+  function schedule() {
+    if (scheduled) return;
+    scheduled = true;
+    if (window.requestIdleCallback) {
+      window.requestIdleCallback(function () { flush(); }, { timeout: 2000 });
+    } else {
+      setTimeout(function () { flush(); }, 0);
+    }
+  }
+
+  function observe() {
+    if (observing) return;
+    observing = true;
+    try {
+      new PerformanceObserver(function (list) {
+        var items = list.getEntries();
+        for (var i = 0; i < items.length; i++) rec(EV.LONGTASK, items[i].duration | 0);
+      }).observe({ type: 'longtask', buffered: true });
+    } catch (e) {
+      // Safari has no longtask entry type. Everything else keeps recording.
+    }
+  }
+
+  function clear() { count = 0; write = 0; }
+
+  function setEnabled(on) {
+    on = !!on;
+    if (on === enabled) return;
+    enabled = on;
+    // Disabled means nothing recorded, including what was buffered before the
+    // preference arrived from the server.
+    if (on) observe(); else clear();
+  }
+
+  window.addEventListener('pagehide', function () { flush(); });
+  document.addEventListener('visibilitychange', function () {
+    if (document.visibilityState === 'hidden') flush();
+  });
+
+  return {
+    EV: EV,
+    LEGEND: LEGEND,
+    rec: rec,
+    code: code,
+    flush: flush,
+    clear: clear,
+    setEnabled: setEnabled,
+    buffered: function () { return count; }
+  };
+})();