mbeditor 0.12.9 → 0.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 264dfef604baf70be3fcb9984f588a93a8388fe13371cb3c8707d5ee7149d441
-  data.tar.gz: d584056fbb108ea55ddb98a819af73e4eabb939d659fc7d54442446b34b2c203
+  metadata.gz: fe5dce956e01ff66387b9ccf99fc8b163ce131a226158eda7b6cf2c8513eaa09
+  data.tar.gz: 37e4f12f4ccd1ca7d209e7fe134a25d813bbe175862d53a470a5042aff9d7797
 SHA512:
-  metadata.gz: 20141c5dcd65e482c4d0437c5b1a4b1431507f424dc1a31b80af5490d30b4611c2c2e050f0716a4a382c9f2b3804001127e03292cfe371b50049c6d058f3c7b0
-  data.tar.gz: 551f8ad767679d4b63364d2c6e9bcb267663c35bf1750a355b29ff22f7149e445511a0fd9be8aa7a279754f6c0a3ccb79a1b3941d1bec3b11792911541081616
+  metadata.gz: 60c74bb23b92719d4273d720af42813e2ecd3d639281901d47037e332697819cbe58c338eea9aeff334f3533d48d2e62c994b2122fb36fbded4bef94bd225b36
+  data.tar.gz: 1451f3b2effb5d9cffd9811b41ea72b07d174702af9e6dc9993d5fbc92d990109dbf834e957c1eced22e8d77b815173d14bf6465b51072002a0e1c482745dc69

data/CHANGELOG.md

@@ -5,7 +5,222 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased]
+## [0.13.1] - 2026-08-26
+
+### Removed
+- **The whole-suite test run is gone** — the status-bar "Tests" button, the
+  Test Run drawer, `POST /test_all`, and the `test_all_command` /
+  `test_all_timeout` settings. It was one blocking request holding a
+  development-server thread for the length of the suite, with no way to cancel
+  it and the runner's output buffered whole in the server process; on a real
+  host app that is twenty minutes of a frozen-looking button for a result the
+  terminal gives you faster and interruptibly. The per-file (and per-line) test
+  run stays — that one is scoped, finishes in seconds and is why the editor
+  runs tests at all. **A host app setting `test_all_command` or
+  `test_all_timeout` in its initializer must drop those lines.**
+- **The ruby-lsp status-bar chip is gone**, along with its 10-second health
+  poll. ruby-lsp itself is untouched — definitions, hover, completion,
+  diagnostics and the rest all still run through it.
+
+### Added
+- `rake mbeditor:scan_duplicates` — scans the workspace for files that contain a
+  duplicated copy of themselves, for finding files damaged before the seeding fix below.
+  Set `MBEDITOR_WORKSPACE_ROOT` to scan a tree other than the resolved workspace.
+
+### Fixed
+- **Data loss: a saved file could contain two copies of itself.** When two editor
+  clients attached to a collaborative room the server had no state for — a fresh
+  room, or one evicted while both sat idle — each one seeded the shared document
+  from disk, and Yjs merged both inserts at offset 0 into two concatenated copies.
+  Saving then wrote the doubled buffer. The server now grants the right to seed a
+  room to exactly one client (`CollaborationDocStore.claim_seed`), never evicts a
+  room that still has subscribers, and a client whose cable reconnects re-publishes
+  its snapshot so a server that lost its state cannot hand out a second seed.
+- **Status bar alignment.** Every item now sits in the same 8px cell instead of
+  carrying its own padding on top of the bar's (the branch, the offline chip
+  and the version each had a different one), the branch drops from 13px to the
+  bar's 11px, and `line-height: 1` on the bar *and* on its buttons puts an icon
+  and the number beside it in identical line boxes — Pico gives `<button>` its
+  own 1.5, so the problem counts sat in a 16.5px box next to an 11px icon.
+- **The Problems panel's Fix button did nothing visible.** `rubocop -a` writes
+  its corrections to disk, but reports the offenses it just fixed alongside the
+  ones it left — each flagged both `corrected` and `correctable` — so the list
+  after a fix was byte-identical to the list before it and the button stayed
+  lit. Corrected offenses are now dropped from the response, open buffers are
+  re-read after the run, and clearing stale diagnostics now clears the React
+  marker map as well as Monaco's, which is what had left the panel, the tab
+  badges and the status-bar tallies disagreeing.
+- **Quick Open matches loosely again.** MiniSearch was configured `fuzzy: false`,
+  so a single typo found nothing; fuzziness is now scaled per term. Folders sort
+  after files instead of ahead of every match, and the dialog and its text are
+  larger.
+- **Search results read like VS Code's.** Hits group under a collapsible row per
+  file with a match count, the matched text is tinted with the accent colour and
+  is kept on screen at any panel width (eliding left and right around it), and
+  clicking a hit selects the match and leaves the cursor at its end.
+- **Bulk import no longer opens on the previous import's folder** — the folder
+  you actually acted on is offered first — and it now reports what it wrote and
+  reveals the destination in the tree.
+- `ReactRailsUJS` no longer reports as undefined; it ships inside the react-rails
+  gem, outside the workspace, so no static scan of the tree could ever find it.
+- `<<~JSX` heredocs highlight as JavaScript (as do `<<~TSX`/`<<~TS`).
+- The Open Editors list no longer runs its filenames underneath the split and
+  close buttons.
+
+### Changed
+- **The activity bar is a third narrower** (60px to 40px), and the editor
+  toolbar's per-file Test button is gone; running the test under the cursor is
+  unaffected.
+
+## [0.13.0] - 2026-08-20
+
+### Added
+- **Whole-suite test run, in a drawer.** `POST /test_all` runs the suite with
+  no file argument under its own `test_all_timeout` (30 min) — a suite run is
+  minutes, not seconds, and forcing `test_timeout` up to cover it would let one
+  hung example block for half an hour. It renders as a bottom drawer beside
+  Problems and the log rather than a modal: a backdrop that blocks the editor
+  for the length of a suite run turns the wait into dead time. Failures group
+  by file, each row jumps to its line, and "Open failing" opens them all at
+  once. The result survives closing the drawer and a reload, and a branch
+  switch drops it.
+- **Whole-workspace RuboCop run in the Problems panel.** The panel could only
+  ever show diagnostics for files Monaco had open, because markers are
+  per-model. Three buttons now cover the rest of the project: RuboCop (a full
+  `rubocop --format json` run), Fix (`-a`, safe corrections only), and Open all.
+
+### Changed
+- **Activity bar and explorer are larger.** Activity buttons go 36px to 60px
+  with a 25px glyph and fill the bar edge to edge, so the active indicator sits
+  flush at the screen edge; state is carried by glyph colour alone and the
+  hover box is gone. Explorer rows and icons go 12px to 14px.
+- **Per-file test timeout raised 60s to 180s**, and the client now derives its
+  request timeout from the server's (`/workspace` reports both ceilings)
+  instead of a hard-coded 120s. Raising the server timeout past the client's
+  used to make the browser abort a run the server was still executing.
+
+### Security
+- **Every entry point is gated on `allowed_environments`.** The check moved to
+  `ApplicationController` ahead of `run_authentication`. `LogsController`
+  declared no gate at all, so `GET /mbeditor/logs/tail` returned the tail of
+  `log/<env>.log` in any environment the engine was mounted in; both cable
+  channels checked only the (nil by default) authentication hook, so anything
+  reaching the host's `/cable` could subscribe and start a log tail or write
+  state. Running the host's auth proc now happens after the environment check,
+  so a disallowed environment 404s without it.
+- **`model_schema` validates its parameter.** The model name flowed into a file
+  path without a format check, so `..` segments escaped the workspace.
+- **Git ref patterns reject a leading dash**, and `git show` takes
+  `--end-of-options` — a ref beginning with `-` was argument injection into a
+  documented git option.
+
+### Performance
+- **Typing no longer re-renders the whole application.** Every keystroke wrote
+  the full document into the store, which re-rendered an app subscribed to all
+  of it. Content writes are now throttled (250 ms, trailing) with a documented
+  flush-on-save contract, and the dirty flag is written only on a clean/dirty
+  transition. On top of that: the file tree is no longer deep-copied per render,
+  the model-graph scene (~10k SVG elements) no longer rebuilds when unrelated
+  state moves, and blame/test view zones, the tab strip's smooth scroll, and the
+  problem counts no longer churn per keypress.
+- **Monaco's ruby-lsp providers honour cancellation.** `documentHighlight`
+  fires per cursor move and was POSTing the entire buffer with no way to cancel
+  it, so superseded requests stayed in flight; all eight raw providers now
+  thread Monaco's `CancellationToken` through one shared path, and highlights
+  memoise per word occurrence.
+- **ruby-lsp requests pipeline again.** The document mutex was held across the
+  whole request/response round-trip, so a single diagnostics call (10 s budget)
+  or rename (30 s) blocked every hover and highlight in the process. It is now
+  held only across the write, which is what actually needs ordering. Abandoned
+  requests send `$/cancelRequest` rather than leaving a single-threaded server
+  computing a result nobody will read.
+- **Conditional GETs on the polled and static routes.** Monaco's 14 MB of
+  assets carried no validators and were re-fetched on every page load; `/files`
+  shipped roughly 1 MB of JSON on a 10 s poll and now answers 304 from a digest
+  memoised with the existing tree cache. `/git_status`, hit every 5 s, is TTL
+  cached instead of spawning two git subprocesses per poll.
+- **`find_branch_base` costs 2 git spawns instead of up to 12**, resolving the
+  candidate list with one `for-each-ref`. Commit detail drops from 3 spawns to
+  2, and the line-diff probe only asks whether a file is untracked when the
+  diff came back empty.
+- **A JS save no longer rebuilds the whole workspace JS program behind a global
+  lock**, and a `.rb` save no longer invalidates the JS program and globals
+  caches at all. Go-to-definition no longer rewrites the entire on-disk cache
+  (tens of MB of JSON) on any lookup that parsed something new.
+- Smaller: one `lstat` per tree entry instead of three stats, unbounded
+  subprocess output capped, and the exclusion matcher splits each path once
+  rather than once per pattern.
+
+### Fixed
+- **Pending migrations no longer lock the editor.** `CheckPending` is swapped
+  for a wrapper that runs the identical check for host traffic but records
+  rather than raises for the editor's, so the tree, opening a file and saving
+  one keep working — including saving the migration causing it. The warning
+  rides a response header, so it appears for a migration created mid-session
+  and clears once migrated without a reload. Host traffic is still blocked
+  exactly as Rails intends. The fallback shell also requested its Sprockets
+  assets under the engine mount, where they 404, and hardcoded `/mbeditor`
+  instead of the configured mount path.
+- **Saves no longer degrade under a burst.** A timeout was counted as an
+  unreachable server, which suppressed the polls that would have proven it up;
+  `files_changed` is coalesced once at the WebSocket dispatch (15 writes: 15
+  dispatches to 1); panes re-ran `git diff` on every save anywhere in the
+  workspace; and the lite git poll escalated to the full fan-out twice per save
+  (12 saves: 12 fan-outs to 1).
+- **Replace All left open tabs showing pre-replace text.** The refresh treated
+  a model-registry entry as a Monaco model, so the update silently no-opped
+  into a bare `catch` — and saving that tab afterwards wrote the stale content
+  back over the replacement.
+- **A dropped cable connection disconnected the host application's own
+  ActionCable consumer** when the host provided one, taking its channels down
+  with it, and left collaboration rooms bound to the dead consumer with no
+  indication they were dead. Consumers are disconnected only when mbeditor
+  created them, and rooms rejoin on reconnect.
+- **ruby-lsp failed entirely for any workspace path containing a space** or
+  other character needing escaping: the `file://` URI was built by
+  interpolation, so ruby-lsp's own `URI` parse raised and every request fell
+  back silently. Return-path comparisons unescape before matching the
+  workspace root.
+- **Git status mangled paths with spaces, non-ASCII characters, or renames.**
+  Porcelain output was read verbatim, so quoted and octal-escaped paths arrived
+  unopenable and missed their numstat enrichment; both sides now use `-z`.
+- **Saves and editor state are written atomically.** Both truncated in place,
+  so a reader landing mid-write parsed an empty file and silently reported no
+  open tabs, and a crash mid-write left the file empty for good. Writes go to a
+  temporary file and rename, resolving through symlinks so a linked file stays
+  a link.
+- **Literal (non-regex) replace corrupted replacements containing
+  backslashes** — `\1`, `\&` and `\\` were interpreted as backreferences across
+  up to 500 files.
+- **A user-supplied search regex could pin a worker indefinitely.** Patterns
+  are compiled with `Regexp.timeout` where the Ruby version supports it;
+  `Timeout.timeout` cannot interrupt a regex match, which is what the previous
+  guard relied on.
+- **A failed ruby-lsp handshake orphaned the child process**, leaving it
+  indexing and holding memory, and up to three could accumulate.
+- **Branch switches left stale buffers and diagnostics.** A checkout rewrites
+  the working tree and nothing told the editor; the git poll now announces it,
+  the app re-reads the tree and every open tab (dirty ones still prompt rather
+  than being clobbered), and `/files?refresh=1` bypasses the 15 s tree cache.
+- **The Problems panel filled with vendored gem source** when a host
+  `.rubocop.yml` replaced RuboCop's default excludes, and reported TypeScript's
+  implicit-any advice on plain JS/JSX, where there are no annotations to add.
+- **`HistoryService` rejected an empty base**, so the first history entry for a
+  file 400'd.
+- Also: a V8 isolate leak in the JS syntax checker, unbounded growth in the
+  collaboration delta log and several per-path caches, JS member completions
+  cached with a stale insert range, `quick_fix`/format/haml-lint running with
+  no timeout, a negative log offset returning a 500, and configured JS globals
+  being dropped when the symbol cap was reached.
+
+### Tests
+- The pending-migration middleware tests built `ActiveRecord::PendingMigrationError`
+  with no arguments, whose initializer lists the pending migrations and so needs
+  a database connection; every CI runner without one failed all six.
+- Two stubs restored `AvailabilityProbe.rg` by rebinding a captured `Method`,
+  which raises `can't bind singleton method to a different class` if the class
+  is reloaded in between — leaving `rg` undefined and failing every later search
+  and workspace test in that process. They alias instead.
 
 ## [0.12.9] - 2026-08-07
 

data/app/assets/javascripts/mbeditor/application.js

@@ -33,6 +33,11 @@
 //= require mbeditor/components/GitPanel
 //= require mbeditor/components/QuickOpenDialog
 //= require mbeditor/components/TabBar
+// Both import modals must be required *inside* the IIFE: React is an IIFE
+// parameter (window.React is deliberately never set), so a component file
+// placed after the tail resolves a bare `React` to undefined and takes the
+// whole app down the first time it renders.
+//= require mbeditor/components/ImportConflictModal
+//= require mbeditor/components/ImportDialog
 //= require mbeditor/components/MbeditorApp
 //= require mbeditor/application_iife_tail
-//= require mbeditor/components/ImportConflictModal

data/app/assets/javascripts/mbeditor/collaboration_service.js

@@ -225,6 +225,9 @@ var CollaborationService = (function () {
       binding: null,
       undoManager: null,
       lateJoin: false,
+      // Set from the sync handshake: the server grants the right to seed an empty
+      // room's shared doc from disk to exactly one client (see claim_seed).
+      seedGranted: false,
       onSeeded: null,
       attachRequested: false,
       degraded: false,
@@ -280,10 +283,14 @@ var CollaborationService = (function () {
           if (d) window.Y.applyUpdate(room.doc, _b64ToU8(d), REMOTE);
         });
       }
+      room.seedGranted = !!data.seed;
       room.synced = true;
       _maybeAttach(room);
     } else if (data.type === 'doc_update') {
       if (data.update) window.Y.applyUpdate(room.doc, _b64ToU8(data.update), REMOTE);
+      // A client that deferred attaching (empty room, seed granted to someone
+      // else) is waiting for exactly this: the seeder's content has landed.
+      _maybeAttach(room);
     } else if (data.type === 'awareness') {
       if (data.awareness && room.awareness && window.awarenessProtocol) {
         // REMOTE origin keeps the outbound handler from echoing peer state back.
@@ -295,6 +302,35 @@ var CollaborationService = (function () {
     }
   }
 
+  // Re-open every room's channel subscription on the current consumer.
+  //
+  // A cable drop tears the consumer down and takes every CollaborationChannel
+  // subscription with it — silently, because isAvailable() reports cable
+  // *support*, not liveness. Nothing here noticed: the rooms stayed in _rooms
+  // with dead subscriptions, so edits stopped reaching peers until the file was
+  // closed and reopened. WebSocketService calls this when the EditorChannel
+  // reconnects. Only the wire is replaced; the Yjs doc, the binding and the undo
+  // history all survive, and the re-sent sync snapshot re-applies harmlessly
+  // (Y.applyUpdate is idempotent).
+  function rejoinRooms() {
+    Object.keys(_rooms).forEach(function (path) {
+      var room = _rooms[path];
+      try { if (room.subscription) room.subscription.unsubscribe(); } catch (e) { /* already dead */ }
+      room.subscription = WebSocketService.subscribeCollaboration(path, {
+        // Awareness is never server-persisted, so peers lost our caret with the
+        // connection and would not see it again until we happened to move.
+        // The server may have lost the room entirely (restart): re-publish our
+        // content so the next opener late-joins instead of being granted a seed
+        // that would merge a second copy into what we still hold.
+        connected: function () {
+          _sendLocalAwareness(room);
+          if (room.binding) pushSnapshot(path);
+        },
+        received: function (data) { _onMessage(room, data); }
+      });
+    });
+  }
+
   // Register the current editor/model for a room and request a binding. Called on
   // every editor (re)creation (tab switch recreates the editor; the model and the
   // Yjs doc persist). opts.onSeeded is invoked once the binding has set the model,
@@ -323,6 +359,11 @@ var CollaborationService = (function () {
 
   function _maybeAttach(room) {
     if (room.binding || !room.synced || !room.attachRequested || !room.model) return;
+    // Shared doc still empty and the seed was granted to another client: its
+    // content is on its way. Binding now would hand the model to an empty Y.Text
+    // and wipe the buffer, so wait for the first doc_update (or the fallback
+    // timer, which lets the natively-loaded content stand).
+    if (room.text.length === 0 && !room.seedGranted && room.model.getValue().length > 0) return;
     _doAttach(room);
   }
 
@@ -330,10 +371,12 @@ var CollaborationService = (function () {
     var model = room.model;
     room.lateJoin = room.text.length > 0; // server already had shared state
 
-    if (!room.lateJoin && model.getValue().length > 0) {
+    if (!room.lateJoin && room.seedGranted && model.getValue().length > 0) {
       // First opener whose disk content is already in the model: seed the shared
       // doc from it before constructing the binding, otherwise the binding would
       // overwrite the model to match the (empty) Y.Text and wipe the content.
+      // Only ever the client the SERVER picked — two clients each seeding an
+      // empty room merge into two concatenated copies of the file.
       room.doc.transact(function () { room.text.insert(0, model.getValue()); });
     }
 
@@ -561,6 +604,7 @@ var CollaborationService = (function () {
   // Client IDs are globally unique, so one shared <style> element covers all open
   // files. Re-runs on any awareness change (cheap; small participant counts).
   var _styleEl = null;
+  var _cursorCss = null;
   function _renderCursorStyles() {
     if (typeof document === 'undefined') return;
     if (!_styleEl) {
@@ -593,6 +637,12 @@ var CollaborationService = (function () {
             'font-family:sans-serif;z-index:10;pointer-events:none;}';
       });
     });
+    // Awareness changes on every caret move and every scroll frame, but the
+    // styles only depend on who is here and what colour they chose — which
+    // almost never changes. Re-assigning textContent invalidates the document's
+    // style rules, so skip the write when the CSS is identical.
+    if (css === _cursorCss) return;
+    _cursorCss = css;
     _styleEl.textContent = css;
   }
 
@@ -739,6 +789,7 @@ var CollaborationService = (function () {
     onAvailabilityChange: onAvailabilityChange,
     isEnabledFor: isEnabledFor,
     ensureRoom: ensureRoom,
+    rejoinRooms: rejoinRooms,
     bindEditor: bindEditor,
     unbindEditor: unbindEditor,
     leaveRoom: leaveRoom,

data/app/assets/javascripts/mbeditor/color_provider.js

@@ -87,6 +87,11 @@
   function provideDocumentColors(model) {
     var colors = [];
     var lineCount = model.getLineCount();
+    // Registered for every language and re-run on every change, so a big file
+    // pays two regex passes per line for every keystroke. Same threshold
+    // EditorPanel's applyLargeFileTuning uses to switch off the other
+    // whole-document decorations.
+    if (lineCount > 2500) return [];
     for (var ln = 1; ln <= lineCount; ln++) {
       var line = model.getLineContent(ln);
       if (line.length > 2000) continue; // skip pathological lines

data/app/assets/javascripts/mbeditor/components/CollapsibleSection.js

@@ -49,7 +49,9 @@ var CollapsibleSection = function CollapsibleSection(_ref) {
       icon && React.createElement("i", { className: "collapsible-icon " + icon }),
       React.createElement(
         "span",
-        { className: "collapsible-title" },
+        // The title truncates away entirely on a narrow sidebar, so it carries
+        // its own tooltip — otherwise the section becomes unidentifiable.
+        { className: "collapsible-title", title: typeof title === 'string' ? title : undefined },
         title
       ),
       actions && React.createElement(