mbeditor 0.12.0 → 0.12.2

data/app/assets/javascripts/mbeditor/file_service.js

@@ -117,6 +117,14 @@ var FileService = (function () {
     return axios.get(window.mbeditorBasePath() + '/ping', { timeout: 4000 }).then(function(res) { return res.data; });
   }
 
+  // Which routes reach each action in a controller. Returns { controller, actions }
+  // with an empty actions map for anything that is not a controller, so the
+  // caller does not have to know the naming convention.
+  function getRoutes(path) {
+    return axios.get(window.mbeditorBasePath() + '/routes?path=' + encodeURIComponent(path))
+      .then(function (res) { return res.data; });
+  }
+
   function getState() {
     return axios.get(window.mbeditorBasePath() + '/state').then(function(res) { return res.data; });
   }
@@ -336,6 +344,7 @@ var FileService = (function () {
     formatFile: formatFile,
     runTests: runTests,
     ping: ping,
+    getRoutes: getRoutes,
     getState: getState,
     saveState: saveState,
     getBranchState: getBranchState,

data/app/assets/stylesheets/mbeditor/editor.css

@@ -61,6 +61,17 @@ html, body, #mbeditor-root {
   font-size: 13px;
   color: var(--ide-text);
   font-weight: 500;
+  /* Never wrap: the titlebar is a fixed 32px row, so a second line pushed the
+     toolbar buttons out of it. */
+  white-space: nowrap;
+}
+
+/* Below the width where the toolbar drops its button labels, drop the title
+   too. The layers icon beside it already identifies the editor, and the host
+   and port are in the browser's own address bar. */
+@media (max-width: 1180px) {
+  .ide-titlebar-title { display: none; }
+  .ide-titlebar-icon { margin-right: 0; }
 }
 
 /* Fills the gap between the title and the button cluster. min-width: 0 lets it
@@ -3120,8 +3131,16 @@ button:not(.pico-btn) { margin-bottom: 0; }
   margin-left: auto;
 }
 .ide-model-graph-search {
-  width: 150px;
-  padding: 3px 6px;
+  width: 170px;
+  /* Two separate things drew over the text here. WebKit renders its own
+     magnifier and clear button inside type="search"; and the vendored Pico
+     stylesheet paints a magnifier as a background-image on every [type=search],
+     positioned at the left, which the 8px padding put the text straight on top
+     of. Disabling the native decorations alone fixed neither — the visible icon
+     was Pico's. Both are off; the placeholder already says what the field is. */
+  -webkit-appearance: none;
+  appearance: none;
+  padding: 3px 8px;
   background: var(--ide-input-bg, #3c3c3c);
   border: 1px solid var(--ide-border, #3c3c3c);
   border-radius: 3px;
@@ -3243,3 +3262,136 @@ button:not(.pico-btn) { margin-bottom: 0; }
 .statusbar-problems-error-icon { color: var(--ide-danger); }
 .statusbar-problems-warning-icon { color: var(--ide-warning); }
 .statusbar-problems-count { font-variant-numeric: tabular-nums; }
+
+/* Search decorations off across engines — Chrome/Safari draw their own
+   magnifier and clear button inside type="search". */
+.ide-model-graph-search::-webkit-search-decoration,
+.ide-model-graph-search::-webkit-search-cancel-button,
+.ide-model-graph-search::-webkit-search-results-button,
+.ide-model-graph-search::-webkit-search-results-decoration {
+  -webkit-appearance: none;
+  appearance: none;
+}
+
+/* Cluster areas — a connected part of the schema, drawn behind its models so
+   the grouping is visible rather than implied by proximity alone. */
+.mg-region-box {
+  fill: color-mix(in srgb, var(--ide-fg, #d4d4d4) 4%, transparent);
+  stroke: color-mix(in srgb, var(--ide-fg, #d4d4d4) 12%, transparent);
+  stroke-width: 1;
+}
+.mg-region-label {
+  fill: color-mix(in srgb, var(--ide-fg, #d4d4d4) 45%, transparent);
+  font-size: 11px;
+  font-weight: 500;
+  pointer-events: none;
+}
+
+/* Hovering a model dims every association it is not part of. With 500+ edges on
+   screen the lines are otherwise indistinguishable from each other, and picking
+   out one model's relationships is the whole reason to look at the diagram.
+   Applied by toggling classes on the DOM rather than through React — re-rendering
+   thousands of SVG nodes on mouseenter is what made this view unusable before. */
+/* The ~30 ms this costs on a 300-model graph is the browser restyling every
+   edge and box, not anything in our code — toggling the classes themselves
+   measures 1.6 ms. Switching to stroke-opacity/fill-opacity was tried on the
+   theory that opacity stacking contexts were the cost; measured slower (38 ms
+   vs 32 ms), so plain opacity stays. */
+.mg-focus-mode .mg-edge { opacity: 0.08; }
+.mg-focus-mode .mg-lit .mg-edge { opacity: 1; stroke-width: 2; }
+.mg-focus-mode .mg-node { opacity: 0.55; }
+.mg-focus-mode .mg-node:hover { opacity: 1; }
+
+/* The association list shown while a model is hovered. Kept mounted and toggled
+   with a class so moving between boxes doesn't thrash the DOM. */
+.mg-assoc-card {
+  position: absolute;
+  z-index: 30;
+  max-width: 290px;
+  padding: 8px 10px;
+  background: var(--ide-panel-bg, #252526);
+  border: 1px solid var(--ide-border, #3c3c3c);
+  border-radius: 6px;
+  box-shadow: 0 6px 20px rgba(0, 0, 0, 0.45);
+  font-size: 11px;
+  line-height: 1.5;
+  color: var(--ide-text, #d4d4d4);
+  pointer-events: none;
+}
+.mg-assoc-card-hidden { display: none; }
+.mg-assoc-title { font-weight: 600; margin-bottom: 4px; }
+.mg-assoc-count { color: var(--ide-text-muted, #858585); margin-bottom: 4px; }
+.mg-assoc-row { display: flex; align-items: baseline; gap: 5px; white-space: nowrap; }
+.mg-assoc-dot { width: 7px; height: 7px; border-radius: 50%; background: currentColor; flex-shrink: 0; }
+.mg-assoc-macro { color: var(--ide-accent-fg, #4ec9b0); }
+.mg-assoc-name { color: var(--ide-text, #d4d4d4); }
+.mg-assoc-dir { color: var(--ide-text-muted, #858585); overflow: hidden; text-overflow: ellipsis; }
+.mg-assoc-through { color: var(--ide-text-muted, #858585); font-style: italic; }
+.mg-assoc-more, .mg-assoc-empty { color: var(--ide-text-muted, #858585); margin-top: 3px; }
+
+/* Explicit "open the schema" target in each model's header. */
+.mg-open-btn { cursor: pointer; }
+.mg-open-btn-bg { fill: transparent; }
+.mg-open-btn-bar { fill: var(--ide-text-muted, #858585); }
+.mg-open-btn:hover .mg-open-btn-bg { fill: color-mix(in srgb, var(--ide-fg, #d4d4d4) 16%, transparent); }
+.mg-open-btn:hover .mg-open-btn-bar { fill: var(--ide-fg, #d4d4d4); }
+.mg-node { cursor: zoom-in; }
+
+/* Pico paints a magnifier as a background-image on every [type=search], at the
+   left of the field, and our 8px padding put the text straight on top of it.
+   Its selector is input:not([type=checkbox],...)[type=search] — specificity
+   (0,2,1) — so a plain .class rule (0,1,0) loses and the icon stayed. Matching
+   that specificity, and loading later, is what actually removes it. */
+input.ide-model-graph-search[type="search"] {
+  background-image: none;
+  padding-inline-start: 8px;
+}
+
+/* Model-graph search dropdown. Replaces a native <datalist>, which the browser
+   renders in its own chrome — unstyleable, and unable to show the table name
+   beside each model. */
+.mg-search-wrap { position: relative; display: inline-block; }
+.mg-search-list {
+  position: absolute;
+  top: calc(100% + 4px);
+  right: 0;
+  z-index: 40;
+  min-width: 220px;
+  max-height: 280px;
+  overflow-y: auto;
+  margin: 0;
+  padding: 4px 0;
+  list-style: none;
+  background: var(--ide-panel-bg, #252526);
+  border: 1px solid var(--ide-border, #3c3c3c);
+  border-radius: 6px;
+  box-shadow: 0 6px 20px rgba(0, 0, 0, 0.45);
+}
+.mg-search-option {
+  display: flex;
+  align-items: baseline;
+  justify-content: space-between;
+  gap: 10px;
+  padding: 4px 10px;
+  font-size: 11px;
+  color: var(--ide-text, #d4d4d4);
+  cursor: pointer;
+  white-space: nowrap;
+}
+.mg-search-option-active { background: var(--ide-accent, #3794ff); color: #fff; }
+.mg-search-option-name { font-family: var(--ide-mono, monospace); }
+.mg-search-option-meta { color: var(--ide-text-muted, #858585); font-size: 10px; }
+.mg-search-option-active .mg-search-option-meta { color: rgba(255, 255, 255, 0.75); }
+
+/* Inline route hints beside controller actions. Muted and italic so they read
+   as annotation rather than code — they sit on the same line as the `def`. */
+.mbeditor-route-hint {
+  color: var(--ide-text-muted, #858585) !important;
+  font-style: italic;
+  opacity: 0.85;
+}
+.mbeditor-route-hint-none {
+  color: var(--ide-warning, #cca700) !important;
+  font-style: italic;
+  opacity: 0.8;
+}

data/app/controllers/mbeditor/editors_controller.rb

@@ -1072,6 +1072,19 @@ module Mbeditor
       }
     end
 
+    # GET /mbeditor/routes?path=app/controllers/users_controller.rb
+    #
+    # Which routes reach each action in a controller, for the inline hints the
+    # editor draws beside every `def`. Returns {} for anything that is not a
+    # controller rather than erroring — the client asks for every Ruby file it
+    # opens and should not have to know the convention.
+    def routes
+      key = RouteService.controller_key(params[:path].to_s)
+      return render json: { controller: nil, actions: {} } unless key
+
+      render json: { controller: key, actions: RouteService.for_controller(key) }
+    end
+
     # GET /mbeditor/related_files?path=...
     def related_files
       path = resolve_path(params[:path])
@@ -1145,14 +1158,41 @@ module Mbeditor
     # authenticate_with) so the host app can supply a collaboration display name.
     # nil — including any failure or a blank result — falls through to the
     # client-generated name.
+    # Display name for the collaboration caret. An explicit user_name_callback
+    # wins; otherwise fall back to current_user, when the host's auth library put
+    # it within reach of an ActionController::Base subclass (Devise, Sorcery and
+    # friends do; a current_user hand-written on the host's own
+    # ApplicationController does not — see default_user_name).
     def resolved_user_name
       cb = Mbeditor.configuration.user_name_callback
-      return nil unless cb
-
-      name = instance_exec(&cb)
+      name = cb ? instance_exec(&cb) : default_user_name
       name = name.to_s.strip
       name.empty? ? nil : name
-    rescue StandardError
+    rescue StandardError => e
+      # Was a bare `nil`, which made a broken callback indistinguishable from an
+      # unconfigured one: you got the generated name and no clue why. The usual
+      # cause is a NameError on current_user, and silently swallowing it sent
+      # people looking in the wrong place.
+      Rails.logger.warn("[mbeditor] user name lookup failed: #{e.class}: #{e.message}")
+      nil
+    end
+
+    # Read the display name straight off current_user, trying each configured
+    # attribute in turn. This is what makes an authenticated editor show real
+    # names with no extra wiring; user_name_methods exists so an app whose column
+    # isn't in the default list can name it instead of writing a callback.
+    def default_user_name
+      return nil unless respond_to?(:current_user, true)
+
+      user = current_user
+      return nil unless user
+
+      Array(Mbeditor.configuration.user_name_methods).each do |m|
+        next unless user.respond_to?(m)
+
+        value = user.public_send(m).to_s.strip
+        return value unless value.empty?
+      end
       nil
     end
 

data/app/services/mbeditor/model_graph_service.rb

@@ -22,7 +22,16 @@ module Mbeditor
       SolidQueue SolidCache SolidCable
     ].freeze
 
-    MAX_MODELS = 300
+    # Cap on models drawn. 300 was chosen before the layout could handle that
+    # many; a schema slightly over it silently lost models and only said
+    # "(truncated)". Raised, and configurable for anything larger — the cost of
+    # a bigger graph is now the browser's rendering, not the layout.
+    DEFAULT_MAX_MODELS = 1000
+
+    def self.max_models
+      value = Mbeditor.configuration.model_graph_max_models.to_i
+      value.positive? ? value : DEFAULT_MAX_MODELS
+    end
 
     # Only the first few columns travel: the diagram box shows that many and the
     # full list is a click away in the schema modal, which fetches its own data
@@ -86,7 +95,8 @@ module Mbeditor
         classes = model_classes
         return unavailable("No ActiveRecord models found in this application.") if classes.empty?
 
-        models = classes.first(MAX_MODELS).map { |klass| describe_model(klass, root) }
+        limit = max_models
+        models = classes.first(limit).map { |klass| describe_model(klass, root) }
         known = models.map { |m| m[:name] }.to_set
 
         {
@@ -95,7 +105,7 @@ module Mbeditor
           # Edges to classes outside the graph (a gem's model, or a typo in
           # class_name:) would render as arrows into nowhere.
           edges: models.flat_map { |m| m.delete(:edges) }.select { |e| known.include?(e[:to]) }.uniq,
-          truncated: classes.length > MAX_MODELS,
+          truncated: classes.length > limit,
           generatedAt: Time.now.utc.iso8601
         }
       rescue StandardError => e

data/app/services/mbeditor/route_service.rb

@@ -0,0 +1,79 @@
+# frozen_string_literal: true
+
+module Mbeditor
+  # Which routes reach a controller's actions, for the inline hints shown beside
+  # each `def` in a controller file.
+  #
+  # Read from the host app's own route set rather than by parsing config/routes.rb.
+  # mbeditor runs inside the host app, so the routes are already built — and they
+  # are the only source that accounts for `resources` expansion, `member`/
+  # `collection` blocks, scopes, constraints, mounted engines and anything a
+  # routes file does in plain Ruby. Parsing the file would get all of that wrong.
+  module RouteService
+    module_function
+
+    # Actions with no route are worth calling out, but only for controllers Rails
+    # would actually dispatch to. These are the inherited ones every controller
+    # has and nobody routes.
+    NON_ACTION_METHODS = %w[
+      new inspect method_of to_s hash class dup freeze
+    ].freeze
+
+    # "app/controllers/admin/users_controller.rb" -> "admin/users", which is the
+    # key Rails stores in a route's defaults.
+    def controller_key(relative_path)
+      path = relative_path.to_s.sub(%r{\A/+}, "")
+      match = path.match(%r{\Aapp/controllers/(.+)_controller\.rb\z})
+      return nil unless match
+
+      match[1]
+    end
+
+    # => { "show" => [{ verb:, path:, name: }], ... }
+    def for_controller(key)
+      return {} if key.nil? || key.empty?
+      return {} unless defined?(Rails) && Rails.respond_to?(:application) && Rails.application
+
+      routes_for(key)
+    rescue StandardError
+      # A broken route set must not take the editor down with it — the file still
+      # opens, just without hints.
+      {}
+    end
+
+    def routes_for(key)
+      out = {}
+      Rails.application.routes.routes.each do |route|
+        defaults = route.defaults
+        next unless defaults[:controller] == key
+
+        action = defaults[:action].to_s
+        next if action.empty?
+
+        (out[action] ||= []) << {
+          verb: verb_for(route),
+          path: path_for(route),
+          name: route.name
+        }
+      end
+      out
+    end
+    private_class_method :routes_for
+
+    # Rails has moved this between a String and a Regexp across versions; both
+    # stringify usefully, but a Regexp needs its slashes stripped.
+    def verb_for(route)
+      verb = route.verb
+      verb = verb.source.gsub(%r{[$^]}, "") if verb.is_a?(Regexp)
+      verb = verb.to_s
+      verb.empty? ? "ANY" : verb
+    end
+    private_class_method :verb_for
+
+    # "(.:format)" is noise in a hint that has to fit on one line.
+    def path_for(route)
+      route.path.spec.to_s.sub(/\(\.:format\)\z/, "")
+    end
+    private_class_method :path_for
+  end
+end

data/lib/mbeditor/configuration.rb

@@ -5,14 +5,14 @@ module Mbeditor
     attr_accessor :allowed_environments, :workspace_root, :excluded_paths, :rubocop_command, :rubocop_server,
                   :redmine_enabled, :redmine_url, :redmine_api_key, :redmine_ticket_source,
                   :test_framework, :test_command, :test_timeout,
-                  :authenticate_with, :authentication_cache_ttl, :user_name_callback,
+                  :authenticate_with, :authentication_cache_ttl, :user_name_callback, :user_name_methods,
                   :lint_timeout, :base_branch_candidates, :git_timeout, :search_timeout,
                   :ruby_def_include_dirs, :related_files_custom_paths,
                   :mount_path, :resilient_routing, :js_global_identifiers,
                   :js_program, :js_program_exclude,
                   :js_syntax_check, :babel_standalone_path,
                   :ruby_lsp, :ruby_lsp_command, :ruby_lsp_timeout,
-                  :exception_capture,
+                  :exception_capture, :model_graph_max_models,
                   :search_respect_gitignore, :ripgrep_command
 
     def initialize
@@ -58,7 +58,11 @@ module Mbeditor
       @ruby_def_include_dirs  = %w[app/models app/controllers app/helpers app/concerns]
       @related_files_custom_paths = []
       @authentication_cache_ttl = 0
-      @user_name_callback = nil # proc resolved in controller context (instance_exec) → collaboration display name; nil falls through to the client-generated name
+      @user_name_callback = nil # proc resolved in controller context (instance_exec) → collaboration display name; nil falls through to current_user, then to the client-generated name
+      # Attributes tried on current_user, in order, when no user_name_callback
+      # is set. First non-blank one wins. Name your own column here rather than
+      # writing a callback for the common case.
+      @user_name_methods = %w[name full_name display_name username login email]
       @js_global_identifiers = [] # extra ambient JS globals for the editor (runtime-only names invisible to static scan, e.g. %w[Routes I18n])
       # Load the workspace's own JS source into Monaco's TypeScript program, so
       # cross-file references get real inferred types instead of ambient `any`.
@@ -80,6 +84,9 @@ module Mbeditor
       # same exposure the log panel already has, since it tails the dev log.
       # Set to false to record nothing.
       @exception_capture = :auto
+      # Models drawn in the model graph before it reports itself truncated.
+      # nil uses ModelGraphService::DEFAULT_MAX_MODELS.
+      @model_graph_max_models = nil
       @mount_path = nil # explicit URL prefix override; nil falls through to detection/"/mbeditor"
       @resilient_routing = true # serve /mbeditor from middleware so the editor survives a broken host routes.rb; false is the escape hatch
     end

data/lib/mbeditor/engine.rb

@@ -54,9 +54,23 @@ module Mbeditor
       # Insert before CheckPending so our middleware wraps it and can rescue
       # the error it raises. Falls back silently if CheckPending is absent
       # (e.g. host app does not use ActiveRecord).
-      # Note: app.middleware is a MiddlewareStackProxy during initializers and
-      # does not support .to_a — rely solely on defined? to detect ActiveRecord.
-      if defined?(ActiveRecord::Migration::CheckPending)
+      #
+      # The constant being defined is not enough: Rails only puts CheckPending
+      # in the stack when config.active_record.migration_error is :page_load, so
+      # an app that loads ActiveRecord with any other setting has the constant
+      # but no middleware — and insert_before then raises "No such middleware",
+      # taking the host app's boot down with it. app.middleware is a
+      # MiddlewareStackProxy here and cannot be inspected, so the only way to
+      # know is to try it. Losing this middleware costs a friendlier pending-
+      # migration page, which is never worth failing to boot over.
+      # Rescuing the call is not an option: app.middleware is a
+      # MiddlewareStackProxy, so insert_before only records the operation and the
+      # "No such middleware" error surfaces later, during merge_into. Test the
+      # same condition Rails uses to add CheckPending in the first place.
+      migration_error = app.config.respond_to?(:active_record) &&
+                        app.config.active_record[:migration_error]
+
+      if defined?(ActiveRecord::Migration::CheckPending) && migration_error == :page_load
         app.middleware.insert_before ActiveRecord::Migration::CheckPending,
                                      Mbeditor::Rack::HandlePendingMigrations
       end

data/lib/mbeditor/route_map.rb

@@ -44,6 +44,7 @@ module Mbeditor
     get    'client_config',   to: 'editors#client_config'
     get    'related_files',   to: 'editors#related_files'
     get    'model_schema',    to: 'editors#model_schema'
+    get    'routes',          to: 'editors#routes'
     get    'changelog',       to: 'editors#changelog'
     get    'git_info',        to: 'editors#git_info'
     get    'git_status',      to: 'editors#git_status'

data/lib/mbeditor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Mbeditor
-  VERSION = "0.12.0"
+  VERSION = "0.12.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mbeditor
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.12.2
 platform: ruby
 authors:
 - Oliver Noonan
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-07-31 00:00:00.000000000 Z
+date: 2026-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -133,6 +133,7 @@ files:
 - app/services/mbeditor/rails_related_files_service.rb
 - app/services/mbeditor/redmine_service.rb
 - app/services/mbeditor/ri_definition_service.rb
+- app/services/mbeditor/route_service.rb
 - app/services/mbeditor/ruby_definition_service.rb
 - app/services/mbeditor/safe_path.rb
 - app/services/mbeditor/schema_service.rb