mbeditor 0.1.2 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 815b7e6688f6e3d377f9c0e0f502f5b2c105da7058209d45e067c20096186c67
-  data.tar.gz: c6f493c1a1a2a4c1f6d4ed14eb593afc28d8b173c88a4fdf1954899f44500f6c
+  metadata.gz: 45f561cf7e36141944025bc54ce679c4492a7c7315902532e350eab44b138361
+  data.tar.gz: 7612a0802d9c8e65d0539b621362b0adc3f09866bf131b14b707efafcd35e752
 SHA512:
-  metadata.gz: b450317bed54ea23c246042a2a86a1a3468f20de9a3d71b81ca7a7a69a80d01279ad40ca569a755077317113099f4cb931702ad620448a812ffecc4d1b4b1508
-  data.tar.gz: 3b23f5db3e43051546fd8997b8b5b975403aa7479c68463b7f1ebe1c6cc812f30322b70b2e838da51c012e7cd87604816d886715259af8169428f13f72a62d55
+  metadata.gz: c896888e924acc1d11e38a0efcdf6f7caec6013eb02426e4d4a0ee847accb3eb5872e5a40e1d4ca7551892352d9fce72ae4667a9585c8265ec7ffc7927e85341
+  data.tar.gz: d8cbae4ecfd6b3ec04fd5fde655a52cd176830ff38d02c89bd76e7b09372be63b0f227261ec3dcfda2cd79edbe9811a0a2bfddff58a51b2c5d1d36ac199fc3c5

data/README.md

@@ -1,5 +1,8 @@
 # mbeditor
 
+[![Gem Version](https://badge.fury.io/rb/mbeditor.svg)](https://rubygems.org/gems/mbeditor)
+[![Test](https://github.com/ojnoonan/mbeditor/actions/workflows/test.yml/badge.svg)](https://github.com/ojnoonan/mbeditor/actions/workflows/test.yml)
+
 Mbeditor (Mini Browser Editor) is a mountable Rails engine that adds a browser-based editor UI to a Rails app.
 
 ## Features

data/app/assets/javascripts/mbeditor/application.js

@@ -1,3 +1,8 @@
+//= require mbeditor/editor_store
+//= require mbeditor/file_service
+//= require mbeditor/git_service
+//= require mbeditor/search_service
+//= require mbeditor/tab_manager
 //= require mbeditor/editor_plugins
 //= require mbeditor/components/CollapsibleSection
 //= require mbeditor/components/ShortcutHelp
@@ -12,8 +17,3 @@
 //= require mbeditor/components/QuickOpenDialog
 //= require mbeditor/components/TabBar
 //= require mbeditor/components/MbeditorApp
-//= require mbeditor/editor_store
-//= require mbeditor/file_service
-//= require mbeditor/git_service
-//= require mbeditor/search_service
-//= require mbeditor/tab_manager

data/app/assets/javascripts/mbeditor/components/EditorPanel.js

@@ -40,6 +40,19 @@ var EditorPanel = function EditorPanel(_ref) {
   var setIsBlameLoading = _useState8[1];
 
   var blameDecorationsRef = useRef([]);
+  var blameZoneIdsRef = useRef([]);
+
+  var clearBlameZones = function clearBlameZones(editor) {
+    if (!editor) return;
+    if (blameZoneIdsRef.current.length === 0) return;
+
+    editor.changeViewZones(function(accessor) {
+      blameZoneIdsRef.current.forEach(function(zoneId) {
+        accessor.removeZone(zoneId);
+      });
+    });
+    blameZoneIdsRef.current = [];
+  };
 
   var findTabByPath = function findTabByPath(path) {
     if (!path) return null;
@@ -143,6 +156,8 @@ var EditorPanel = function EditorPanel(_ref) {
     });
 
     return function () {
+      blameDecorationsRef.current = editor.deltaDecorations(blameDecorationsRef.current, []);
+      clearBlameZones(editor);
       TabManager.saveTabViewState(tab.id, editor.saveViewState());
       if (window.__mbeditorActiveEditor === editor) {
         window.__mbeditorActiveEditor = null;
@@ -224,14 +239,20 @@ var EditorPanel = function EditorPanel(_ref) {
   // Reset blame state when file path changes
   useEffect(function () {
     setBlameData(null);
-    setIsBlameVisible(false);
     setIsBlameLoading(false);
+
+    // Clear stale blame render when switching files.
+    if (monacoRef.current && monacoRef.current.getModel()) {
+      clearBlameZones(monacoRef.current);
+      blameDecorationsRef.current = monacoRef.current.deltaDecorations(blameDecorationsRef.current, []);
+    }
   }, [tab.path]);
 
   // Handle Blame data fetching
   useEffect(function () {
     if (!isBlameVisible) {
       if (monacoRef.current && monacoRef.current.getModel()) {
+        clearBlameZones(monacoRef.current);
         blameDecorationsRef.current = monacoRef.current.deltaDecorations(blameDecorationsRef.current, []);
       }
       return;
@@ -240,7 +261,13 @@ var EditorPanel = function EditorPanel(_ref) {
     if (!blameData && !isBlameLoading) {
       setIsBlameLoading(true);
       GitService.fetchBlame(tab.path).then(function(data) {
-        setBlameData(data.lines || []);
+        var lines = data && Array.isArray(data.lines) ? data.lines : [];
+        setBlameData(lines);
+        if (lines.length === 0) {
+          EditorStore.setStatus('No blame data available for this file', 'warning');
+        } else {
+          EditorStore.setStatus('Loaded blame for ' + lines.length + ' lines', 'info');
+        }
         setIsBlameLoading(false);
       }).catch(function(err) {
         var status = err.response && err.response.status;
@@ -248,38 +275,89 @@ var EditorPanel = function EditorPanel(_ref) {
           ? "File is not tracked by git"
           : "Failed to load blame: " + ((err.response && err.response.data && err.response.data.error) || err.message);
         EditorStore.setStatus(msg, "error");
+        setBlameData([]);
         setIsBlameLoading(false);
-        setIsBlameVisible(false);
       });
     }
   }, [isBlameVisible, tab.path, blameData, isBlameLoading]);
 
-  // Render Blame decorations
+  // Render Blame block headers (author + summary) above contiguous commit regions.
   useEffect(function () {
     if (!monacoRef.current || !window.monaco || !isBlameVisible || !blameData) return;
+
     var editor = monacoRef.current;
-    
-    var newDecorations = blameData.map(function(lineData) {
-      var ln = lineData.line;
-      var hash = lineData.sha && lineData.sha.substring(0, 8) || '';
-      var author = lineData.author || '';
-      // Exclude uncommitted changes from noisy blame
-      var isUncommitted = hash === '00000000';
-      var text = isUncommitted ? 'Not Committed' : author + ' \xB7 ' + hash;
-      
-      return {
-        range: new window.monaco.Range(ln, 1, ln, 1),
-        options: {
-          isWholeLine: false,
-          after: {
-            content: '\xA0\xA0\xA0\xA0' + text,
-            inlineClassName: isUncommitted ? 'ide-blame-annotation-uncommitted' : 'ide-blame-annotation'
-          }
+    var model = editor.getModel();
+    var lineCount = model ? model.getLineCount() : 0;
+
+    try {
+      // Clear previous render before rebuilding.
+      clearBlameZones(editor);
+      blameDecorationsRef.current = editor.deltaDecorations(blameDecorationsRef.current, []);
+
+      var normalized = blameData.map(function(lineData) {
+        var ln = Number(lineData && lineData.line);
+        if (!model || !ln || ln < 1 || ln > lineCount) return null;
+
+        var sha = lineData && lineData.sha || '';
+        var author = lineData && lineData.author || 'Unknown';
+        var summary = lineData && lineData.summary || 'No commit message';
+        var isUncommitted = sha.substring(0, 8) === '00000000';
+
+        return {
+          line: ln,
+          sha: sha,
+          author: isUncommitted ? 'Not Committed' : author,
+          summary: summary,
+          isUncommitted: isUncommitted
+        };
+      }).filter(Boolean);
+
+      normalized.sort(function(a, b) { return a.line - b.line; });
+
+      var blocks = [];
+      normalized.forEach(function(item) {
+        var current = blocks.length > 0 ? blocks[blocks.length - 1] : null;
+        if (!current || current.sha !== item.sha || item.line !== current.endLine + 1) {
+          blocks.push({
+            sha: item.sha,
+            author: item.author,
+            summary: item.summary,
+            isUncommitted: item.isUncommitted,
+            startLine: item.line,
+            endLine: item.line
+          });
+          return;
         }
-      };
-    });
-    
-    blameDecorationsRef.current = editor.deltaDecorations(blameDecorationsRef.current, newDecorations);
+        current.endLine = item.line;
+      });
+
+      var zoneIds = [];
+      editor.changeViewZones(function(accessor) {
+        blocks.forEach(function(block, idx) {
+          var header = document.createElement('div');
+          header.className = block.isUncommitted
+            ? 'ide-blame-block-header ide-blame-block-header-uncommitted'
+            : 'ide-blame-block-header';
+          header.textContent = block.author + ' - ' + block.summary;
+
+          var zoneId = accessor.addZone({
+            afterLineNumber: block.startLine > 1 ? block.startLine - 1 : 0,
+            heightInLines: 1,
+            domNode: header,
+            suppressMouseDown: true
+          });
+          zoneIds.push(zoneId);
+        });
+      });
+      blameZoneIdsRef.current = zoneIds;
+    } catch (err) {
+      var message = err && err.message ? err.message : 'Unknown decoration error';
+      EditorStore.setStatus('Failed to render blame annotations: ' + message, 'error');
+      clearBlameZones(editor);
+      blameDecorationsRef.current = editor.deltaDecorations(blameDecorationsRef.current, []);
+    }
+
+  // Include tab.content so blame re-renders once async file contents finish loading.
   }, [blameData, isBlameVisible, tab.id, tab.content]);
 
   var sourceTab = tab.isPreview ? findTabByPath(tab.previewFor) : null;
@@ -337,20 +415,24 @@ var EditorPanel = function EditorPanel(_ref) {
     return React.createElement('div', { className: 'markdown-preview markdown-preview-full', dangerouslySetInnerHTML: { __html: markup } });
   }
 
+  // Always render the same wrapper structure so the editorRef div is never
+  // unmounted when gitAvailable changes (e.g. loaded async after workspace
+  // call returns). The toolbar is conditionally included inside the wrapper.
   return React.createElement(
     'div',
     { className: 'ide-editor-wrapper', style: { display: 'flex', flexDirection: 'column', height: '100%' } },
-    React.createElement(
+    gitAvailable && React.createElement(
       'div',
       { className: 'ide-editor-toolbar', style: { display: 'flex', justifyContent: 'flex-end', padding: '4px 8px', background: '#252526', borderBottom: '1px solid #3c3c3c' } },
       React.createElement(
         'button',
-        { 
-          className: 'ide-icon-btn ' + (isBlameVisible ? 'active' : ''), 
-          disabled: !gitAvailable,
-          onClick: gitAvailable ? function() { setIsBlameVisible(!isBlameVisible); } : undefined,
-          title: gitAvailable ? 'Toggle Git Blame' : 'Git not available in this workspace',
-          style: { fontSize: '12px', padding: '2px 6px', opacity: (gitAvailable && isBlameVisible) ? 1 : 0.6, background: isBlameVisible ? 'rgba(255,255,255,0.1)' : 'transparent', border: 'none', color: gitAvailable ? '#ccc' : '#666', cursor: gitAvailable ? 'pointer' : 'not-allowed', borderRadius: '3px' }
+        {
+          className: 'ide-icon-btn ' + (isBlameVisible ? 'active' : ''),
+          onClick: function() {
+            setIsBlameVisible(function(prev) { return !prev; });
+          },
+          title: 'Toggle Git Blame',
+          style: { fontSize: '12px', padding: '2px 6px', opacity: isBlameVisible ? 1 : 0.6, background: isBlameVisible ? 'rgba(255,255,255,0.1)' : 'transparent', border: 'none', color: '#ccc', cursor: 'pointer', borderRadius: '3px' }
         },
         React.createElement('i', { className: 'fas fa-shoe-prints', style: { marginRight: '6px' } }),
         isBlameLoading ? 'Loading...' : 'Blame'

data/app/assets/javascripts/mbeditor/components/FileTree.js

@@ -300,5 +300,21 @@ var FileTree = function FileTree(_ref) {
   );
 };
 
+// Wrap FileTree in React.memo with a custom comparator that only checks
+// the data props that affect what's rendered. Function prop references
+// (event handlers) are re-created on every parent render but do not
+// change the visual output, so we intentionally ignore them here.
+// This prevents O(n) tree traversal on every MbeditorApp re-render
+// caused by unrelated state changes (status messages, git polls, etc.).
+var FileTreeMemo = React.memo(FileTree, function(prev, next) {
+  return prev.items === next.items &&
+    prev.activePath === next.activePath &&
+    prev.selectedPath === next.selectedPath &&
+    prev.gitFiles === next.gitFiles &&
+    prev.expandedDirs === next.expandedDirs &&
+    prev.pendingCreate === next.pendingCreate &&
+    prev.pendingRename === next.pendingRename;
+});
+
 // Expose globally for sprockets require
-window.FileTree = FileTree;
+window.FileTree = FileTreeMemo;

data/app/assets/javascripts/mbeditor/components/MbeditorApp.js

@@ -197,11 +197,15 @@ var MbeditorApp = function MbeditorApp() {
   var _useState182 = _slicedToArray(_useState18, 2);
   var showGitPanel = _useState182[0];
   var setShowGitPanel = _useState182[1];
+  var showGitPanelRef = useRef(showGitPanel);
+  showGitPanelRef.current = showGitPanel;
 
   var _useState18g = useState(320);
   var _useState18g2 = _slicedToArray(_useState18g, 2);
   var gitPanelWidth = _useState18g2[0];
   var setGitPanelWidth = _useState18g2[1];
+  var gitPanelWidthRef = useRef(gitPanelWidth);
+  gitPanelWidthRef.current = gitPanelWidth;
 
   var _useState18h = useState(false);
 
@@ -567,7 +571,7 @@ var MbeditorApp = function MbeditorApp() {
           if (!body) return;
 
           var rect = body.getBoundingClientRect();
-          var reservedRight = EDITOR_MIN_WIDTH + (showGitPanel ? gitPanelWidth : 0);
+          var reservedRight = EDITOR_MIN_WIDTH + (showGitPanelRef.current ? gitPanelWidthRef.current : 0);
           var maxSidebarWidth = Math.min(SIDEBAR_MAX_WIDTH, Math.max(SIDEBAR_MIN_WIDTH, rect.width - reservedRight));
           var nextWidth = clientX - rect.left;
           setSidebarWidth(clamp(nextWidth, SIDEBAR_MIN_WIDTH, maxSidebarWidth));
@@ -614,23 +618,41 @@ var MbeditorApp = function MbeditorApp() {
     };
   }, []);
 
-  // Heartbeat — poll /ping every 5s and reflect connectivity in the status bar
+  // Heartbeat — adaptive poll: 30s when connected, 5s when trying to reconnect.
+  // Skipped entirely while the tab is hidden (Page Visibility API).
   useEffect(function () {
     var wasOnline = true;
-    var interval = setInterval(function () {
+    var timeoutId = null;
+
+    function schedule() {
+      var delay = wasOnline ? 30000 : 5000;
+      timeoutId = setTimeout(tick, delay);
+    }
+
+    function tick() {
+      if (document.hidden) {
+        // Tab is backgrounded — skip this cycle and reschedule at the normal
+        // online interval so we resume quickly once the tab becomes visible again.
+        schedule();
+        return;
+      }
       FileService.ping().then(function () {
         if (!wasOnline) {
           wasOnline = true;
           setServerOnline(true);
         }
+        schedule();
       }).catch(function () {
         if (wasOnline) {
           wasOnline = false;
           setServerOnline(false);
         }
+        schedule();
       });
-    }, 5000);
-    return function () { clearInterval(interval); };
+    }
+
+    schedule();
+    return function () { clearTimeout(timeoutId); };
   }, []);
 
   var handleSelectFile = function handleSelectFile(path, name, line) {
@@ -2103,6 +2125,11 @@ var MbeditorApp = function MbeditorApp() {
         "div",
         { className: "statusbar-msg " + state.statusMessage.kind },
         state.statusMessage.text
+      ),
+      React.createElement(
+        "div",
+        { className: "statusbar-version" },
+        "v" + (document.body.dataset.mbeditorVersion || "")
       )
     ),
 

data/app/assets/javascripts/mbeditor/editor_store.js

@@ -36,6 +36,21 @@ var EditorStore = (function () {
     emit();
   }
 
+  // Subscribe to changes in a specific subset of state keys.
+  // The listener is only called when at least one of the watched keys changes
+  // by reference (===), preventing unnecessary re-renders for unrelated updates.
+  function subscribeToSlice(keys, fn) {
+    var prev = {};
+    keys.forEach(function(k) { prev[k] = _state[k]; });
+    return subscribe(function(newState) {
+      var changed = keys.some(function(k) { return newState[k] !== prev[k]; });
+      if (changed) {
+        keys.forEach(function(k) { prev[k] = newState[k]; });
+        fn(newState);
+      }
+    });
+  }
+
   function setStatus(text, kind) {
     kind = kind || "info";
     setState({ statusMessage: { text: text, kind: kind } });
@@ -49,5 +64,5 @@ var EditorStore = (function () {
     }
   }
 
-  return { getState: getState, subscribe: subscribe, setState: setState, setStatus: setStatus };
+  return { getState: getState, subscribe: subscribe, subscribeToSlice: subscribeToSlice, setState: setState, setStatus: setStatus };
 })();

data/app/assets/javascripts/mbeditor/search_service.js

@@ -9,22 +9,28 @@ var SearchService = (function () {
   });
 
   function buildIndex(treeData) {
-    var docs = [];
-    var idCounter = 1;
+    // Capture the tree data immediately so a subsequent refresh doesn't
+    // clobber us before the idle callback fires.
+    var snapshot = treeData;
+    var schedule = window.requestIdleCallback || function(cb) { setTimeout(cb, 50); };
+    schedule(function() {
+      var docs = [];
+      var idCounter = 1;
 
-    function traverse(nodes) {
-      nodes.forEach(function(n) {
-        if (n.type === 'file') {
-          docs.push({ id: idCounter++, path: n.path, name: n.name });
-        } else if (n.children) {
-          traverse(n.children);
-        }
-      });
-    }
+      function traverse(nodes) {
+        nodes.forEach(function(n) {
+          if (n.type === 'file') {
+            docs.push({ id: idCounter++, path: n.path, name: n.name });
+          } else if (n.children) {
+            traverse(n.children);
+          }
+        });
+      }
 
-    traverse(treeData);
-    _miniSearch.removeAll();
-    _miniSearch.addAll(docs);
+      traverse(snapshot);
+      _miniSearch.removeAll();
+      _miniSearch.addAll(docs);
+    });
   }
 
   function searchFiles(query) {

data/app/assets/stylesheets/mbeditor/application.css

@@ -461,6 +461,27 @@
   user-select: none;
   opacity: 0.7;
 }
+.ide-blame-widget {
+  pointer-events: none;
+  white-space: pre;
+  margin-left: 10px;
+}
+.ide-blame-block-header {
+  font-size: 11px;
+  font-style: italic;
+  font-family: var(--font-mono);
+  color: #9aa0a6;
+  opacity: 0.85;
+  white-space: nowrap;
+  overflow: hidden;
+  text-overflow: ellipsis;
+  border-top: 1px dashed rgba(255, 255, 255, 0.08);
+  padding: 2px 10px;
+  pointer-events: none;
+}
+.ide-blame-block-header-uncommitted {
+  color: #4CAF50;
+}
 
 /* Code Review Panel & Redmine */
 .ide-code-review {

data/app/assets/stylesheets/mbeditor/editor.css

@@ -641,6 +641,13 @@ html, body, #mbeditor-root {
 .statusbar-msg.error { color: #f48771; }
 .statusbar-msg.success { color: #89d185; }
 
+.statusbar-version {
+  color: rgba(255,255,255,0.45);
+  font-size: 10px;
+  white-space: nowrap;
+  padding-left: 8px;
+}
+
 /* ── Search Panel ─────────────────────────────────────────── */
 .search-panel {
   padding: 8px;

data/app/controllers/mbeditor/application_controller.rb

@@ -1,3 +1,8 @@
+# frozen_string_literal: true
+
+require "open3"
+require "pathname"
+
 module Mbeditor
   class ApplicationController < ActionController::Base
     private
@@ -6,5 +11,49 @@ module Mbeditor
       allowed = Array(Mbeditor.configuration.allowed_environments).map(&:to_sym)
       render plain: 'Not found', status: :not_found unless allowed.include?(Rails.env.to_sym)
     end
+
+    def workspace_root
+      configured_root = Mbeditor.configuration.workspace_root
+      if configured_root.present?
+        Pathname.new(configured_root.to_s)
+      else
+        self.class.instance_variable_get(:@workspace_root_cache) ||
+          self.class.instance_variable_set(:@workspace_root_cache, begin
+            rails_root = Rails.root.to_s
+            out, status = Open3.capture2("git", "-C", rails_root, "rev-parse", "--show-toplevel")
+            Pathname.new(status.success? && out.strip.present? ? out.strip : rails_root)
+          rescue StandardError
+            Rails.root
+          end)
+      end
+    end
+
+    # Expand path and confirm it's inside workspace_root.
+    # For existing paths we also resolve symlinks so that a symlink inside the
+    # workspace that points outside cannot be used to escape the sandbox.
+    def resolve_path(raw)
+      return nil if raw.blank?
+
+      root = workspace_root.to_s
+      full = File.expand_path(raw.to_s, root)
+      return nil unless full.start_with?("#{root}/") || full == root
+
+      if File.exist?(full)
+        real_root = File.realpath(root)
+        real = File.realpath(full)
+        return nil unless real.start_with?("#{real_root}/") || real == real_root
+      end
+
+      full
+    rescue Errno::EACCES
+      nil
+    end
+
+    def relative_path(full)
+      root = workspace_root.to_s
+      return "" if full == root
+
+      full.delete_prefix(root + "/")
+    end
   end
 end

data/app/controllers/mbeditor/editors_controller.rb

@@ -12,12 +12,6 @@ module Mbeditor
     before_action :ensure_allowed_environment!
     before_action :verify_mbeditor_client, unless: -> { request.get? || request.head? }
 
-    ALLOWED_EXTENSIONS = %w[
-      rb js jsx ts tsx css scss sass html erb haml slim
-      json yaml yml md txt gemspec gemfile rakefile
-      gitignore env sh bash zsh conf config toml
-    ].freeze
-
     IMAGE_EXTENSIONS = %w[png jpg jpeg gif svg ico webp bmp avif].freeze
     MAX_OPEN_FILE_SIZE_BYTES = 5 * 1024 * 1024
     RG_AVAILABLE = system("which rg > /dev/null 2>&1")
@@ -29,8 +23,9 @@ module Mbeditor
     end
 
     # GET /mbeditor/ping — heartbeat for the frontend connectivity check
+    # Silence the log line so development consoles are not spammed.
     def ping
-      render json: { ok: true }
+      Rails.logger.silence { render json: { ok: true } }
     end
 
     # GET /mbeditor/workspace — metadata about current workspace root
@@ -171,11 +166,6 @@ module Mbeditor
       render json: { error: e.message }, status: :unprocessable_entity
     end
 
-    # Backward compatibility for stale route/action caches.
-    def rename_path
-      rename
-    end
-
     # DELETE /mbeditor/delete — remove file or directory
     def destroy_path
       path = resolve_path(params[:path])
@@ -194,11 +184,6 @@ module Mbeditor
       render json: { error: e.message }, status: :unprocessable_entity
     end
 
-    # Backward compatibility for stale route/action caches.
-    def delete_path
-      destroy_path
-    end
-
     # GET /mbeditor/search?q=...
     def search
       query = params[:q].to_s.strip
@@ -408,41 +393,6 @@ module Mbeditor
       render plain: 'Forbidden', status: :forbidden
     end
 
-    def workspace_root
-      configured_root = Mbeditor.configuration.workspace_root
-      if configured_root.present?
-        # Explicitly configured — no subprocess required, just wrap it.
-        Pathname.new(configured_root.to_s)
-      else
-        # Auto-detect from git. Cache the result since the git root cannot change
-        # within a running process.
-        self.class.instance_variable_get(:@workspace_root_cache) ||
-          self.class.instance_variable_set(:@workspace_root_cache, begin
-            rails_root = Rails.root.to_s
-            out, status = Open3.capture2("git", "-C", rails_root, "rev-parse", "--show-toplevel")
-            Pathname.new(status.success? && out.strip.present? ? out.strip : rails_root)
-          rescue StandardError
-            Rails.root
-          end)
-      end
-    end
-
-    # Expand path and confirm it's inside workspace_root
-    def resolve_path(raw)
-      return nil if raw.blank?
-
-      root = workspace_root.to_s
-      full = File.expand_path(raw.to_s, root)
-      full.start_with?(root + "/") || full == root ? full : nil
-    end
-
-    def relative_path(full)
-      root = workspace_root.to_s
-      return "" if full == root
-
-      full.delete_prefix(root + "/")
-    end
-
     def path_blocked_for_operations?(full_path)
       rel = relative_path(full_path)
       return true if rel.blank?
@@ -453,7 +403,7 @@ module Mbeditor
     def build_tree(dir, max_depth: 10, depth: 0)
       return [] if depth >= max_depth
 
-      entries = Dir.entries(dir).sort.reject { |entry| entry.start_with?(".") || entry == "." || entry == ".." }
+      entries = Dir.entries(dir).sort.reject { |entry| entry == "." || entry == ".." }
       entries.filter_map do |name|
         full = File.join(dir, name)
         rel = relative_path(full)

data/app/controllers/mbeditor/git_controller.rb

@@ -137,7 +137,7 @@ module Mbeditor
       end
 
       render plain: out, content_type: "text/plain"
-    rescue StandardError => e
+    rescue StandardError
       render plain: "", content_type: "text/plain"
     end
 
@@ -159,11 +159,6 @@ module Mbeditor
 
     private
 
-    def workspace_root
-      configured = Mbeditor.configuration.workspace_root
-      configured.present? ? configured.to_s : Rails.root.to_s
-    end
-
     # Require & validate a `file` query param, responding 400/403 on bad input.
     # Returns the relative path string on success, or nil if already responded.
     def require_file_param
@@ -174,15 +169,13 @@ module Mbeditor
         return nil
       end
 
-      # Validate that the path stays within the workspace
-      root = workspace_root
-      full = File.expand_path(raw, root)
-      unless full.start_with?(root + "/") || full == root
+      full = resolve_path(raw)
+      unless full
         render json: { error: "Forbidden" }, status: :forbidden
         return nil
       end
 
-      raw
+      relative_path(full)
     end
   end
 end

data/app/views/layouts/mbeditor/application.html.erb

@@ -29,7 +29,7 @@
   <script>var require = { paths: { vs: '<%= json_escape("#{base_path}/monaco-editor/vs") %>' } };</script>
   <script src="<%= "#{base_path}/monaco-editor/vs/loader.js" %>"></script>
 </head>
-<body data-rails-root="<%= Rails.root.to_s %>">
+<body data-rails-root="<%= Rails.root.to_s %>" data-mbeditor-version="<%= Mbeditor::VERSION %>">
   <script>
     window.MBEDITOR_BASE_PATH = "<%= json_escape(base_path) %>";
     window.prettierPlugins = {

data/lib/mbeditor/engine.rb

@@ -1,7 +1,13 @@
+require "mbeditor/rack/silence_ping_request"
+
 module Mbeditor
   class Engine < ::Rails::Engine
     isolate_namespace Mbeditor
 
+    initializer "mbeditor.silence_ping_request" do |app|
+      app.middleware.insert_before Rails::Rack::Logger, Mbeditor::Rack::SilencePingRequest
+    end
+
     initializer "mbeditor.assets.precompile" do |app|
       app.config.assets.precompile += %w[
         mbeditor/application.css

data/lib/mbeditor/rack/silence_ping_request.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require "active_support/logger_silence"
+
+module Mbeditor
+  module Rack
+    # Silence periodic editor heartbeats so development logs stay readable.
+    class SilencePingRequest
+      def initialize(app)
+        @app = app
+      end
+
+      def call(env)
+        if ping_request?(env)
+          Rails.logger.silence { @app.call(env) }
+        else
+          @app.call(env)
+        end
+      end
+
+      private
+
+      def ping_request?(env)
+        env["REQUEST_METHOD"] == "GET" &&
+          env["HTTP_X_MBEDITOR_CLIENT"] == "1" &&
+          env["PATH_INFO"].to_s.end_with?("/ping")
+      end
+    end
+  end
+end

data/lib/mbeditor/version.rb

@@ -1,3 +1,3 @@
 module Mbeditor
-  VERSION = "0.1.2"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mbeditor
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.4
 platform: ruby
 authors:
 - Oliver Noonan
@@ -92,6 +92,7 @@ files:
 - lib/mbeditor.rb
 - lib/mbeditor/configuration.rb
 - lib/mbeditor/engine.rb
+- lib/mbeditor/rack/silence_ping_request.rb
 - lib/mbeditor/version.rb
 - mbeditor.gemspec
 - public/min-maps/vs/base/worker/workerMain.js.map