maxmind 0.1.2 → 0.4.2

data/lib/maxmind/response.rb

@@ -1,70 +1,76 @@
 module Maxmind
-  class Response  
-    attr_accessor :country_match, :country_code, :high_risk_country, :distance, 
-      :ip_region, :ip_city, :ip_latitude, :ip_longitude, :ip_isp, :ip_org,
-      :anonymous_proxy, :proxy_score, :is_transparent_proxy,
-      :free_mail, :carder_email, :high_risk_username, :high_risk_password,
-      :bin_match, :bin_country, :bin_name_match, :bin_name, :bin_phone_match,
-      :bin_phone, :phone_in_billing_location, :ship_forward, :city_postal_match,
-      :ship_city_postal_match, :score, :explanation, :risk_score, :queries_remaining,
-      :maxmind_id, :error, :response
-  
+  class Response
+    attr_accessor :attributes
+
+    ATTRIBUTE_MAP = {
+      'custPhoneInBillingLoc' => 'phone_in_billing_location',
+      'maxmindID' => 'maxmind_id',
+      'isTransProxy' => 'is_transparent_proxy',
+      'err' => 'error'
+    }
+
     def initialize(response = nil)
-      raise ArgumentError, 'need a valid response string' if response.nil?
-    
+      raise ArgumentError, 'Missing response string' unless response
+      @attributes = {}
       parse(response)
     end
-      
+
     def parse(response)
       response.split(';').each do |parameter|
         k, v = parameter.split('=')
-      
-        case k
-        when 'err'
-          set_attribute('error', v)
-        when 'custPhoneInBillingLoc'
-          set_attribute('phone_in_billing_location', v)
-        when 'maxmindID'
-          set_attribute('maxmind_id', v)
-        when 'isTransProxy'
-          set_attribute('is_transparent_proxy', v)
-        when 'explanation'
-          @explanation = v
+
+        if ATTRIBUTE_MAP.has_key?(k)
+          set_attribute(ATTRIBUTE_MAP[k], v)
         else
           set_attribute(k.gsub(/([A-Z])/, '_\1').downcase, v)
         end
       end
-    end   
-  
-    alias_method :country_match?, :country_match
-    alias_method :high_risk_country?, :high_risk_country
-    alias_method :anonymous_proxy?, :anonymous_proxy
-    alias_method :is_transparent_proxy?, :is_transparent_proxy
-    alias_method :free_mail?, :free_mail
-    alias_method :carder_email?, :carder_email
-    alias_method :high_risk_username?, :high_risk_username
-    alias_method :high_risk_password?, :high_risk_password
-    alias_method :city_postal_match?, :city_postal_match
-    alias_method :ship_city_postal_match?, :ship_city_postal_match 
-    alias_method :bin_match?, :bin_match
-  
+    end
+
+    # Returns an array of names for the attributes available
+    # on this object sorted alphabetically.
+    def attribute_names
+      attributes.keys.sort
+    end
+
+    def method_missing(meth, *args)
+      if meth.to_s[-1] == '?'
+        send(meth[0..-2])
+      elsif attributes.has_key?(meth)
+        attributes[meth]
+      else
+        super
+      end
+    end
+
+    def respond_to?(meth)
+      if meth.to_s[-1] == '?'
+        respond_to? meth[0..-2]
+      else
+        super
+      end 
+    end
+
     protected
-    def set_attribute(k, v)      
+    
+    def set_attribute(k, v)
+      k = k.to_sym
+
       if v.nil?
-        self.instance_variable_set("@#{k}", nil) 
+        attributes[k] = nil
         return
       end
-      
+
       v = Integer(v) rescue Float(v) rescue v;
-      
+
       case v
       when /[Yy]es/
-        self.instance_variable_set("@#{k}", true)
+        attributes[k] = true
       when /[Nn]o/
-        self.instance_variable_set("@#{k}", false)
+        attributes[k] = false
       else
-        self.instance_variable_set("@#{k}", v)
+        attributes[k] = v
       end
-    end    
+    end
   end
 end

data/lib/maxmind/version.rb

@@ -0,0 +1,3 @@
+module Maxmind
+  VERSION = '0.4.2'
+end

data/maxmind.gemspec

@@ -1,55 +1,30 @@
 # -*- encoding: utf-8 -*-
+$:.push File.expand_path('../lib', __FILE__)
+require 'maxmind/version'
 
 Gem::Specification.new do |s|
-  s.name = %q{maxmind}
-  s.version = "0.1.2"
+  s.name = "maxmind"
+  s.version = Maxmind::VERSION
 
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = ["Adam Daniels"]
-  s.date = %q{2009-05-16}
-  s.email = %q{adam@mediadrive.ca}
+  s.authors = ["Adam Daniels", "Tinu Cleatus", "t.e.morgan", "Sam Oliver"]
+  s.date = "2012-01-06"
+  s.description = "A wrapper around MaxMind's minFraud anti-fraud service. \n\nhttp://www.maxmind.com/app/ccv_overview\n"
+  s.email = "adam@mediadrive.ca"
   s.extra_rdoc_files = [
     "LICENSE",
-     "README.markdown"
+    "README.md"
   ]
-  s.files = [
-    ".document",
-     ".gitignore",
-     "LICENSE",
-     "README.markdown",
-     "Rakefile",
-     "VERSION",
-     "examples/example.rb",
-     "lib/maxmind.rb",
-     "lib/maxmind/request.rb",
-     "lib/maxmind/response.rb",
-     "maxmind.gemspec",
-     "test/fixtures/response.txt",
-     "test/maxmind_test.rb",
-     "test/test_helper.rb"
-  ]
-  s.has_rdoc = true
-  s.homepage = %q{http://github.com/adam12/maxmind}
-  s.rdoc_options = ["--charset=UTF-8"]
+  
+  s.files         = `git ls-files`.split("\n")
+  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
+  s.homepage = "http://github.com/adam12/maxmind"
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.1}
-  s.summary = %q{TODO}
-  s.test_files = [
-    "test/maxmind_test.rb",
-     "test/test_helper.rb",
-     "examples/example.rb"
-  ]
+  s.summary = "Wrapper for MaxMind's minFraud service"
 
-  if s.respond_to? :specification_version then
-    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
-    s.specification_version = 2
+  s.add_development_dependency 'rspec'
+  s.add_development_dependency 'mocha'
+  s.add_development_dependency 'webmock'
 
-    if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<httparty>, [">= 0"])
-    else
-      s.add_dependency(%q<httparty>, [">= 0"])
-    end
-  else
-    s.add_dependency(%q<httparty>, [">= 0"])
-  end
+  s.add_runtime_dependency 'active_support', '>= 3.0.0'
 end
+

data/spec/data/optional_fields.json

@@ -0,0 +1,17 @@
+{
+  "bin_name": "MBNA America Bank",
+  "bin_phone": "800-421-2110",
+  "cust_phone": "212-242",
+  "request_type": "premium",
+  "shipping_address": "145-50 157th Street",
+  "shipping_city": "Jamaica",
+  "shipping_region": "NY",
+  "shipping_postal": "11434",
+  "shipping_country": "US",
+  "transaction_id": "1234",
+  "order_amount": 9.99,
+  "order_currency": "GBP",
+  "session_id": "abcd9876",
+  "user_agent": "Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_5; en-us) AppleWebKit/525.18 (KHTML, like Gecko) Version/3.1.2 Safari/525.20.1",
+  "accept_language": "en-us"
+}

data/spec/data/recommended_fields.json

@@ -0,0 +1,8 @@
+{
+  "domain": "yahoo.com",
+  "bin": "549099",
+  "forwarded_ip": "24.24.24.25",
+  "email": "test@test.com",
+  "username": "test_carder_username",
+  "password": "test_carder_password"
+}

data/spec/data/required_fields.json

@@ -0,0 +1,7 @@
+{
+  "client_ip": "24.24.24.24",
+  "city": "New York",
+  "region": "NY",
+  "postal": "11434",
+  "country": "US"
+}

data/spec/maxmind/request_spec.rb

@@ -0,0 +1,50 @@
+require 'spec_helper'
+
+describe Maxmind::Request do
+  before do
+    Maxmind.license_key = 'key'
+    required_fields = JSON.parse(load_fixture("required_fields.json"))
+    @request = Maxmind::Request.new(required_fields)
+  end
+
+  it "requires a key" do
+    Maxmind.license_key = nil
+    expect { @request.send(:validate) }.to raise_error(ArgumentError)
+    Maxmind.license_key = 'key'
+  end
+
+  it "requires client IP" do
+    expect { @request.client_ip = nil; @request.send(:validate) }.to raise_exception(ArgumentError)
+  end
+
+  it "requires city" do
+    expect { @request.city = nil; @request.send(:validate) }.to raise_exception(ArgumentError)
+  end
+
+  it "requires region" do
+    expect { @request.region = nil; @request.send(:validate) }.to raise_exception(ArgumentError)
+  end
+
+  it "requires postal" do
+    expect { @request.postal = nil; @request.send(:validate) }.to raise_exception(ArgumentError)
+  end
+
+  it "requires country" do
+    expect { @request.country = nil; @request.send(:validate) }.to raise_exception(ArgumentError)
+  end
+
+  it "converts username to MD5" do
+    @request.username = 'testuser'
+    @request.username.should == '5d9c68c6c50ed3d02a2fcf54f63993b6'
+  end
+
+  it "converts password to MD5" do
+    @request.password = 'testpassword'
+    @request.password.should == 'e16b2ab8d12314bf4efbd6203906ea6c'
+  end
+
+  it "converts email to MD5" do
+    @request.email = 'test@test.com'
+    @request.email.should == 'b642b4217b34b1e8d3bd915fc65c4452'
+  end
+end

data/spec/maxmind/response_spec.rb

@@ -0,0 +1,72 @@
+require 'spec_helper'
+
+REQUIRED_FIELDS =
+
+RECOMMENDED_FIELDS =
+
+OPTIONAL_FIELDS =
+
+describe Maxmind::Response do
+  before do
+    Maxmind.license_key = 'LICENSE_KEY'
+
+    required_fields = JSON.parse(load_fixture("required_fields.json"))
+    recommended_fields = JSON.parse(load_fixture("recommended_fields.json"))
+    optional_fields = JSON.parse(load_fixture("optional_fields.json"))
+    all_fields = required_fields.merge(recommended_fields).merge(optional_fields)
+
+    request = Maxmind::Request.new(all_fields)
+    stub_request(:post, "https://minfraud.maxmind.com/app/ccv2r").
+      to_return(:body => load_fixture("response.txt"), :status => 200)
+    @response = request.process!
+  end
+
+  it "requires a response" do
+    expect { Maxmind::Response.new }.to raise_exception(ArgumentError)
+  end
+
+  it "exposes its attributes" do
+    @response.attributes.should be_a Hash
+  end
+
+  it "has a distance" do
+    @response.distance.should == 329
+  end
+
+  it "has a maxmind ID" do
+    @response.maxmind_id.should == '9VSOSDE2'
+  end
+
+  it "has a risk score" do
+    @response.risk_score.should == 2.0
+  end
+
+  it "has a score" do
+    @response.score.should == 7.66
+  end
+
+  it "has queries remaining" do
+    @response.queries_remaining.should == 955
+  end
+
+  it "has an explanation" do
+    @response.explanation.should_not == nil
+  end
+
+  it "has a country match" do
+    @response.country_match.should_not == nil
+  end
+
+  it "has a boolean country match" do
+    @response.country_match.should_not == "Yes"
+    @response.country_match.should == true
+  end
+
+  it "has a phone in billing location" do
+    @response.phone_in_billing_location.should == false
+  end
+
+  it "has a phone in billing location ? method" do
+    @response.phone_in_billing_location?.should == false
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,30 @@
+require 'mocha_standalone'
+require 'maxmind'
+require 'json'
+require 'webmock/rspec'
+
+RSpec.configure do |config|
+
+  config.before(:suite) do
+    # Disable all live HTTP requests
+    WebMock.disable_net_connect!(allow_localhost: true)
+  end
+
+  config.mock_with :mocha
+end
+
+# Constants (classes, etc) defined within a block passed to this method
+# will be removed from the global namespace after the block as run.
+def isolate_constants
+  existing_constants = Object.constants
+  yield
+ensure
+  (Object.constants - existing_constants).each do |constant|
+    Object.send(:remove_const, constant)
+  end
+end
+
+
+def load_fixture(*filename)
+  File.open(File.join('spec', 'data', *filename)).read
+end

metadata

@@ -1,78 +1,145 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: maxmind
-version: !ruby/object:Gem::Version 
-  version: 0.1.2
+version: !ruby/object:Gem::Version
+  version: 0.4.2
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - Adam Daniels
+- Tinu Cleatus
+- t.e.morgan
+- Sam Oliver
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2009-05-16 00:00:00 -04:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  name: httparty
+date: 2012-01-06 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: active_support
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 3.0.0
   type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
-    version: 
-description: 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+description: ! "A wrapper around MaxMind's minFraud anti-fraud service. \n\nhttp://www.maxmind.com/app/ccv_overview\n"
 email: adam@mediadrive.ca
 executables: []
-
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
 - LICENSE
-- README.markdown
-files: 
-- .document
+- README.md
+files:
 - .gitignore
+- Gemfile
+- Guardfile
 - LICENSE
-- README.markdown
+- README.md
 - Rakefile
-- VERSION
 - examples/example.rb
 - lib/maxmind.rb
 - lib/maxmind/request.rb
 - lib/maxmind/response.rb
+- lib/maxmind/version.rb
 - maxmind.gemspec
-- test/fixtures/response.txt
-- test/maxmind_test.rb
-- test/test_helper.rb
-has_rdoc: true
+- spec/data/optional_fields.json
+- spec/data/recommended_fields.json
+- spec/data/required_fields.json
+- spec/data/response.txt
+- spec/maxmind/request_spec.rb
+- spec/maxmind/response_spec.rb
+- spec/spec_helper.rb
 homepage: http://github.com/adam12/maxmind
+licenses: []
 post_install_message: 
-rdoc_options: 
-- --charset=UTF-8
-require_paths: 
+rdoc_options: []
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-  version: 
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-  version: 
+required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
+      - 0
+      hash: -1867686245011996081
+required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+      segments:
+      - 0
+      hash: -1867686245011996081
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.3.1
+rubygems_version: 1.8.21
 signing_key: 
-specification_version: 2
-summary: TODO
-test_files: 
-- test/maxmind_test.rb
-- test/test_helper.rb
-- examples/example.rb
+specification_version: 3
+summary: Wrapper for MaxMind's minFraud service
+test_files:
+- spec/data/optional_fields.json
+- spec/data/recommended_fields.json
+- spec/data/required_fields.json
+- spec/data/response.txt
+- spec/maxmind/request_spec.rb
+- spec/maxmind/response_spec.rb
+- spec/spec_helper.rb