maximus 0.1.5.1 → 0.1.6.1

data/spec/maximus/git_control_spec.rb

@@ -85,28 +85,28 @@ describe Maximus::GitControl do
 
   end
 
-  describe '#set_psuedo_commit' do
+  describe '#define_psuedo_commit' do
 
     context 'words are provided' do
 
       context 'master is supplied' do
         let(:config) { { commit: 'master' } }
         it 'should return the master sha' do
-          expect( git.send(:set_psuedo_commit) ).to eq `git -C #{Dir.pwd} rev-parse --branches=master HEAD`.strip!
+          expect( git.send(:define_psuedo_commit) ).to eq `git -C #{Dir.pwd} rev-parse --branches=master HEAD`.strip!
         end
       end
 
       context 'last is supplied' do
         let(:config) { { commit: 'last' } }
         it 'should return the previous_commit sha' do
-          expect( git.send(:set_psuedo_commit) ).to eq `git -C #{Dir.pwd} rev-parse HEAD^`.strip!
+          expect( git.send(:define_psuedo_commit) ).to eq `git -C #{Dir.pwd} rev-list --max-count=2 HEAD --reverse | head -n1`.strip!
         end
       end
 
       context 'working is supplied' do
         let(:config) { { commit: 'working' } }
         it 'should return the word "working"' do
-          expect( git.send(:set_psuedo_commit) ).to eq 'working'
+          expect( git.send(:define_psuedo_commit) ).to eq 'working'
         end
       end
 
@@ -115,7 +115,7 @@ describe Maximus::GitControl do
     context 'a commit hash is provided' do
       let(:config) { { commit: '22126a6ba227d81f770d13c302e6225f7463f7be' } }
       it 'should return the provided hash' do
-        expect( git.send(:set_psuedo_commit) ).to eq '22126a6ba227d81f770d13c302e6225f7463f7be'
+        expect( git.send(:define_psuedo_commit) ).to eq '22126a6ba227d81f770d13c302e6225f7463f7be'
       end
     end
 

data/spec/maximus/helper_spec.rb

@@ -14,8 +14,19 @@ describe Maximus::Helper do
       end
     end
 
+    context 'when Rails is defined' do
+      it 'should be true' do
+        stub_const('Rails', true)
+        expect(dummy_class.is_rails?).to be_truthy
+      end
+    end
+
   end
 
+  # @todo - return to 68adbaa7b1e729c5d38a2dde6245e8c86704ad5f and figure out a
+  #   way to test for middleman's existence. Can't stub it very well.
+  #   Once this is determined, change up #discover_path too
+
   describe '#root_dir', :isolated_environment do
 
     context 'when project is not a Rails app' do
@@ -82,15 +93,38 @@ describe Maximus::Helper do
 
   end
 
-  describe '#lines_added_to_range', :isolated_environment do
+  describe '#discover_path' do
+
+    context 'when @path is set' do
+      it 'should return @path' do
+        dummy_class.instance_variable_set("@path", '/some/fake/path/to/files')
+        expect( dummy_class.discover_path(Dir.pwd) ).to eq '/some/fake/path/to/files'
+      end
+    end
+
+    context 'when Rails is defined' do
+      it 'should return a rails-y path' do
+        stub_const('Rails', true)
+        path = dummy_class.discover_path(Dir.pwd, 'stylesheets', 'scss')
+        expect( path ).to include('app/assets/stylesheets')
+        expect( dummy_class.discover_path(Dir.pwd, 'scss') ).to include('assets')
+      end
+    end
 
-    context 'when a functional hash is provided' do
-      let(:lines_added) { { changes: ['0..5', '11..14'] } }
+    context 'when neither Middleman or Rails are defined' do
+      it 'should return a path with just the root directory' do
+        path = dummy_class.discover_path(Dir.pwd)
+        expect( path ).to eq Dir.pwd
+      end
+    end
 
-      it 'should return an array of numbers' do
-        expect( dummy_class.lines_added_to_range lines_added ).to eq( [ 0,1,2,3,4,5, 11,12,13,14] )
+    context 'when neither Middleman or Rails are defined and an extension is provided' do
+      it 'should return a generic glob path' do
+        path = dummy_class.discover_path(Dir.pwd, 'stylesheets', 'scss')
+        expect( path ).to include('**/*')
       end
     end
+
   end
 
 

data/spec/maximus/lint_spec.rb

@@ -7,14 +7,17 @@ describe Maximus::Lint do
     {"/Users/Tim/dummy/app/assets/stylesheets/application.css"=>[{"line"=>1, "column"=>1, "length"=>1, "severity"=>"warning", "reason"=>"Use `//` comments everywhere", "linter"=>"Comment"}], "/Users/Tim/dummy/app/assets/stylesheets/main.css.scss"=>[{"line"=>2, "column"=>3, "length"=>16, "severity"=>"warning", "reason"=>"Properties should be ordered margin, max-width", "linter"=>"PropertySortOrder"}]}
   }
 
-  subject(:lint) { described_class.new }
+  subject(:lint) do
+    described_class.new
+  end
+
+  describe '.refine', :isolated_environment do
 
-  describe '#refine', :isolated_environment do
     context 'data is blank' do
       let(:data) { }
       it 'should provide a blank response' do
         STDOUT.should_receive(:puts).with("#{''.color(:green)}: #{'[0]'.color(:yellow)}#{' [0]'.color(:red)}")
-        blank_response = { lint_warnings: [], lint_errors: [], lint_conventions: [], lint_refactors: [], raw_data: "{}" }
+        blank_response = { lint_warnings: [], lint_errors: [], lint_conventions: [], lint_refactors: [], lint_fatals: [], raw_data: "{}" }
         expect( lint.refine(data) ).to eq blank_response
       end
     end
@@ -37,6 +40,7 @@ describe Maximus::Lint do
         expect( lint.refine(data.to_json) ).to be_a(Hash)
       end
     end
+
   end
 
   describe '#evaluate_severities', :isolated_environment do
@@ -48,4 +52,15 @@ describe Maximus::Lint do
     end
   end
 
+  describe '#lines_added_to_range', :isolated_environment do
+
+    context 'when a functional hash is provided' do
+      let(:lines_added) { { changes: ['0..5', '11..14'] } }
+
+      it 'should return an array of numbers' do
+        expect( lint.send(:lines_added_to_range, lines_added) ).to eq( [ 0,1,2,3,4,5, 11,12,13,14] )
+      end
+    end
+  end
+
 end

data/spec/spec_helper.rb

@@ -1,8 +1,11 @@
 require 'maximus'
 require 'coveralls'
+require 'pry'
 Coveralls.wear!
 
 RSpec.configure do |config|
+  config.before { allow($stdout).to receive(:puts) }
+  config.order = "random"
   config.mock_with :rspec do |c|
     c.syntax = [:should, :expect]
   end

data/spec/support/config_helper.rb

@@ -0,0 +1,14 @@
+
+module ConfigHelper
+
+  def create_config(contents = '', location = '.maximus.yml')
+    File.write(location, contents)
+    config_contents = contents.blank? ? {} : { config_file: location }
+    described_class.new(config_contents)
+  end
+
+  def destroy_config(location = '.maximus.yml')
+    FileUtils.rm(location) if File.exist?(location)
+  end
+
+end

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: maximus
 version: !ruby/object:Gem::Version
-  version: 0.1.5.1
+  version: 0.1.6.1
 platform: ruby
 authors:
 - Tim Shedor
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-02 00:00:00.000000000 Z
+date: 2015-03-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: git
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.2.9
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.2.9
 - !ruby/object:Gem::Dependency
   name: scss-lint
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.33.0
+        version: 0.34.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.33.0
+        version: 0.34.0
 - !ruby/object:Gem::Dependency
   name: rainbow
   requirement: !ruby/object:Gem::Requirement
@@ -56,140 +56,154 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.28'
+        version: '0.29'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.28'
+        version: '0.29'
 - !ruby/object:Gem::Dependency
   name: rails_best_practices
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.15'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.15'
 - !ruby/object:Gem::Dependency
   name: brakeman
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.0.1
 - !ruby/object:Gem::Dependency
   name: wraith
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: 2.3.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.3'
+        version: 2.3.2
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.7.8
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.7.8
 description: The all-in-one linting solution
@@ -200,9 +214,10 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -239,6 +254,7 @@ files:
 - spec/maximus/helper_spec.rb
 - spec/maximus/lint_spec.rb
 - spec/spec_helper.rb
+- spec/support/config_helper.rb
 - spec/support/rubocop.yml
 homepage: https://github.com/wearefine/maximus
 licenses:
@@ -250,17 +266,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.4.2
 signing_key: 
 specification_version: 4
 summary: Make your code spic and <span>
@@ -270,5 +286,6 @@ test_files:
 - spec/maximus/helper_spec.rb
 - spec/maximus/lint_spec.rb
 - spec/spec_helper.rb
+- spec/support/config_helper.rb
 - spec/support/rubocop.yml
 has_rdoc: