mavenlint 1.2.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 882e8d33124b9ee52b9217164397280aa6cd66c9
-  data.tar.gz: 72741abfa7c50f4d25796611cc1a2f7173fd6c32
+  metadata.gz: dcfc99e4f4f3972ef1b8f710e2f038061810051d
+  data.tar.gz: 6fecb9a506040fdc6242c96dde6f719f7f778a9d
 SHA512:
-  metadata.gz: b22956d519f95a4ffb3fdae9a25c83718f072e6c26e1c2c4f9fa68b2d457fe7b6a4b85f14c3f29b2f083767e2774639cdf6068340c045c6b292ba0b1fa449307
-  data.tar.gz: a377001f38dd395d3116ac2596810a6bf8cdb90be8058a0df4420d1e98b294b0ba8fd492621d72fe847a2a2294a76f7a0bb2c9cb7e4b232e3ee40d3dd9c46d6c
+  metadata.gz: 3035ed08d6026916007c04c77978c75465d26de511ccf4737c403524fef221acbcbf8343d577978d8df30329989239a82b715e36e26d3072fb0270802dbc7ae9
+  data.tar.gz: 55cdf4ed75294698ee27061f7777f54191adbaf3f5e500be35a8b70f24ba0a8402e2c12a94ff0f8c60f911468227b8bbd34a5ffb035077ae5cf3be4c16ee8a24

data/lib/mavenlint.rb

@@ -1,2 +1,3 @@
-require 'rubocop/cop/mavenlint/unsafe-mass-assignment'
-require 'rubocop/cop/mavenlint/use-application-record'
+require 'rubocop/cop/mavenlint/unsafe_mass_assignment'
+require 'rubocop/cop/mavenlint/use_application_record'
+require 'rubocop/cop/mavenlint/use_fast_capybara_matchers'

data/lib/rubocop/cop/mavenlint/{unsafe-mass-assignment.rb → unsafe_mass_assignment.rb}

@@ -15,7 +15,7 @@ module RuboCop
       # or updated through a publicly accessible endpoint, because the associated model isn't
       # necessarily loaded and ran through security checks.
       class UnsafeMassAssignment < RuboCop::Cop::Cop
-        MSG = "Do not allow mass-assignment of foreign key columns. See http://bit.ly/2IjZco0".freeze
+        MSG = "Do not allow mass-assignment of foreign key columns. See https://github.com/mavenlink/welcome/wiki/Lint-Errors#unsafemassassignment".freeze
 
         def on_send(node)
           return unless node.command?(:attr_accessible)

data/lib/rubocop/cop/mavenlint/use_fast_capybara_matchers.rb

@@ -0,0 +1,46 @@
+require 'rubocop'
+
+module RuboCop
+  module Cop
+    module Mavenlint
+      # Identify usages of `to_not` with a Capybara matcher, which will be really slow.
+      #
+      # For example
+      #
+      #   expect(page).to_not have_text('Hi')
+      #
+      # Writing an assertion this way will first try to find the text 'Hi'. If not present,
+      # Capybara will wait for the full timeout (often 30 seconds) before then inverting with
+      # `to_not` and passing.
+      #
+      # Instead, we should do something like:
+      #
+      #   expect(page).to have_no_text('Hi')
+      #
+      # Which will pass as soon as the text is not detected without any timeout.
+      class UseFastCapybaraMatchers < RuboCop::Cop::Cop
+        MSG = 'Use a `to have_no_*` selector. See https://github.com/mavenlink/welcome/wiki/Lint-Errors#usefastcapybaramatchers'.freeze
+        CAPYBARA_MATCHERS = %i(have_button have_checked_field have_content have_css have_field have_link have_select have_selector have_table have_text have_unchecked_field have_xpath)
+
+        def_node_matcher :slow_capybara_matcher?, <<~PATTERN
+          (send
+            (send nil? :expect _)
+            :to_not
+            (send nil? #capybara? ...))
+        PATTERN
+
+        def on_send(node)
+          return unless slow_capybara_matcher?(node)
+
+          add_offense(node)
+        end
+
+        private
+
+        def capybara?(symbol)
+          CAPYBARA_MATCHERS.include?(symbol)
+        end
+      end
+    end
+  end
+end

data/rubocop.yml

@@ -56,3 +56,9 @@ Layout/EmptyLinesAroundMethodBody:
 # Ensure that two spaces are used for indentation.
 Layout/IndentationWidth:
   Enabled: true
+
+# Only run our Capybara checks in directories that will have Capybara tests.
+Mavenlint/UseFastCapybaraMatchers:
+  Include:
+    - spec/selenium/**/*.rb
+    - spec/features/**/*.rb

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mavenlint
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.3.0
 platform: ruby
 authors:
 - Mavenlnk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-07 00:00:00.000000000 Z
+date: 2018-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -60,8 +60,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - lib/mavenlint.rb
-- lib/rubocop/cop/mavenlint/unsafe-mass-assignment.rb
-- lib/rubocop/cop/mavenlint/use-application-record.rb
+- lib/rubocop/cop/mavenlint/unsafe_mass_assignment.rb
+- lib/rubocop/cop/mavenlint/use_application_record.rb
+- lib/rubocop/cop/mavenlint/use_fast_capybara_matchers.rb
 - rubocop.yml
 homepage: https://github.com/mavenlink/mavenlint
 licenses: