maven-cli 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a7477c96b8ce0bd10f2e0fecc3cbe6c953da3d68
-  data.tar.gz: 1e4423fc97b285e9ab7ba75f1b61d56e124f0739
+  metadata.gz: e452f3749de2fa98dbd28bb5231db63088af6121
+  data.tar.gz: 42acb73cc02aa2990b7c1f0928248b2349e87d73
 SHA512:
-  metadata.gz: da11e072a7e428db945c5ca3dc2b11e521a658cfa406e0e9d4ae1baecd074c3e9f090a0bdbf95201385c54dcfb9ebda50c911522a70247cd724ed0888e2324af
-  data.tar.gz: 73b0587485728a7ad32132a8534197235005af5525840a600d997eb99dd4060195614cf702650482140b37750d004938d7cefa8b7e5d560ef5dc78dcf4d10f33
+  metadata.gz: 8906eaa07d210768cea8cad9cd33ac2ee51aa9586e445c3e5c6c77992c310f3b10b2f3483582c2cf239e11946c09c826700c27c0f7d30bde0a3973e6b5d1e6a0
+  data.tar.gz: 83c0f810390caf0e33b45a03c1d57b799a5400e4e53de7671f4704a44ba1314a1ff046e2a506772ea01ce18cd3de6d126202809cee491316822b66f50cf03331

data/.gitignore

@@ -1,3 +1,4 @@
 maven-cli-*.gem
 test-*
 Gemfile.lock
+coverage

data/.gitlab-ci.yml

@@ -1,16 +1,19 @@
 image: sbernard/arch-kitchen-docker
 
 rubocop:
+  stage: test
   script:
     - rubocop
 
 lines_length:
+  stage: test
   script:
     - >
       curl https://gitlab.com/s4m/checks/raw/master/check_lines_length.sh |
       bash
 
 git_history:
+  stage: test
   script:
     - >
       curl https://gitlab.com/s4m/checks/raw/master/check_git_history.sh |
@@ -20,5 +23,22 @@ before_script:
   - bundle install
 
 rspec:
+  stage: test
   script:
     - rspec
+  artifacts:
+    paths:
+      - coverage/
+
+pages:
+  stage: deploy
+  dependencies:
+    - rspec
+  script:
+    - mv coverage/ public/
+  artifacts:
+    paths:
+      - public
+    expire_in: 30 days
+  only:
+    - develop

data/CHANGELOG

@@ -1,6 +1,23 @@
 Changelog
 =========
 
+1.1.0
+-----
+
+Main:
+
+- Fix #2: download latest version if not specified
+- Fix #3: 404 error when version contains an hyphen
+- Exit 1 when an error occur, except during tests
+- Fix gem description, add ruby support
+
+Tests:
+
+- Add code coverage
+- Fix rspec tests (https instead of http)
+- Achieve 100% test coverage!
+- Rewrite stub testcases, shorter and more readable
+
 1.0.0
 -----
 

data/README.md

@@ -3,6 +3,16 @@ MavenCLI
 
 Simple maven cli tool.
 
+Build Status & Coverage Report
+------------------------------
+
+[![build status]
+(https://gitlab.com/s4m-gems/maven-cli/badges/develop/build.svg)]
+(https://gitlab.com/s4m-gems/maven-cli/commits/develop)
+[![coverage report]
+(https://gitlab.com/s4m-gems/maven-cli/badges/develop/coverage.svg)]
+(https://s4m-gems.gitlab.io/maven-cli/)
+
 Installation
 ------------
 

data/lib/mavencli.rb

@@ -22,10 +22,11 @@ module MavenCLI
       require file
     end
 
-    def start
-      MavenCLI::CLI.start(ARGV)
+    def start(args = ARGV, test = false)
+      MavenCLI::CLI.start(args)
     rescue => e
-      puts e
+      $stderr.puts e
+      exit(1) unless test # Do not exit if we are in a test
     end
   end
 end

data/lib/mavencli/cli.rb

@@ -25,7 +25,8 @@ module MavenCLI
       puts "MavenCLI version #{MavenCLI::VERSION}"
     end
 
-    desc 'download GROUP ARTIFACT VERSION [options]', 'Download an artifact'
+    desc('download GROUP ARTIFACT VERSION [options]',
+         'Download an artifact from a maven repository.')
     option(
       :repository,
       aliases: ['-r'],
@@ -35,18 +36,18 @@ module MavenCLI
     option(
       :classifier,
       aliases: ['-c'],
-      desc: 'Classifier of the requested artifact.'
+      desc: 'Classifier of the requested artifact'
     )
     option(
       :packaging,
       aliases: ['-p'],
       default: 'jar',
-      desc: 'Packaging of the requested artifact.'
+      desc: 'Packaging of the requested artifact'
     )
     option(
       :output_file,
       aliases: ['-o'],
-      desc: 'Output file.'
+      desc: 'Output file'
     )
     option(
       :quiet,
@@ -62,6 +63,14 @@ module MavenCLI
       default: false,
       desc: 'Simulation mode. Do nothing'
     )
+    option(
+      :snapshot,
+      aliases: ['-n'],
+      type: :boolean,
+      default: false,
+      desc: 'Allow the download of a SNAPSHOT version. Overriden if'\
+      'version contains SNAPSHOT'
+    )
     def download(group, artifact, version)
       downloader = MavenCLI::Downloader.new(group, artifact, version, options)
       downloader.download

data/lib/mavencli/downloader.rb

@@ -23,9 +23,11 @@ module MavenCLI
   # This is a simple file downloader class.
   class Downloader
     def initialize(group, artifact, version, opts)
-      path = "#{group.tr('.', '/')}/#{artifact}/#{version}"
-      artifact_name = filename(artifact, version, opts, path)
-      @target = "#{opts['repository']}/#{path}/#{artifact_name}"
+      path = "#{group.tr('.', '/')}/#{artifact}"
+      version = latest_version(opts, path) if version.casecmp('latest').zero?
+      fullpath = "#{path}/#{version}"
+      artifact_name = filename(artifact, version, opts, fullpath)
+      @target = "#{opts['repository']}/#{fullpath}/#{artifact_name}"
       @outfile = opts['output_file'].nil? ? artifact_name : opts['output_file']
       @quiet = opts['quiet']
       @simulation = opts['simulation']
@@ -38,27 +40,35 @@ module MavenCLI
 
     private
 
+    def latest_version(opts, path)
+      xml = http_get("#{opts['repository']}/#{path}/maven-metadata.xml")
+      latest = xml_path(xml, 'versioning', 'latest')
+      release = xml_path(xml, 'versioning', 'release')
+      version = opts['snapshot'] && !latest.nil? ? latest : release
+      raise 'No valid version found, try with --snapshot?' if version.nil?
+      version
+    end
+
     def filename(artifact, version, opts, path)
-      name = "#{artifact}-#{version.split('-').first}"
-      if version.include? 'SNAPSHOT'
+      name = "#{artifact}-#{version.chomp('-SNAPSHOT')}"
+      if version.end_with?('SNAPSHOT')
         xml = http_get("#{opts['repository']}/#{path}/maven-metadata.xml")
-        name += "-#{timestamp(xml)}-#{buildnumber(xml)}"
+        name += snapshot_tag(xml)
       end
       name += "-#{opts['classifier']}" unless opts['classifier'].nil?
       name += ".#{opts['packaging']}"
       name
     end
 
-    def timestamp(xml)
-      versioning_node = XmlSimple.xml_in(xml)['versioning'].first
-      snapshot_node = versioning_node['snapshot'].first
-      snapshot_node['timestamp'].first
+    def snapshot_tag(xml)
+      node = xml_path(xml, 'versioning', 'snapshot')
+      "-#{node['timestamp'].first}-#{node['buildNumber'].first}"
     end
 
-    def buildnumber(xml)
-      versioning_node = XmlSimple.xml_in(xml)['versioning'].first
-      snapshot_node = versioning_node['snapshot'].first
-      snapshot_node['buildNumber'].first
+    def xml_path(xml, *path)
+      path.reduce(XmlSimple.xml_in(xml)) { |acc, elem| acc[elem].first }
+    rescue
+      nil
     end
 
     def http_get(url)

data/lib/mavencli/version.rb

@@ -16,5 +16,5 @@
 #
 
 module MavenCLI
-  VERSION = '1.0.0'.freeze
+  VERSION = '1.1.0'.freeze
 end

data/maven-cli.gemspec

@@ -26,7 +26,7 @@ Gem::Specification.new do |s|
   s.license = 'Apache-2.0'
 
   s.summary = 'Tool to interact with Maven repositories with CLI'
-  s.description = IO.read(File.join(File.dirname(__FILE__), 'README.md'))
+  s.description = 'Tool to interact with Maven repositories with CLI'
   s.homepage = 'https://gitlab.com/s4m-gems/maven-cli'
 
   s.files = `git ls-files`.lines.map(&:chomp)
@@ -36,11 +36,14 @@ Gem::Specification.new do |s|
   end
   s.require_paths = ['lib']
 
+  s.required_ruby_version = '>= 2.0'
+
   s.add_development_dependency 'bundler', '~> 1.12'
   s.add_development_dependency 'rspec', '~> 3.5'
   s.add_development_dependency 'rake', '~> 11.2'
   s.add_development_dependency 'rubocop', '~> 0.43'
   s.add_development_dependency 'webmock', '~> 2.1'
+  s.add_development_dependency 'simplecov', '~> 0.12'
 
   s.add_dependency 'thor', '~> 0.19'
   s.add_dependency 'faraday', '~> 0.9'

data/spec/files/{maven-metadata.xml → inside_maven-metadata.xml}

@@ -1,7 +1,7 @@
 <metadata modelVersion="1.1.0">
   <groupId>com.mygroup</groupId>
-  <artifactId>test1</artifactId>
-  <version>0.0.0-SNAPSHOT</version>
+  <artifactId>test</artifactId>
+  <version>7.0.0-SNAPSHOT</version>
   <versioning>
     <snapshot>
       <timestamp>19831018.151200</timestamp>
@@ -11,24 +11,24 @@
     <snapshotVersions>
       <snapshotVersion>
         <extension>jar</extension>
-        <value>1.0.0-19831018.151200-1</value>
+        <value>7.0.0-19831018.151200-1</value>
         <updated>19831018151200</updated>
       </snapshotVersion>
       <snapshotVersion>
         <extension>pom</extension>
-        <value>1.0.0-19831018.151200-1</value>
+        <value>7.0.0-19831018.151200-1</value>
         <updated>19831018151200</updated>
       </snapshotVersion>
       <snapshotVersion>
         <classifier>sources</classifier>
         <extension>jar</extension>
-        <value>1.0.0-19831018.151200-1</value>
+        <value>7.0.0-19831018.151200-1</value>
         <updated>19831018151200</updated>
       </snapshotVersion>
       <snapshotVersion>
         <classifier>javadoc</classifier>
         <extension>jar</extension>
-        <value>1.0.0-19831018.151200-1</value>
+        <value>7.0.0-19831018.151200-1</value>
         <updated>19831018151200</updated>
       </snapshotVersion>
     </snapshotVersions>

data/spec/files/rel_maven-metadata.xml

@@ -0,0 +1,11 @@
+<metadata modelVersion="1.1.0">
+  <groupId>com.mygroup</groupId>
+  <artifactId>test2</artifactId>
+  <versioning>
+    <release>1.0.0</release>
+    <versions>
+      <version>1.0.0</version>
+    </versions>
+    <lastUpdated>19831018151200</lastUpdated>
+  </versioning>
+</metadata>

data/spec/files/root_maven-metadata.xml

@@ -0,0 +1,19 @@
+<metadata modelVersion="1.1.0">
+  <groupId>com.mygroup</groupId>
+  <artifactId>test</artifactId>
+  <versioning>
+    <latest>7.0.0-SNAPSHOT</latest>
+    <release>7.0.0-rc1</release>
+    <versions>
+      <version>1.0.0</version>
+      <version>2.0.0</version>
+      <version>3.0.0</version>
+      <version>4.0.0</version>
+      <version>5.0.0</version>
+      <version>6.0.0</version>
+      <version>7.0.0-rc1</version>
+      <version>7.0.0-SNAPSHOT</version>
+    </versions>
+    <lastUpdated>19831018151200</lastUpdated>
+  </versioning>
+</metadata>

data/spec/files/snap_maven-metadata.xml

@@ -0,0 +1,11 @@
+<metadata modelVersion="1.1.0">
+  <groupId>com.mygroup</groupId>
+  <artifactId>test3</artifactId>
+  <versioning>
+    <latest>1.0.0-SNAPSHOT</latest>
+    <versions>
+      <version>1.0.0-SNAPSHOT</version>
+    </versions>
+    <lastUpdated>19831018151200</lastUpdated>
+  </versioning>
+</metadata>

data/spec/mavencli/cli_spec.rb

@@ -16,19 +16,6 @@
 
 require 'spec_helper'
 
-dir = File.dirname(__FILE__)
-nexus = 'https://nexus.mydomain.net/repository/maven-public'
-
-dl_test = [
-  'test-1.0.0.jar',
-  'test-2.0.0-19831018.151200-1.jar',
-  'test-3.0.0.jar',
-  'test-4.0.0.tgz',
-  'test-5.0.0_test.jar',
-  'test-6.0.0.jar',
-  'test-7.0.0.jar'
-].map { |file| File.join(dir, '..', '..', file) }
-
 describe MavenCLI::CLI do
   context 'version' do
     it 'prints the version.' do
@@ -36,45 +23,4 @@ describe MavenCLI::CLI do
       expect { start(self) }.to output(out).to_stdout
     end
   end
-
-  context 'download com/mygroup test 1.0.0 -s' do
-    it 'should simulate a download without option via CLI.' do
-      out = "#{File.basename(dl_test[0])} has been Downloaded.\n"
-      expect { start(self) }.to output(out).to_stdout
-    end
-  end
-
-  context 'download com/mygroup test 2.0.0-SNAPSHOT -s ' do
-    it 'should simulate a download a snapshot version via CLI.' do
-      out = "#{File.basename(dl_test[1])} has been Downloaded.\n"
-      expect { start(self) }.to output(out).to_stdout
-    end
-  end
-
-  context "download com/mygroup test 3.0.0 -r #{nexus} -s" do
-    it 'should simulate a download with option --repository via CLI.' do
-      out = "#{File.basename(dl_test[2])} has been Downloaded.\n"
-      expect { start(self) }.to output(out).to_stdout
-    end
-  end
-
-  context 'download com/mygroup test 4.0.0 -p tgz -s' do
-    it 'should simulate a download with option --packaging via CLI.' do
-      out = "#{File.basename(dl_test[3])} has been Downloaded.\n"
-      expect { start(self) }.to output(out).to_stdout
-    end
-  end
-
-  context "download com/mygroup test 5.0.0 -o #{dl_test[4]} -s" do
-    it 'should simulate a download with option --output-file via CLI.' do
-      out = "#{dl_test[4]} has been Downloaded.\n"
-      expect { start(self) }.to output(out).to_stdout
-    end
-  end
-
-  context 'download com/mygroup test 6.0.0 -q -s' do
-    it 'should simulate a download with option --quiet via CLI.' do
-      expect { start(self) }.to output('').to_stdout
-    end
-  end
 end

data/spec/mavencli/downloader_spec.rb

@@ -16,76 +16,121 @@
 
 require 'spec_helper'
 
-dir = File.dirname(__FILE__)
 nexus = 'https://nexus.mydomain.net/repository/maven-public'
 
-dl_test = [
-  'test-1.0.0.jar',
-  'test-2.0.0-19831018.151200-1.jar',
-  'test-3.0.0.jar',
-  'test-4.0.0.tgz',
-  'test-5.0.0_test.jar',
-  'test-6.0.0.jar',
-  'test-7.0.0.jar'
-].map { |file| File.join(dir, '..', '..', file) }
+def dl_test(file)
+  dir = File.dirname(__FILE__)
+  File.join(dir, '..', '..', file)
+end
 
 describe MavenCLI::Downloader do
   context 'download com/mygroup test 1.0.0' do
     it 'downloads without option.' do
-      out = "test-1.0.0.jar has been Downloaded.\n"
+      file = 'test-1.0.0.jar'
+      out = "#{file} has been Downloaded.\n"
       expect { start(self) }.to output(out).to_stdout
-      expect { print File.read(dl_test[0]) }.to output('OK').to_stdout
-      File.delete(dl_test[0])
+      expect { print File.read(dl_test(file)) }.to output('OK').to_stdout
+      File.delete(dl_test(file))
     end
   end
 
-  context 'download com/mygroup test 2.0.0-SNAPSHOT' do
-    it 'downloads a snapshot version.' do
-      out = "test-2.0.0-19831018.151200-1.jar has been Downloaded.\n"
+  context 'download com/mygroup test 2.0.0 -s' do
+    it 'should simulate a download.' do
+      out = "test-2.0.0.jar has been Downloaded.\n"
       expect { start(self) }.to output(out).to_stdout
-      expect { print File.read(dl_test[1]) }.to output('OK').to_stdout
-      File.delete(dl_test[1])
     end
   end
 
   context "download com/mygroup test 3.0.0 -r #{nexus}" do
     it 'downloads with option --repository.' do
-      out = "test-3.0.0.jar has been Downloaded.\n"
+      file = 'test-3.0.0.jar'
+      out = "#{file} has been Downloaded.\n"
       expect { start(self) }.to output(out).to_stdout
-      expect { print File.read(dl_test[2]) }.to output('OK').to_stdout
-      File.delete(dl_test[2])
+      expect { print File.read(dl_test(file)) }.to output('OK').to_stdout
+      File.delete(dl_test(file))
     end
   end
 
   context 'download com/mygroup test 4.0.0 -p tgz' do
     it 'downloads with option --packaging.' do
-      out = "test-4.0.0.tgz has been Downloaded.\n"
+      file = 'test-4.0.0.tgz'
+      out = "#{file} has been Downloaded.\n"
       expect { start(self) }.to output(out).to_stdout
-      expect { print File.read(dl_test[3]) }.to output('OK').to_stdout
-      File.delete(dl_test[3])
+      expect { print File.read(dl_test(file)) }.to output('OK').to_stdout
+      File.delete(dl_test(file))
     end
   end
 
-  context "download com/mygroup test 5.0.0 -o #{dl_test[4]}" do
+  context 'download com/mygroup test 5.0.0 -o test-5.0.0_test.jar' do
     it 'downloads with option --output-file.' do
-      out = "#{dl_test[4]} has been Downloaded.\n"
+      file = 'test-5.0.0_test.jar'
+      out = "#{file} has been Downloaded.\n"
       expect { start(self) }.to output(out).to_stdout
-      expect { print File.read(dl_test[4]) }.to output('OK').to_stdout
-      File.delete(dl_test[4])
+      expect { print File.read(dl_test(file)) }.to output('OK').to_stdout
+      File.delete(dl_test(file))
     end
   end
 
   context 'download com/mygroup test 6.0.0 -q' do
     it 'downloads with option --quiet.' do
+      file = 'test-6.0.0.jar'
       expect { start(self) }.to output('').to_stdout
-      File.delete(dl_test[5])
+      File.delete(dl_test(file))
     end
   end
 
   context "download com/mygroup test 7.0.0 -r #{nexus}" do
     it 'fails to download an absent artifact.' do
-      out = 'Unable to download .* Status: 404'
-      expect { start(self) }.to raise_error(RuntimeError, /#{out}/)
+      out = 'Unable to download '\
+        "#{nexus}/com/mygroup/test/7.0.0/test-7.0.0.jar: Status: 404\n"
+      expect { start(self) }.to output(out).to_stderr
+    end
+  end
+
+  context 'download com/mygroup test 7.0.0-SNAPSHOT' do
+    it 'downloads a snapshot version by appending SNAPSHOT to the version.' do
+      file = 'test-7.0.0-19831018.151200-1.jar'
+      out = "#{file} has been Downloaded.\n"
+      expect { start(self) }.to output(out).to_stdout
+      expect { print File.read(dl_test(file)) }.to output('OK').to_stdout
+      File.delete(dl_test(file))
+    end
+  end
+
+  context 'download com/mygroup test latest' do
+    it 'downloads latest released (actually rc1) version.' do
+      file = 'test-7.0.0-rc1.jar'
+      out = "#{file} has been Downloaded.\n"
+      expect { start(self) }.to output(out).to_stdout
+      expect { print File.read(dl_test(file)) }.to output('OK').to_stdout
+      File.delete(dl_test(file))
+    end
+  end
+
+  context 'download com/mygroup test latest -n' do
+    it 'downloads latest snapshot version.' do
+      file = 'test-7.0.0-19831018.151200-1.jar'
+      out = "#{file} has been Downloaded.\n"
+      expect { start(self) }.to output(out).to_stdout
+      expect { print File.read(dl_test(file)) }.to output('OK').to_stdout
+      File.delete(dl_test(file))
+    end
+  end
+
+  context 'download com/mygroup test2 latest -n' do
+    it 'downloads latest released version because no snapshot exists.' do
+      file = 'test2-1.0.0.jar'
+      out = "#{file} has been Downloaded.\n"
+      expect { start(self) }.to output(out).to_stdout
+      expect { print File.read(dl_test(file)) }.to output('OK').to_stdout
+      File.delete(dl_test(file))
+    end
+  end
+
+  context 'download com/mygroup test3 latest' do
+    it 'fails to download anything because no release exists.' do
+      out = "No valid version found, try with --snapshot?\n"
+      expect { start(self) }.to output(out).to_stderr
     end
   end
 end

data/spec/mavencli/stubs/servers_stubs.rb

@@ -16,49 +16,56 @@
 
 require 'spec_helper'
 
-dir = File.dirname(__FILE__)
 meta_file = 'maven-metadata.xml'
-xml_content = File.read(File.join(dir, '..', '..', 'files', meta_file))
-maven = 'http://repo.maven.apache.org/maven2'
+
+def read_xml(name)
+  meta_file = 'maven-metadata.xml'
+  dir = File.dirname(__FILE__)
+  File.read(File.join(dir, '..', '..', 'files', "#{name}_#{meta_file}"))
+end
+
+maven = 'https://repo.maven.apache.org/maven2'
 nexus = 'https://nexus.mydomain.net/repository/maven-public'
-artifact = 'test'
+
 tests = {
-  artifact => [
-    [200, maven, 'com/mygroup', '1.0.0', 'jar'],
-    [
-      200,
-      maven,
-      'com/mygroup',
-      '2.0.0-SNAPSHOT',
-      'jar',
-      '19831018.151200',
-      '1'
-    ],
-    [200, nexus, 'com/mygroup', '3.0.0', 'jar'],
-    [200, maven, 'com/mygroup', '4.0.0', 'tgz'],
-    [200, maven, 'com/mygroup', '5.0.0', 'jar'],
-    [200, maven, 'com/mygroup', '6.0.0', 'jar'],
-    [404, nexus, 'com/mygroup', '7.0.0', 'jar']
+  [maven, 'com/mygroup', 'test', 'root'] => [
+    [200, '1.0.0', 'jar'],
+    [200, '4.0.0', 'tgz'],
+    [200, '5.0.0', 'jar'],
+    [200, '6.0.0', 'jar'],
+    [200, '7.0.0-rc1', 'jar'],
+    [200, '7.0.0-SNAPSHOT', 'jar', '-19831018.151200-1']
+  ],
+  [nexus, 'com/mygroup', 'test', 'root'] => [
+    [200, '3.0.0', 'jar'],
+    [404, '7.0.0', 'jar']
+  ],
+  [maven, 'com/mygroup', 'test2', 'rel'] => [
+    [200, '1.0.0', 'jar']
+  ],
+  [maven, 'com/mygroup', 'test3', 'snap'] => [
+    [200, '1.0.0-SNAPSHOT', 'jar', '-19831018.151200-1']
   ]
 }
 
 RSpec.configure do |config|
   config.before(:each) do
-    tests[artifact].each do |array|
-      vernum = array[3].split('-').first
-      file = "#{artifact}-#{vernum}"
-      file += "-#{array[5]}" unless array[5].nil?
-      file += "-#{array[6]}" unless array[6].nil?
-      file += ".#{array[4]}"
-      xml = "#{array[1]}/#{array[2]}/#{artifact}/#{array[3]}/#{meta_file}"
-      test = "#{array[1]}/#{array[2]}/#{artifact}/#{array[3]}/#{file}"
+    tests.each do |key, arrays|
+      repo, group, artifact, root_xml = key
+      stub_request(:get, "#{repo}/#{group}/#{artifact}/#{meta_file}")
+        .to_return(status: 200, body: read_xml(root_xml), headers: {})
+
+      arrays.each do |code, version, type, tag|
+        path = "#{repo}/#{group}/#{artifact}/#{version}"
 
-      xml_status = array[3].include?('SNAPSHOT') ? array[0] : 404
-      stub_request(:get, xml)
-        .to_return(status: xml_status, body: xml_content, headers: {})
+        xml_status = version.end_with?('SNAPSHOT') ? code : 404
+        stub_request(:get, "#{path}/#{meta_file}")
+          .to_return(status: xml_status, body: read_xml('inside'), headers: {})
 
-      stub_request(:get, test)
-        .to_return(status: array[0], body: 'OK', headers: {})
+        file = "#{artifact}-#{version.chomp('-SNAPSHOT')}#{tag}.#{type}"
+        stub_request(:get, "#{path}/#{file}")
+          .to_return(status: code, body: 'OK', headers: {})
+      end
     end
   end
 end

data/spec/spec_helper.rb

@@ -13,6 +13,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
+require 'simplecov'
+SimpleCov.start
 
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 require 'mavencli'
@@ -41,5 +43,5 @@ Dir[files].each { |file| require file }
 def start(caller_object, subcommand = nil)
   cmd = caller_object.class.description.split(' ')
   args = [subcommand, *cmd].compact
-  MavenCLI::CLI.start(args)
+  MavenCLI.start(args, true)
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: maven-cli
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Samuel Bernard
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-11 00:00:00.000000000 Z
+date: 2017-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -81,6 +81,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.1'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.12'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.12'
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
@@ -123,71 +137,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
-description: |
-  MavenCLI
-  ========
-
-  Simple maven cli tool.
-
-  Installation
-  ------------
-
-  Install as a gem:
-
-      $ gem install maven-cli
-
-  Usage
-  -----
-
-  You can have an interactive help using:
-
-      $ maven-cli help
-
-  Examples
-  --------
-
-  To download a jar from maven repository (http://repo.maven.apache.org/maven2)
-
-      $ maven-cli download <group> <artifact> <version>
-
-  For instance: `maven-cli download com.google.guava guava 19.0`
-
-  To download a jar from a non standard repository
-
-      $ maven-cli download <group> <artifact> <version> -r <repository>
-
-  To download a jar from maven repository and save it to file
-
-      $ maven-cli download <group> <artifact> <version> -o <outfile>
-
-  Contributing
-  ------------
-
-  Please read carefully [CONTRIBUTING.md](CONTRIBUTING.md) before making a merge
-  request.
-
-  License and Author
-  ------------------
-
-  - Author:: DPS Team (<dps.team@s4m.io>)
-  - Author:: Samuel Bernard (<samuel.bernard@s4m.io>)
-  - Author:: Richard Delaplace (<richard.delaplace@s4m.io>)
-
-  ```text
-  Copyright (c) 2016 Sam4Mobile
-
-  Licensed under the Apache License, Version 2.0 (the "License");
-  you may not use this file except in compliance with the License.
-  You may obtain a copy of the License at
-
-      http://www.apache.org/licenses/LICENSE-2.0
-
-  Unless required by applicable law or agreed to in writing, software
-  distributed under the License is distributed on an "AS IS" BASIS,
-  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  See the License for the specific language governing permissions and
-  limitations under the License.
-  ```
+description: Tool to interact with Maven repositories with CLI
 email: dps.team@s4m.io
 executables:
 - maven-cli
@@ -209,7 +159,10 @@ files:
 - lib/mavencli/downloader.rb
 - lib/mavencli/version.rb
 - maven-cli.gemspec
-- spec/files/maven-metadata.xml
+- spec/files/inside_maven-metadata.xml
+- spec/files/rel_maven-metadata.xml
+- spec/files/root_maven-metadata.xml
+- spec/files/snap_maven-metadata.xml
 - spec/mavencli/cli_spec.rb
 - spec/mavencli/downloader_spec.rb
 - spec/mavencli/stubs/servers_stubs.rb
@@ -227,7 +180,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -235,7 +188,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Tool to interact with Maven repositories with CLI