mattetti-couchrest 0.17 → 0.20

data/lib/couchrest.rb

@@ -22,12 +22,13 @@ $:.unshift File.dirname(__FILE__) unless
   $:.include?(File.dirname(__FILE__)) ||
   $:.include?(File.expand_path(File.dirname(__FILE__)))
   
+$COUCHREST_DEBUG ||= false
   
 require 'couchrest/monkeypatches'
 
 # = CouchDB, close to the metal
 module CouchRest
-  VERSION = '0.17' unless self.const_defined?("VERSION")
+  VERSION    = '0.20' unless self.const_defined?("VERSION")
   
   autoload :Server,       'couchrest/core/server'
   autoload :Database,     'couchrest/core/database'
@@ -129,7 +130,11 @@ module CouchRest
       begin
         JSON.parse(RestClient.put(uri, payload))
       rescue Exception => e
-        raise "Error while sending a PUT request #{uri}\npayload: #{payload.inspect}\n#{e}"
+        if $COUCHREST_DEBUG == true
+          raise "Error while sending a PUT request #{uri}\npayload: #{payload.inspect}\n#{e}"
+        else
+          raise e
+        end
       end
     end
 
@@ -137,7 +142,11 @@ module CouchRest
       begin
         JSON.parse(RestClient.get(uri), :max_nesting => false)
       rescue => e
-        raise "Error while sending a GET request #{uri}\n: #{e}"
+        if $COUCHREST_DEBUG == true
+          raise "Error while sending a GET request #{uri}\n: #{e}"
+        else
+          raise e
+        end
       end
     end
   
@@ -146,7 +155,11 @@ module CouchRest
       begin
         JSON.parse(RestClient.post(uri, payload))
       rescue Exception => e
-        raise "Error while sending a POST request #{uri}\npayload: #{payload.inspect}\n#{e}"
+        if $COUCHREST_DEBUG == true
+          raise "Error while sending a POST request #{uri}\npayload: #{payload.inspect}\n#{e}"
+        else
+          raise e
+        end
       end
     end
   

data/lib/couchrest/core/database.rb

@@ -20,7 +20,7 @@ module CouchRest
       @uri = @root = "#{host}/#{name}"
       @streamer = Streamer.new(self)
       @bulk_save_cache = []
-      @bulk_save_cache_limit = 50
+      @bulk_save_cache_limit = 500  # must be smaller than the uuid count
     end
     
     # returns the database's uri

data/lib/couchrest/mixins/callbacks.rb

@@ -1,6 +1,7 @@
 require File.join(File.dirname(__FILE__), '..', 'support', 'class')
 
 # Extracted from ActiveSupport::Callbacks written by Yehuda Katz
+# http://github.com/wycats/rails/raw/abstract_controller/activesupport/lib/active_support/new_callbacks.rb
 # http://github.com/wycats/rails/raw/18b405f154868204a8f332888871041a7bad95e1/activesupport/lib/active_support/callbacks.rb
 
 module CouchRest
@@ -11,7 +12,7 @@ module CouchRest
   #
   # Example:
   #   class Storage
-  #     include CouchRest::Callbacks
+  #     include ActiveSupport::Callbacks
   #
   #     define_callbacks :save
   #   end
@@ -45,7 +46,7 @@ module CouchRest
   #
   # Example:
   #   class Storage
-  #     include CouchRest::Callbacks
+  #     include ActiveSupport::Callbacks
   #
   #     define_callbacks :save
   #
@@ -85,8 +86,8 @@ module CouchRest
       klass.extend ClassMethods
     end
         
-    def run_callbacks(kind, options = {})
-      send("_run_#{kind}_callbacks")
+    def run_callbacks(kind, options = {}, &blk)
+      send("_run_#{kind}_callbacks", &blk)
     end
     
     class Callback
@@ -166,9 +167,13 @@ module CouchRest
       
       # This will supply contents for before and around filters, and no
       # contents for after filters (for the forward pass).
-      def start(key = nil, object = nil)
+      def start(key = nil, options = {})
+        object, terminator = (options || {}).values_at(:object, :terminator)
+        
         return if key && !object.send("_one_time_conditions_valid_#{@callback_id}?")
         
+        terminator ||= false
+        
         # options[0] is the compiled form of supplied conditions
         # options[1] is the "end" for the conditional
                 
@@ -177,8 +182,14 @@ module CouchRest
             # if condition    # before_save :filter_name, :if => :condition
             #   filter_name
             # end
-            [@compiled_options[0], @filter, @compiled_options[1]].compact.join("\n")
-          elsif @compiled_options[0]
+            filter = <<-RUBY_EVAL
+              unless halted
+                result = #{@filter}
+                halted ||= (#{terminator})
+              end
+            RUBY_EVAL
+            [@compiled_options[0], filter, @compiled_options[1]].compact.join("\n")
+          else
             # Compile around filters with conditions into proxy methods
             # that contain the conditions.
             #
@@ -196,8 +207,8 @@ module CouchRest
             
             name = "_conditional_callback_#{@kind}_#{next_id}"
             txt = <<-RUBY_EVAL
-              def #{name}
-                #{@compiled_options[0]}
+              def #{name}(halted)
+                #{@compiled_options[0] || "if true"} && !halted
                   #{@filter} do
                     yield self
                   end
@@ -207,16 +218,16 @@ module CouchRest
               end
             RUBY_EVAL
             @klass.class_eval(txt)
-            "#{name} do"
-          else
-            "#{@filter} do"
+            "#{name}(halted) do"
           end
         end
       end
       
       # This will supply contents for around and after filters, but not
       # before filters (for the backward pass).
-      def end(key = nil, object = nil)
+      def end(key = nil, options = {})
+        object = (options || {})[:object]
+        
         return if key && !object.send("_one_time_conditions_valid_#{@callback_id}?")
         
         if @kind == :around || @kind == :after
@@ -299,7 +310,7 @@ module CouchRest
     # This method_missing is supplied to catch callbacks with keys and create
     # the appropriate callback for future use.
     def method_missing(meth, *args, &blk)
-      if meth.to_s =~ /_run_(\w+)_(\w+)_(\w+)_callbacks/
+      if meth.to_s =~ /_run__([\w:]+)__(\w+)__(\w+)__callbacks/
         return self.class._create_and_run_keyed_callback($1, $2.to_sym, $3.to_sym, self, &blk)
       end
       super
@@ -307,20 +318,26 @@ module CouchRest
     
     # An Array with a compile method
     class CallbackChain < Array
-      def compile(key = nil, object = nil)
+      def initialize(symbol)
+        @symbol = symbol
+      end
+      
+      def compile(key = nil, options = {})
         method = []
+        method << "halted = false"
         each do |callback|
-          method << callback.start(key, object)
+          method << callback.start(key, options)
         end
-        method << "yield self"
+        method << "yield self if block_given?"
         reverse_each do |callback|
-          method << callback.end(key, object)
+          method << callback.end(key, options)
         end
         method.compact.join("\n")
       end
       
       def clone(klass)
-        CallbackChain.new(map {|c| c.clone(klass)})
+        chain = CallbackChain.new(@symbol)
+        chain.push(*map {|c| c.clone(klass)})
       end
     end
         
@@ -338,16 +355,18 @@ module CouchRest
       # The _run_save_callbacks method can optionally take a key, which
       # will be used to compile an optimized callback method for each
       # key. See #define_callbacks for more information.
-      def _define_runner(symbol, str, options)
-        self.class_eval <<-RUBY_EVAL, __FILE__, __LINE__ + 1
+      def _define_runner(symbol, str, options)        
+        str = <<-RUBY_EVAL
           def _run_#{symbol}_callbacks(key = nil)
             if key
-              send("_run_\#{self.class}_#{symbol}_\#{key}_callbacks") { yield }
+              send("_run__\#{self.class.name.split("::").last}__#{symbol}__\#{key}__callbacks") { yield if block_given? }
             else
               #{str}
             end
           end
         RUBY_EVAL
+  
+        class_eval str, __FILE__, __LINE__ + 1
         
         before_name, around_name, after_name = 
           options.values_at(:before, :after, :around)
@@ -359,15 +378,18 @@ module CouchRest
       def _create_and_run_keyed_callback(klass, kind, key, obj, &blk)
         @_keyed_callbacks ||= {}
         @_keyed_callbacks[[kind, key]] ||= begin
-          str = self.send("_#{kind}_callbacks").compile(key, obj)
+          str = self.send("_#{kind}_callbacks").compile(key, :object => obj, :terminator => self.send("_#{kind}_terminator"))
+
           self.class_eval <<-RUBY_EVAL, __FILE__, __LINE__ + 1
-            def _run_#{klass}_#{kind}_#{key}_callbacks
+            def _run__#{klass.split("::").last}__#{kind}__#{key}__callbacks
               #{str}
             end
           RUBY_EVAL
+                    
           true
         end
-        obj.send("_run_#{klass}_#{kind}_#{key}_callbacks", &blk)
+                                  
+        obj.send("_run__#{klass.split("::").last}__#{kind}__#{key}__callbacks", &blk)
       end
       
       # Define callbacks.
@@ -402,20 +424,32 @@ module CouchRest
       # method that took into consideration the per_key conditions. This
       # is a speed improvement for ActionPack.
       def define_callbacks(*symbols)
+        terminator = symbols.pop if symbols.last.is_a?(String)
         symbols.each do |symbol|
+          self.class_inheritable_accessor("_#{symbol}_terminator")
+          self.send("_#{symbol}_terminator=", terminator)
           self.class_eval <<-RUBY_EVAL, __FILE__, __LINE__ + 1
             class_inheritable_accessor :_#{symbol}_callbacks
-            self._#{symbol}_callbacks = CallbackChain.new
+            self._#{symbol}_callbacks = CallbackChain.new(:#{symbol})
 
-            def self.#{symbol}_callback(type, *filters, &blk)
+            def self.#{symbol}_callback(*filters, &blk)
+              type = [:before, :after, :around].include?(filters.first) ? filters.shift : :before
               options = filters.last.is_a?(Hash) ? filters.pop : {}
               filters.unshift(blk) if block_given?
-              filters.map! {|f| Callback.new(f, type, options.dup, self, :#{symbol})}
+              
+              filters.map! do |filter| 
+                # overrides parent class
+                self._#{symbol}_callbacks.delete_if {|c| c.matches?(type, :#{symbol}, filter)}
+                Callback.new(filter, type, options.dup, self, :#{symbol})
+              end
               self._#{symbol}_callbacks.push(*filters)
-              _define_runner(:#{symbol}, self._#{symbol}_callbacks.compile, options)
+              _define_runner(:#{symbol}, 
+                self._#{symbol}_callbacks.compile(nil, :terminator => _#{symbol}_terminator), 
+                options)
             end
             
-            def self.skip_#{symbol}_callback(type, *filters, &blk)
+            def self.skip_#{symbol}_callback(*filters, &blk)
+              type = [:before, :after, :around].include?(filters.first) ? filters.shift : :before
               options = filters.last.is_a?(Hash) ? filters.pop : {}
               filters.unshift(blk) if block_given?
               filters.each do |filter|
@@ -428,15 +462,22 @@ module CouchRest
                 else
                   self._#{symbol}_callbacks.delete(filter)
                 end
-                _define_runner(:#{symbol}, self._#{symbol}_callbacks.compile, options)
+                _define_runner(:#{symbol}, 
+                  self._#{symbol}_callbacks.compile(nil, :terminator => _#{symbol}_terminator), 
+                  options)
               end
               
             end
             
+            def self.reset_#{symbol}_callbacks
+              self._#{symbol}_callbacks = CallbackChain.new(:#{symbol})
+              _define_runner(:#{symbol}, self._#{symbol}_callbacks.compile, {})
+            end
+            
             self.#{symbol}_callback(:before)
           RUBY_EVAL
         end
       end
     end
   end
-end
+end

data/lib/couchrest/mixins/design_doc.rb

@@ -16,6 +16,7 @@ module CouchRest
         def design_doc_slug
           return design_doc_slug_cache if (design_doc_slug_cache && design_doc_fresh)
           funcs = []
+          design_doc ||= Design.new(default_design_doc)
           design_doc['views'].each do |name, view|
             funcs << "#{name}/#{view['map']}#{view['reduce']}"
           end

data/lib/couchrest/mixins/views.rb

@@ -129,13 +129,11 @@ module CouchRest
         private
 
         def fetch_view_with_docs(name, opts, raw=false, &block)
-          if raw
+          if raw || (opts.has_key?(:include_docs) && opts[:include_docs] == false)
             fetch_view(name, opts, &block)
           else
             begin
-              # auto load mentioned documents unless asked differently
-              opts.merge({:include_docs => true}) unless opts.has_key?(:include_docs)
-              view = fetch_view name, opts, &block
+              view = fetch_view name, opts.merge({:include_docs => true}), &block
               view['rows'].collect{|r|new(r['doc'])} if view['rows']
             rescue
               # fallback for old versions of couchdb that don't 

data/lib/couchrest/monkeypatches.rb

@@ -31,13 +31,19 @@ if RUBY_VERSION.to_f < 1.9
   class Net::BufferedIO #:nodoc:
     alias :old_rbuf_fill :rbuf_fill
     def rbuf_fill
-      begin
-        @rbuf << @io.read_nonblock(65536)
-      rescue Errno::EWOULDBLOCK
-        if IO.select([@io], nil, nil, @read_timeout)
+      if @io.respond_to?(:read_nonblock)
+        begin
           @rbuf << @io.read_nonblock(65536)
-        else
-          raise Timeout::TimeoutError
+        rescue Errno::EWOULDBLOCK
+          if IO.select([@io], nil, nil, @read_timeout)
+            retry
+          else
+            raise Timeout::TimeoutError
+          end
+        end
+      else
+        timeout(@read_timeout) do
+          @rbuf << @io.sysread(65536)
         end
       end
     end

data/lib/couchrest/support/class.rb

@@ -25,151 +25,167 @@
 # example, an array without those additions being shared with either their
 # parent, siblings, or children, which is unlike the regular class-level
 # attributes that are shared across the entire hierarchy.
-class Class
-  # Defines class-level and instance-level attribute reader.
-  #
-  # @param *syms<Array> Array of attributes to define reader for.
-  # @return <Array[#to_s]> List of attributes that were made into cattr_readers
-  #
-  # @api public
-  #
-  # @todo Is this inconsistent in that it does not allow you to prevent
-  # an instance_reader via :instance_reader => false
-  def cattr_reader(*syms)
-    syms.flatten.each do |sym|
-      next if sym.is_a?(Hash)
-      class_eval(<<-RUBY, __FILE__, __LINE__ + 1)
-unless defined? @@#{sym}
-@@#{sym} = nil
-end
+module CouchRest
+  module ClassExtension
+    def self.included(base)
+      if CouchRest::ClassExtension::InstanceMethods.instance_methods.all? {|m| base.respond_to?(m)}
+        # do nothing
+      elsif CouchRest::ClassExtension::InstanceMethods.instance_methods.any? {|m| base.respond_to?(m)}
+        raise RuntimeError, "Conflicting extentions to Class, work it out"
+      else
+        base.send(:include, CouchRest::ClassExtension::InstanceMethods)
+      end
+    end
+    
+    module InstanceMethods
+      # Defines class-level and instance-level attribute reader.
+      #
+      # @param *syms<Array> Array of attributes to define reader for.
+      # @return <Array[#to_s]> List of attributes that were made into cattr_readers
+      #
+      # @api public
+      #
+      # @todo Is this inconsistent in that it does not allow you to prevent
+      # an instance_reader via :instance_reader => false
+      def cattr_reader(*syms)
+        syms.flatten.each do |sym|
+          next if sym.is_a?(Hash)
+          class_eval(<<-RUBY, __FILE__, __LINE__ + 1)
+    unless defined? @@#{sym}
+    @@#{sym} = nil
+    end
  
-def self.#{sym}
-@@#{sym}
-end
+    def self.#{sym}
+    @@#{sym}
+    end
  
-def #{sym}
-@@#{sym}
-end
-RUBY
+    def #{sym}
+    @@#{sym}
     end
-  end
+    RUBY
+        end
+      end
  
-  # Defines class-level (and optionally instance-level) attribute writer.
-  #
-  # @param <Array[*#to_s, Hash{:instance_writer => Boolean}]> Array of attributes to define writer for.
-  # @option syms :instance_writer<Boolean> if true, instance-level attribute writer is defined.
-  # @return <Array[#to_s]> List of attributes that were made into cattr_writers
-  #
-  # @api public
-  def cattr_writer(*syms)
-    options = syms.last.is_a?(Hash) ? syms.pop : {}
-    syms.flatten.each do |sym|
-      class_eval(<<-RUBY, __FILE__, __LINE__ + 1)
-unless defined? @@#{sym}
-@@#{sym} = nil
-end
+      # Defines class-level (and optionally instance-level) attribute writer.
+      #
+      # @param <Array[*#to_s, Hash{:instance_writer => Boolean}]> Array of attributes to define writer for.
+      # @option syms :instance_writer<Boolean> if true, instance-level attribute writer is defined.
+      # @return <Array[#to_s]> List of attributes that were made into cattr_writers
+      #
+      # @api public
+      def cattr_writer(*syms)
+        options = syms.last.is_a?(Hash) ? syms.pop : {}
+        syms.flatten.each do |sym|
+          class_eval(<<-RUBY, __FILE__, __LINE__ + 1)
+    unless defined? @@#{sym}
+    @@#{sym} = nil
+    end
  
-def self.#{sym}=(obj)
-@@#{sym} = obj
-end
-RUBY
+    def self.#{sym}=(obj)
+    @@#{sym} = obj
+    end
+    RUBY
  
-      unless options[:instance_writer] == false
-        class_eval(<<-RUBY, __FILE__, __LINE__ + 1)
-def #{sym}=(obj)
-@@#{sym} = obj
-end
-RUBY
-      end
+          unless options[:instance_writer] == false
+            class_eval(<<-RUBY, __FILE__, __LINE__ + 1)
+    def #{sym}=(obj)
+    @@#{sym} = obj
     end
-  end
+    RUBY
+          end
+        end
+      end
  
-  # Defines class-level (and optionally instance-level) attribute accessor.
-  #
-  # @param *syms<Array[*#to_s, Hash{:instance_writer => Boolean}]> Array of attributes to define accessor for.
-  # @option syms :instance_writer<Boolean> if true, instance-level attribute writer is defined.
-  # @return <Array[#to_s]> List of attributes that were made into accessors
-  #
-  # @api public
-  def cattr_accessor(*syms)
-    cattr_reader(*syms)
-    cattr_writer(*syms)
-  end
+      # Defines class-level (and optionally instance-level) attribute accessor.
+      #
+      # @param *syms<Array[*#to_s, Hash{:instance_writer => Boolean}]> Array of attributes to define accessor for.
+      # @option syms :instance_writer<Boolean> if true, instance-level attribute writer is defined.
+      # @return <Array[#to_s]> List of attributes that were made into accessors
+      #
+      # @api public
+      def cattr_accessor(*syms)
+        cattr_reader(*syms)
+        cattr_writer(*syms)
+      end
  
-  # Defines class-level inheritable attribute reader. Attributes are available to subclasses,
-  # each subclass has a copy of parent's attribute.
-  #
-  # @param *syms<Array[#to_s]> Array of attributes to define inheritable reader for.
-  # @return <Array[#to_s]> Array of attributes converted into inheritable_readers.
-  #
-  # @api public
-  #
-  # @todo Do we want to block instance_reader via :instance_reader => false
-  # @todo It would be preferable that we do something with a Hash passed in
-  # (error out or do the same as other methods above) instead of silently
-  # moving on). In particular, this makes the return value of this function
-  # less useful.
-  def class_inheritable_reader(*ivars)
-    instance_reader = ivars.pop[:reader] if ivars.last.is_a?(Hash)
+      # Defines class-level inheritable attribute reader. Attributes are available to subclasses,
+      # each subclass has a copy of parent's attribute.
+      #
+      # @param *syms<Array[#to_s]> Array of attributes to define inheritable reader for.
+      # @return <Array[#to_s]> Array of attributes converted into inheritable_readers.
+      #
+      # @api public
+      #
+      # @todo Do we want to block instance_reader via :instance_reader => false
+      # @todo It would be preferable that we do something with a Hash passed in
+      # (error out or do the same as other methods above) instead of silently
+      # moving on). In particular, this makes the return value of this function
+      # less useful.
+      def class_inheritable_reader(*ivars)
+        instance_reader = ivars.pop[:reader] if ivars.last.is_a?(Hash)
  
-    ivars.each do |ivar|
-      self.class_eval <<-RUBY, __FILE__, __LINE__ + 1
-def self.#{ivar}
-return @#{ivar} if self.object_id == #{self.object_id} || defined?(@#{ivar})
-ivar = superclass.#{ivar}
-return nil if ivar.nil? && !#{self}.instance_variable_defined?("@#{ivar}")
-@#{ivar} = ivar && !ivar.is_a?(Module) && !ivar.is_a?(Numeric) && !ivar.is_a?(TrueClass) && !ivar.is_a?(FalseClass) && !ivar.is_a?(Symbol) ? ivar.dup : ivar
-end
-RUBY
-      unless instance_reader == false
-        self.class_eval <<-RUBY, __FILE__, __LINE__ + 1
-def #{ivar}
-self.class.#{ivar}
-end
-RUBY
+        ivars.each do |ivar|
+          self.class_eval <<-RUBY, __FILE__, __LINE__ + 1
+    def self.#{ivar}
+    return @#{ivar} if self.object_id == #{self.object_id} || defined?(@#{ivar})
+    ivar = superclass.#{ivar}
+    return nil if ivar.nil? && !#{self}.instance_variable_defined?("@#{ivar}")
+    @#{ivar} = ivar && !ivar.is_a?(Module) && !ivar.is_a?(Numeric) && !ivar.is_a?(TrueClass) && !ivar.is_a?(FalseClass) && !ivar.is_a?(Symbol) ? ivar.dup : ivar
+    end
+    RUBY
+          unless instance_reader == false
+            self.class_eval <<-RUBY, __FILE__, __LINE__ + 1
+    def #{ivar}
+    self.class.#{ivar}
+    end
+    RUBY
+          end
+        end
       end
+ 
+      # Defines class-level inheritable attribute writer. Attributes are available to subclasses,
+      # each subclass has a copy of parent's attribute.
+      #
+      # @param *syms<Array[*#to_s, Hash{:instance_writer => Boolean}]> Array of attributes to
+      # define inheritable writer for.
+      # @option syms :instance_writer<Boolean> if true, instance-level inheritable attribute writer is defined.
+      # @return <Array[#to_s]> An Array of the attributes that were made into inheritable writers.
+      #
+      # @api public
+      #
+      # @todo We need a style for class_eval <<-HEREDOC. I'd like to make it
+      # class_eval(<<-RUBY, __FILE__, __LINE__), but we should codify it somewhere.
+      def class_inheritable_writer(*ivars)
+        instance_writer = ivars.pop[:instance_writer] if ivars.last.is_a?(Hash)
+        ivars.each do |ivar|
+          self.class_eval <<-RUBY, __FILE__, __LINE__ + 1
+    def self.#{ivar}=(obj)
+    @#{ivar} = obj
     end
-  end
+    RUBY
+          unless instance_writer == false
+            self.class_eval <<-RUBY, __FILE__, __LINE__ + 1
+    def #{ivar}=(obj) self.class.#{ivar} = obj end
+    RUBY
+          end
+        end
+      end
  
-  # Defines class-level inheritable attribute writer. Attributes are available to subclasses,
-  # each subclass has a copy of parent's attribute.
-  #
-  # @param *syms<Array[*#to_s, Hash{:instance_writer => Boolean}]> Array of attributes to
-  # define inheritable writer for.
-  # @option syms :instance_writer<Boolean> if true, instance-level inheritable attribute writer is defined.
-  # @return <Array[#to_s]> An Array of the attributes that were made into inheritable writers.
-  #
-  # @api public
-  #
-  # @todo We need a style for class_eval <<-HEREDOC. I'd like to make it
-  # class_eval(<<-RUBY, __FILE__, __LINE__), but we should codify it somewhere.
-  def class_inheritable_writer(*ivars)
-    instance_writer = ivars.pop[:instance_writer] if ivars.last.is_a?(Hash)
-    ivars.each do |ivar|
-      self.class_eval <<-RUBY, __FILE__, __LINE__ + 1
-def self.#{ivar}=(obj)
-@#{ivar} = obj
-end
-RUBY
-      unless instance_writer == false
-        self.class_eval <<-RUBY, __FILE__, __LINE__ + 1
-def #{ivar}=(obj) self.class.#{ivar} = obj end
-RUBY
+      # Defines class-level inheritable attribute accessor. Attributes are available to subclasses,
+      # each subclass has a copy of parent's attribute.
+      #
+      # @param *syms<Array[*#to_s, Hash{:instance_writer => Boolean}]> Array of attributes to
+      # define inheritable accessor for.
+      # @option syms :instance_writer<Boolean> if true, instance-level inheritable attribute writer is defined.
+      # @return <Array[#to_s]> An Array of attributes turned into inheritable accessors.
+      #
+      # @api public
+      def class_inheritable_accessor(*syms)
+        class_inheritable_reader(*syms)
+        class_inheritable_writer(*syms)
       end
     end
   end
- 
-  # Defines class-level inheritable attribute accessor. Attributes are available to subclasses,
-  # each subclass has a copy of parent's attribute.
-  #
-  # @param *syms<Array[*#to_s, Hash{:instance_writer => Boolean}]> Array of attributes to
-  # define inheritable accessor for.
-  # @option syms :instance_writer<Boolean> if true, instance-level inheritable attribute writer is defined.
-  # @return <Array[#to_s]> An Array of attributes turned into inheritable accessors.
-  #
-  # @api public
-  def class_inheritable_accessor(*syms)
-    class_inheritable_reader(*syms)
-    class_inheritable_writer(*syms)
-  end
-end
+end
+
+Class.send(:include, CouchRest::ClassExtension)

data/spec/couchrest/core/database_spec.rb

@@ -312,8 +312,9 @@ describe CouchRest::Database do
         }
       }
       @db.save_doc(doc)
+      doc['_rev'].should_not be_nil
       doc['field'] << 'another value'
-      @db.save_doc(doc).should be_true
+      @db.save_doc(doc)["ok"].should be_true
     end
     
     it 'should be there' do

data/spec/couchrest/more/extended_doc_view_spec.rb

@@ -105,6 +105,9 @@ describe "ExtendedDocument views" do
 
   describe "a model with a compound key view" do
     before(:all) do
+      Article.design_doc_fresh = false
+      Article.by_user_id_and_date.each{|a| a.destroy(true)}
+      Article.database.bulk_delete
       written_at = Time.now - 24 * 3600 * 7
       @titles = ["uniq one", "even more interesting", "less fun", "not junk"]
       @user_ids = ["quentin", "aaron"]
@@ -164,24 +167,24 @@ describe "ExtendedDocument views" do
   # TODO: moved to Design, delete
   describe "adding a view" do
     before(:each) do
+      reset_test_db!
       Article.by_date
-      @design_docs = Article.database.documents :startkey => "_design/", 
-        :endkey => "_design/\u9999"
+      @design_docs = Article.database.documents :startkey => "_design/", :endkey => "_design/\u9999"
     end
     it "should not create a design doc on view definition" do
       Article.view_by :created_at
-      newdocs = Article.database.documents :startkey => "_design/", 
-        :endkey => "_design/\u9999"
+      newdocs = Article.database.documents :startkey => "_design/", :endkey => "_design/\u9999"
       newdocs["rows"].length.should == @design_docs["rows"].length
     end
-    it "should create a new design document on view access" do
+    it "should create a new version of the design document on view access" do
+      old_design_doc = Article.database.documents(:key => @design_docs["rows"].first["key"], :include_docs => true)["rows"][0]["doc"]
       Article.view_by :updated_at
       Article.by_updated_at
-      newdocs = Article.database.documents :startkey => "_design/", 
-        :endkey => "_design/\u9999"
-      # puts @design_docs.inspect
-      # puts newdocs.inspect
-      newdocs["rows"].length.should == @design_docs["rows"].length + 1
+      newdocs = Article.database.documents({:startkey => "_design/", :endkey => "_design/\u9999"})
+
+      doc = Article.database.documents(:key => @design_docs["rows"].first["key"], :include_docs => true)["rows"][0]["doc"]
+      doc["_rev"].should_not        == old_design_doc["_rev"]
+      doc["views"].keys.should include("by_updated_at")
     end
   end
 
@@ -192,10 +195,9 @@ describe "ExtendedDocument views" do
       Article.by_field
     end
     it "should clean them up" do
+      ddocs = Article.all_design_doc_versions
       Article.view_by :stream
       Article.by_stream
-      ddocs = Article.all_design_doc_versions
-      ddocs["rows"].length.should > 1
       Article.cleanup_design_docs!
       ddocs = Article.all_design_doc_versions
       ddocs["rows"].length.should == 1

data/spec/couchrest/support/class_spec.rb

@@ -0,0 +1,59 @@
+require File.join(File.dirname(__FILE__), '..', '..', 'spec_helper')
+require File.join(File.dirname(__FILE__), '..', '..', '..', 'lib', 'couchrest', 'support', 'class')
+
+describe CouchRest::ClassExtension do
+  
+  before :all do
+    class FullyDefinedClassExtensions
+      def self.respond_to?(method)
+        if CouchRest::ClassExtension::InstanceMethods.instance_methods.include?(method)
+          true
+        else
+          super
+        end
+      end
+    end
+    
+    class PartDefinedClassExtensions
+      def self.respond_to?(method)
+        methods = CouchRest::ClassExtension::InstanceMethods.instance_methods
+        methods.delete('cattr_reader')
+        
+        if methods.include?(method)
+          false
+        else
+          super
+        end
+      end
+    end
+    
+    class NoClassExtensions
+      def self.respond_to?(method)
+        if CouchRest::ClassExtension::InstanceMethods.instance_methods.include?(method)
+          false
+        else
+          super
+        end
+      end
+    end
+
+
+  end
+  
+  it "should not include InstanceMethods if the class extensions are already defined" do
+    FullyDefinedClassExtensions.send(:include, CouchRest::ClassExtension)
+    FullyDefinedClassExtensions.ancestors.should_not include(CouchRest::ClassExtension::InstanceMethods)
+  end
+  
+  it "should raise RuntimeError if the class extensions are only partially defined" do
+    lambda {
+      PartDefinedClassExtensions.send(:include, CouchRest::ClassExtension)
+    }.should raise_error(RuntimeError)
+  end
+  
+  it "should include class extensions if they are not already defined" do
+    NoClassExtensions.send(:include, CouchRest::ClassExtension)
+    NoClassExtensions.ancestors.should include(CouchRest::ClassExtension::InstanceMethods)
+  end
+  
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: mattetti-couchrest
 version: !ruby/object:Gem::Version 
-  version: "0.17"
+  version: "0.20"
 platform: ruby
 authors: 
 - J. Chris Anderson
@@ -142,6 +142,8 @@ files:
 - spec/couchrest/more/extended_doc_spec.rb
 - spec/couchrest/more/extended_doc_view_spec.rb
 - spec/couchrest/more/property_spec.rb
+- spec/couchrest/support
+- spec/couchrest/support/class_spec.rb
 - spec/fixtures
 - spec/fixtures/attachments
 - spec/fixtures/attachments/couchdb.png