massive_record 0.2.1 → 0.2.2.rc1

data/spec/orm/cases/raw_data_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+
+describe MassiveRecord::ORM::RawData do
+  let(:value) { "FooBar!" }
+  let(:created_at) { Time.now.to_s }
+
+  subject { MassiveRecord::ORM::RawData.new(value: value, created_at: created_at) }
+
+  describe "#initialize" do
+    it "assigns value" do
+      subject.value.should eq value
+    end
+
+    it "assigns created_at" do
+      subject.created_at.should eq created_at
+    end
+  end
+
+
+  describe ".new_with_data_from" do
+    describe "thrift cell" do
+      let(:cell) { MassiveRecord::Wrapper::Cell.new(value: value, created_at: created_at) }
+
+      subject { described_class.new_with_data_from(cell) }
+
+      it "assigns value" do
+        subject.value.should eq value
+      end
+
+      it "assigns created_at" do
+        subject.created_at.should eq created_at
+      end
+    end
+  end
+
+
+  describe "#to_s" do
+    it "represents itself with it's value" do
+      subject.to_s.should eq value
+    end
+  end
+
+  describe "#inspect" do
+    it "represents itself with it's value" do
+      subject.to_s.should eq value
+    end
+  end
+
+  
+  describe "equality" do
+    it "considered equal if created at and value are the same" do
+      cell = described_class.new_with_data_from(
+        MassiveRecord::Wrapper::Cell.new(value: value, created_at: created_at)
+      )
+      cell.should eq subject
+    end
+  end
+end

data/spec/orm/cases/single_table_inheritance_spec.rb

@@ -12,15 +12,71 @@ describe "Single table inheritance" do
 
       its(:type) { should == klass.to_s }
 
-      it "should instantiate correct class when reading from database" do
+      it "instantiates correct class when reading from database via super class" do
         subject.save!
         Person.find(subject.id).should == subject
       end
     end
   end
 
-  it "should not set type if record being saved is base class" do
+  it "sets no type when saving base class" do
     person = Person.new "ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true
     person.type.should be_nil
   end
+
+  describe "fetching and restrictions" do
+    describe "#first" do
+      it "returns record if class found is the look-up class" do
+        person = Person.create!("ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true)
+        Person.first.should eq person
+      end
+
+      it "returns record if class found is subclass of look up class" do
+        friend = Friend.create!("ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true)
+        Person.first.should eq friend
+      end
+
+      it "raises an error if you call first on sub class" do
+        expect { Friend.first }.to raise_error MassiveRecord::ORM::SingleTableInheritance::FirstUnsupported
+      end
+
+      it "does not raise error if you call first on base class" do
+        Person.first.should eq nil
+      end
+    end
+
+    describe "#all" do
+      it "returns [] if class found is a super class of look-up class" do
+        Person.create!("ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true)
+        Friend.all.should eq []
+      end
+
+      it "returns record if class found is the look-up class" do
+        person = Person.create!("ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true)
+        Person.all.should eq [person]
+      end
+
+      it "returns record if class found is subclass of look up class" do
+        friend = Friend.create!("ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true)
+        Person.all.should eq [friend]
+      end
+
+      it "returns record if class found is subclass of look up class, when class is not base class" do
+        person = Person.create!("ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true)
+        friend = Friend.create!("ID2", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true)
+        best_friend = BestFriend.create!("ID3", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true)
+
+        Friend.all.tap do |result|
+          result.should include friend, best_friend
+          result.should_not include person
+        end
+      end
+    end
+
+    it "does not check kind of records if class is not STI enabled" do
+      record = TestClass.create! :foo => 'wee'
+      TestClass.should_not_receive(:ensure_only_class_or_subclass_of_self_are_returned)
+      TestClass.first
+    end
+  end
 end

data/spec/orm/cases/table_spec.rb

@@ -53,7 +53,7 @@ describe "Person which is a table" do
 
   it "should keep different column families per sub class" do
     Person.column_families.collect(&:name).should include "info", "base"
-    TestClass.column_families.collect(&:name).should == ["test_family"]
+    TestClass.column_families.collect(&:name).should include "test_family", "addresses"
   end
   
   it "should have a list of attributes created from the column family 'info'" do
@@ -73,9 +73,9 @@ describe "Person which is a table" do
   end
 
   it "should decode/encode empty hashes correctly" do
-    @person.addresses = {}
+    @person.dictionary = {}
     @person.save! :validate => false
     @person.reload
-    @person.addresses.should be_instance_of Hash
+    @person.dictionary.should be_instance_of Hash
   end
 end

data/spec/orm/cases/time_zone_awareness_spec.rb

@@ -153,5 +153,32 @@ describe "Time zone awareness" do
         cell.value.should eq MassiveRecord::ORM::Base.coder.dump(Time.zone.parse(time_as_string).utc)
       end
     end
+
+    describe "write string representation pf time" do
+      it "it writes string in current time zone" do
+        in_time_zone tz_us do
+          subject.tested_at = time_as_string
+          subject.save!
+
+          subject.reload.tested_at.to_s.should eq Time.zone.parse(time_as_string).to_s
+        end
+      end
+
+      it "handles crappy strings" do
+        in_time_zone tz_us do
+          subject.tested_at = "rubbish"
+          subject.tested_at.should be_nil
+        end
+      end
+
+      it "write_attribute writes in current time zone" do
+        in_time_zone tz_us do
+          subject.write_attribute :tested_at, time_as_string
+          subject.save!
+
+          subject.reload.tested_at.to_s.should eq Time.zone.parse(time_as_string).to_s
+        end
+      end
+    end
   end
 end

data/spec/orm/cases/timestamps_spec.rb

@@ -1,132 +1,46 @@
 require 'spec_helper'
 require 'orm/models/person'
 require 'orm/models/person_with_timestamp'
+require 'orm/models/address'
+require 'orm/models/address_with_timestamp'
 
 describe "timestamps" do
-  include TimeZoneHelper
-  include CreatePersonBeforeEach
+  include SetUpHbaseConnectionBeforeAll
+  include SetTableNamesToTestTable
 
-  before do
-    @person = Person.first
-  end
-
-
-  describe "#updated_at" do
-    it "should have updated at equal to nil on new records" do
-      Person.new.updated_at.should be_nil
-    end
-
-    it "should not be possible to set updated at" do
-      lambda { @person.updated_at = Time.now }.should raise_error MassiveRecord::ORM::CantBeManuallyAssigned
-      lambda { @person['updated_at'] = Time.now }.should raise_error MassiveRecord::ORM::CantBeManuallyAssigned
-      lambda { @person.write_attribute(:updated_at, Time.now) }.should raise_error MassiveRecord::ORM::CantBeManuallyAssigned
-    end
+  describe "on table classes" do
+    let(:attribute_to_be_changed) { 'name' }
 
-    it "should have updated at on a persisted record" do
-      @person.updated_at.should be_a_kind_of Time
-    end
+    describe PersonWithTimestamp do
+      subject { PersonWithTimestamp.create!(:name => "John Doe", :email => "john@base.com", :age => "20") }
 
-    it "should be included in the list of known_attribute_names_for_inspect" do
-      @person.send(:known_attribute_names_for_inspect).should include 'updated_at'
+      it_should_behave_like "a model with timestamps"
     end
 
-    it "should include updated_at in inspect" do
-      @person.inspect.should include(%q{updated_at:})
-    end
-
-    it "should be updated after a save" do
-      sleep(1)
-
-      updated_at_was = @person.updated_at
-      @person.update_attribute :name, "Should Give Me New Updated At"
+    describe Person do
+      subject { Person.create!(:name => "John Doe", :email => "john@base.com", :age => "20") }
 
-      @person.updated_at.should_not == updated_at_was
-    end
-
-    it "should not be updated after a save which failed" do
-      sleep(1)
-
-      updated_at_was = @person.updated_at
-      @person.name = nil
-
-      @person.should_not be_valid
-
-      @person.updated_at.should == updated_at_was
-    end
-
-    context "with time zone awarenesswith zone enabled" do
-      it "should return time with zone" do
-        in_time_zone "Europe/Stockholm" do
-          @person.updated_at.should be_instance_of ActiveSupport::TimeWithZone
-        end
-      end
-
-      it "should be nil on new records" do
-        in_time_zone "Europe/Stockholm" do
-          Person.new.updated_at.should be_nil
-        end
-      end
+      it_should_behave_like "a model without timestamps"
     end
   end
 
-  describe "#created_at" do
-    before do
-      @person_with_timestamp = PersonWithTimestamp.create! :name => "John Doe", :email => "john@base.com", :age => "20"
-    end
-
-    it "should have created at" do
-      @person_with_timestamp.should be_set_created_at_on_create
-    end
-
-    it "should not have created at on create if model does not have created at" do
-      @person.should_not be_set_created_at_on_create
-    end
-
-    it "should have updated at equal to nil on new records" do
-      PersonWithTimestamp.new.created_at.should be_nil
-    end
 
-    it "should not be possible to set updated at" do
-      lambda { @person_with_timestamp.created_at = Time.now }.should raise_error MassiveRecord::ORM::CantBeManuallyAssigned
-      lambda { @person_with_timestamp['created_at'] = Time.now }.should raise_error MassiveRecord::ORM::CantBeManuallyAssigned
-      lambda { @person_with_timestamp.write_attribute(:created_at, Time.now) }.should raise_error MassiveRecord::ORM::CantBeManuallyAssigned
-    end
+  describe "on embedded classes" do
+    let(:attribute_to_be_changed) { 'street' }
+    let(:person) { Person.create!(:name => "John Doe", :email => "john@base.com", :age => "20") }
 
-    it "should not raise cant-set-error if object has no timestamps" do
-      lambda { @person.created_at = Time.now }.should_not raise_error MassiveRecord::ORM::CantBeManuallyAssigned
-    end
+    describe AddressWithTimestamp do
+      subject { AddressWithTimestamp.new "id1", :street => "Karl Johans gate 13" }
+      before { person.addresses_with_timestamp << subject; subject }
 
-    it "should have created_at on a persisted record" do
-      @person_with_timestamp.created_at.should be_a_kind_of Time
+      it_should_behave_like "a model with timestamps"
     end
 
-    it "should not alter created at on update" do
-      created_at_was = @person_with_timestamp.created_at
-
-      sleep(1)
-
-      @person_with_timestamp.update_attribute :name, @person_with_timestamp.name + "NEW"
-      @person_with_timestamp.created_at.should == created_at_was
-    end
-
-    it "should be included in the list of known_attribute_names_for_inspect" do
-      @person_with_timestamp.send(:known_attribute_names_for_inspect).should include 'created_at'
-    end
-
-    it "should include created_at in inspect" do
-      @person_with_timestamp.inspect.should include(%q{created_at:})
-    end
-
-    it "should not include created_at if object does not have it" do
-      @person.send(:known_attribute_names_for_inspect).should_not include 'created_at'
-    end
-
-    it "should raise error if created_at is not time" do
-      PersonWithTimestamp.attributes_schema['created_at'].type = :string
-
-      lambda { PersonWithTimestamp.create! }.should raise_error "created_at must be of type time"
+    describe Address do
+      subject { Address.new "id1", :street => "Karl Johans gate 13" }
+      before { person.addresses << subject; subject }
 
-      PersonWithTimestamp.attributes_schema['created_at'].type = :time
+      it_should_behave_like "a model without timestamps"
     end
   end
 end

data/spec/orm/cases/validation_spec.rb

@@ -58,6 +58,15 @@ shared_examples_for "validateable massive record model" do
       @model.class.stub(:new).and_return(@model)
       lambda { @model.class.create! }.should raise_error MassiveRecord::ORM::RecordInvalid
     end
+
+    describe ":on option" do
+      before { @model.consider_carma = true }
+
+      it "takes :on => create into consideration" do
+        @model.should_not be_valid
+        @model.errors[:carma].length.should eq 1
+      end
+    end
   end
 end
 

data/spec/orm/models/address.rb

@@ -1,7 +1,11 @@
-class Address < MassiveRecord::ORM::Column
+class Address < MassiveRecord::ORM::Embedded
+  embedded_in :person
+  embedded_in :addressable, :inverse_of => :addresses, :polymorphic => true
+
   field :street
   field :number, :integer
   field :nice_place, :boolean, :default => true
+  field :zip, :column => :postal_code
 
   validates_presence_of :street
 end

data/spec/orm/models/address_with_timestamp.rb

@@ -0,0 +1,12 @@
+class AddressWithTimestamp < MassiveRecord::ORM::Embedded
+  embedded_in :person, :inverse_of => :addresses_with_timestamp
+  embedded_in :addressable, :inverse_of => :addresses, :polymorphic => true
+
+  field :street
+  field :number, :integer
+  field :nice_place, :boolean, :default => true
+  field :zip, :column => :postal_code
+  timestamps
+
+  validates_presence_of :street
+end

data/spec/orm/models/car.rb

@@ -0,0 +1,5 @@
+class Car < MassiveRecord::ORM::Embedded
+  embedded_in :person
+
+  field :color
+end

data/spec/orm/models/person.rb

@@ -3,14 +3,17 @@ class Person < MassiveRecord::ORM::Table
     field :name
     field :email
     field :age, :integer
+    field :carma, :float
     field :date_of_birth, :date
-    field :addresses, :hash, :default => {}
+    field :last_signed_in_at, :time
+    field :dictionary, :hash, :default => {}
     field :type
   end
 
   column_family :base do
     field :points, :integer, :default => 1, :column => :pts
     field :status, :boolean, :default => false
+    field :positive_as_default, :boolean, :default => true, :allow_nil => false
     field :phone_numbers, :array, :allow_nil => false
   end
 
@@ -19,10 +22,19 @@ class Person < MassiveRecord::ORM::Table
   references_many :test_classes, :store_in => :info
   references_many :friends, :class_name => "Person", :records_starts_from => :friends_records_starts_from_id
 
+  embeds_many :addresses
+  embeds_many :addresses_with_timestamp, :class_name => "AddressWithTimestamp"
+  embeds_many :cars, :store_in => :info
+
   validates_presence_of :name, :age
   validates_numericality_of :age, :greater_than_or_equal_to => 0
   validates_format_of :email, :with => /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i, :allow_blank => true
 
+  validates :carma, :presence => true, :if => :consider_carma?, :on => :create 
+
+  attr_accessor :consider_carma
+  alias :consider_carma? :consider_carma
+
 
   def friends_records_starts_from_id
     id+'-'

data/spec/orm/models/person_with_timestamp.rb

@@ -6,11 +6,13 @@ class PersonWithTimestamp < MassiveRecord::ORM::Table
     field :points, :integer, :default => 1, :column => :pts
     field :date_of_birth, :date
     field :status, :boolean, :default => false
-    field :addresses, :hash, :default => {}
+    field :dictionary, :hash, :default => {}
 
-    field :created_at, :time
+    timestamps
   end
 
+  validates_presence_of :name
+
   private
 
   def default_id