massive_record 0.1.1 → 0.2.0.beta

data/lib/massive_record/wrapper/errors.rb

@@ -0,0 +1,10 @@
+module MassiveRecord
+  module Wrapper
+    module Errors
+      
+      class ConnectionException < StandardError
+      end
+      
+    end
+  end
+end

data/lib/massive_record/wrapper/tables_collection.rb

@@ -5,7 +5,7 @@ module MassiveRecord
       attr_accessor :connection
     
       def load(table_name)
-        Table.new(connection, table_name)
+        ADAPTER::Table.new(connection, table_name)
       end
     
     end

data/lib/massive_record.rb

@@ -1,15 +1,7 @@
-# Thrift Gems
-require 'thrift'
-require 'thrift/transport/socket'
-require 'thrift/protocol/binary_protocol'
+module MassiveRecord; end
 
-# Exceptions
-require 'massive_record/exceptions'
-
-# Generated Ruby classes from Thrift for HBase
-require 'massive_record/thrift/hbase_constants'
-require 'massive_record/thrift/hbase_types'
-require 'massive_record/thrift/hbase'
+# Adapter
+require 'massive_record/adapters/initialize'
 
 # Wrapper
 require 'massive_record/wrapper/base'
@@ -17,6 +9,7 @@ require 'massive_record/wrapper/base'
 # ORM
 require 'massive_record/orm/base'
 
+# Others
 if defined?(::Rails) && ::Rails::VERSION::MAJOR == 3
   require 'massive_record/rails/railtie'
-end
+end

data/spec/orm/cases/attribute_methods_spec.rb

@@ -3,7 +3,7 @@ require 'orm/models/person'
 
 describe "attribute methods" do
   before do
-    @model = Person.new :id => 5, :name => "John", :age => 15
+    @model = Person.new :id => 5, :name => "John", :age => "15"
   end
 
   it "should define reader method" do
@@ -23,6 +23,10 @@ describe "attribute methods" do
   it "should be possible to read attributes" do
     @model.read_attribute(:name).should == "John"
   end
+
+  it "should return casted value when read" do
+    @model.read_attribute(:age).should == 15
+  end
   
   it "should contains the id in the attributes getter" do
     @model.attributes.should include("id")

data/spec/orm/cases/base_spec.rb

@@ -1,5 +1,7 @@
 require 'spec_helper'
 require 'orm/models/test_class'
+require 'orm/models/friend'
+require 'orm/models/best_friend'
 
 describe MassiveRecord::ORM::Base do
   include MockMassiveRecordConnection
@@ -7,6 +9,14 @@ describe MassiveRecord::ORM::Base do
   describe "table name" do
     before do
       TestClass.reset_table_name_configuration!
+      Friend.reset_table_name_configuration!
+      BestFriend.reset_table_name_configuration!
+    end
+
+    after do
+      TestClass.reset_table_name_configuration!
+      Friend.reset_table_name_configuration!
+      BestFriend.reset_table_name_configuration!
     end
 
     it "should have a table name" do
@@ -22,6 +32,14 @@ describe MassiveRecord::ORM::Base do
       TestClass.table_name_suffix = "_suffix"
       TestClass.table_name.should == "test_classes_suffix"
     end
+
+    it "first sub class should have the same table name as base class" do
+      Friend.table_name.should == Person.table_name
+    end
+
+    it "second sub class should have the same table name as base class" do
+      BestFriend.table_name.should == Person.table_name
+    end
     
     describe "set explicitly" do
       it "should be able to set it" do
@@ -45,6 +63,11 @@ describe MassiveRecord::ORM::Base do
         TestClass.set_table_name("foo")
         TestClass.table_name.should == "foo"
       end
+
+      it "sub class should have have table name overridden" do
+        Friend.table_name = "foo"
+        Friend.table_name.should == "foo"
+      end
     end
   end
 
@@ -54,14 +77,14 @@ describe MassiveRecord::ORM::Base do
 
   describe "#initialize" do
     it "should take a set of attributes and make them readable" do
-      model = TestClass.new :foo => :bar
-      model.foo.should == :bar
+      model = TestClass.new :foo => 'bar'
+      model.foo.should == 'bar'
     end
 
     it "should initialize an object via init_with()" do
       model = TestClass.allocate
-      model.init_with 'attributes' => {:foo => :bar}
-      model.foo.should == :bar
+      model.init_with 'attributes' => {:foo => 'bar'}
+      model.foo.should == 'bar'
     end
 
     it "should stringify keys set on attributes" do
@@ -73,6 +96,10 @@ describe MassiveRecord::ORM::Base do
     it "should return nil as id by default" do
       TestClass.new.id.should be_nil
     end
+
+    it "should be possible to create an object with nil as argument" do
+      lambda { TestClass.new(nil) }.should_not raise_error
+    end
   end
 
   describe "equality" do
@@ -196,4 +223,50 @@ describe MassiveRecord::ORM::Base do
       test.should be_readonly
     end
   end
+
+
+  describe "#base_class" do
+    it "should return correct base class for direct descendant of Base" do
+      Person.base_class.should == Person
+    end
+
+    it "should return Person when asking a descendant of Person" do
+      Friend.base_class.should == Person
+    end
+
+    it "should return Person when asking a descendant of Person multiple levels" do
+      BestFriend.base_class.should == Person
+    end
+  end
+  
+  
+  describe "#clone" do
+    before do
+      @test_object = TestClass.create!(:id => "1", :foo => 'bar')
+      @clone_object = @test_object.clone
+    end
+    
+    it "should be the same object class" do
+      @test_object.class.should == @clone_object.class
+    end
+    
+    it "should have a different object_id" do
+      @test_object.object_id.should_not == @clone_object.object_id
+    end
+    
+    it "should have the same attributes" do
+      @test_object.foo.should == @clone_object.foo
+    end
+    
+    it "should have a nil id" do
+      @clone_object.id.should be_nil
+    end
+  end
+
+
+  describe "coder" do
+    it "should have a default coder" do
+      Person.coder.should be_instance_of MassiveRecord::ORM::Coders::JSON
+    end
+  end
 end

data/spec/orm/cases/column_spec.rb

@@ -28,7 +28,7 @@ describe "column classes" do
 
   # TODO  We might want to remove this when we have implemented
   #       associations correctly. Since Columns are contained within
-  #       tables, calling save should do something on it's owner object.
+  #       tables, calling save should do something on it's proxy_owner object.
   describe "not be possible to persist (at least for now...)" do
     %w(first last all exists? destroy_all).each do |method|
       it "should not respond to class method #{method}" do

data/spec/orm/cases/finder_default_scope.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+require 'orm/models/person'
+
+describe "Default scope in" do
+  include SetUpHbaseConnectionBeforeAll
+  include SetTableNamesToTestTable
+
+  describe Person do
+    let(:subject) { Person.new :id => "ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true }
+
+    before do
+      subject.save!
+
+      Person.class_eval do
+        default_scope select(:info)
+      end
+    end
+
+    after do
+      Person.class_eval do
+        default_scope nil
+      end
+    end
+
+
+
+    it "should be possible to find the a record and use the default scope" do
+      Person.find(subject.id).points.should be_nil
+    end
+
+    it "should only load column family info as a default with first" do
+      Person.first.points.should be_nil # its in :base
+    end
+
+    it "should only load column family info as default with all" do
+      Person.all.first.points.should be_nil
+    end
+
+    it "should be possible to bypass default scope by unscoped" do
+      Person.unscoped.first.points.should == 111
+    end
+
+    it "should be possible to set default_scope with a hash" do
+      Person.class_eval do
+        default_scope :select => :base
+      end
+
+      person = Person.first
+      person.points.should == 111
+      person.name.should be_nil
+    end
+  end
+end

data/spec/orm/cases/finder_scope_spec.rb

@@ -0,0 +1,288 @@
+require 'spec_helper'
+require 'orm/models/person'
+
+describe MassiveRecord::ORM::Finders::Scope do
+  let(:subject) { MassiveRecord::ORM::Finders::Scope.new(nil) }
+
+  MassiveRecord::ORM::Finders::Scope::MULTI_VALUE_METHODS.each do |multi_values|
+    it "should have #{multi_values} as an empty array as default" do
+      subject.send(multi_values+"_values").should == []
+    end
+  end
+
+  MassiveRecord::ORM::Finders::Scope::SINGLE_VALUE_METHODS.each do |singel_value|
+    it "should have #{singel_value} as nil as default" do
+      subject.send(singel_value+"_value").should be_nil
+    end
+  end
+
+
+  describe "scoping methods" do
+    (MassiveRecord::ORM::Finders::Scope::MULTI_VALUE_METHODS + MassiveRecord::ORM::Finders::Scope::SINGLE_VALUE_METHODS).each do |method|
+      it { should respond_to(method) }
+
+      it "should return self after #{method}()" do
+        subject.send(method, nil).should == subject
+      end
+    end
+
+
+
+    describe "multi value methods" do
+      describe "select" do
+        it "should not add nil values" do
+          subject.select(nil)
+          subject.select_values.should be_empty
+        end
+
+        it "should add incomming value to list" do
+          subject.select(:info)
+          subject.select_values.should include 'info'
+        end
+
+        it "should be adding values if called twice" do
+          subject.select(:info).select(:base)
+          subject.select_values.should include 'info', 'base'
+        end
+
+        it "should add multiple arguments" do
+          subject.select(:info, :base)
+          subject.select_values.should include 'info', 'base'
+        end
+
+        it "should add multiple values given as array" do
+          subject.select([:info, :base])
+          subject.select_values.should include 'info', 'base'
+        end
+
+        it "should not add same value twice" do
+          subject.select(:info).select('info')
+          subject.select_values.should == ['info']
+        end
+      end
+    end
+
+
+
+    describe "singel value methods" do
+      describe "limit" do
+        it "should set a limit" do
+          subject.limit(5)
+          subject.limit_value.should == 5
+        end
+
+        it "should be set to the last value set" do
+          subject.limit(1).limit(5)
+          subject.limit_value.should == 5
+        end
+      end
+    end
+  end
+
+
+  describe "#find_options" do
+    it "should return an empty hash when no limitations are set" do
+      subject.send(:find_options).should == {}
+    end
+
+    it "should include a limit if asked to be limited" do
+      subject.limit(5).send(:find_options).should include :limit => 5
+    end
+
+    it "should include selection when asked for it" do
+      subject.select(:info).send(:find_options).should include :select => ['info']
+    end
+  end
+
+
+  describe "loaded" do
+    it { should_not be_loaded }
+
+    it "should be loaded if set to true" do
+       subject.loaded = true
+       should be_loaded
+    end
+  end
+
+
+  describe "#reset" do
+    it "should reset loaded status" do
+      subject.loaded = true
+      subject.reset
+      should_not be_loaded
+    end
+  end
+
+  describe "#to_a" do
+    it "should return @records if loaded" do
+      records = [:foo]
+      subject.instance_variable_set(:@records, records)
+      subject.loaded = true
+
+      subject.to_a.should == records
+    end
+
+
+    [:to_xml, :to_yaml, :length, :collect, :map, :each, :all?, :include?].each do |method|
+      it "should delegate #{method} to to_a" do
+        records = []
+        records.should_receive(method)
+
+        subject.instance_variable_set(:@records, records)
+        subject.loaded = true
+
+        subject.send(method)
+      end
+    end
+
+    it "should always return an array, even though results are single object" do
+      record = mock(Object)
+      subject.should_receive(:load_records).and_return(record)
+      subject.to_a.should be_instance_of Array
+    end
+  end
+
+  describe "#find" do
+    it "should return nil if not found" do
+      klass = mock(Object)
+      klass.should_receive(:do_find).and_return(nil)
+      subject.should_receive(:klass).and_return(klass)
+
+      subject.find(1).should be_nil
+    end
+
+    it "should be possible to add scopes" do
+      klass = mock(Object)
+      klass.should_receive(:do_find).with(1, :select => ['foo']).and_return(nil)
+      subject.should_receive(:klass).and_return(klass)
+      subject.select(:foo).find(1)
+    end
+  end
+
+
+
+  describe "#first" do
+    it "should return first record if loaded" do
+      records = []
+      records.should_receive(:first).and_return(:first_record)
+      subject.instance_variable_set(:@records, records)
+      subject.loaded = true
+
+      subject.first.should == :first_record
+    end
+
+    it "should include finder options" do
+      extra_options = {:select => ["foo"], :conditions => 'should_be_passed_on_to_finder'}
+
+      klass = mock(Object)
+      klass.should_receive(:do_find).with(anything, hash_including(extra_options)).and_return([])
+      subject.should_receive(:klass).and_return(klass)
+
+      subject.first(extra_options)
+    end
+  end
+
+  describe "#all" do
+    it "should simply call to_a" do
+      subject.should_receive(:to_a).and_return []
+      subject.all
+    end
+
+
+    it "should include finder options" do
+      extra_options = {:select => ["foo"], :conditions => 'should_be_passed_on_to_finder'}
+
+      klass = mock(Object)
+      klass.should_receive(:do_find).with(anything, extra_options)
+      subject.should_receive(:klass).and_return(klass)
+
+      subject.all(extra_options)
+    end
+  end
+
+
+  describe "#==" do
+    it "should be counted equal if it's records are the same as asked what being compared to" do
+      subject.instance_variable_set(:@records, [:foo])
+      subject.loaded = true
+
+      subject.==([:foo]).should == true
+    end
+  end
+
+
+
+  describe "real world test" do
+    include SetUpHbaseConnectionBeforeAll
+    include SetTableNamesToTestTable
+
+    describe "with a person" do
+      let(:person_1) { Person.create :id => "ID1", :name => "Person1", :email => "one@person.com", :age => 11, :points => 111, :status => true }
+      let(:person_2) { Person.create :id => "ID2", :name => "Person2", :email => "two@person.com", :age => 22, :points => 222, :status => false }
+
+      before do
+        person_1.save!
+        person_2.save!
+      end
+
+      (MassiveRecord::ORM::Finders::Scope::MULTI_VALUE_METHODS + MassiveRecord::ORM::Finders::Scope::SINGLE_VALUE_METHODS).each do |method|
+        it "should not load from database when Person.#{method}() is called" do
+          Person.should_not_receive(:find)
+          Person.send(method, 5)
+        end
+      end
+
+      it "should find just one record when asked for it" do
+        Person.limit(1).should == [person_1]
+      end
+
+      it "should find only selected column families when asked for it" do
+        records = Person.select(:info).limit(1)
+        person_from_db = records.first
+
+        person_from_db.points.should be_nil
+        person_from_db.status.should be_nil
+      end
+
+      it "should not return read only objects when select is used" do
+        person = Person.select(:info).first
+        person.should_not be_readonly
+      end
+
+      it "should be possible to iterate over a collection with each" do
+        result = []
+
+        Person.limit(5).each do |person|
+          result << person.name
+        end
+
+        result.should == ["Person1", "Person2"]
+      end
+
+      it "should be possible to collect" do
+        Person.select(:info).collect(&:name).should == ["Person1", "Person2"]
+      end
+
+      it "should be possible to checkc if it includes something" do
+        Person.limit(1).include?(person_2).should be_false
+      end
+    end
+  end
+
+
+  describe "#apply_finder_options" do
+    it "should apply limit correctly" do
+      subject.should_receive(:limit).with(30)
+      subject.send :apply_finder_options, :limit => 30
+    end
+
+    it "should apply select correctly" do
+      subject.should_receive(:select).with(:foo)
+      subject.send :apply_finder_options, :select => :foo
+    end
+
+    it "should raise unknown scope error if options is unkown" do
+      lambda { subject.send(:apply_finder_options, :unkown => false) }.should_not raise_error
+    end
+  end
+end