mass_insert 0.2.4 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 26d14bfd22069edf29737a7eb97321e3292d558a
-  data.tar.gz: 3185e4f1caae8fda79464859507f9448c2fdb572
+  metadata.gz: 18392b0e959d9ca325b062eebdb89f481b94d654
+  data.tar.gz: b1b910f77458d48fbcdd6db93793eb44d358900f
 SHA512:
-  metadata.gz: 8b9163e8d0941d1ffa6a206ba26a8c5da737e1db9f0664770fc7cc2411c580cf576e36196c8bb9b2068f87222acac65d084bdde4fba0df174e164a4fbbaafe38
-  data.tar.gz: b6c807db5bee2b7b504bbd12f2645640a6cfc96a0a1ea1e5385f53a789bac61fc19e4ab83699db323469b2e814e9b499e2a44beb7e7202a0d5c719fa016bf146
+  metadata.gz: 210e4f0303a3ed783414754c11097f1d0709dbe8800f40af813d19747cf6996372a6580d9933f9a7a20d751e35e874d8721bcac3cf77dbb9c868eac12393e834
+  data.tar.gz: 874eb4f0c1d3a57d9c1167637f598018629d1b0b35650ba962c4cff877dd8a427f860e908eb8ea168430924811f98e4fe14355bbc8b6598110435b2cb37771e6

data/README.md

@@ -44,6 +44,24 @@ User.mass_insert(values)
 ```
 
 
+
+### Allow primary key
+Sometimes you can need to insert records forcing primary keys.
+Just pass the `primary_key` option with true. Example...
+```ruby
+values = [
+  {
+    id:     1000, # Force primary key.
+    name:   'Jay',
+    email:  'tremendous_gamer@gmail.com',
+    age:    15
+  }
+]
+
+User.mass_insert(values, primary_key: true)
+```
+
+
 ### Insertion per batches
 Due you can get a database timeout error you can specify that the insertion will be in batches.
 Just pass the `per_batch` option with the records per batch. Example...

data/gemfiles/rails_4.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    mass_insert (0.2.3)
+    mass_insert (0.2.5)
       activerecord (>= 4.0)
 
 GEM

data/gemfiles/rails_5.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    mass_insert (0.2.3)
+    mass_insert (0.2.5)
       activerecord (>= 4.0)
 
 GEM

data/lib/mass_insert/adapters/abstract_adapter.rb

@@ -3,10 +3,10 @@ module MassInsert
     class AbstractAdapter < SimpleDelegator
       attr_accessor :values, :options
 
-      def initialize(class_name, values, options)
+      def initialize(values, options)
+        super(options.fetch(:class_name))
         @values  = values
         @options = options
-        super(class_name)
       end
 
       def to_sql
@@ -18,7 +18,7 @@ module MassInsert
       def columns
         @columns ||= begin
           columns = column_names
-          columns.delete(primary_key)
+          columns.delete(primary_key) unless options[:primary_key]
           columns.map(&:to_sym)
         end
       end

data/lib/mass_insert/base.rb

@@ -1,7 +1,8 @@
 module MassInsert
   module Base
     def mass_insert(values, options = {})
-      options[:class_name] ||= self
+      options[:class_name]  ||= self
+      options[:primary_key] ||= false
       Process.new(values, options).start
     end
   end

data/lib/mass_insert/builder.rb

@@ -1,8 +1,7 @@
 module MassInsert
   class Builder
     def build(values, options)
-      class_name = options[:class_name]
-      Utilities.adapter_class.new(class_name, values, options).to_sql
+      Utilities.adapter_class.new(values, options).to_sql
     end
   end
 end

data/lib/mass_insert/version.rb

@@ -1,3 +1,3 @@
 module MassInsert
-  VERSION = '0.2.4'
+  VERSION = '0.2.5'
 end

data/test/models/post.rb

@@ -0,0 +1,2 @@
+class Post < ActiveRecord::Base
+end

data/test/schema.rb

@@ -1,15 +1,20 @@
 ActiveRecord::Schema.define do
   create_table :users, force: true do |t|
-    t.string  :name
+    t.string :name
     t.boolean :active
     t.integer :age
     t.decimal :money, precision: 10, scale: 2
-    t.date    :birth_date
+    t.date :birth_date
     t.timestamps null: false
   end
 
   create_table :kinds, force: true do |t|
-    t.string  :name
+    t.string :name
     t.index ['name'], name: 'index_kinds_on_name', unique: true, using: :btree
   end
+
+  create_table :posts, force: true, id: false do |t|
+    t.integer :id, primary_key: true
+    t.string :name
+  end
 end

data/test/support/shared_examples.rb

@@ -14,6 +14,7 @@ def shared_examples
 
     after :each do
       User.delete_all
+      Post.delete_all
     end
 
     describe 'Column types' do
@@ -26,31 +27,63 @@ def shared_examples
       end
 
       it 'saves values correctly' do
-        assert_equal user.name, 'User Name'
-        assert_equal user.active, true
-        assert_equal user.age, 25
-        assert_equal user.money, 20.50
-        assert_equal user.birth_date, Date.today
+        assert_equal 'User Name', user.name
+        assert_equal true, user.active
+        assert_equal 25, user.age
+        assert_equal 20.50, user.money
+        assert_equal Date.today, user.birth_date
       end
     end
 
     describe 'Bulk inseting' do
       def array_of_values_with(size)
-        (0...size).map do |i|
-          attributes
-        end
+        Array.new(size) { attributes }
       end
 
       it 'saves 500 records correctly' do
         values = array_of_values_with(500)
         User.mass_insert(values)
-        assert_equal User.count, 500
+        assert_equal 500, User.count
       end
 
       it 'saves 1000 records correctly' do
         values = array_of_values_with(1000)
         User.mass_insert(values)
-        assert_equal User.count, 1000
+        assert_equal 1000, User.count
+      end
+    end
+
+    describe 'Primary key' do
+      describe 'when primary key is true' do
+        def setup
+          Post.mass_insert([
+            { id: 10_000, name: 'Post' }
+          ], primary_key: true)
+        end
+
+        def post
+          @post ||= Post.last
+        end
+
+        it 'saves values correctly' do
+          assert_equal 10_000, post.id
+        end
+      end
+
+      describe 'when primary key is false' do
+        def setup
+          User.mass_insert([
+            attributes.merge(id: 10_000)
+          ], primary_key: false)
+        end
+
+        def user
+          @user ||= User.last
+        end
+
+        it 'saves values incorrectly' do
+          refute_equal 10_000, user.id
+        end
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mass_insert
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
 platform: ruby
 authors:
 - Alejandro Gutiérrez
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-17 00:00:00.000000000 Z
+date: 2017-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -117,6 +117,7 @@ files:
 - test/adapters/sqlite3/example_test.rb
 - test/database.yml.example
 - test/models/kind.rb
+- test/models/post.rb
 - test/models/user.rb
 - test/schema.rb
 - test/support/adapters/mysql2.rb
@@ -144,7 +145,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Mass database insertion in Rails
@@ -154,6 +155,7 @@ test_files:
 - test/adapters/sqlite3/example_test.rb
 - test/database.yml.example
 - test/models/kind.rb
+- test/models/post.rb
 - test/models/user.rb
 - test/schema.rb
 - test/support/adapters/mysql2.rb