masamune 0.17.12 → 0.17.13

data/spec/masamune/helpers/postgres_spec.rb

@@ -25,7 +25,7 @@ describe Masamune::Helpers::Postgres do
   let(:instance) { described_class.new(environment) }
 
   describe '#database_exists' do
-    let(:mock_status) { }
+    let(:mock_status) {}
 
     before do
       expect(instance).to receive(:postgres).with(hash_including(exec: 'SELECT version();', fail_fast: false, retries: 0)).and_return(mock_status)

data/spec/masamune/rspec/job_fixture_spec.rb

@@ -276,7 +276,6 @@ describe Masamune::JobFixture do
       end
     end
 
-
     context 'with reference fixture and section' do
       let(:reference_data) do
         {

data/spec/masamune/schema/catalog_spec.rb

@@ -87,7 +87,7 @@ describe Masamune::Schema::Catalog do
         end
       end
 
-      it { expect { schema }.to raise_error ArgumentError, "schema store arguments required" }
+      it { expect { schema }.to raise_error ArgumentError, 'schema store arguments required' }
     end
 
     context 'when schema defines unknown store' do
@@ -203,7 +203,7 @@ describe Masamune::Schema::Catalog do
             column 'name', type: :string, unique: true
             column 'description', type: :string
 
-            row name: 'current_database()', attributes: {default: true}
+            row name: 'current_database()', attributes: { default: true }
           end
         end
       end
@@ -237,10 +237,10 @@ describe Masamune::Schema::Catalog do
       let(:fact_one) { postgres.fact_one_fact }
       let(:fact_two) { postgres.fact_two_fact }
 
-      it { expect(fact_one.references).to include :dimension_one}
+      it { expect(fact_one.references).to include :dimension_one }
       it { expect(fact_one.measures).to include :measure_one }
       it { expect(fact_one.measures[:measure_one].aggregate).to eq(:sum) }
-      it { expect(fact_two.references).to include :dimension_one}
+      it { expect(fact_two.references).to include :dimension_one }
       it { expect(fact_two.measures).to include :measure_two }
       it { expect(fact_two.measures[:measure_two].aggregate).to eq(:average) }
     end
@@ -373,8 +373,8 @@ describe Masamune::Schema::Catalog do
     context 'when schema contains file with headers & format override' do
       before do
         instance.schema :postgres do
-          file 'override', headers: false, format: :tsv do; end
-          file 'default' do; end
+          file 'override', headers: false, format: :tsv
+          file 'default'
         end
       end
 
@@ -399,7 +399,7 @@ describe Masamune::Schema::Catalog do
       end
 
       it 'should raise an exception' do
-        expect { schema }.to raise_error /dimension user_account not defined/
+        expect { schema }.to raise_error(/dimension user_account not defined/)
       end
     end
 
@@ -429,7 +429,7 @@ describe Masamune::Schema::Catalog do
             {
               'tenant_id'               => row[:tenant_id],
               'user_id'                 => row[:id],
-              'user_account_state.name' => row[:deleted_at] ? 'deleted' :  'active',
+              'user_account_state.name' => row[:deleted_at] ? 'deleted' : 'active',
               'start_at'                => row[:updated_at],
               'delta'                   => 0
             }
@@ -456,7 +456,7 @@ describe Masamune::Schema::Catalog do
       end
 
       it 'should raise an exception' do
-        expect { schema }.to raise_error /invalid map, from: is missing/
+        expect { schema }.to raise_error(/invalid map, from: is missing/)
       end
     end
 
@@ -472,14 +472,14 @@ describe Masamune::Schema::Catalog do
       end
 
       it 'should raise an exception' do
-        expect { schema }.to raise_error /invalid map, from: is missing/
+        expect { schema }.to raise_error(/invalid map, from: is missing/)
       end
     end
 
     context 'when schema contains map missing the to: field' do
       subject(:schema) do
         instance.schema :postgres do
-          file 'users' do; end
+          file 'users'
 
           map from: postgres.users_file do
             field 'tenant_id'
@@ -488,15 +488,15 @@ describe Masamune::Schema::Catalog do
       end
 
       it 'should raise an exception' do
-        expect { schema }.to raise_error /invalid map from: 'users', to: is missing/
+        expect { schema }.to raise_error(/invalid map from: 'users', to: is missing/)
       end
     end
 
     context 'when schema addressed with symbols' do
       before do
         instance.schema :postgres do
-          dimension 'user', type: :one do; end
-          file 'users' do; end
+          dimension 'user', type: :one
+          file 'users'
 
           map from: postgres.files[:users], to: postgres.dimensions[:user] do
             field 'tenant_id'
@@ -514,8 +514,8 @@ describe Masamune::Schema::Catalog do
     context 'when schema addressed with strings' do
       before do
         instance.schema :postgres do
-          dimension 'user', type: :one do; end
-          file 'users' do; end
+          dimension 'user', type: :one
+          file 'users'
 
           map from: postgres.files['users'], to: postgres.dimensions['user'] do
             field 'tenant_id'

data/spec/masamune/schema/column_spec.rb

@@ -123,7 +123,7 @@ describe Masamune::Schema::Column do
     end
 
     context 'with index: ["id", "shared"]' do
-      subject(:column) { described_class.new(id: 'id', index: ['id', 'shared']) }
+      subject(:column) { described_class.new(id: 'id', index: %w(id shared)) }
       context '#index' do
         subject { column.index }
         it { is_expected.to include(:id) }
@@ -189,7 +189,7 @@ describe Masamune::Schema::Column do
       let(:column) { described_class.new(id: 'string', type: :string) }
       context 'with string value' do
         let(:value) { 'value' }
-        it { is_expected.to eq(%q{'value'}) }
+        it { is_expected.to eq("'value'") }
       end
       it_behaves_like 'with :null value'
     end
@@ -213,7 +213,7 @@ describe Masamune::Schema::Column do
       let(:column) { described_class.new(id: 'enum', type: :enum, values: %w(public private)) }
       context 'with enum value' do
         let(:value) { 'public' }
-        it { is_expected.to eq(%q{'public'::ENUM_TYPE}) }
+        it { is_expected.to eq("'public'::ENUM_TYPE") }
       end
 
       it_behaves_like 'with :null value'
@@ -261,7 +261,7 @@ describe Masamune::Schema::Column do
       end
 
       context "when ''1''" do
-        let(:value) { %Q{'1'} }
+        let(:value) { %('1') }
         it { is_expected.to eq(true) }
       end
 
@@ -286,7 +286,7 @@ describe Masamune::Schema::Column do
       end
 
       context "when ''0''" do
-        let(:value) { %Q{'0'} }
+        let(:value) { %('0') }
         it { is_expected.to eq(false) }
       end
 
@@ -325,18 +325,18 @@ describe Masamune::Schema::Column do
       end
 
       context 'when Date' do
-        let(:value) { Date.civil(2015,01,01) }
+        let(:value) { Date.civil(2015, 01, 01) }
         it { is_expected.to eq(value) }
       end
 
       context 'when YYYY-mm-dd' do
         let(:value) { '2015-01-01' }
-        it { is_expected.to eq(Date.civil(2015,01,01)) }
+        it { is_expected.to eq(Date.civil(2015, 01, 01)) }
       end
 
       context 'when ISO8601' do
         let(:value) { Date.parse('2015-01-01').iso8601 }
-        it { is_expected.to eq(Date.civil(2015,01,01)) }
+        it { is_expected.to eq(Date.civil(2015, 01, 01)) }
       end
     end
 
@@ -354,7 +354,7 @@ describe Masamune::Schema::Column do
       end
 
       context 'when String encoded Integer' do
-        let(:value) { "1" }
+        let(:value) { '1' }
         it { is_expected.to eq(1) }
       end
 
@@ -397,12 +397,12 @@ describe Masamune::Schema::Column do
       end
 
       context 'when Date' do
-        let(:value) { Date.civil(2015,01,01) }
+        let(:value) { Date.civil(2015, 01, 01) }
         it { is_expected.to eq(value.to_time) }
       end
 
       context 'when DateTime' do
-        let(:value) { DateTime.civil(2015,01,01) }
+        let(:value) { DateTime.civil(2015, 01, 01) }
         it { is_expected.to eq(value.to_time) }
       end
 
@@ -417,7 +417,7 @@ describe Masamune::Schema::Column do
       end
 
       context 'when String encoded Integer' do
-        let(:value) { "#{Time.now.utc.to_i}" }
+        let(:value) { Time.now.utc.to_i.to_s }
         it { is_expected.to eq(Time.at(value.to_i)) }
       end
 
@@ -428,7 +428,7 @@ describe Masamune::Schema::Column do
 
       context 'when ISO8601' do
         let(:value) { Date.parse('2015-01-01').to_time.iso8601 }
-        it { is_expected.to eq(Date.civil(2015,01,01).to_time) }
+        it { is_expected.to eq(Date.civil(2015, 01, 01).to_time) }
       end
     end
 
@@ -452,7 +452,7 @@ describe Masamune::Schema::Column do
 
       context 'when array' do
         let(:value) { '[1,2]' }
-        it { is_expected.to eq([1,2]) }
+        it { is_expected.to eq([1, 2]) }
       end
     end
 
@@ -476,7 +476,7 @@ describe Masamune::Schema::Column do
 
       context 'when array' do
         let(:value) { '{"k":"v"}' }
-        it { is_expected.to eq({"k" => "v"}) }
+        it { is_expected.to eq('k' => 'v') }
       end
     end
   end
@@ -587,12 +587,12 @@ describe Masamune::Schema::Column do
       end
 
       context 'when array of integer' do
-        let(:value) { [1,2] }
+        let(:value) { [1, 2] }
         it { is_expected.to eq('[1,2]') }
       end
 
       context 'when array of string' do
-        let(:value) { ['1','2'] }
+        let(:value) { %w(1 2) }
         it { is_expected.to eq('[1,2]') }
       end
     end
@@ -616,12 +616,12 @@ describe Masamune::Schema::Column do
       end
 
       context 'when array of string' do
-        let(:value) { ['1','2'] }
+        let(:value) { %w(1 2) }
         it { is_expected.to eq('["1","2"]') }
       end
 
       context 'when array of integer' do
-        let(:value) { [1,2] }
+        let(:value) { [1, 2] }
         it { is_expected.to eq('["1","2"]') }
       end
     end

data/spec/masamune/schema/dimension_spec.rb

@@ -80,7 +80,7 @@ describe Masamune::Schema::Dimension do
         ]
     end
 
-    it { expect { dimension }.to raise_error /contains undefined columns/ }
+    it { expect { dimension }.to raise_error(/contains undefined columns/) }
   end
 
   context 'for type :four' do
@@ -93,7 +93,7 @@ describe Masamune::Schema::Dimension do
         rows: [
           Masamune::Schema::Row.new(values: {
             name: 'active',
-            description: 'Active',
+            description: 'Active'
           }, default: true)
         ]
     end

data/spec/masamune/schema/fact_spec.rb

@@ -158,9 +158,9 @@ describe Masamune::Schema::Fact do
 
       it 'yields partition tables' do
         expect { |b| fact.partition_tables(start_date, stop_date, &b) }.to yield_successive_args \
-           fact.partition_table(Date.civil(2015, 01, 01)),
-           fact.partition_table(Date.civil(2015, 02, 01)),
-           fact.partition_table(Date.civil(2015, 03, 01))
+          fact.partition_table(Date.civil(2015, 01, 01)),
+          fact.partition_table(Date.civil(2015, 02, 01)),
+          fact.partition_table(Date.civil(2015, 03, 01))
       end
     end
   end

data/spec/masamune/schema/map_spec.rb

@@ -113,7 +113,7 @@ describe Masamune::Schema::Map do
           file 'input'
           file 'output'
 
-          map from: files.input , to: files.output do |row|
+          map from: files.input, to: files.output do |_row|
             # Empty
           end
         end
@@ -178,12 +178,12 @@ describe Masamune::Schema::Map do
       before do
         expect(environment.logger).to receive(:warn).with(/missing required columns 'id'/).ordered
         expect(environment.logger).to receive(:debug).with(
-          :message => %q(missing required columns 'id'),
-          :source  => 'user_stage',
-          :target  => 'user_dimension_ledger',
-          :file    => input.path,
-          :line    => 3,
-          :row     => {
+          message: "missing required columns 'id'",
+          source: 'user_stage',
+          target: 'user_dimension_ledger',
+          file: input.path,
+          line: 3,
+          row: {
             'id'          => nil,
             'tenant_id'   => '50',
             'junk_id'     => 'X',
@@ -238,32 +238,32 @@ describe Masamune::Schema::Map do
       before do
         expect(environment.logger).to receive(:warn).with(/failed to process/).ordered
         expect(environment.logger).to receive(:debug).with(
-          :message => "failed to process",
-          :source  => "input_stage",
-          :target  => "user_dimension_ledger",
-          :file    => input.path,
-          :line    => 2,
-          :row     => {
-            "id"          => 1,
-            "tenant_id"   => 42,
-            "admin"       => false,
-            "preferences" => {},
-            "deleted_at"  => nil
+          message: 'failed to process',
+          source: 'input_stage',
+          target: 'user_dimension_ledger',
+          file: input.path,
+          line: 2,
+          row: {
+            'id'          => 1,
+            'tenant_id'   => 42,
+            'admin'       => false,
+            'preferences' => {},
+            'deleted_at'  => nil
           }
         ).ordered
         expect(environment.logger).to receive(:warn).with("Could not coerce 'INVALID_JSON' into :json for column 'preferences'").ordered
         expect(environment.logger).to receive(:debug).with(
-          :message => "Could not coerce 'INVALID_JSON' into :json for column 'preferences'",
-          :source  => "input_stage",
-          :target  => "user_dimension_ledger",
-          :file    => input.path,
-          :line    => 4,
-          :row     => {
-            :id          => "3",
-            :tenant_id   => "50",
-            :admin       => "0",
-            :preferences => "INVALID_JSON",
-            :deleted_at  => nil
+          message: "Could not coerce 'INVALID_JSON' into :json for column 'preferences'",
+          source: 'input_stage',
+          target: 'user_dimension_ledger',
+          file: input.path,
+          line: 4,
+          row: {
+            id: '3',
+            tenant_id: '50',
+            admin: '0',
+            preferences: 'INVALID_JSON',
+            deleted_at: nil
           }
         ).ordered
       end
@@ -698,7 +698,7 @@ describe Masamune::Schema::Map do
             column 'id', type: :integer
           end
 
-          map from: files.input, to: files.output, columns: [:id], fail_fast: true do |row|
+          map from: files.input, to: files.output, columns: [:id], fail_fast: true do |_row|
             raise 'wha happen'
           end
         end
@@ -729,17 +729,17 @@ describe Masamune::Schema::Map do
       before do
         expect(environment.logger).to receive(:error).with(/wha happen/).ordered
         expect(environment.logger).to receive(:debug).with(
-          :message => "wha happen",
-          :source  => "input_stage",
-          :target  => "output_stage",
-          :file    => input.path,
-          :line    => 0,
-          :row     => {"id" => 1}
+          message: 'wha happen',
+          source: 'input_stage',
+          target: 'output_stage',
+          file: input.path,
+          line: 0,
+          row: { 'id' => 1 }
         ).ordered
       end
 
       it 'raises exception' do
-        expect { subject }.to raise_error /wha happen/
+        expect { subject }.to raise_error(/wha happen/)
       end
     end
   end
@@ -806,7 +806,7 @@ describe Masamune::Schema::Map do
         io.write '{},{}'
         io.rewind
       end
-      it { is_expected.to eq(%Q{"{}","{}"}) }
+      it { is_expected.to eq(%("{}","{}")) }
     end
 
     context 'with quoted empty json' do
@@ -814,7 +814,7 @@ describe Masamune::Schema::Map do
         io.write '"{}","{}"'
         io.rewind
       end
-      it { is_expected.to eq(%Q{"{}","{}"}) }
+      it { is_expected.to eq(%("{}","{}")) }
     end
 
     context 'with raw json' do
@@ -822,7 +822,7 @@ describe Masamune::Schema::Map do
         io.write '{"enabled":true,"state":""}'
         io.rewind
       end
-      it { is_expected.to eq(%Q{"{""enabled"":true,""state"":""""}"}) }
+      it { is_expected.to eq(%("{""enabled"":true,""state"":""""}")) }
     end
 
     context 'with quoted json' do
@@ -830,7 +830,7 @@ describe Masamune::Schema::Map do
         io.write '"{""enabled"":true,""state"":""""}"'
         io.rewind
       end
-      it { is_expected.to eq(%Q{"{""enabled"":true,""state"":""""}"}) }
+      it { is_expected.to eq(%("{""enabled"":true,""state"":""""}")) }
     end
   end
 end