mas-rad_core 0.0.65 → 0.0.66

data/spec/models/firm_spec.rb

@@ -13,6 +13,18 @@ RSpec.describe Firm do
     end
   end
 
+  describe '#registered?' do
+    it 'is false if the firm has no email address' do
+      firm.email_address = nil
+      expect(firm).not_to be_registered
+    end
+
+    it 'is true if the firm has an email address' do
+      firm.email_address = 'acme@example.com'
+      expect(firm).to be_registered
+    end
+  end
+
   describe '#telephone_number' do
     context 'when `nil`' do
       it 'returns `nil`' do

data/spec/models/principal_spec.rb

@@ -202,4 +202,200 @@ RSpec.describe Principal do
       expect(Firm.where(id: firm.id)).to be_empty
     end
   end
+
+  describe '#next_onboarding_action' do
+    context 'when principal has no firms or trading names' do
+      before :each do
+        principal.firm.destroy
+        principal.reload
+        expect(principal.main_firm_with_trading_names).to be_empty
+      end
+
+      it 'returns :complete_a_firm' do
+        expect(principal.next_onboarding_action).to eql(:complete_a_firm)
+      end
+    end
+
+    context 'when principal only has a parent firm' do
+      before :each do
+        expect(principal.firm).not_to be_nil
+        expect(Firm.where(fca_number: principal.fca_number).count).to eql(1)
+      end
+
+      context 'and the parent firm is not registered' do
+        before :each do
+          expect(principal.firm).not_to be_registered
+        end
+
+        it 'returns :complete_a_firm' do
+          expect(principal.next_onboarding_action).to eql(:complete_a_firm)
+        end
+      end
+
+      context 'and the parent firm is registered' do
+        before :each do
+          principal.firm.update_column(:email_address, 'acme@example.com')
+          principal.reload
+          expect(principal.firm).to be_registered
+        end
+
+        context 'and the firm primarily gives remote advice' do
+          before :each do
+            principal.firm.in_person_advice_methods.destroy_all
+            principal.firm.other_advice_methods << create(:other_advice_method)
+            principal.reload
+          end
+
+          context 'and the firm has no advisers' do
+            before :each do
+              expect(principal.firm.advisers.any?).to eql(false)
+            end
+
+            it 'returns :onboarded' do
+              expect(principal.next_onboarding_action).to eql(:onboarded)
+            end
+          end
+
+          context 'and the firm has advisers' do
+            before :each do
+              create(:adviser, firm: principal.firm)
+              principal.reload
+              expect(principal.firm.advisers.any?).to eql(true)
+            end
+
+            it 'returns :onboarded' do
+              expect(principal.next_onboarding_action).to eql(:onboarded)
+            end
+          end
+        end
+
+        context 'and the firm primarily gives in-person advice' do
+          before :each do
+            principal.firm.in_person_advice_methods << create(:in_person_advice_method)
+            principal.reload
+          end
+
+          context 'and has at least one adviser' do
+            before :each do
+              create(:adviser, firm: principal.firm)
+              principal.reload
+            end
+
+            it 'returns :onboarded' do
+              expect(principal.next_onboarding_action).to eql(:onboarded)
+            end
+          end
+
+          context 'and does not have at least one adviser' do
+            before :each do
+              expect(principal.firm.advisers.any?).to eql(false)
+            end
+
+            it 'returns :complete_an_adviser' do
+              expect(principal.next_onboarding_action).to eql(:complete_an_adviser)
+            end
+          end
+        end
+      end
+    end
+
+    context 'when principal has a parent firm and a trading name' do
+      let(:parent_firm)   { principal.firm }
+      let!(:trading_name) { create(:firm, registered_name: 'cabbage', parent_id: parent_firm.id, fca_number: principal.fca_number) }
+
+      before :each do
+        parent_firm.update_column(:email_address, 'acme@example.com')
+        principal.reload
+        expect(Firm.where(fca_number: principal.fca_number).count).to eql(2)
+      end
+
+      context 'and neither firm give in-person advice' do
+        before :each do
+          parent_firm.in_person_advice_methods.destroy_all
+          parent_firm.other_advice_methods << create(:other_advice_method)
+          trading_name.in_person_advice_methods.destroy_all
+          trading_name.other_advice_methods << create(:other_advice_method)
+          principal.reload
+        end
+
+        it_behaves_like 'at least one remote firm'
+      end
+
+      context 'if at least one firm gives remote advice' do
+        context 'parent firm gives remote advice' do
+          before :each do
+            parent_firm.in_person_advice_methods.destroy_all
+            parent_firm.other_advice_methods << create(:other_advice_method)
+            trading_name.in_person_advice_methods << create(:in_person_advice_method)
+            principal.reload
+          end
+
+          it_behaves_like 'at least one remote firm'
+        end
+
+        context 'trading name gives remote advice' do
+          before :each do
+            parent_firm.in_person_advice_methods << create(:in_person_advice_method)
+            trading_name.in_person_advice_methods.destroy_all
+            trading_name.other_advice_methods << create(:other_advice_method)
+            principal.reload
+          end
+
+          it_behaves_like 'at least one remote firm'
+        end
+      end
+
+      context 'and both firms give in-person advice' do
+        before :each do
+          parent_firm.in_person_advice_methods  << create(:in_person_advice_method)
+          trading_name.in_person_advice_methods << create(:in_person_advice_method)
+          principal.reload
+        end
+
+        context 'and neither firm has advisers' do
+          before :each do
+            expect(parent_firm.advisers.any?).to eql(false)
+            expect(trading_name.advisers.any?).to eql(false)
+          end
+
+          it 'returns :complete_an_adviser' do
+            expect(principal.next_onboarding_action).to eql(:complete_an_adviser)
+          end
+        end
+
+        context 'and parent firm has advisers' do
+          before :each do
+            create(:adviser, firm: parent_firm)
+            expect(trading_name.advisers.any?).to eql(false)
+          end
+
+          it 'returns :onboarded' do
+            expect(principal.next_onboarding_action).to eql(:onboarded)
+          end
+        end
+
+        context 'and trading name has advisers' do
+          before :each do
+            expect(parent_firm.advisers.any?).to eql(false)
+            create(:adviser, firm: trading_name)
+          end
+
+          it 'returns :onboarded' do
+            expect(principal.next_onboarding_action).to eql(:onboarded)
+          end
+        end
+
+        context 'and both firms have advisers' do
+          before :each do
+            create(:adviser, firm: parent_firm)
+            create(:adviser, firm: trading_name)
+          end
+
+          it 'returns :onboarded' do
+            expect(principal.next_onboarding_action).to eql(:onboarded)
+          end
+        end
+      end
+    end
+  end
 end

data/spec/support/shared_examples/at_least_one_remote_firm.rb

@@ -0,0 +1,53 @@
+##
+# Needs:
+#   principal    = instance of Principal with two firms attached (parent_firm and trading_name)
+#   parent_firm  = an instance of Firm with the same FCA Number as the Principal but no parent firm
+#   trading_name = an instance of Firm with the same FCA Number as the Principal and the parent_firm as the parent firm
+RSpec.shared_examples 'at least one remote firm' do
+  context 'and neither firm has advisers' do
+    before :each do
+      expect(parent_firm.advisers.any?).to eql(false)
+      expect(trading_name.advisers.any?).to eql(false)
+    end
+
+    it 'returns :onboarded' do
+      expect(principal.next_onboarding_action).to eql(:onboarded)
+    end
+  end
+
+  context 'and the parent firm has advisers' do
+    before :each do
+      create(:adviser, firm: parent_firm)
+      expect(trading_name.advisers.any?).to eql(false)
+      principal.reload
+    end
+
+    it 'returns :onboarded' do
+      expect(principal.next_onboarding_action).to eql(:onboarded)
+    end
+  end
+
+  context 'and the trading name has advisers' do
+    before :each do
+      expect(parent_firm.advisers.any?).to eql(false)
+      create(:adviser, firm: trading_name)
+      principal.reload
+    end
+
+    it 'returns :onboarded' do
+      expect(principal.next_onboarding_action).to eql(:onboarded)
+    end
+  end
+
+  context 'and both firms have advisers' do
+    before :each do
+      create(:adviser, firm: parent_firm)
+      create(:adviser, firm: trading_name)
+      principal.reload
+    end
+
+    it 'returns :onboarded' do
+      expect(principal.next_onboarding_action).to eql(:onboarded)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mas-rad_core
 version: !ruby/object:Gem::Version
-  version: 0.0.65
+  version: 0.0.66
 platform: ruby
 authors:
 - Ben Lovell
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-07 00:00:00.000000000 Z
+date: 2015-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -385,6 +385,7 @@ files:
 - spec/serializers/adviser_serializer_spec.rb
 - spec/serializers/firm_serializer_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_examples/at_least_one_remote_firm.rb
 - spec/support/shared_examples/friendly_named.rb
 - spec/support/shared_examples/geocodable_examples.rb
 - spec/support/shared_examples/reference_data.rb
@@ -504,6 +505,7 @@ test_files:
 - spec/serializers/adviser_serializer_spec.rb
 - spec/serializers/firm_serializer_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_examples/at_least_one_remote_firm.rb
 - spec/support/shared_examples/friendly_named.rb
 - spec/support/shared_examples/geocodable_examples.rb
 - spec/support/shared_examples/reference_data.rb