mas-rad_core 0.0.39 → 0.0.40

data/spec/lib/mas/firm_result_spec.rb

@@ -14,7 +14,7 @@ RSpec.describe FirmResult do
         'address_town' => 'Romford',
         'address_county' => 'Essex',
         'address_postcode' => 'RM1 1AL',
-        'telephone_number' => '0208 595 2346',
+        'telephone_number' => '02085952346',
         'website_address' => 'http://www.example.com',
         'email_address' => 'someone@example.com',
         'free_initial_meeting' => true,
@@ -74,10 +74,6 @@ RSpec.describe FirmResult do
       expect(subject.address_postcode).to eq('RM1 1AL')
     end
 
-    it 'maps the `telephone_number`' do
-      expect(subject.telephone_number).to eq('0208 595 2346')
-    end
-
     it 'maps the `website_address`' do
       expect(subject.website_address).to eq('http://www.example.com')
     end
@@ -132,6 +128,14 @@ RSpec.describe FirmResult do
       expect(subject.adviser_qualification_ids).to eq([3])
     end
 
+    describe '#telephone_number' do
+      context 'when present' do
+        it 'correctly formatted' do
+          expect(subject.telephone_number).to eq('020 8595 2346')
+        end
+      end
+    end
+
     describe '#closest_adviser' do
       let(:text) { 'less than a mile away' }
 

data/spec/models/firm_spec.rb

@@ -3,6 +3,22 @@ RSpec.describe Firm do
 
   before { allow(GeocodeFirmJob).to receive(:perform_later) }
 
+  describe '#telephone_number' do
+    context 'when `nil`' do
+      it 'returns `nil`' do
+        expect(build(:firm, telephone_number: nil).telephone_number).to be_nil
+      end
+    end
+
+    context 'when provided' do
+      let(:firm) { build(:firm, telephone_number: ' 07715 930 457  ') }
+
+      it 'removes whitespace' do
+        expect(firm.telephone_number).to eq('07715930457')
+      end
+    end
+  end
+
   describe '#postcode_searchable?' do
     it 'delegates to #in_person_advice?' do
       expect(firm).to be_postcode_searchable

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mas-rad_core
 version: !ruby/object:Gem::Version
-  version: 0.0.39
+  version: 0.0.40
 platform: ruby
 authors:
 - Ben Lovell
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-10 00:00:00.000000000 Z
+date: 2015-04-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: uk_phone_numbers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: factory_girl_rails
   requirement: !ruby/object:Gem::Requirement