mas-rad_core 0.0.12 → 0.0.13

data/spec/jobs/geocode_adviser_job_spec.rb

@@ -7,12 +7,21 @@ RSpec.describe GeocodeAdviserJob do
     context 'when the adviser postcode can be geocoded' do
       let(:postcode) { 'EC1N 2TD' }
 
-      it 'the adviser is geocoded with the coordinates' do
+      subject do
         VCR.use_cassette('postcode-one-result') do
-          expect(adviser).to receive(:geocode!).with([51.5180697, -0.1085203])
           job.perform(adviser)
         end
       end
+
+      it 'the adviser is geocoded with the coordinates' do
+        subject
+
+        expect(adviser.coordinates).to contain_exactly(51.51807, -0.10852)
+      end
+
+      it 'schedules the indexing' do
+        expect { subject }.to change { ActiveJob::Base.queue_adapter.enqueued_jobs.size }.by(1)
+      end
     end
 
     context 'when adviser postcode cannot be geocoded' do
@@ -20,8 +29,9 @@ RSpec.describe GeocodeAdviserJob do
 
       it 'the latitude and longitude are set to nil' do
         VCR.use_cassette('postcode-no-results') do
-          expect(adviser).to receive(:geocode!).with(nil)
           job.perform(adviser)
+
+          expect(adviser.coordinates).to contain_exactly(nil, nil)
         end
       end
     end

data/spec/models/adviser_spec.rb

@@ -13,24 +13,6 @@ RSpec.describe Adviser do
     end
   end
 
-  describe 'scheduling the parent firm for indexing' do
-    context 'when the adviser has not been geocoded' do
-      it 'does not schedule the job' do
-        expect do
-          create(:adviser, latitude: nil, longitude: nil)
-        end.not_to change { ActiveJob::Base.queue_adapter.enqueued_jobs.size }
-      end
-    end
-
-    context 'when the adviser has been geocoded' do
-      it 'schedules the job' do
-        expect do
-          create(:adviser)
-        end.to change { ActiveJob::Base.queue_adapter.enqueued_jobs.size }.by(1)
-      end
-    end
-  end
-
   describe 'before validation' do
     context 'when a reference number is present' do
       let(:attributes) { attributes_for(:adviser) }

data/spec/serializers/firm_serializer_spec.rb

@@ -16,10 +16,6 @@ RSpec.describe FirmSerializer do
       expect(subject[:postcode_searchable]).to eql(firm.postcode_searchable?)
     end
 
-    it 'exposes the `advisers` association' do
-      expect(subject[:advisers]).to be
-    end
-
     it 'exposes `options_when_paying_for_care`' do
       expect(subject[:options_when_paying_for_care]).to be
     end
@@ -40,5 +36,13 @@ RSpec.describe FirmSerializer do
       expect(subject[:other_advice_methods]).
         to eql(firm.other_advice_method_ids)
     end
+
+    describe 'advisers' do
+      before { create(:adviser, firm: firm, latitude: nil, longitude: nil) }
+
+      it 'only includes geocoded records' do
+        expect(subject[:advisers].count).to eq(1)
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mas-rad_core
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.13
 platform: ruby
 authors:
 - Ben Lovell
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-03 00:00:00.000000000 Z
+date: 2015-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails