marver 0.0.6 → 0.1.0

data/spec/marver/factories/text_object_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe Marver::Factory::TextObject do
+  let(:json) { fixture('comic.json').read }
+  let(:response) { Marver::API::Response.new(json) }
+  let(:results) { Marver::DataContainer.new(response).results }
+  let(:factory) { described_class.new(results['textObjects']) }
+
+  it 'builds a list of text objects from api results' do
+    expect(factory.build).to be_kind_of Array
+    expect(factory.build.first).to be_kind_of Marver::TextObject
+  end
+end

data/spec/marver/factories/url_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe Marver::Factory::Url do
+  let(:json) { fixture('serie.json').read }
+  let(:response) { Marver::API::Response.new(json) }
+  let(:results) { Marver::DataContainer.new(response).results }
+  let(:factory) { described_class.new(results['urls']) }
+
+  it 'builds a list of urls from api results' do
+    expect(factory.build).to be_kind_of Array
+    expect(factory.build.first).to be_kind_of Marver::Url
+  end
+end

data/spec/marver/finders/character_finder_spec.rb

@@ -1,18 +1,26 @@
-require './lib/marver/finders/character_finder.rb'
+require 'spec_helper'
 
 describe Marver::CharacterFinder do
   let(:finder) { Marver::CharacterFinder.new }
 
-  describe '#find' do
-    context 'no arguments' do
-      it 'returns a list of characters' do
-      end
+  before :each do
+    Time.stub_chain(:now, :to_i, :to_s).and_return "1"
+    stub_get("http://gateway.marvel.com/v1/public/characters?apikey=pub_key&hash=3d4ce88a477c7e4a5accbf6cd2c8b819&name=Hulk&ts=1").to_return(:body => fixture('character.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
+
+    Marver.configure do |config|
+      config.public_key = 'pub_key'
+      config.private_key = 'priv_key'
     end
+  end
+
+  it 'builds a Comic out of the received json' do
+    expect(finder.find_by_name('Hulk')).to be_kind_of(Marver::Character)
+  end
 
-    context 'with arguments' do
-      it 'returns a character' do
-        pending
-      end
+  Marver::CharacterFinder::ALLOWED_PARAMS.each do |param|
+    parameterized_param = Marver::StringHelper.parameterize(param.to_s)
+    it 'should respond to #{parameterized_param}' do
+      expect(finder).to respond_to("find_by_#{parameterized_param}".to_sym)
     end
   end
 end

data/spec/marver/finders/comic_finder_spec.rb

@@ -1,10 +1,12 @@
 require 'spec_helper'
 
 describe Marver::ComicFinder do
+  let(:finder) { described_class.new }
+
   describe '#find' do 
     before :each do
       Time.stub_chain(:now, :to_i, :to_s).and_return "1"
-      stub_get("http://gateway.marvel.com/v1/public/comics?apikey=pub_key&hash=3d4ce88a477c7e4a5accbf6cd2c8b819&name=The%20Avengers&ts=1").to_return(:body => fixture('comic.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
+      stub_get("http://gateway.marvel.com/v1/public/comics?apikey=pub_key&hash=3d4ce88a477c7e4a5accbf6cd2c8b819&title=The%20Avengers&ts=1").to_return(:body => fixture('comic.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
 
       Marver.configure do |config|
         config.public_key = 'pub_key'
@@ -13,7 +15,14 @@ describe Marver::ComicFinder do
     end
 
     it 'builds a Comic out of the received json' do
-      expect(Marver::ComicFinder.new.find({ name: 'The Avengers' })).to be_kind_of(Marver::Comic)
+      expect(finder.find_by_title('The Avengers')).to be_kind_of(Marver::Comic)
+    end
+
+    Marver::ComicFinder::ALLOWED_PARAMS.each do |param|
+      parameterized_param = Marver::StringHelper.parameterize(param.to_s)
+      it 'should respond to #{parameterized_param}' do
+        expect(finder).to respond_to("find_by_#{parameterized_param}".to_sym)
+      end
     end
   end
 end

data/spec/marver/finders/creator_finder_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+describe Marver::CreatorFinder do
+  let(:finder) { described_class.new }
+  describe '#find' do 
+    before :each do
+      Time.stub_chain(:now, :to_i, :to_s).and_return "1"
+      stub_get("http://gateway.marvel.com/v1/public/creators?apikey=pub_key&firstName=Abel&hash=3d4ce88a477c7e4a5accbf6cd2c8b819&ts=1").to_return(:body => fixture('creator.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
+
+      Marver.configure do |config|
+        config.public_key = 'pub_key'
+        config.private_key = 'priv_key'
+      end
+    end
+
+    it 'builds a Creator out of the received json' do
+      expect(finder.find_by_first_name('Abel')).to be_kind_of(Marver::Creator)
+    end
+
+    Marver::CreatorFinder::ALLOWED_PARAMS.each do |param|
+      parameterized_param = Marver::StringHelper.parameterize(param.to_s)
+      it 'should respond to #{parameterized_param}' do
+        expect(finder).to respond_to("find_by_#{parameterized_param}".to_sym)
+      end
+    end
+  end
+end

data/spec/marver/finders/event_finder_spec.rb

@@ -1,10 +1,12 @@
 require 'spec_helper'
 
 describe Marver::EventFinder do
+  let(:finder) { described_class.new }
+
   describe '#find' do 
     before :each do
       Time.stub_chain(:now, :to_i, :to_s).and_return "1"
-      stub_get("http://gateway.marvel.com/v1/public/events?apikey=pub_key&hash=3d4ce88a477c7e4a5accbf6cd2c8b819&title=Fall%20of%20the%20Mutants&ts=1").to_return(:body => fixture('event.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
+      stub_get("http://gateway.marvel.com/v1/public/events?apikey=pub_key&hash=3d4ce88a477c7e4a5accbf6cd2c8b819&name=Fall%20of%20the%20Mutants&ts=1").to_return(:body => fixture('event.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
 
       Marver.configure do |config|
         config.public_key = 'pub_key'
@@ -13,7 +15,14 @@ describe Marver::EventFinder do
     end
 
     it 'builds an Event out of the received json' do
-      expect(Marver::EventFinder.new.find({ title: 'Fall of the Mutants' })).to be_kind_of(Marver::Event)
+      expect(finder.find_by_name('Fall of the Mutants')).to be_kind_of(Marver::Event)
+    end
+
+    Marver::EventFinder::ALLOWED_PARAMS.each do |param|
+      parameterized_param = Marver::StringHelper.parameterize(param.to_s)
+      it 'should respond to #{parameterized_param}' do
+        expect(finder).to respond_to("find_by_#{parameterized_param}".to_sym)
+      end
     end
   end
 end

data/spec/marver/finders/serie_finder_spec.rb

@@ -1,8 +1,9 @@
 require 'spec_helper'
 
 describe Marver::SerieFinder do
-  describe '#find' do 
+  let(:finder) { described_class.new }
 
+  describe '#find' do 
     before :each do
       Time.stub_chain(:now, :to_i, :to_s).and_return "1"
       stub_get("http://gateway.marvel.com/v1/public/series?apikey=pub_key&hash=3d4ce88a477c7e4a5accbf6cd2c8b819&name=The%20Avengers&ts=1").to_return(:body => fixture('serie.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
@@ -14,7 +15,14 @@ describe Marver::SerieFinder do
     end
 
     it 'builds a Serie out of the received json' do
-      expect(Marver::SerieFinder.new.find({ name: 'The Avengers' })).to be_kind_of(Marver::Serie)
+      expect(finder.find_by_name('The Avengers')).to be_kind_of(Marver::Serie)
+    end
+
+    Marver::SerieFinder::ALLOWED_PARAMS.each do |param|
+      parameterized_param = Marver::StringHelper.parameterize(param.to_s)
+      it 'should respond to #{parameterized_param}' do
+        expect(finder).to respond_to("find_by_#{parameterized_param}".to_sym)
+      end
     end
   end
 end

data/spec/marver/finders/story_finder_spec.rb

@@ -1,11 +1,12 @@
 require 'spec_helper'
 
 describe Marver::StoryFinder do
-  describe '#find' do 
+  let(:finder) { described_class.new }
 
+  describe '#find' do 
     before :each do
       Time.stub_chain(:now, :to_i, :to_s).and_return "1"
-      stub_get("http://gateway.marvel.com/v1/public/stories?apikey=pub_key&hash=3d4ce88a477c7e4a5accbf6cd2c8b819&name=Cover%20%23892&ts=1").to_return(:body => fixture('story.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
+      stub_get("http://gateway.marvel.com/v1/public/stories?apikey=pub_key&comics=1,%202,%203&hash=3d4ce88a477c7e4a5accbf6cd2c8b819&ts=1").to_return(:body => fixture('story.json'), :headers => {:content_type => 'application/json; charset=utf-8'})
 
       Marver.configure do |config|
         config.public_key = 'pub_key'
@@ -14,7 +15,14 @@ describe Marver::StoryFinder do
     end
 
     it 'builds a Story out of the received json' do
-      expect(Marver::StoryFinder.new.find({ name: 'Cover #892' })).to be_kind_of(Marver::Story)
+      expect(finder.find_by_comics('1, 2, 3')).to be_kind_of(Marver::Story)
+    end
+
+    Marver::StoryFinder::ALLOWED_PARAMS.each do |param|
+      parameterized_param = Marver::StringHelper.parameterize(param.to_s)
+      it 'should respond to #{parameterized_param}' do
+        expect(finder).to respond_to("find_by_#{parameterized_param}".to_sym)
+      end
     end
   end
 end

data/spec/marver/mappers/character_attributes_mapper_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe Marver::CharacterAttributesMapper do
+  let(:json) { fixture('character.json').read }
+  let(:response) { Marver::API::Response.new(json) }
+  let(:results) { Marver::DataContainer.new(response).results }
+
+  let(:mapped_attributes) { described_class.new(results).map }
+
+  it 'maps valid json attributes to a hash' do
+    expect(mapped_attributes).to be_kind_of(Hash)
+    expect(mapped_attributes[:name]).to eq "Captain America"
+  end 
+end

data/spec/marver/mappers/comic_attributes_mapper_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe Marver::ComicAttributesMapper do
+  let(:json) { fixture('comic.json').read }
+  let(:response) { Marver::API::Response.new(json) }
+  let(:results) { Marver::DataContainer.new(response).results }
+  let(:mapped_attributes) { described_class.new(results).map }
+
+  it 'maps valid json attributes to a hash' do
+    expect(mapped_attributes).to be_kind_of(Hash)
+    expect(mapped_attributes[:format]).to eq "Comic"
+  end 
+
+  it 'rejects invalid json attributes' do
+    expect(mapped_attributes[:some_invalid_attribute]).to be_nil
+  end
+end

data/spec/marver/mappers/creator_attributes_mapper_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Marver::CreatorAttributesMapper do
+  let(:json) { fixture('creator.json').read }
+  let(:response) { Marver::API::Response.new(json) }
+  let(:results) { Marver::DataContainer.new(response).results }
+  let(:mapped_attributes) { described_class.new(results).map }
+
+  it 'maps valid json attributes to a hash' do
+    expect(mapped_attributes).to be_kind_of(Hash)
+    expect(mapped_attributes[:first_name]).to eq "Simone"
+    expect(mapped_attributes[:middle_name]).to eq ""
+    expect(mapped_attributes[:last_name]).to eq "Bianchi"
+  end 
+end

data/spec/marver/mappers/event_attributes_mapper_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe Marver::EventAttributesMapper do
+  let(:json) { fixture('event.json').read }
+  let(:response) { Marver::API::Response.new(json) }
+  let(:results) { Marver::DataContainer.new(response).results }
+  let(:mapped_attributes) { described_class.new(results).map }
+
+  it 'maps valid json attributes to a hash' do
+    expect(mapped_attributes).to be_kind_of(Hash)
+    expect(mapped_attributes[:title]).to eq "Fall of the Mutants"
+    expect(mapped_attributes[:description]).to include "The X-Men battled the Adversary in Dallas"
+  end 
+end

data/spec/marver/mappers/serie_attributes_mapper_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe Marver::SerieAttributesMapper do
+  let(:json) { fixture('serie.json').read }
+  let(:response) { Marver::API::Response.new(json) }
+  let(:results) { Marver::DataContainer.new(response).results }
+  let(:mapped_attributes) { described_class.new(results).map }
+
+  it 'maps valid json attributes to a hash' do
+    expect(mapped_attributes).to be_kind_of(Hash)
+    expect(mapped_attributes[:title]).to eq "Daredevil (1963 - 1998)"
+    expect(mapped_attributes[:start_year]).to eq 1963
+    expect(mapped_attributes[:end_year]).to eq 1998
+    expect(mapped_attributes[:rating]).to eq ""
+    expect(mapped_attributes[:type]).to eq "ongoing"
+  end 
+end

data/spec/marver/mappers/story_attributes_mapper_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Marver::StoryAttributesMapper do  
+  let(:json) { fixture('story.json').read }
+  let(:response) { Marver::API::Response.new(json) }
+  let(:results) { Marver::DataContainer.new(response).results }
+  let(:mapped_attributes) { described_class.new(results).map }
+
+  it 'maps valid json attributes to a hash' do
+    expect(mapped_attributes).to be_kind_of(Hash)
+    expect(mapped_attributes[:title]).to eq "Cover #892"
+    expect(mapped_attributes[:description]).to eq ""
+    expect(mapped_attributes[:type]).to eq "cover"
+  end 
+end

data/spec/marver/utils/finder_param_filter_spec.rb

@@ -0,0 +1,17 @@
+require 'spec_helper'
+
+describe Marver::FinderParamFilter do 
+  it 'raises an error if one or more provided params are not allowed by the API' do
+    allowed_params = [:param1, :param2]
+    params = { param1: double, param3: double }
+    expect{
+      described_class.filter!(params, allowed_params)
+    }.to raise_error Marver::UnallowedParamsError
+  end 
+
+  it 'shouldnt return true if all params are whiltelisted' do
+    allowed_params = [:param1, :param2]
+    params = { param1: double, param2: double }
+    expect(described_class.filter!(params, allowed_params)).to eq true
+  end
+end

data/spec/marver/utils/string_helper_spec.rb

@@ -0,0 +1,7 @@
+require 'spec_helper'
+
+describe Marver::StringHelper do 
+  it 'can parameterize strings' do
+    expect(described_class.parameterize("camelCasedString")).to eq 'camel_cased_string'
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: marver
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.1.0
 platform: ruby
 authors:
 - Ile Eftimov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-01 00:00:00.000000000 Z
+date: 2014-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -111,28 +111,24 @@ files:
 - LICENSE
 - README.md
 - Rakefile
-- TODO
 - lib/marver.rb
 - lib/marver/api.rb
 - lib/marver/api/client.rb
 - lib/marver/api/credentials.rb
-- lib/marver/api/error.rb
+- lib/marver/api/errors.rb
 - lib/marver/api/response.rb
 - lib/marver/client.rb
 - lib/marver/configuration.rb
 - lib/marver/data_container.rb
 - lib/marver/entities/character.rb
 - lib/marver/entities/comic.rb
-- lib/marver/entities/commonable.rb
 - lib/marver/entities/creator.rb
 - lib/marver/entities/event.rb
 - lib/marver/entities/image.rb
 - lib/marver/entities/key_date.rb
 - lib/marver/entities/price.rb
-- lib/marver/entities/queryable.rb
 - lib/marver/entities/serie.rb
 - lib/marver/entities/story.rb
-- lib/marver/entities/summarizable.rb
 - lib/marver/entities/summary.rb
 - lib/marver/entities/summary/character.rb
 - lib/marver/entities/summary/comic.rb
@@ -142,12 +138,41 @@ files:
 - lib/marver/entities/summary/story.rb
 - lib/marver/entities/text_object.rb
 - lib/marver/entities/url.rb
+- lib/marver/factories/character.rb
+- lib/marver/factories/comic.rb
+- lib/marver/factories/creator.rb
+- lib/marver/factories/date.rb
+- lib/marver/factories/event.rb
+- lib/marver/factories/factory.rb
+- lib/marver/factories/image.rb
+- lib/marver/factories/price.rb
+- lib/marver/factories/serie.rb
+- lib/marver/factories/story.rb
+- lib/marver/factories/summary/character.rb
+- lib/marver/factories/summary/comic.rb
+- lib/marver/factories/summary/creator.rb
+- lib/marver/factories/summary/event.rb
+- lib/marver/factories/summary/serie.rb
+- lib/marver/factories/summary/story.rb
+- lib/marver/factories/summary/summary.rb
+- lib/marver/factories/text_object.rb
+- lib/marver/factories/url.rb
 - lib/marver/finders/character_finder.rb
 - lib/marver/finders/comic_finder.rb
+- lib/marver/finders/creator_finder.rb
 - lib/marver/finders/event_finder.rb
 - lib/marver/finders/serie_finder.rb
 - lib/marver/finders/story_finder.rb
 - lib/marver/helpers/string_helper.rb
+- lib/marver/mappers/character_attributes_mapper.rb
+- lib/marver/mappers/comic_attributes_mapper.rb
+- lib/marver/mappers/creator_attributes_mapper.rb
+- lib/marver/mappers/event_attributes_mapper.rb
+- lib/marver/mappers/mappable.rb
+- lib/marver/mappers/serie_attributes_mapper.rb
+- lib/marver/mappers/story_attributes_mapper.rb
+- lib/marver/utils/finder_param_filter.rb
+- lib/marver/utils/string_helper.rb
 - lib/marver/version.rb
 - marver.gemspec
 - spec/fixtures/character.json
@@ -157,6 +182,7 @@ files:
 - spec/fixtures/raw_json.json
 - spec/fixtures/serie.json
 - spec/fixtures/story.json
+- spec/marver/.DS_Store
 - spec/marver/api/client_spec.rb
 - spec/marver/api/credentials_spec.rb
 - spec/marver/api/error_spec.rb
@@ -181,11 +207,37 @@ files:
 - spec/marver/entities/summary/story_spec.rb
 - spec/marver/entities/text_object_spec.rb
 - spec/marver/entities/url_spec.rb
+- spec/marver/factories/character_spec.rb
+- spec/marver/factories/comic_spec.rb
+- spec/marver/factories/creator_spec.rb
+- spec/marver/factories/date_spec.rb
+- spec/marver/factories/event_spec.rb
+- spec/marver/factories/image_spec.rb
+- spec/marver/factories/price_spec.rb
+- spec/marver/factories/serie_spec.rb
+- spec/marver/factories/story_spec.rb
+- spec/marver/factories/summary/character_spec.rb
+- spec/marver/factories/summary/comic_spec.rb
+- spec/marver/factories/summary/creator_spec.rb
+- spec/marver/factories/summary/event_spec.rb
+- spec/marver/factories/summary/serie_spec.rb
+- spec/marver/factories/summary/story_spec.rb
+- spec/marver/factories/text_object_spec.rb
+- spec/marver/factories/url_spec.rb
 - spec/marver/finders/character_finder_spec.rb
 - spec/marver/finders/comic_finder_spec.rb
+- spec/marver/finders/creator_finder_spec.rb
 - spec/marver/finders/event_finder_spec.rb
 - spec/marver/finders/serie_finder_spec.rb
 - spec/marver/finders/story_finder_spec.rb
+- spec/marver/mappers/character_attributes_mapper_spec.rb
+- spec/marver/mappers/comic_attributes_mapper_spec.rb
+- spec/marver/mappers/creator_attributes_mapper_spec.rb
+- spec/marver/mappers/event_attributes_mapper_spec.rb
+- spec/marver/mappers/serie_attributes_mapper_spec.rb
+- spec/marver/mappers/story_attributes_mapper_spec.rb
+- spec/marver/utils/finder_param_filter_spec.rb
+- spec/marver/utils/string_helper_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/fteem/marver
 licenses:
@@ -219,6 +271,7 @@ test_files:
 - spec/fixtures/raw_json.json
 - spec/fixtures/serie.json
 - spec/fixtures/story.json
+- spec/marver/.DS_Store
 - spec/marver/api/client_spec.rb
 - spec/marver/api/credentials_spec.rb
 - spec/marver/api/error_spec.rb
@@ -243,9 +296,35 @@ test_files:
 - spec/marver/entities/summary/story_spec.rb
 - spec/marver/entities/text_object_spec.rb
 - spec/marver/entities/url_spec.rb
+- spec/marver/factories/character_spec.rb
+- spec/marver/factories/comic_spec.rb
+- spec/marver/factories/creator_spec.rb
+- spec/marver/factories/date_spec.rb
+- spec/marver/factories/event_spec.rb
+- spec/marver/factories/image_spec.rb
+- spec/marver/factories/price_spec.rb
+- spec/marver/factories/serie_spec.rb
+- spec/marver/factories/story_spec.rb
+- spec/marver/factories/summary/character_spec.rb
+- spec/marver/factories/summary/comic_spec.rb
+- spec/marver/factories/summary/creator_spec.rb
+- spec/marver/factories/summary/event_spec.rb
+- spec/marver/factories/summary/serie_spec.rb
+- spec/marver/factories/summary/story_spec.rb
+- spec/marver/factories/text_object_spec.rb
+- spec/marver/factories/url_spec.rb
 - spec/marver/finders/character_finder_spec.rb
 - spec/marver/finders/comic_finder_spec.rb
+- spec/marver/finders/creator_finder_spec.rb
 - spec/marver/finders/event_finder_spec.rb
 - spec/marver/finders/serie_finder_spec.rb
 - spec/marver/finders/story_finder_spec.rb
+- spec/marver/mappers/character_attributes_mapper_spec.rb
+- spec/marver/mappers/comic_attributes_mapper_spec.rb
+- spec/marver/mappers/creator_attributes_mapper_spec.rb
+- spec/marver/mappers/event_attributes_mapper_spec.rb
+- spec/marver/mappers/serie_attributes_mapper_spec.rb
+- spec/marver/mappers/story_attributes_mapper_spec.rb
+- spec/marver/utils/finder_param_filter_spec.rb
+- spec/marver/utils/string_helper_spec.rb
 - spec/spec_helper.rb