marvelite 0.0.5 → 0.0.6.a

data/spec/marvelite/api/client_characters_endpoints_spec.rb

@@ -115,6 +115,7 @@ describe Marvelite::API::Client do
 
     describe '#character_stories' do
       before do
+        stub_get('characters?name=Spider-Man&apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'characters/character.json')
         stub_get('characters/1009610/stories?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'characters/character_stories.json')
       end
 

data/spec/marvelite/api/client_events_endpoints_spec.rb

@@ -21,19 +21,19 @@ describe Marvelite::API::Client do
 
     describe '#event' do
       before do
-        stub_get('events/40128?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'events/event.json')
+        stub_get('events/116?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'events/event.json')
         stub_get('events?name=Acts%20of%20Vengeance!&apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'events/event.json')
       end
       it 'returns a Marvelite::API::Response object' do
-        expect(client.event(40128)).to be_a(Marvelite::API::Response)
+        expect(client.event(116)).to be_a(Marvelite::API::Response)
       end
 
       it 'Response object is populated with JSON from the event endpoint' do
-        expect(client.event(40128)[:data][:results][0][:title]).to eq('Acts of Vengeance!')
+        expect(client.event(116)[:data][:results][0][:title]).to eq('Acts of Vengeance!')
       end
 
       it 'accepts an Integer as event id' do
-        expect(client.event(40128)[:data][:results][0][:title]).to eq('Acts of Vengeance!')
+        expect(client.event(116)[:data][:results][0][:title]).to eq('Acts of Vengeance!')
       end
 
       it 'accepts a String as event name' do

data/spec/marvelite/api/client_series_endpoints_spec.rb

@@ -0,0 +1,135 @@
+require 'spec_helper'
+
+describe Marvelite::API::Client do
+  context "Series Endpoints" do
+    let(:client) { marvelite_test_client }
+
+    describe '#series' do
+      before do
+        stub_get('series?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'series/series.json')
+      end
+
+      it 'returns a Marvelite::API::Response object' do
+        expect(client.series).to be_a(Marvelite::API::Response)
+      end
+
+      it 'Response object is populated with JSON from the series endpoint' do
+        expect(client.series["status"]).to eq("Ok")
+        expect(client.series[:data][:results].size).to eq(20)
+      end
+    end
+
+    describe '#serie' do
+      before do
+        stub_get('series/2069?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'series/serie.json')
+        stub_get('series?title=Spider-Man!&apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'series/serie.json')
+      end
+      it 'returns a Marvelite::API::Response object' do
+        expect(client.serie(2069)).to be_a(Marvelite::API::Response)
+      end
+
+      it 'Response object is populated with JSON from the serie endpoint' do
+        expect(client.serie(2069)[:data][:results][0][:title]).to eq('Spider-Man (1990 - 1998)')
+      end
+
+      it 'accepts an Integer as serie id' do
+        expect(client.serie(2069)[:data][:results][0][:title]).to eq('Spider-Man (1990 - 1998)')
+      end
+    end
+
+    describe '#serie_characters' do
+      before do
+        stub_get('series/2069/characters?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'series/serie_characters.json')
+      end
+
+      it 'returns a Marvelite::API::Response object' do
+        expect(client.series_characters(2069)).to be_a(Marvelite::API::Response)
+      end
+
+      it 'Response object is populated with JSON from the series endpoint' do
+        expect(client.series_characters(2069)["status"]).to eq("Ok")
+        expect(client.series_characters(2069)[:data][:results].size).to eq(16)
+      end
+
+      it 'accepts an Integer as serie id' do
+        expect(client.series_characters(2069)[:data][:results][0][:name]).to eq('Adam Warlock')
+      end
+    end
+
+    describe '#serie_comics' do
+      before do
+        stub_get('series/2069/comics?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'series/serie_comics.json')
+      end
+
+      it 'returns a Marvelite::API::Response object' do
+        expect(client.series_comics(2069)).to be_a(Marvelite::API::Response)
+      end
+
+      it 'Response object is populated with JSON from the series endpoint' do
+        expect(client.series_comics(2069)["status"]).to eq("Ok")
+        expect(client.series_comics(2069)[:data][:results].size).to eq(20)
+      end
+
+      it 'accepts an Integer as serie id' do
+        expect(client.series_comics(2069)[:data][:results][0][:title]).to eq('Spider-Man (1990) #98')
+      end
+    end
+
+    describe '#serie_creators' do
+      before do
+        stub_get('series/2069/creators?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'series/serie_creators.json')
+      end
+
+      it 'returns a Marvelite::API::Response object' do
+        expect(client.series_creators(2069)).to be_a(Marvelite::API::Response)
+      end
+
+      it 'Response object is populated with JSON from the series endpoint' do
+        expect(client.series_creators(2069)["status"]).to eq("Ok")
+        expect(client.series_creators(2069)[:data][:results].size).to eq(20)
+      end
+
+      it 'accepts an Integer as serie id' do
+        expect(client.series_creators(2069)[:data][:results][0][:fullName]).to eq('Comicraft')
+      end
+    end
+
+    describe '#serie_events' do
+      before do
+        stub_get('series/2069/events?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'series/serie_events.json')
+      end
+
+      it 'returns a Marvelite::API::Response object' do
+        expect(client.series_events(2069)).to be_a(Marvelite::API::Response)
+      end
+
+      it 'Response object is populated with JSON from the series endpoint' do
+        expect(client.series_events(2069)["status"]).to eq("Ok")
+        expect(client.series_events(2069)[:data][:results].size).to eq(3)
+      end
+
+      it 'accepts an Integer as serie id' do
+        expect(client.series_events(2069)[:data][:results][0][:title]).to eq('Infinity War')
+      end
+    end
+
+    describe '#serie_stories' do
+      before do
+        stub_get('series/2069/stories?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'series/serie_stories.json')
+      end
+
+      it 'returns a Marvelite::API::Response object' do
+        expect(client.series_stories(2069)).to be_a(Marvelite::API::Response)
+      end
+
+      it 'Response object is populated with JSON from the series endpoint' do
+        expect(client.series_stories(2069)["status"]).to eq("Ok")
+        expect(client.series_stories(2069)[:data][:results].size).to eq(20)
+      end
+
+      it 'accepts an Integer as serie id' do
+        expect(client.series_stories(2069)[:data][:results][0][:title]).to eq('Cover #23741')
+      end
+    end
+  end
+end

data/spec/marvelite/api/client_spec.rb

@@ -61,24 +61,4 @@ describe Marvelite::API::Client do
       end
     end
   end
-
-  context "helper methods" do
-    describe '#find_character_by_name' do
-      let(:client) { marvelite_test_client }
-
-      before do
-        stub_get('characters?name=Spider-Man&apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'characters/character.json')
-      end
-
-      it 'retrieves a character through its name' do
-        response = client.send(:find_character_by_name, 'Spider-Man')
-        expect(response[:data][:results][0][:id]).to eq(1009610)
-      end
-
-      it 'can call character.id to the response' do
-        character = client.send(:find_character_by_name, 'Spider-Man')
-        expect(character.id).to eq(1009610)
-      end
-    end
-  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: marvelite
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6.a
 platform: ruby
 authors:
 - Antonio Antillon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-06 00:00:00.000000000 Z
+date: 2014-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -129,11 +129,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- lib/marvelite/api/character_methods.rb
 - lib/marvelite/api/client.rb
-- lib/marvelite/api/comic_methods.rb
 - lib/marvelite/api/config/v1.yml
-- lib/marvelite/api/event_methods.rb
 - lib/marvelite/api/response.rb
 - lib/marvelite/api/router.rb
 - lib/marvelite/version.rb
@@ -157,9 +154,17 @@ files:
 - spec/fixtures/events/event_series.json
 - spec/fixtures/events/event_stories.json
 - spec/fixtures/events/events.json
+- spec/fixtures/series/serie.json
+- spec/fixtures/series/serie_characters.json
+- spec/fixtures/series/serie_comics.json
+- spec/fixtures/series/serie_creators.json
+- spec/fixtures/series/serie_events.json
+- spec/fixtures/series/serie_stories.json
+- spec/fixtures/series/series.json
 - spec/marvelite/api/client_characters_endpoints_spec.rb
 - spec/marvelite/api/client_comics_endpoints_spec.rb
 - spec/marvelite/api/client_events_endpoints_spec.rb
+- spec/marvelite/api/client_series_endpoints_spec.rb
 - spec/marvelite/api/client_spec.rb
 - spec/marvelite/api/router_spec.rb
 - spec/spec_helper.rb
@@ -183,9 +188,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.0.6
@@ -212,9 +217,17 @@ test_files:
 - spec/fixtures/events/event_series.json
 - spec/fixtures/events/event_stories.json
 - spec/fixtures/events/events.json
+- spec/fixtures/series/serie.json
+- spec/fixtures/series/serie_characters.json
+- spec/fixtures/series/serie_comics.json
+- spec/fixtures/series/serie_creators.json
+- spec/fixtures/series/serie_events.json
+- spec/fixtures/series/serie_stories.json
+- spec/fixtures/series/series.json
 - spec/marvelite/api/client_characters_endpoints_spec.rb
 - spec/marvelite/api/client_comics_endpoints_spec.rb
 - spec/marvelite/api/client_events_endpoints_spec.rb
+- spec/marvelite/api/client_series_endpoints_spec.rb
 - spec/marvelite/api/client_spec.rb
 - spec/marvelite/api/router_spec.rb
 - spec/spec_helper.rb

data/lib/marvelite/api/character_methods.rb

@@ -1,70 +0,0 @@
-module Marvelite
-  module API
-    module CharacterMethods
-      def characters(query_params = {})
-        response = self.class.get(router.characters_path, :query => params(query_params))
-        build_response_object(response)
-      end
-
-      def character(value)
-        by_name = value.is_a?(String) ? true : false
-        response = if by_name
-          find_character_by_name(value)
-        else
-          self.class.get(router.character_path(:id => value), :query => params)
-        end
-
-        build_response_object(response)
-      end
-
-      def character_comics(id, query_params = {})
-        if id.is_a?(String)
-          character = find_character_by_name(id)
-          return false unless character
-          id = character.id
-        end
-
-        response = self.class.get(router.character_comics_path(:id => id), :query => params(query_params))
-        build_response_object(response)
-      end
-
-      def character_events(id, query_params = {})
-        if id.is_a?(String)
-          character = find_character_by_name(id)
-          return false unless character
-          id = character.id
-        end
-        response = self.class.get(router.character_events_path(:id => id), :query => params(query_params))
-        build_response_object(response)
-      end
-
-      def character_series(id, query_params = {})
-        if id.is_a?(String)
-          character = find_character_by_name(id)
-          return false unless character
-          id = character.id
-        end
-        response = self.class.get(router.character_series_path(:id => id), :query => params(query_params))
-        build_response_object(response)
-      end
-      
-      def character_stories(id, query_params = {})
-        if id.is_a?(String)
-          character = find_character_by_name(id)
-          return false unless character
-          id = character.id
-        end
-        response = self.class.get(router.character_stories_path(:id => id), :query => params(query_params))
-        build_response_object(response)
-      end
-
-      def find_character_by_name(name)
-        response = self.characters(:name => name)
-        return false unless response[:data][:results].size > 0
-
-        response.id = response[:data][:results][0][:id]
-        response
-      end
-    end
-  end
-end

data/lib/marvelite/api/comic_methods.rb

@@ -1,35 +0,0 @@
-module Marvelite
-  module API
-    module ComicMethods
-      def comics(query_params = {})
-        response = self.class.get(router.comics_path, :query => params(query_params))
-        build_response_object(response)
-      end
-
-      def comic(id)
-        response = self.class.get(router.comic_path(:id => id), :query => params)
-        build_response_object(response)
-      end
-
-      def comic_characters(id, query_params = {})
-        response = self.class.get(router.comic_characters_path(:id => id), :query => params(query_params))
-        build_response_object(response)
-      end
-
-      def comic_events(id, query_params = {})
-        response = self.class.get(router.comic_events_path(:id => id), :query => params(query_params))
-        build_response_object(response)
-      end
-
-      def comic_creators(id, query_params = {})
-        response = self.class.get(router.comic_creators_path(:id => id), :query => params(query_params))
-        build_response_object(response)
-      end
-      
-      def comic_stories(id, query_params = {})
-        response = self.class.get(router.comic_stories_path(:id => id), :query => params(query_params))
-        build_response_object(response)
-      end
-    end
-  end
-end

data/lib/marvelite/api/event_methods.rb

@@ -1,80 +0,0 @@
-module Marvelite
-  module API
-    module EventMethods
-      def events(query_params = {})
-        response = self.class.get(router.events_path, :query => params(query_params))
-        build_response_object(response)
-      end
-
-      def event(id)
-        by_name = id.is_a?(String) ? true : false
-        response = if by_name
-          find_event_by_name(id)
-        else
-          # self.class.get(router.character_path(:id => value), :query => params)
-          self.class.get(router.event_path(:id => id), :query => params)
-        end
-        build_response_object(response)
-      end
-
-      def event_characters(id, query_params = {})
-        if id.is_a?(String)
-          event = find_event_by_name(id)
-          return false unless event
-          id = event.id
-        end
-        response = self.class.get(router.event_characters_path(:id => id), :query => params(query_params))
-        build_response_object(response)
-      end
-
-      def event_comics(id, query_params = {})
-        if id.is_a?(String)
-          event = find_event_by_name(id)
-          return false unless event
-          id = event.id
-        end
-        response = self.class.get(router.event_comics_path(:id => id), :query => params(query_params))
-        build_response_object(response)
-      end
-
-      def event_creators(id, query_params = {})
-        if id.is_a?(String)
-          event = find_event_by_name(id)
-          return false unless event
-          id = event.id
-        end
-        response = self.class.get(router.event_creators_path(:id => id), :query => params(query_params))
-        build_response_object(response)
-      end
-      
-      def event_series(id, query_params = {})
-        if id.is_a?(String)
-          event = find_event_by_name(id)
-          return false unless event
-          id = event.id
-        end
-        response = self.class.get(router.event_series_path(:id => id), :query => params(query_params))
-        build_response_object(response)
-      end
-
-      def event_stories(id, query_params = {})
-        if id.is_a?(String)
-          event = find_event_by_name(id)
-          return false unless event
-          id = event.id
-        end
-        response = self.class.get(router.event_stories_path(:id => id), :query => params(query_params))
-        build_response_object(response)
-      end
-
-      protected
-      def find_event_by_name(name)
-        response = self.events(:name => name)
-        return false unless response[:data][:results].size > 0
-
-        response.id = response[:data][:results][0][:id]
-        response
-      end
-    end
-  end
-end