marvelite 0.0.2 → 0.0.3

data/spec/marvelite/api/client_spec.rb

@@ -38,32 +38,185 @@ describe Marvelite::API::Client do
     end
   end
 
-  describe '#ts' do
-    let(:client) { Marvelite::API::Client.new(:public_key => '1234', :private_key => 'abcd') }
+  context "private methods" do
+    describe '#ts' do
+      let(:client) { Marvelite::API::Client.new(:public_key => '1234', :private_key => 'abcd') }
+
+      it 'calls Time.now' do
+        Time.should_receive(:now)
+        client.send(:ts)
+      end
 
-    it 'calls Time.now' do
-      Time.should_receive(:now)
-      client.ts
+      it 'represents a timestamp converted to integer' do
+        expect(client.send(:ts)).to be_a(Integer)
+      end
     end
-    
-    it 'represents a timestamp converted to integer' do
-      expect(client.ts).to be_a(Integer)
+
+    describe '#params' do
+      let(:client) { Marvelite::API::Client.new(:public_key => '1234', :private_key => 'abcd') }
+
+      it 'passes required API params to all requests' do
+        client.stub(:ts).and_return('1')
+        expect(client.send(:params)).to eq({:apikey => client.public_key, :ts => '1', :hash => 'ffd275c5130566a2916217b101f26150'})
+      end
     end
   end
 
-  describe '#params' do
-    let(:client) { Marvelite::API::Client.new(:public_key => '1234', :private_key => 'abcd') }
+  context "helper methods" do
+    describe '#find_character_by_name' do
+      let(:client) { marvelite_test_client }
+
+      before do
+        stub_get('characters?name=Spider-Man&apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'character.json')
+      end
+
+      it 'retrieves a character through its name' do
+        response = client.send(:find_character_by_name, 'Spider-Man')
+        expect(response[:data][:results][0][:id]).to eq(1009610)
+      end
 
-    it 'passes required API params to all requests' do
-      expect(client.params).to eq('?apikey=1234&ts=1&hash=ffd275c5130566a2916217b101f26150')
+      it 'can call character.id to the response' do
+        character = client.send(:find_character_by_name, 'Spider-Man')
+        expect(character.id).to eq(1009610)
+      end
     end
   end
 
-  describe '#characters' do
-    let(:client) { Marvelite::API::Client.new(:public_key => '1234', :private_key => 'abcd') }
 
-    it 'returns a JSON response from the characters endpoint' do
-      expect(client.characters).to eq('http://gateway.marvel.com/v1/public/characters?apikey=1234&ts=1&hash=ffd275c5130566a2916217b101f26150')
+  context "Character Endpoints" do
+    let(:client) { marvelite_test_client }
+
+    describe '#characters' do
+      before do
+        stub_get('characters?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'characters.json')
+      end
+
+      it 'returns a Marvelite::API::Response object' do
+        expect(client.characters).to be_a(Marvelite::API::Response)
+      end
+
+      it 'Response object is populated with JSON from the characters endpoint' do
+        expect(client.characters["status"]).to eq("Ok")
+        expect(client.characters[:data][:results].size).to eq(20)
+      end
+    end
+
+    describe '#character' do
+      before do
+        stub_get('characters?name=Spider-Man&apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'character.json')
+        stub_get('characters/1009610?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'character.json')
+      end
+      it 'returns a Marvelite::API::Response object' do
+        expect(client.character(1009610)).to be_a(Marvelite::API::Response)
+      end
+
+      it 'Response object is populated with JSON from the character endpoint' do
+        expect(client.character(1009610)[:data][:results][0][:name]).to eq('Spider-Man')
+      end
+
+      it 'accepts an Integer as character id' do
+        expect(client.character(1009610)[:data][:results][0][:name]).to eq('Spider-Man')
+      end
+
+      it 'accepts a String as character name' do
+        expect(client.character('Spider-Man')[:data][:results][0][:name]).to eq('Spider-Man')
+      end
+    end
+
+    describe '#character_comics' do
+      before do
+        stub_get('characters/1009610/comics?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'character_comics.json')
+      end
+
+      it 'returns a Marvelite::API::Response object' do
+        expect(client.character_comics(1009610)).to be_a(Marvelite::API::Response)
+      end
+
+      it 'Response object is populated with JSON from the characters endpoint' do
+        expect(client.character_comics(1009610)["status"]).to eq("Ok")
+        expect(client.character_comics(1009610)[:data][:results].size).to eq(20)
+      end
+
+      it 'accepts an Integer as character id' do
+        expect(client.character_comics(1009610)[:data][:results][0][:title]).to eq('Superior Spider-Man (2013) #22')
+      end
+
+      it 'accetps a String as character id' do
+        expect(client.character_comics('Spider-Man')["status"]).to eq("Ok")
+        expect(client.character_comics('Spider-Man')[:data][:results].size).to eq(20)
+      end
+    end
+
+    describe '#character_events' do
+      before do
+        stub_get('characters/1009610/events?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'character_events.json')
+      end
+
+      it 'returns a Marvelite::API::Response object' do
+        expect(client.character_events(1009610)).to be_a(Marvelite::API::Response)
+      end
+
+      it 'Response object is populated with JSON from the characters endpoint' do
+        expect(client.character_events(1009610)["status"]).to eq("Ok")
+        expect(client.character_events(1009610)[:data][:results].size).to eq(20)
+      end
+
+      it 'accepts an Integer as character id' do
+        expect(client.character_events(1009610)[:data][:results][0][:title]).to eq('Acts of Vengeance!')
+      end
+
+      it 'accetps a String as character id' do
+        expect(client.character_comics('Spider-Man')["status"]).to eq("Ok")
+        expect(client.character_comics('Spider-Man')[:data][:results].size).to eq(20)
+      end
+    end
+
+    describe '#character_series' do
+      before do
+        stub_get('characters/1009610/series?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'character_series.json')
+      end
+
+      it 'returns a Marvelite::API::Response object' do
+        expect(client.character_series(1009610)).to be_a(Marvelite::API::Response)
+      end
+
+      it 'Response object is populated with JSON from the characters endpoint' do
+        expect(client.character_series(1009610)["status"]).to eq("Ok")
+        expect(client.character_series(1009610)[:data][:results].size).to eq(20)
+      end
+
+      it 'accepts an Integer as character id' do
+        expect(client.character_series(1009610)[:data][:results][0][:title]).to eq('A+X (2012 - Present)')
+      end
+
+      it 'accetps a String as character id' do
+        expect(client.character_comics('Spider-Man')["status"]).to eq("Ok")
+        expect(client.character_comics('Spider-Man')[:data][:results].size).to eq(20)
+      end
+    end
+
+    describe '#character_stories' do
+      before do
+        stub_get('characters/1009610/stories?apikey=123456&ts=1&hash=d4f1bab013916a533ef31e3ad5fb0887', 'character_stories.json')
+      end
+
+      it 'returns a Marvelite::API::Response object' do
+        expect(client.character_stories(1009610)).to be_a(Marvelite::API::Response)
+      end
+
+      it 'Response object is populated with JSON from the characters endpoint' do
+        expect(client.character_stories(1009610)["status"]).to eq("Ok")
+        expect(client.character_stories(1009610)[:data][:results].size).to eq(20)
+      end
+
+      it 'accepts an Integer as character id' do
+        expect(client.character_stories(1009610)[:data][:results][0][:title]).to eq('Interior #483')
+      end
+      
+      it 'accetps a String as character id' do
+        expect(client.character_comics('Spider-Man')["status"]).to eq("Ok")
+        expect(client.character_comics('Spider-Man')[:data][:results].size).to eq(20)
+      end
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,2 +1,37 @@
 require 'marvelite'
-require 'pry'
+require 'pry'
+require 'pathname'
+require 'json'
+require 'hashie'
+require 'fakeweb'
+
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift(File.dirname(__FILE__))
+
+RSpec.configure do |config|
+  FakeWeb.allow_net_connect = false
+
+  def marvel_url(url)
+    "http://gateway.marvel.com/v1/public/#{url}"
+  end
+
+  def marvelite_test_client
+    client = Marvelite::API::Client.new(:public_key => '123456', :private_key => 'abcdef')
+    client.stub(:ts).and_return('1')
+    client.stub(:hash).and_return('d4f1bab013916a533ef31e3ad5fb0887')
+    client
+  end
+
+  def json_response(filename)
+    file = Pathname("./spec/fixtures/#{filename}")
+    file.read
+  end
+
+  def stub_get(url, filename, options={})
+    opts = {
+      :body => json_response(filename),
+      :content_type => 'application/json; charset=utf-8'
+    }.merge(options)
+    FakeWeb.register_uri(:get, marvel_url(url), opts)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: marvelite
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Antonio Antillon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-03 00:00:00.000000000 Z
+date: 2014-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -108,6 +108,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: fakeweb
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
 description: Simple wrapper around the Marvel Comics API
 email:
 - antillas21@gmail.com
@@ -120,9 +134,16 @@ files:
 - lib/marvelite/api/router.rb
 - lib/marvelite/version.rb
 - lib/marvelite.rb
+- spec/fixtures/character.json
+- spec/fixtures/character_comics.json
+- spec/fixtures/character_events.json
+- spec/fixtures/character_series.json
+- spec/fixtures/character_stories.json
+- spec/fixtures/characters.json
 - spec/marvelite/api/client_spec.rb
 - spec/marvelite/api/router_spec.rb
 - spec/spec_helper.rb
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - Rakefile
@@ -152,6 +173,12 @@ signing_key:
 specification_version: 4
 summary: Simple wrapper around the Marvel Comics API
 test_files:
+- spec/fixtures/character.json
+- spec/fixtures/character_comics.json
+- spec/fixtures/character_events.json
+- spec/fixtures/character_series.json
+- spec/fixtures/character_stories.json
+- spec/fixtures/characters.json
 - spec/marvelite/api/client_spec.rb
 - spec/marvelite/api/router_spec.rb
 - spec/spec_helper.rb