marty 5.2.0 → 6.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c09276b6e27aad355d8f9b512b7bdd753f62a19fc669757f6835337c20554f7f
-  data.tar.gz: 91626928a7caa158cc81628978b00d5b1a8b0266c24960c5d6164e06ef0815aa
+  metadata.gz: 1f1457a8c273c33b4b74c01a76e07fc6b690fb5dd836511c648e7e60211ae2d7
+  data.tar.gz: 570417d238e3225b53914e99c7f293804c75bd3498bb3ce4ba90976a48d81c8b
 SHA512:
-  metadata.gz: b5901679d961b8484cdf274566d1f0bf8781364b0ce83a542bf1aee859f72ba6d95e8de2f71430ae5ceb86888c301e45fa0b29444ff770e60a3aed58ba64456c
-  data.tar.gz: 1b849061d5d1293f43e6949820426004f73fe3e6f385e72a18e33bc0bc8d52446dd854069944e77cc0dcf55549b3308930b7c0058aef5e63c36e55a22ca7fdef
+  metadata.gz: 90b58649b5c1d327798ed130f0725fec9c08b4aa1bf74cdf09b170d28d8067052563f985b3be49cf76a0a80a835845a1224682ffc973ded8f6eeee196a978318
+  data.tar.gz: 8c73073a407a988bf6a13e7f3ec19305b0253e7e18d1f948bba4e47fbbf2993852c87858b407a6ed0c57ca63c810a5fa417723a90859fff1791b85eac10cf347

data/.gitlab-ci.yml

@@ -1,4 +1,4 @@
-image: 415596832415.dkr.ecr.us-west-2.amazonaws.com/cm_tech/docker-ruby-ci-image:2.4.2-20190129
+image: 415596832415.dkr.ecr.us-west-2.amazonaws.com/cm_tech/docker-ruby-ci-image:2.6.3-20191003	
 
 services:
   - "postgres:9.6"

data/.rubocop_todo.yml

@@ -1,12 +1,12 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-08-13 13:20:18 -0700 using RuboCop version 0.73.0.
+# on 2019-09-12 08:37:20 -0700 using RuboCop version 0.73.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 418
+# Offense count: 416
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
 # SupportedHashRocketStyles: key, separator, table
@@ -23,21 +23,20 @@ Layout/ClosingHeredocIndentation:
     - 'spec/support/components/netzke_combobox.rb'
     - 'spec/support/components/netzke_grid.rb'
 
-# Offense count: 56
+# Offense count: 57
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
 # SupportedStylesAlignWith: keyword, variable, start_of_line
 Layout/EndAlignment:
   Enabled: false
 
-# Offense count: 33
+# Offense count: 32
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
 Layout/ExtraSpacing:
   Exclude:
     - 'app/components/marty/data_grid_view.rb'
     - 'app/components/marty/posting_window.rb'
-    - 'app/models/marty/data_grid.rb'
     - 'lib/marty/logger.rb'
     - 'lib/marty/migrations.rb'
     - 'lib/marty/monkey.rb'
@@ -69,13 +68,13 @@ Layout/IndentFirstHashElement:
 Layout/IndentHeredoc:
   Enabled: false
 
-# Offense count: 288
+# Offense count: 290
 # Cop supports --auto-correct.
 # Configuration parameters: Width, IgnoredPatterns.
 Layout/IndentationWidth:
   Enabled: false
 
-# Offense count: 22
+# Offense count: 20
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: symmetrical, new_line, same_line
@@ -86,20 +85,18 @@ Layout/MultilineHashBraceLayout:
     - 'app/models/marty/delorean_rule.rb'
     - 'lib/marty/migrations.rb'
     - 'lib/marty/schema_helper.rb'
-    - 'other/marty/api/base.rb'
-    - 'other/marty/diagnostic/nodes.rb'
     - 'spec/features/rule_spec.rb'
     - 'spec/lib/json_schema_spec.rb'
     - 'spec/other/diagnostic/base_spec.rb'
 
-# Offense count: 123
+# Offense count: 118
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: symmetrical, new_line, same_line
 Layout/MultilineMethodCallBraceLayout:
   Enabled: false
 
-# Offense count: 88
+# Offense count: 92
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: aligned, indented, indented_relative_to_receiver
@@ -114,7 +111,7 @@ Layout/MultilineMethodDefinitionBraceLayout:
   Exclude:
     - 'lib/marty/data_importer.rb'
 
-# Offense count: 18
+# Offense count: 17
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: aligned, indented
@@ -126,7 +123,6 @@ Layout/MultilineOperationIndentation:
     - 'app/models/marty/script.rb'
     - 'app/models/marty/user.rb'
     - 'lib/marty/data_change.rb'
-    - 'other/marty/api/base.rb'
     - 'spec/controllers/application_controller_spec.rb'
     - 'spec/models/api_auth_spec.rb'
     - 'spec/models/script_spec.rb'
@@ -148,7 +144,7 @@ Lint/AmbiguousBlockAssociation:
 Lint/AmbiguousOperator:
   Exclude:
     - 'app/components/marty/script_form.rb'
-    - 'other/marty/diagnostic/aws/ec2_instance.rb'
+    - 'lib/marty/diagnostic/aws/ec2_instance.rb'
 
 # Offense count: 3
 Lint/AmbiguousRegexpLiteral:
@@ -180,20 +176,20 @@ Lint/HandleExceptions:
   Exclude:
     - 'spec/support/netzke.rb'
 
-# Offense count: 25
+# Offense count: 19
 Lint/IneffectiveAccessModifier:
   Exclude:
     - 'app/components/marty/mcfly_grid_panel.rb'
     - 'app/models/marty/data_grid.rb'
     - 'app/models/marty/token.rb'
     - 'lib/marty/content_handler.rb'
+    - 'lib/marty/diagnostic/reporter.rb'
     - 'lib/marty/migrations.rb'
-    - 'other/marty/diagnostic/reporter.rb'
 
 # Offense count: 1
 Lint/InterpolationCheck:
   Exclude:
-    - 'other/marty/diagnostic/request.rb'
+    - 'lib/marty/diagnostic/request.rb'
 
 # Offense count: 1
 Lint/LiteralAsCondition:
@@ -222,12 +218,12 @@ Lint/ScriptPermission:
 Lint/ShadowingOuterLocalVariable:
   Exclude:
     - 'app/models/marty/data_grid.rb'
+    - 'lib/marty/api/base.rb'
     - 'lib/marty/data_change.rb'
     - 'lib/marty/data_conversion.rb'
+    - 'lib/marty/diagnostic/base.rb'
+    - 'lib/marty/diagnostic/database.rb'
     - 'lib/marty/json_schema.rb'
-    - 'other/marty/api/base.rb'
-    - 'other/marty/diagnostic/base.rb'
-    - 'other/marty/diagnostic/database.rb'
 
 # Offense count: 7
 # Cop supports --auto-correct.
@@ -257,8 +253,8 @@ Lint/UselessAccessModifier:
     - 'app/components/marty/mcfly_grid_panel.rb'
     - 'app/models/marty/data_grid.rb'
     - 'lib/marty/content_handler.rb'
+    - 'lib/marty/diagnostic/reporter.rb'
     - 'lib/marty/json_schema.rb'
-    - 'other/marty/diagnostic/reporter.rb'
 
 # Offense count: 90
 Lint/UselessAssignment:
@@ -274,20 +270,20 @@ Lint/Void:
     - 'spec/lib/xl_styles_spec.rb'
     - 'spec/models/posting_spec.rb'
 
-# Offense count: 109
+# Offense count: 107
 Metrics/AbcSize:
   Max: 129
 
-# Offense count: 22
+# Offense count: 21
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 578
+  Max: 452
 
-# Offense count: 68
+# Offense count: 65
 Metrics/CyclomaticComplexity:
   Max: 40
 
-# Offense count: 171
+# Offense count: 169
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 98
@@ -302,7 +298,7 @@ Metrics/ModuleLength:
 Metrics/ParameterLists:
   Max: 10
 
-# Offense count: 50
+# Offense count: 48
 Metrics/PerceivedComplexity:
   Max: 35
 
@@ -356,12 +352,12 @@ Naming/PredicateName:
     - 'app/components/marty/grid.rb'
     - 'app/components/marty/main_auth_app.rb'
     - 'app/models/marty/user.rb'
+    - 'lib/marty/api/base.rb'
     - 'lib/marty/aws/base.rb'
+    - 'lib/marty/diagnostic/packer.rb'
     - 'lib/marty/permissions.rb'
-    - 'other/marty/api/base.rb'
-    - 'other/marty/diagnostic/packer.rb'
 
-# Offense count: 148
+# Offense count: 145
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
 # AllowedNames: io, id, to, by, on, in, at, ip, db
 Naming/UncommunicativeMethodParamName:
@@ -396,19 +392,12 @@ Performance/DoubleStartEndWith:
   Exclude:
     - 'lib/marty/migrations.rb'
 
-# Offense count: 2
+# Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnabledForFlattenWithoutParams.
 Performance/FlatMap:
   Exclude:
     - 'lib/marty/aws/request.rb'
-    - 'other/marty/diagnostic/aws/ec2_instance.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Performance/InefficientHashSearch:
-  Exclude:
-    - 'other/marty/diagnostic/reporter.rb'
 
 # Offense count: 5
 # Cop supports --auto-correct.
@@ -495,7 +484,21 @@ Style/BarePercentLiterals:
     - 'spec/models/config_spec.rb'
     - 'spec/support/netzke.rb'
 
-# Offense count: 130
+# Offense count: 1
+Style/CaseEquality:
+  Exclude:
+    - 'app/components/marty/report_form.rb'
+    - 'app/models/marty/data_grid.rb'
+    - 'app/helpers/marty/enum_helper.rb'
+    - 'lib/marty/data_change.rb'
+    - 'lib/marty/data_conversion.rb'
+    - 'lib/marty/mcfly_model.rb'
+    - 'lib/marty/monkey.rb'
+    - 'other/marty/api/base.rb'
+    - 'spec/lib/mcfly_model_spec.rb'
+    - 'lib/marty/api/base.rb'
+
+# Offense count: 132
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
@@ -518,23 +521,22 @@ Style/ClassVars:
     - 'app/helpers/marty/script_set.rb'
     - 'app/models/marty/data_grid.rb'
     - 'app/models/marty/tag.rb'
+    - 'lib/marty/api/base.rb'
     - 'lib/marty/data_conversion.rb'
+    - 'lib/marty/diagnostic/base.rb'
+    - 'lib/marty/diagnostic/request.rb'
     - 'lib/marty/rule_script_set.rb'
     - 'lib/marty/util.rb'
-    - 'other/marty/api/base.rb'
-    - 'other/marty/diagnostic/base.rb'
-    - 'other/marty/diagnostic/request.rb'
     - 'spec/support/helper.rb'
     - 'spec/support/post_run_logger.rb'
     - 'spec/support/shared_connection.rb'
 
-# Offense count: 6
+# Offense count: 2
 # Cop supports --auto-correct.
 Style/ColonMethodCall:
   Exclude:
     - 'app/components/marty/data_grid_view.rb'
     - 'app/components/marty/script_tester.rb'
-    - 'other/marty/api/base.rb'
 
 # Offense count: 5
 # Cop supports --auto-correct.
@@ -547,11 +549,6 @@ Style/CommentAnnotation:
     - 'app/models/marty/promise.rb'
     - 'lib/marty/xl.rb'
 
-# Offense count: 1
-Style/CommentedKeyword:
-  Exclude:
-    - 'app/models/marty/data_grid.rb'
-
 # Offense count: 5
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
@@ -564,7 +561,7 @@ Style/ConditionalAssignment:
     - 'spec/support/components/netzke_combobox.rb'
     - 'spec/support/components/netzke_grid.rb'
 
-# Offense count: 159
+# Offense count: 164
 Style/Documentation:
   Enabled: false
 
@@ -582,7 +579,7 @@ Style/EachForSimpleLoop:
   Exclude:
     - 'spec/controllers/rpc_import_spec.rb'
 
-# Offense count: 8
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: compact, expanded
@@ -590,7 +587,6 @@ Style/EmptyMethod:
   Exclude:
     - 'app/models/marty/data_grid.rb'
     - 'app/models/marty/pg_enum.rb'
-    - 'other/marty/api/base.rb'
     - 'spec/job_helper.rb'
     - 'spec/models/import_type_spec.rb'
     - 'spec/support/empty_job.rb'
@@ -636,8 +632,9 @@ Style/FormatStringToken:
     - 'spec/features/rule_spec.rb'
     - 'spec/lib/struct_compare_spec.rb'
     - 'spec/models/rule_spec.rb'
+    - 'spec/support/performance_helper.rb'
 
-# Offense count: 211
+# Offense count: 215
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, never
@@ -719,7 +716,7 @@ Style/Lambda:
     - 'spec/lib/xl_styles_spec.rb'
     - 'spec/support/shared_connection.rb'
 
-# Offense count: 24
+# Offense count: 23
 # Cop supports --auto-correct.
 Style/LineEndConcatenation:
   Exclude:
@@ -729,7 +726,6 @@ Style/LineEndConcatenation:
     - 'lib/marty/data_importer.rb'
     - 'lib/marty/mcfly_model.rb'
     - 'lib/marty/migrations.rb'
-    - 'other/marty/api/base.rb'
     - 'spec/controllers/application_controller_spec.rb'
     - 'spec/features/reporting_spec.rb'
     - 'spec/features/user_view_spec.rb'
@@ -777,12 +773,12 @@ Style/MultilineBlockChain:
   Exclude:
     - 'app/components/marty/report_select.rb'
     - 'app/models/marty/event.rb'
+    - 'lib/marty/diagnostic/delayed_job_version.rb'
+    - 'lib/marty/diagnostic/node.rb'
     - 'lib/marty/migrations.rb'
     - 'lib/marty/xl.rb'
-    - 'other/marty/diagnostic/delayed_job_version.rb'
-    - 'other/marty/diagnostic/node.rb'
 
-# Offense count: 22
+# Offense count: 21
 # Cop supports --auto-correct.
 Style/MultilineIfModifier:
   Exclude:
@@ -803,11 +799,10 @@ Style/MultilineIfModifier:
 Style/MultilineTernaryOperator:
   Enabled: false
 
-# Offense count: 3
+# Offense count: 2
 Style/MultipleComparison:
   Exclude:
     - 'app/components/marty/base_rule_view.rb'
-    - 'app/models/marty/data_grid.rb'
     - 'lib/marty/xl.rb'
 
 # Offense count: 74
@@ -884,7 +879,7 @@ Style/NumericPredicate:
     - 'lib/marty/data_importer.rb'
     - 'lib/marty/xl.rb'
 
-# Offense count: 40
+# Offense count: 36
 # Cop supports --auto-correct.
 Style/ParallelAssignment:
   Enabled: false
@@ -898,7 +893,7 @@ Style/ParenthesesAroundCondition:
     - 'lib/marty/data_change.rb'
     - 'lib/marty/xl.rb'
 
-# Offense count: 12
+# Offense count: 11
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
@@ -906,7 +901,6 @@ Style/PercentLiteralDelimiters:
     - 'app/components/marty/simple_app.rb'
     - 'app/models/marty/data_grid.rb'
     - 'lib/marty/migrations.rb'
-    - 'other/marty/api/base.rb'
     - 'spec/models/event_spec.rb'
     - 'spec/models/rule_spec.rb'
 
@@ -926,14 +920,6 @@ Style/PerlBackrefs:
   Exclude:
     - 'lib/marty/migrations.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: compact, exploded
-Style/RaiseArgs:
-  Exclude:
-    - 'other/marty/diagnostic/reporter.rb'
-
 # Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
@@ -1005,7 +991,7 @@ Style/StructInheritance:
     - 'lib/marty/promise_job.rb'
     - 'lib/marty/promise_ruby_job.rb'
 
-# Offense count: 4
+# Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, AllowSafeAssignment.
 # SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
@@ -1013,9 +999,8 @@ Style/TernaryParentheses:
   Exclude:
     - 'app/models/marty/data_grid.rb'
     - 'lib/marty/xl.rb'
-    - 'other/marty/api/base.rb'
 
-# Offense count: 39
+# Offense count: 40
 # Cop supports --auto-correct.
 Style/TrailingBodyOnModule:
   Enabled: false
@@ -1034,7 +1019,7 @@ Style/TrailingCommaInArguments:
 Style/TrailingCommaInArrayLiteral:
   Enabled: false
 
-# Offense count: 147
+# Offense count: 146
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
@@ -1055,14 +1040,14 @@ Style/UnneededSort:
   Exclude:
     - 'app/models/marty/event.rb'
 
-# Offense count: 96
+# Offense count: 97
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, MinSize, WordRegex.
 # SupportedStyles: percent, brackets
 Style/WordArray:
   Enabled: false
 
-# Offense count: 136
+# Offense count: 137
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https