marty 2.4.0 → 2.4.1

data/spec/controllers/job_controller_spec.rb

@@ -15,7 +15,7 @@ describe Marty::JobController, slow: true do
 
     # Needed here because shutting transactional fixtures off
     # means we lose the globally set uesr
-    Mcfly.whodunnit = UserHelpers.system_user
+    Mcfly.whodunnit = system_user
 
     Marty::Script.load_script_bodies(promise_bodies, Date.today)
 

data/spec/dummy/app/components/gemini/xyz_rule_view.rb

@@ -3,7 +3,6 @@ class Gemini::XyzRuleView < Marty::DeloreanRuleView
                         read: :admin,
                         update: :admin,
                         delete: :admin
-
   def self.klass
     Gemini::XyzRule
   end

data/spec/dummy/config/application.rb

@@ -74,7 +74,6 @@ module Dummy
     config.marty.system_account = 'marty'
     config.marty.local_password = 'marty'
     require 'class_list'
-
     config.marty.roles = [
                           :admin,
                           :dev,

data/spec/features/enum_spec.rb

@@ -14,6 +14,27 @@ feature 'test netzke + pg_enum compatibility', js: true do
   end
 
   it 'shows netzke grid combobox works w pg_enums' do
+
+    lp_grid = netzke_find('loan_program_view')
+    @amort_combo = netzke_find('amortization_type__name', 'combobox')
+    @mortgage_combo = netzke_find('mortgage_type__name', 'combobox')
+    @streamline_combo = netzke_find('streamline_type__name', 'combobox')
+    @state_combo = netzke_find('enum_state', 'combobox')
+
+    def setup_enum_form(stateVal)
+      @amort_combo.click
+      @amort_combo.select_values('Fixed')
+
+      @mortgage_combo.click
+      @mortgage_combo.select_values('FHA')
+
+      @streamline_combo.click
+      @streamline_combo.select_values('DURP')
+
+      @state_combo.click
+      @state_combo.select_values(stateVal)
+    end
+
     log_in_as('dev1')
 
     by 'navigating to loan program screen' do
@@ -21,11 +42,6 @@ feature 'test netzke + pg_enum compatibility', js: true do
       press('Loan Programs')
     end
 
-    lp_grid = netzke_find('loan_program_view')
-    amort_combo = netzke_find('amortization_type__name', 'combobox')
-    mortgage_combo = netzke_find('mortgage_type__name', 'combobox')
-    streamline_combo = netzke_find('streamline_type__name', 'combobox')
-    state_combo = netzke_find('enum_state', 'combobox')
 
     and_by 'bring up new window' do
       press('Add')
@@ -35,14 +51,14 @@ feature 'test netzke + pg_enum compatibility', js: true do
       within(:gridpanel, 'add_window', match: :first) do
         fill_in("Name", with: 'a_l_p')
 
-        amort_combo.click
-        amort_combo.select_values('Fixed')
+        @amort_combo.click
+        @amort_combo.select_values('Fixed')
 
-        mortgage_combo.click
-        mortgage_combo.select_values('FHA')
+        @mortgage_combo.click
+        @mortgage_combo.select_values('FHA')
 
-        streamline_combo.click
-        streamline_combo.select_values('DURP')
+        @streamline_combo.click
+        @streamline_combo.select_values('DURP')
 
         press('OK')
       end
@@ -58,18 +74,7 @@ feature 'test netzke + pg_enum compatibility', js: true do
     and_by 'fill form w enum value & duplicated name (error), then fix' do
       within(:gridpanel, 'add_window', match: :first) do
         fill_in("Name", with: 'a_l_p')
-        amort_combo.click
-        amort_combo.select_values('Fixed')
-
-        mortgage_combo.click
-        mortgage_combo.select_values('FHA')
-
-        streamline_combo.click
-        streamline_combo.select_values('DURP')
-
-        state_combo.click
-        state_combo.select_values('CA')
-
+        setup_enum_form("CA")
         press('OK')
 
         expect(find(:msg)).to have_content 'Name - record must be unique'
@@ -100,18 +105,7 @@ feature 'test netzke + pg_enum compatibility', js: true do
     and_by 'fill form w --- for enum value' do
       within(:gridpanel, 'add_window', match: :first) do
         fill_in("Name", with: 'a_l_p')
-        amort_combo.click
-        amort_combo.select_values('Fixed')
-
-        mortgage_combo.click
-        mortgage_combo.select_values('FHA')
-
-        streamline_combo.click
-        streamline_combo.select_values('DURP')
-
-        state_combo.click
-        state_combo.select_values('---')
-
+        setup_enum_form("---")
         press('OK')
       end
 
@@ -121,5 +115,76 @@ feature 'test netzke + pg_enum compatibility', js: true do
         expect(lp_grid.get_row_vals(1)).to netzke_include({enum_state: nil})
       end
     end
+
+    and_by 'delete leftover rows' do
+      lp_grid.select_row(1)
+      press('Delete')
+      press('Yes')
+      wait_for_ajax
+      lp_grid.select_row(1)
+      press('Delete')
+      press('Yes')
+      wait_for_ajax
+      expect(lp_grid.row_count).to eq(0)
+    end
+
+    and_by "bring up new window" do
+      press("Add")
+    end
+
+    and_by "fill form with state_enum DC" do
+      within(:gridpanel, "add_window", match: :first) do
+        fill_in("Name", with: "DC Row")
+        setup_enum_form("DC")
+        press("OK")
+      end
+    end
+
+    and_by "bring up new window" do
+      press("Add")
+    end
+
+    and_by "fill form with state_enum AS" do
+      within(:gridpanel, "add_window", match: :first) do
+        fill_in("Name", with: "AS Row")
+        setup_enum_form("AS")
+        press("OK")
+      end
+    end
+
+    and_by "bring up new window" do
+      press("Add")
+    end
+
+    and_by "fill form with state_enum WA" do
+      within(:gridpanel, "add_window", match: :first) do
+        fill_in("Name", with: "WA Row")
+        setup_enum_form("WA")
+        press("OK")
+      end
+    end
+
+    and_by "bring up new window" do
+      press("Add")
+    end
+
+    and_by "fill form with state_enum AZ" do
+      within(:gridpanel, "add_window", match: :first) do
+        fill_in("Name", with: "AZ Row")
+        setup_enum_form("AZ")
+        press("OK")
+      end
+    end
+
+    and_by "filter form by state_enum ASCENDING" do
+      press("Enum state")
+      expect(lp_grid.get_col_vals(:enum_state)).to eq(["AS","AZ","DC","WA"])
+    end
+
+    and_by "filter form by state_enum DESCENDING" do
+      press("Enum state")
+      expect(lp_grid.get_col_vals(:enum_state)).to eq(["WA","DC","AZ","AS"])
+    end
+
   end
 end

data/spec/features/log_view_spec.rb

@@ -45,7 +45,7 @@ feature 'logger view', js: true, capybara: true do
     press('System')
     show_submenu('Log Maintenance')
     press('View Log')
-    wait_for_ready
+    wait_for_ajax
 
     exp_types = ["fatal", "error", "info", "debug", "warn"]
     exp_messages = ["fatal message", "error message",
@@ -72,11 +72,11 @@ feature 'logger view', js: true, capybara: true do
       wait_for_ajax
       cnt = logview.row_count()
       expect(cnt).to eq(exp_count)
-      types = logview.col_values('message_type', cnt, 0)
-      messages = logview.col_values('message', cnt, 0)
-      details = logview.col_values('details', cnt, 0).
+      types = logview.get_col_vals('message_type', cnt, 0)
+      messages = logview.get_col_vals('message', cnt, 0)
+      details = logview.get_col_vals('details', cnt, 0).
                   map { |d| CGI.unescapeHTML(d) }
-      ts = logview.col_values('timestamp_custom', cnt, 0)
+      ts = logview.get_col_vals('timestamp_custom', cnt, 0)
       expect(ts).to eq(@ts.slice(0,exp_count))
       expect(types).to eq(exp_types.slice(0,exp_count))
       expect(messages).to eq(exp_messages.slice(0,exp_count))

data/spec/features/rule_spec.rb

@@ -200,7 +200,7 @@ feature 'rule view', js: true do
     exp = "Computed - Error in rule 'abc' field 'computed_guards': Syntax error on line 1"
     expect(page).to have_content(exp)
     sleep 2  # sleep needed for message to clear, otherwise failing tests could
-             # pass due to prior messages
+    # pass due to prior messages
 
     # lhs is not identifier - BaseRuleView#simple_to_has will raise
     fill_in(:computed_guards, with: '0sadf = 123j')
@@ -307,7 +307,7 @@ computed_value = if paramb
                  then param1 / (grid1_grid_result||1)
                  else (grid2_grid_result||1) / param1
 EOL
-    names = mrv.col_values(:name, 9, 0)
+    names = mrv.get_col_vals(:name, 9, 0)
     idx = names.index{|n|n=='Rule3'}+1
     mrv.select_row(idx)
     press("Edit")
@@ -326,9 +326,9 @@ EOL
     go_to_xyz_rules
     xrv = netzke_find("xyz_rule_view")
     expect(page).to have_content("Rule type")
-    expect(xrv.col_values(:name, 5, 0)).to eq(["ZRule1", "ZRule2",
-                                                    "ZRule3", "ZRule4",
-                                                    "ZRule5"])
+    expect(xrv.get_col_vals(:name, 5, 0)).to eq(["ZRule1", "ZRule2",
+                                                 "ZRule3", "ZRule4",
+                                                 "ZRule5"])
     xrv.select_row(1)
     press("Edit")
     fill_in("Range Guard 1", with: "[100,200)")
@@ -359,37 +359,37 @@ EOL
             "bv"=>"base_value"}}
 
     expect(r.first.as_json).to include(exp)
-    expect(xrv.col_values(:g_string, 8, 0)).to eq(["aaa", "bbb", "ccc", "ddd",
-                                                   "eee", "eee", "eee", "eee"])
+    expect(xrv.get_col_vals(:g_string, 8, 0)).to eq(["aaa", "bbb", "ccc", "ddd",
+                                                     "eee", "eee", "eee", "eee"])
     click_column(xrv, "String list Guard")
-    expect(xrv.col_values(:g_string, 8, 0)).to eq(["eee", "eee", "eee", "eee",
-                                                   "ddd", "ccc", "bbb", "aaa"])
+    expect(xrv.get_col_vals(:g_string, 8, 0)).to eq(["eee", "eee", "eee", "eee",
+                                                     "ddd", "ccc", "bbb", "aaa"])
     column_filter(xrv, "String list Guard", "eee")
     rc = xrv.row_count
-    expect(xrv.col_values(:g_string,rc,0)).to eq(["eee", "eee", "eee", "eee"])
+    expect(xrv.get_col_vals(:g_string,rc,0)).to eq(["eee", "eee", "eee", "eee"])
     column_filter_toggle(xrv, "String list Guard")
     rc = xrv.row_count
-    expect(xrv.col_values(:g_string,rc,0)).to eq(["eee", "eee", "eee", "eee",
-                                                  "ddd", "ccc", "bbb", "aaa"])
+    expect(xrv.get_col_vals(:g_string,rc,0)).to eq(["eee", "eee", "eee", "eee",
+                                                    "ddd", "ccc", "bbb", "aaa"])
     column_filter(xrv, "Grids", "Grid1")
     rc = xrv.row_count
-                                         # netzke reports jsonb as string
-    expect(xrv.col_values(:grids,rc,0)).to eq([%Q({"grid1":"DataGrid1"}),
-                                               %Q({"grid1":"DataGrid1"})])
+    # netzke reports jsonb as string
+    expect(xrv.get_col_vals(:grids,rc,0)).to eq([%Q({"grid1":"DataGrid1"}),
+                                                 %Q({"grid1":"DataGrid1"})])
     column_filter_toggle(xrv, "Grids")
     rc = xrv.row_count
-    expect(xrv.col_values(:grids,rc,0)).to eq([%Q({"grid1":"DataGrid3"}),
-                                               %Q({"grid1":"DataGrid3"}),
-                                               %Q({"grid1":"DataGrid3"}),
-                                               %Q({"grid1":"DataGrid3"}),
-                                               %Q({"grid1":"DataGrid3"}),
-                                               %Q({"grid1":"DataGrid2"}),
-                                               %Q({"grid1":"DataGrid1"}),
-                                               %Q({"grid1":"DataGrid1"})])
+    expect(xrv.get_col_vals(:grids,rc,0)).to eq([%Q({"grid1":"DataGrid3"}),
+                                                 %Q({"grid1":"DataGrid3"}),
+                                                 %Q({"grid1":"DataGrid3"}),
+                                                 %Q({"grid1":"DataGrid3"}),
+                                                 %Q({"grid1":"DataGrid3"}),
+                                                 %Q({"grid1":"DataGrid2"}),
+                                                 %Q({"grid1":"DataGrid1"}),
+                                                 %Q({"grid1":"DataGrid1"})])
     press("Applications")
     press("Data Grids")
     dgv = netzke_find("data_grid_view")
-    cvs = dgv.col_values(:name, 4, 0)
+    cvs = dgv.get_col_vals(:name, 4, 0)
     ind1 = cvs.index("DataGrid1")+1
     ind4 = cvs.index("DataGrid4")+1
     dgv.select_row(ind1)
@@ -406,8 +406,8 @@ EOL
     go_to_xyz_rules
     wait_for_ajax
 
-    names = xrv.col_values(:name, 5, 0)
-    gvs = xrv.col_values(:grids, 5, 0)
+    names = xrv.get_col_vals(:name, 5, 0)
+    gvs = xrv.get_col_vals(:grids, 5, 0)
     g1h = {"grid1"=>"DataGrid1 new"}
     expect(JSON.parse(gvs[names.index("ZRule1")])).to eq(g1h)
     expect(JSON.parse(gvs[names.index("ZRule2")])).to eq(g1h)
@@ -415,14 +415,14 @@ EOL
     go_to_my_rules
     wait_for_ajax
 
-    names = mrv.col_values(:name, 9, 0)
-    gvs = mrv.col_values(:grids, 9, 0)
-    rvs = mrv.col_values(:results, 9, 0)
+    names = mrv.get_col_vals(:name, 9, 0)
+    gvs = mrv.get_col_vals(:grids, 9, 0)
+    rvs = mrv.get_col_vals(:results, 9, 0)
     expect(JSON.parse(gvs[names.index('abc')])).to eq(g1h)
     expect(JSON.parse(gvs[names.index('Rule2b')])).to eq(g1h +
                                                          {"grid2"=>"DataGrid2"})
     expect(JSON.parse(rvs[names.index('Rule5')])["other_grid"]).to eq(
-                                                               '"DataGrid4 new"')
+                                                                     '"DataGrid4 new"')
 
   end
 end

data/spec/features/user_view_spec.rb

@@ -33,6 +33,8 @@ feature 'under Sytem menu, User Management worflows', js: true do
 
   it 'marty user can add/edit but not delete users' do
     log_in_as('marty')
+    wait_for_ajax
+
     go_to_user_view
 
     user_view = netzke_find('user_view')

data/spec/lib/logger_spec.rb

@@ -68,7 +68,7 @@ module Marty
 
       # Needed here because shutting transactional fixtures off
       # means we lose the globally set user
-      Mcfly.whodunnit = UserHelpers.system_user
+      Mcfly.whodunnit = system_user
 
       Marty::Script.load_script_bodies(promise_bodies, Date.today)
       start_delayed_job

data/spec/models/event_spec.rb

@@ -12,7 +12,7 @@ describe Marty::Event do
 
     # Needed here because shutting transactional fixtures off
     # means we lose the globally set user
-    Mcfly.whodunnit = UserHelpers.system_user
+    Mcfly.whodunnit = system_user
 
     Marty::Script.load_script_bodies(promise_bodies, Date.today)
     start_delayed_job

data/spec/models/promise_spec.rb

@@ -10,7 +10,7 @@ describe Marty::Promise, slow: true do
 
     # Needed here because shutting transactional fixtures off
     # means we lose the globally set user
-    Mcfly.whodunnit = UserHelpers.system_user
+    Mcfly.whodunnit = system_user
 
     Marty::Script.load_script_bodies(promise_bodies, Date.today)
 

data/spec/models/user_spec.rb

@@ -4,11 +4,11 @@ module Marty
   describe User do
     before(:each) do
       Rails.configuration.marty.system_account =
-        UserHelpers.system_user.login
+        system_user.login
     end
 
     let (:tuser) {
-      UserHelpers.create_user('other_user')
+      create_user('other_user')
     }
 
     describe "validations" do
@@ -22,7 +22,7 @@ module Marty
 
       it "should require unique login" do
         expect(Mcfly.whodunnit).to_not be_nil
-        user = UserHelpers.system_user.dup
+        user = system_user.dup
         expect(user).to_not be_valid
         expect(user.errors[:login].to_s).to include('already been taken')
         user.login = 'marty2'
@@ -30,7 +30,7 @@ module Marty
       end
 
       it "should not allow Gemini account to be de-activated" do
-        user = UserHelpers.system_user
+        user = system_user
         user.active = false
         expect(user).to_not be_valid
         expect(user.errors[:base].to_s).
@@ -38,14 +38,14 @@ module Marty
       end
 
       it "should not allow accounts to be deleted" do
-        user = UserHelpers.system_user
+        user = system_user
         user.destroy
         expect(user.destroyed?).to be false
       end
 
       it "should not allow user managers to edit the Gemini account" do
         Mcfly.whodunnit = tuser
-        user = UserHelpers.system_user
+        user = system_user
         allow_any_instance_of(Marty::User).to receive(:user_manager_only).
           and_return(true)
         user.firstname = 'Testing'

data/spec/spec_helper.rb

@@ -3,67 +3,22 @@ ENV["RAILS_ENV"] ||= "test"
 require 'dummy/config/application'
 require 'rspec/rails'
 require 'database_cleaner'
-require 'marty_rspec'
+
+support = Pathname.new(__FILE__).parent.to_s + '/support'
+require "#{support}/suite"
+require "#{support}/shared_connection"
 
 Dummy::Application.initialize! unless Dummy::Application.initialized?
 
 ActiveRecord::Migrator.migrate File.expand_path("../../db/migrate/", __FILE__)
 ActiveRecord::Migrator.migrate File.expand_path("../dummy/db/migrate/", __FILE__)
 
-Dir[Rails.root.join("../support/**/*.rb")].each { |f| require f }
-
-def register_chrome_driver driver = :chrome, options={}
-  Capybara.register_driver driver do |app|
-    caps = Selenium::WebDriver::Remote::Capabilities.
-             chrome(options + {pageLoadStrategy: 'none'})
-
-    Capybara::Selenium::Driver.new(app,
-                                   browser: :chrome,
-                                   desired_capabilities: caps)
-  end
-end
-
-CLASSES_TO_EXCLUDE_FROM_SHARED = ["Marty::Log"]
-class ActiveRecord::Base
-  mattr_accessor :shared_connection
-  class << self
-    alias_method :orig_connection, :connection
-  end
-  def self.clear_connection
-    @@shared_connection = nil
-  end
-
-  clear_connection
-
-  def self.connection
-    CLASSES_TO_EXCLUDE_FROM_SHARED.include?(model_name) ? orig_connection :
-      @@shared_connection ||
-      ConnectionPool::Wrapper.new(:size => 1) {retrieve_connection}
-  end
-
-  def self.reset_shared_connection
-    @@shared_connection = ConnectionPool::Wrapper.
-                            new(:size => 1) {retrieve_connection}
-  end
-end
-
-register_chrome_driver(:chrome, chromeOptions: { args: %w[start-maximized]})
-register_chrome_driver(:headless,
-                       chromeOptions: {
-                         args: %w[headless disable-gpu window-size=3840,2160]
-                       })
-
-Capybara.javascript_driver = ENV['HEADLESS'] == 'true' ? :headless : :chrome
-
-ActiveRecord::Base.shared_connection = ActiveRecord::Base.connection
-
 RSpec.configure do |config|
-  config.include DelayedJobHelpers
-  config.include CleanDbHelpers
-  config.include SpecSetup
-  config.include Marty::IntegrationHelpers
-  config.include MartyRSpec::Util
+  config.include Marty::RSpec::Suite
+  config.include Marty::RSpec::SharedConnection
+  config.include Marty::RSpec::SharedConnectionDbHelpers
 
+  #RspecMarty::SharedConnection.classes_to_exclude_shared = ['Marty::Log']
   Capybara.default_max_wait_time = 3
 
   # TODO: Continue to remove should syntax from specs - remove this line to see
@@ -83,7 +38,7 @@ RSpec.configure do |config|
   end
 
   config.before(:each) do
-    Mcfly.whodunnit = UserHelpers.system_user
+    marty_whodunnit
   end
 
   config.after(:each, :js => true) do |example|
@@ -102,19 +57,4 @@ RSpec.configure do |config|
   config.use_transactional_fixtures = true
 
   Netzke::Testing.rspec_init(config)
-
-  # FIXME: temporary monkey patch to fix marty_rspec for new extjs/rails
-  module MartyRSpec
-    module Components
-      class NetzkeGrid
-        def get_row_vals row
-          res = run_js <<-JS
-          #{ext_var(grid, 'grid')}
-          return Ext.encode(#{ext_row(row.to_i - 1, 'grid')}.data);
-          JS
-          JSON.parse(res)
-        end
-      end
-    end
-  end
 end