marty 13.0.2 → 14.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9af04e8e76cf3023af1aa02e26000f68ecfe47ded9811345921b01a266a79e8f
-  data.tar.gz: 4846444b2028e4f757082647c453cae88e6d034e1eea15c4b14eadee0eedb632
+  metadata.gz: 268b89d12df4e9698333655172962a7ae5cdb083298bbf3260d5e9314527a4cf
+  data.tar.gz: 033e4df522a0627af012eb84174cbad90e556e055a0a0d29383dd33dc13aa65f
 SHA512:
-  metadata.gz: 590a21ed0061f1a29fc294f5600ce409c2f0c762f481373a42552559c20f5f8ea2149b213afe38c3dfae46a532f180ab8853aaf65dc96a338283f04291973eec
-  data.tar.gz: ad4a62998ce1d912205c118c8403cf5ef008a29e60427871fd75b595631b5ab4309460e6ebd4619459cd9b028e10d64daf98c2190cd52ef724c0c1c7ecffce2f
+  metadata.gz: b936825cf18110a8a02691a02f35a1c8c74eb655d1ceed88600d16e2aeb8543cdb7d4e5d36fe026a0d9947d15a556cee7b4c0e6518878ddf90f7de792633d6a8
+  data.tar.gz: 9d447d0881e640da79cdbcdbce23d9ce01ab851722c8decde17d944f48e3fd5799df4ed35ee04aa983c083741cf9b391b512b343fd3d5cee8dc7839b3b3b2488

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-11-28 17:01:18 -0800 using RuboCop version 0.77.0.
+# on 2020-04-20 09:29:13 -0700 using RuboCop version 0.81.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -14,20 +14,19 @@ Layout/ClosingHeredocIndentation:
     - 'spec/support/components/netzke_combobox.rb'
     - 'spec/support/components/netzke_grid.rb'
 
-# Offense count: 56
+# Offense count: 54
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
 # SupportedStylesAlignWith: keyword, variable, start_of_line
 Layout/EndAlignment:
   Enabled: false
 
-# Offense count: 29
+# Offense count: 24
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
 Layout/ExtraSpacing:
   Exclude:
     - 'app/components/marty/data_grid_view.rb'
-    - 'app/components/marty/posting_window.rb'
     - 'lib/marty/migrations.rb'
     - 'lib/marty/monkey.rb'
     - 'spec/controllers/rpc_controller_spec.rb'
@@ -50,7 +49,7 @@ Layout/FirstHashElementIndentation:
     - 'spec/lib/json_schema_spec.rb'
     - 'spec/models/api_auth_spec.rb'
 
-# Offense count: 394
+# Offense count: 391
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
 # SupportedHashRocketStyles: key, separator, table
@@ -59,7 +58,7 @@ Layout/FirstHashElementIndentation:
 Layout/HashAlignment:
   Enabled: false
 
-# Offense count: 95
+# Offense count: 96
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: squiggly, active_support, powerpack, unindent
@@ -81,19 +80,18 @@ Layout/HeredocIndentation:
     - 'spec/models/data_grid_spec.rb'
     - 'spec/models/script_spec.rb'
 
-# Offense count: 283
+# Offense count: 268
 # Cop supports --auto-correct.
 # Configuration parameters: Width, IgnoredPatterns.
 Layout/IndentationWidth:
   Enabled: false
 
-# Offense count: 19
+# Offense count: 18
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: symmetrical, new_line, same_line
 Layout/MultilineHashBraceLayout:
   Exclude:
-    - 'app/components/marty/user_view.rb'
     - 'app/models/marty/delorean_rule.rb'
     - 'lib/marty/migrations.rb'
     - 'lib/marty/schema_helper.rb'
@@ -101,14 +99,14 @@ Layout/MultilineHashBraceLayout:
     - 'spec/lib/json_schema_spec.rb'
     - 'spec/other/diagnostic/base_spec.rb'
 
-# Offense count: 115
+# Offense count: 119
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: symmetrical, new_line, same_line
 Layout/MultilineMethodCallBraceLayout:
   Enabled: false
 
-# Offense count: 96
+# Offense count: 107
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: aligned, indented, indented_relative_to_receiver
@@ -123,7 +121,7 @@ Layout/MultilineMethodDefinitionBraceLayout:
   Exclude:
     - 'lib/marty/data_importer.rb'
 
-# Offense count: 17
+# Offense count: 22
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: aligned, indented
@@ -140,13 +138,6 @@ Layout/MultilineOperationIndentation:
     - 'spec/models/script_spec.rb'
     - 'spec/support/shared_connection.rb'
 
-# Offense count: 11
-# Cop supports --auto-correct.
-# Configuration parameters: IndentationWidth.
-Layout/Tab:
-  Exclude:
-    - 'app/components/marty/posting_window.rb'
-
 # Offense count: 1
 Lint/AmbiguousBlockAssociation:
   Exclude:
@@ -233,7 +224,7 @@ Lint/ShadowingOuterLocalVariable:
     - 'lib/marty/diagnostic/database.rb'
     - 'lib/marty/json_schema.rb'
 
-# Offense count: 5
+# Offense count: 4
 # Configuration parameters: AllowComments.
 Lint/SuppressedException:
   Exclude:
@@ -264,7 +255,7 @@ Lint/UselessAccessModifier:
     - 'lib/marty/diagnostic/reporter.rb'
     - 'lib/marty/json_schema.rb'
 
-# Offense count: 105
+# Offense count: 111
 Lint/UselessAssignment:
   Enabled: false
 
@@ -278,20 +269,24 @@ Lint/Void:
     - 'spec/lib/xl_styles_spec.rb'
     - 'spec/models/posting_spec.rb'
 
-# Offense count: 105
+# Offense count: 113
+# Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
   Max: 129
 
 # Offense count: 22
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 452
+  Max: 500
+  Exclude:
+    - 'app/models/marty/data_grid.rb'
 
-# Offense count: 66
+# Offense count: 68
+# Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
   Max: 40
 
-# Offense count: 170
+# Offense count: 177
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 98
@@ -306,7 +301,8 @@ Metrics/ModuleLength:
 Metrics/ParameterLists:
   Max: 10
 
-# Offense count: 50
+# Offense count: 54
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
   Max: 35
 
@@ -332,7 +328,7 @@ Naming/HeredocDelimiterCase:
     - 'spec/controllers/rpc_controller_spec.rb'
     - 'spec/models/script_spec.rb'
 
-# Offense count: 67
+# Offense count: 68
 # Configuration parameters: ForbiddenDelimiters.
 # ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
@@ -348,9 +344,9 @@ Naming/HeredocDelimiterNaming:
     - 'spec/lib/xl_styles_spec.rb'
     - 'spec/models/data_grid_spec.rb'
 
-# Offense count: 150
+# Offense count: 155
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db, os
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
 Naming/MethodParameterName:
   Enabled: false
 
@@ -422,7 +418,7 @@ Performance/RedundantMatch:
   Exclude:
     - 'lib/marty/migrations.rb'
 
-# Offense count: 4
+# Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: MaxKeyValuePairs.
 Performance/RedundantMerge:
@@ -430,7 +426,6 @@ Performance/RedundantMerge:
     - 'app/components/marty/api_config_view.rb'
     - 'app/components/marty/base_rule_view.rb'
     - 'app/components/marty/data_grid_view.rb'
-    - 'app/components/marty/user_view.rb'
 
 # Offense count: 21
 # Cop supports --auto-correct.
@@ -453,13 +448,12 @@ Performance/TimesMap:
   Exclude:
     - 'spec/models/data_grid_spec.rb'
 
-# Offense count: 7
+# Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: prefer_alias, prefer_alias_method
 Style/Alias:
   Exclude:
-    - 'app/models/marty/vw_promise.rb'
     - 'lib/marty/monkey.rb'
     - 'lib/marty/promise_proxy.rb'
     - 'spec/support/components/netzke_grid.rb'
@@ -487,7 +481,7 @@ Style/BarePercentLiterals:
     - 'spec/models/config_spec.rb'
     - 'spec/support/netzke.rb'
 
-# Offense count: 132
+# Offense count: 125
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
@@ -549,7 +543,7 @@ Style/ConditionalAssignment:
     - 'spec/support/components/netzke_combobox.rb'
     - 'spec/support/components/netzke_grid.rb'
 
-# Offense count: 189
+# Offense count: 195
 Style/Documentation:
   Enabled: false
 
@@ -621,14 +615,14 @@ Style/FormatStringToken:
     - 'spec/models/rule_spec.rb'
     - 'spec/support/performance_helper.rb'
 
-# Offense count: 248
+# Offense count: 260
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, never
+# SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-# Offense count: 15
+# Offense count: 16
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Exclude:
@@ -656,11 +650,10 @@ Style/IfInsideElse:
   Exclude:
     - 'lib/marty/data_change.rb'
 
-# Offense count: 5
+# Offense count: 4
 # Cop supports --auto-correct.
 Style/IfUnlessModifier:
   Exclude:
-    - 'app/components/marty/promise_view.rb'
     - 'app/models/marty/promise.rb'
     - 'app/models/marty/token.rb'
 
@@ -683,7 +676,7 @@ Style/InverseMethods:
     - 'lib/marty/xl.rb'
     - 'spec/support/download_helper.rb'
 
-# Offense count: 27
+# Offense count: 28
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: line_count_dependent, lambda, literal
@@ -702,11 +695,10 @@ Style/Lambda:
     - 'spec/lib/xl_styles_spec.rb'
     - 'spec/support/shared_connection.rb'
 
-# Offense count: 23
+# Offense count: 20
 # Cop supports --auto-correct.
 Style/LineEndConcatenation:
   Exclude:
-    - 'app/components/marty/posting_grid.rb'
     - 'app/controllers/marty/application_controller.rb'
     - 'lib/marty/data_change.rb'
     - 'lib/marty/data_importer.rb'
@@ -748,7 +740,7 @@ Style/MissingRespondToMissing:
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, Autocorrect.
-# SupportedStyles: module_function, extend_self
+# SupportedStyles: module_function, extend_self, forbidden
 Style/ModuleFunction:
   Exclude:
     - 'spec/support/download_helper.rb'
@@ -762,13 +754,12 @@ Style/MultilineBlockChain:
     - 'lib/marty/migrations.rb'
     - 'lib/marty/xl.rb'
 
-# Offense count: 21
+# Offense count: 20
 # Cop supports --auto-correct.
 Style/MultilineIfModifier:
   Exclude:
     - 'app/components/marty/api_log_view.rb'
     - 'app/components/marty/script_form.rb'
-    - 'app/components/marty/user_view.rb'
     - 'app/models/marty/base_rule.rb'
     - 'app/models/marty/data_grid.rb'
     - 'app/models/marty/delorean_rule.rb'
@@ -789,21 +780,20 @@ Style/MultipleComparison:
     - 'app/components/marty/base_rule_view.rb'
     - 'lib/marty/xl.rb'
 
-# Offense count: 79
+# Offense count: 84
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: literals, strict
 Style/MutableConstant:
   Enabled: false
 
-# Offense count: 15
+# Offense count: 14
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: both, prefix, postfix
 Style/NegatedIf:
   Exclude:
     - 'app/components/marty/data_grid_view.rb'
-    - 'app/components/marty/promise_view.rb'
     - 'app/components/marty/script_grid.rb'
     - 'app/components/marty/script_tester.rb'
     - 'app/components/marty/tag_grid.rb'
@@ -850,18 +840,6 @@ Style/Next:
 Style/NumericLiterals:
   MinDigits: 7
 
-# Offense count: 16
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
-# SupportedStyles: predicate, comparison
-Style/NumericPredicate:
-  Exclude:
-    - 'spec/**/*'
-    - 'lib/marty/content_handler.rb'
-    - 'lib/marty/data_change.rb'
-    - 'lib/marty/data_importer.rb'
-    - 'lib/marty/xl.rb'
-
 # Offense count: 39
 # Cop supports --auto-correct.
 Style/ParallelAssignment:
@@ -922,7 +900,7 @@ Style/RegexpLiteral:
     - 'lib/marty/monkey.rb'
     - 'lib/marty/xl.rb'
 
-# Offense count: 35
+# Offense count: 34
 # Cop supports --auto-correct.
 Style/RescueModifier:
   Enabled: false
@@ -957,7 +935,7 @@ Style/Semicolon:
     - 'spec/controllers/rpc_controller_spec.rb'
     - 'spec/support/helper.rb'
 
-# Offense count: 2
+# Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: .
 # SupportedStyles: use_perl_names, use_english_names
@@ -978,7 +956,7 @@ Style/StructInheritance:
     - 'lib/marty/promise_job.rb'
     - 'lib/marty/promise_ruby_job.rb'
 
-# Offense count: 3
+# Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, AllowSafeAssignment.
 # SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
@@ -987,40 +965,40 @@ Style/TernaryParentheses:
     - 'app/models/marty/data_grid.rb'
     - 'lib/marty/xl.rb'
 
-# Offense count: 39
+# Offense count: 38
 # Cop supports --auto-correct.
 Style/TrailingBodyOnModule:
   Enabled: false
 
-# Offense count: 71
+# Offense count: 80
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
 Style/TrailingCommaInArguments:
   Enabled: false
 
-# Offense count: 55
+# Offense count: 53
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
 Style/TrailingCommaInArrayLiteral:
   Enabled: false
 
-# Offense count: 148
+# Offense count: 150
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
 Style/TrailingCommaInHashLiteral:
   Enabled: false
 
-# Offense count: 94
+# Offense count: 102
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, MinSize, WordRegex.
 # SupportedStyles: percent, brackets
 Style/WordArray:
   Enabled: false
 
-# Offense count: 149
+# Offense count: 159
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https

data/CHANGELOG.md

@@ -1,3 +1,22 @@
+14.0.0 - 2020-04-28
+=====================================================
+* Adds NULL support for data grid matchers:
+Adds strict_null_mode field to Marty::DataGrids
+In non strict mode passed nil attribute is now treated the same way is missing: it matches everything.
+All existing grids are in non strict_null_mode by default
+In strict mode it would only match wildcards and keys with NULL value
+NULL can be combined with other values in array
+
+* DataGrid's PLPGSQL lookups are no longer supported
+
+13.1.0 - 2020-04-14
+=====================
+* Use ruby for Marty::DataGrid lookups. That gives a small performance boost and simplifies the code.
+
+Use `Rails.application.config.marty.data_grid_plpg_lookups = true` if
+you want to continue using PLPG for lookups. That can be deprecated in
+future
+
 13.0.2 - 2020-04-14
 =================
 * Use VARCHAR without size limit instead of recently added TEXT columns, since default field for TEXT column is textarea.
@@ -6,6 +25,13 @@
 =================
 * Add missing index by `posting_type` for `marty_postings` table.
 
+13.0.0 - 2020-04-13
+======================
+
+* All VARCHAR column types changed to TEXT
+
+* Added schema linter
+
 12.0.0 - 2020-04-02
 =================
 * Marty::PostingType converted to PgEnum. AR methods (find_by, all, etc...) will no longer work.