marty 0.5.34 → 0.5.35

data/spec/features/reporting_spec.rb

@@ -0,0 +1,242 @@
+require 'spec_helper'
+
+feature 'under Applications menu, Reports workflows', js: true do
+  before(:all) do
+    SOME_DATE = "20130520"
+    SOME_TIME = "1200"
+    SOME_DT   = "#{SOME_DATE} #{SOME_TIME} PST8PDT"
+    @clean_file = "/tmp/clean_#{Process.pid}.psql"
+    save_clean_db(@clean_file)
+
+    populate_test_users
+    populate_sample_reports
+    custom_selectors
+  end
+
+  after(:all) do
+    restore_clean_db(@clean_file)
+  end
+
+  def go_to_reporting
+    press('Applications')
+    press('Reports')
+  end
+
+  def with_user(uname, &block)
+    u = Marty::User.find_by_login(uname)
+    begin
+      old_u, Mcfly.whodunnit = Mcfly.whodunnit, u
+      block.call(u)
+    ensure
+      Mcfly.whodunnit = old_u
+    end
+  end
+
+  def populate_sample_reports
+    a_report  = <<DELOREAN
+PostingField:
+    field_label = "Posting"
+    xtype       = ":combo"
+    name        = "pt_name"
+    store       = [lp.name for lp in Marty::Posting.get_latest(10)]
+
+RateField:
+    field_label = "Note Rate"
+    xtype       = ":numberfield"
+    name        = "note_rate"
+
+AA:
+    title   = "AA"
+    pt_name =?
+    res1    = [pt_name + i.to_s() for i in [1,2,3,4]]
+    res2    = [res1] + [[a, a*2, a*3, a*4] for a in [1,2,3,4]]
+
+    form = [
+        PostingField,
+        ]
+
+    result = res2
+    format = "csv"
+
+BB:
+    title = "BB"
+    form = [ RateField ]
+
+    # Should not see this as a report since result is misspelled
+    resultx = 456
+    format = "csv"
+
+DD: BB
+    # has valid role, should be displayed in nodename combo
+    roles = ["dev"]
+    title = "DD [role: dev]"
+    background_only = true
+
+    result = 444
+DELOREAN
+
+    with_user("dev1") { |u|
+      Marty::Posting.do_create('BASE', SOME_DT, 'a comment')
+
+      Marty::Script.
+        load_script_bodies({ "SomeReport" => a_report, },
+                           Date.today)
+
+      Marty::Script.
+        load_script_bodies({ "SomeReport" =>
+                             a_report +
+                             "CC: BB\n    title=\"CC\"\n    result = 123" },
+                           Date.today + 1.minute)
+    }
+  end
+
+  let(:tg) { gridpanel('tag_grid') }
+  let(:sg) { gridpanel('script_grid') }
+  let(:rf) { gridpanel('report_form') }
+
+  def select_node node_name
+    wait_for_ajax
+    #hacky: assumes only 1 combobox without label
+    within(:gridpanel, 'report_select', match: :first) do
+      # hacky, hardcoding netzkecombobox dropdown arrow name
+      arrow = find(:input, 'nodename')['componentid'] + '-trigger-picker'
+      find(:xpath, ".//div[@id='#{arrow}']").click
+      find(:xpath, "//li[text()='#{node_name}']").click
+    end
+  end
+
+  it 'run_script displays proper data' do
+    log_in_as('dev1')
+    go_to_reporting
+
+    by 'select 2nd tag' do
+      wait_for_ajax
+      zoom_out(tg)
+      select_row(2, tg)
+    end
+
+    and_by 'select SomeReport script & CC node' do
+      select_row(1, sg)
+      select_node('CC (csv)')
+    end
+
+     and_by 'fill form' do
+      wait_for_ajax
+
+      within(:gridpanel, 'report_form', match: :first) do
+        fill_in('Note Rate', with: '3.00')
+      end
+    end
+
+    and_by 'do Background Report with delayed jobs' do
+      Delayed::Worker.delay_jobs = false
+      press('Background Report')
+      wait_for_ajax
+      Delayed::Worker.delay_jobs = true
+    end
+
+    and_by 'select AA node' do
+      select_node('AA (csv)')
+    end
+
+    and_by 'validate posting combobox' do
+      wait_for_ajax
+      expect(combobox_values('Posting')).to include('BASE-20130520-1200')
+    end
+
+    and_by 'select 3rd tag' do
+      select_row(3, tg)
+    end
+
+    and_by 'select SomeReport script' do
+      select_row(1, sg)
+    end
+
+    and_by 'validate script combobox' do
+      expect(combobox_values('')).to include('AA (csv)',
+                                             'DD [role: dev] (csv)',
+                                             '---')
+    end
+
+    and_by 'select AA node' do
+      select_node('AA (csv)')
+    end
+
+    and_by 'validate posting comobox' do
+      wait_for_ajax
+      expect(combobox_values('Posting')).to include('BASE-20130520-1200')
+    end
+  end
+
+  it 'run_script generates CSV' do
+    log_in_as('dev1')
+    go_to_reporting
+
+    by 'select 2nd tag' do
+      wait_for_ajax
+      zoom_out(tg)
+      select_row(2, tg)
+    end
+
+    and_by 'select SomeReport script & AA node' do
+      select_row(1, sg)
+      select_node('AA (csv)')
+    end
+
+    and_by 'fill form' do
+      wait_for_ajax
+      set_field_value('XYZ', '', 'pt_name')
+      # hidden field that causes results to be inlined
+      set_field_value('true', 'textfield', 'selected_testing')
+      press("Generate Report")
+    end
+
+    wait_for_element do
+      expect(page).to have_content('XYZ1,XYZ2,XYZ3,XYZ4 1,2,3,4 2,4,6,8 ' +
+                                   '3,6,9,12 4,8,12,16')
+    end
+  end
+
+  it 'report screen handles security roles properly - enabled' do
+    log_in_as('dev1')
+    go_to_reporting
+
+    by 'select 2nd tag' do
+      wait_for_ajax
+      zoom_out(tg)
+      select_row(2, tg)
+    end
+
+    and_by 'select SomeReport script & AA node' do
+      select_row(1, sg)
+      select_node('DD [role: dev] (csv)')
+    end
+
+    and_by 'generate report disabled' do
+      fill_in('Note Rate', with: '3.00')
+      expect(btn_disabled?('Generate Report', rf)).to be_truthy
+      expect(btn_disabled?('Background Report', rf)).to be_falsy
+    end
+  end
+
+  it 'report screen handles security roles properly - disabled' do
+    log_in_as('viewer1')
+    go_to_reporting
+
+    by 'select 2nd tag' do
+      wait_for_ajax
+      zoom_out(tg)
+      select_row(2, tg)
+    end
+
+    and_by 'select SomeReport script & AA' do
+      select_row(1, sg)
+    end
+
+    and_by 'no DD [role: dev] (csv)' do
+      expect(combobox_values('')).to include('AA (csv)',
+                                             'CC (csv)',
+                                             '---')
+    end
+  end
+end

data/spec/features/scripting_spec.rb

@@ -0,0 +1,308 @@
+require 'spec_helper'
+
+feature 'under Applications menu, Scripting workflows', js: true do
+
+  before(:all) do
+    self.use_transactional_fixtures = false
+
+    @clean_file = "/tmp/clean_#{Process.pid}.psql"
+    save_clean_db(@clean_file)
+
+    custom_selectors
+  end
+
+  before(:each) do
+    populate_test_users
+    populate_test_scripts
+  end
+
+  after(:each) do
+    restore_clean_db(@clean_file, false)
+  end
+
+  after(:all) do
+    restore_clean_db(@clean_file)
+    self.use_transactional_fixtures = true
+  end
+
+  def go_to_scripting
+    press('Applications')
+    press('Scripting')
+  end
+
+  def with_user(uname, &block)
+    u = Marty::User.find_by_login(uname)
+    begin
+      old_u, Mcfly.whodunnit = Mcfly.whodunnit, u
+      block.call(u)
+    ensure
+      Mcfly.whodunnit = old_u
+    end
+  end
+
+  def populate_test_scripts
+    lastid = nil
+
+    with_user("dev2") {
+
+      Marty::Script.
+        load_script_bodies({
+                             "A1" => "#1\n",
+                             "A2" => "#2\n",
+                             "A3" => "#3\n",
+                             "A4" => "#4\n",
+                             "A5" => "#5\n",
+                           }, Date.today)
+
+      # create 3 additional tags and modify A5 in the process
+      (1..3).each { |i|
+        body = Marty::Script.find_script("A5").body
+
+        Marty::Script.
+          load_script_bodies({
+                               "A5" => body + "##{i}\n"
+                             }, Date.today + i.minute)
+      }
+    }
+  end
+
+  let(:tg) { gridpanel('tag_grid') }
+  let(:sg) { gridpanel('script_grid') }
+  let(:sf) { gridpanel('script_form') }
+
+  it 'adding scripts and tags & ensure proper validations' do
+    log_in_as('dev1')
+    go_to_scripting
+
+    by 'select DEV tag' do
+      wait_for_ajax
+      select_row(1, tg)
+    end
+
+    and_by 'add script' do
+      press('New Script')
+      within(:gridpanel, 'add_window', match: :first) do
+        fill_in('Name', with: 'Xyz')
+        press('OK')
+      end
+    end
+
+    and_by 'select the new script' do
+      wait_for_ajax
+      within(:gridpanel, 'script_grid', match: :first) do
+        validate_row_values(6, sg, name: 'Xyz', tag: 'DEV')
+        select_row(6, sg)
+      end
+    end
+
+    and_by 'fill script body' do
+      wait_for_ajax
+      within(:gridpanel, 'script_form', match: :first) do
+        set_field_value('###', '', 'body')
+        press('Save')
+      end
+    end
+
+    and_by 'new script body shows up' do
+      expect(page).to have_content '###'
+    end
+
+    and_by 'add new tag' do
+      press('New Tag')
+      within(:gridpanel, 'add_window', match: :first) do
+        fill_in('Comment', with: 'This is my log')
+        press('OK')
+      end
+    end
+
+    and_by 'new tag shows up' do
+      wait_for_ajax
+      within(:gridpanel, 'tag_grid', match: :first) do
+        expect(row_count(tg)).to eq 6
+      end
+    end
+
+    and_by 'tag row 2 has 6 scripts' do
+      select_row(2, tg)
+      wait_for_ajax
+      expect(row_count(sg)).to eq 6
+    end
+
+    and_by 'tag row 3 has 5 scripts' do
+      select_row(3, tg)
+      wait_for_ajax
+      expect(row_count(sg)).to eq 5
+    end
+  end
+
+  it 'add a script with invalid names, no scripts get added' do
+    log_in_as('dev1')
+    go_to_scripting
+
+    by 'select DEV tag' do
+      wait_for_ajax
+      select_row(1, tg)
+    end
+
+    and_by 'add script with duplicate name' do
+      press('New Script')
+      within(:gridpanel, 'add_window', match: :first) do
+        fill_in('Name', with: 'A1')
+        press('OK')
+        expect(find(:msg)).to have_content 'Name - record must be unique'
+      end
+    end
+
+    and_by 'add script with number name' do
+      within(:gridpanel, 'add_window', match: :first) do
+        fill_in('Name', with: '123')
+        press('OK')
+        expect(find(:msg)).to have_content 'Name must be capitalized'
+        press('Cancel')
+      end
+    end
+
+    and_by 'no script got added' do
+      wait_for_ajax
+      expect(row_count(sg)).to eq 5
+    end
+  end
+
+  it 'has proper access controls (viewer/anon users)' do
+    log_in_as('anon')
+    # no nav buttons available, but check direct access
+    ensure_on('/#scripting')
+
+    by 'nothing should work & log out' do
+      wait_for_ajax
+      expect(row_count(sg)).to eq 0
+      expect(row_count(tg)).to eq 0
+      expect(btn_disabled?('New Script', sg)).to be_truthy
+      expect(btn_disabled?('New Tag', tg)).to be_truthy
+      log_out
+    end
+
+    and_by 'log in as viewer1' do
+      log_in_as('viewer1')
+      go_to_scripting
+    end
+
+    and_by 'viewable but cannot add scripts or tags' do
+      wait_for_ajax
+      expect(row_count(sg)).to eq 5
+      select_row(1, tg)
+      wait_for_ajax
+      expect(btn_disabled?('New Script', sg)).to be_truthy
+      expect(btn_disabled?('New Tag', tg)).to be_truthy
+      select_row(4, tg)
+      wait_for_ajax
+      expect(row_count(sg)).to eq 5
+      expect(btn_disabled?('Save', sf)).to be_truthy
+    end
+  end
+
+  it 'selects different scripts & shows correct details' do
+    log_in_as('dev1')
+    go_to_scripting
+
+    by 'select tag row 2' do
+      wait_for_ajax
+      select_row(2, tg)
+    end
+
+    and_by 'select script row 5' do
+      wait_for_ajax
+      select_row(5, sg)
+    end
+
+    and_by 'form displays correct body' do
+      wait_for_ajax
+      expect(page).to have_content "#5\n#1\n#2\n#3\n"
+    end
+
+    and_by 'select different tag' do
+      select_row(4, tg)
+    end
+
+    and_by 'select script row 5' do
+      wait_for_ajax
+      select_row(5, sg)
+    end
+
+    and_by 'form displays updated body' do
+      wait_for_ajax
+      expect(page).to have_content "#5\n#1\n"
+    end
+  end
+
+  it 'saving an edited script' do
+    log_in_as('dev1')
+    go_to_scripting
+
+    by 'select DEV tag' do
+      wait_for_ajax
+      select_row(1, tg)
+    end
+
+    and_by 'select script row 5' do
+      wait_for_ajax
+      select_row(5, sg)
+    end
+
+    and_by 'edit script form body' do
+      wait_for_ajax
+      within(:gridpanel, 'script_form', match: :first) do
+        set_field_value('#123\n#456\n', '', 'body')
+        press('Save')
+      end
+    end
+
+    and_by 'new script does not exist in old tag' do
+      wait_for_ajax
+      select_row(2, tg)
+      # FIX?  selection change required to refresh script form
+      select_row(1, sg)
+      select_row(5, sg)
+      wait_for_ajax
+      expect(page).not_to have_content "#123\n#456\n"
+      select_row(1, sg)
+    end
+
+    and_by 'make new tag' do
+      press('New Tag')
+      within(:gridpanel, 'add_window', match: :first) do
+        fill_in('Comment', with: 'ABCD')
+        press('OK')
+      end
+    end
+
+    and_by 'new tag contains new script' do
+      wait_for_ajax
+      select_row(2, tg)
+      wait_for_ajax
+      select_row(5, sg)
+      expect(page).to have_content "#123\n#456\n"
+      expect(validate_row_values(2, tg, comment: 'ABCD')).to be_truthy
+    end
+  end
+
+  it 'checking in without changes does not modify history' do
+    log_in_as('dev1')
+    go_to_scripting
+
+    by 'select DEV tag' do
+      wait_for_ajax
+      select_row(1, tg)
+    end
+
+    and_by 'select script row 1' do
+      wait_for_ajax
+      select_row(1, sg)
+    end
+
+    and_by 'save without changes' do
+      press('Save')
+      expect(find(:msg)).to have_content 'no save needed'
+    end
+  end
+end