markety 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 38cc31c8cd2077f0868313952b394f8c47712512
-  data.tar.gz: 9016bdefb8cd7d9aaec957379d90004e02d02952
+  metadata.gz: b1347cb773faa75e338f11502d21809049000dd0
+  data.tar.gz: 24b107c2113c0b2584f2d640bbe470025f8817ca
 SHA512:
-  metadata.gz: 29ab1101e22a4cfde02a7e7ff879e2ecd15cfe74426057a20b6d48bc865a1b71b275fcf39dd33d882532b477ca9056f43262bae062ee94bd726a3f9af194414e
-  data.tar.gz: 13de0488f4d123ffa13dd63fcf8c70b3467b05a1829b2c837a4b19b99a49b6c7624b44144d0bb64e9dc30ba0b4ff3981a4c60721f1cedbe30cdf2417fbdd18eb
+  metadata.gz: 93d3ce0bab7a5663f01508adbab902a27529c8f92a48633aece92c9500a32f37a0914f5af7fe6b4199464ad10f973c758ed5b9b6da390a9a67133d6029a0b10b
+  data.tar.gz: a41153b4bb03266193dc9969db45fabdb85d362c3ce051bbd275928b582471ea12cc00212a6a571c471d95287beb0edfbe2c5f595062dde5dac91e0f572e8b5c

data/README.md

@@ -23,11 +23,15 @@ Instantiate a new Markety client using your Marketo SOAP endpoint, User ID, and
 ```ruby
 client = Markety::Client.new(USER_ID, ENCRYPTION_KEY, END_POINT)
 # or, if using a workspace:
-client = Markety.::Client.new(USER_ID, ENCRYPTION_KEY, END_POINT, target_workspace: "ws_name")
+client = Markety::Client.new(USER_ID, ENCRYPTION_KEY, END_POINT, target_workspace: "ws_name")
 ```
 
-You can get leads from Marketo by idnum or by email. Markety returns a ``GetLeadResponse`` object which contains an array of leads. Because Marketo allows for an email address to be tied to more than one lead, getting by email could
-potentially result in an array of leads with the same email address so you can call ``.leads`` to get all the leads in the array. Getting a lead by idnum will return a single lead, however because ``GetLeadResponse`` is an array of leads, you'll need to add ``.lead`` to get the lead from the response.
+You can get leads from Marketo by idnum or by email. Markety returns a ``GetLeadResponse``
+object which contains an array of leads.  Because Marketo allows for an email address to be
+tied to more than one lead, getting by email could potentially result in an array of leads
+with the same email address so you can call ``.leads`` to get all the leads in the array.
+Getting a lead by idnum will return a single lead, however because ``GetLeadResponse`` is
+an array of leads, you'll need to add ``.lead`` to get the lead from the response.
 ```ruby
 # By idnum
 lead = client.get_lead_by_idnum("123456").lead  # Single lead object (or nil)
@@ -45,7 +49,8 @@ lead.set_attribute("Email", "joe-schmoe@example.com")
 lead.set_attribute("Activated", true, "Boolean") # [1] see below
 ```
 
-Once you're ready to sync back, just tell Markety how you'd like it to sync. There are currently 3 supported methods, "EMAIL", "MARKETO_ID" and "FOREIGN_ID"
+Once you're ready to sync back, just tell Markety how you'd like it to sync.
+There are currently 3 supported methods, "EMAIL", "MARKETO_ID" and "FOREIGN_ID"
 ```
 # Sync the lead with Marketo
 response = client.sync_lead_record(lead, "EMAIL")
@@ -65,7 +70,8 @@ client.add_to_list('The_List_Name', lead.idnum).list_operation_status #true if s
 client.remove_from_list('The_List_Name', lead.idnum).list_operation_status #true if successful removal
 ```
 
-Lastly, if you would like to create a lead in Marketo, you can use the sync lead method the same way you would use the sync lead to update a lead. Just start by instantiating a Markety::Lead.
+Lastly, if you would like to create a lead in Marketo, you can use the sync lead method the same way
+you would use the sync lead to update a lead. Just start by instantiating a Markety::Lead.
 ```ruby
 new_lead = Markety::Lead.new
 new_lead.set_attribute("Email", "doge@suchemail.com")
@@ -80,7 +86,8 @@ _(Admin » Field Management » New Custom Field)_
 ##  Options
 
 ```ruby
-# Turn of Savon logging - logging is helpful during development, but outputs a lot of text which you may not want in production
+# Turn off Savon logging - logging is helpful during development,
+# but outputs a lot of text which you may not want in production
 client = Markety::Client.new(USER_ID, ENCRYPTION_KEY, END_POINT, { log: false })
 ```
 
@@ -94,13 +101,22 @@ PRs are very welcome! Feel free to send a PR for any endpoint you might need.
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
 
+###Dev hint:
+
+In `irb`, from this repo's root dir, this will load the Markety classes:
+
+    > $LOAD_PATH.unshift "./lib"
+    > require 'markety'
+
+
 ## To Do's
 1. More tests.
 2. Add campaign endpoints.
 
 ##  Marketo Lead REST API
 
-Marketo released a lead REST API on June 20, 2014 so be sure to check developers.marketo.com for another lead management integration possibility.
+Marketo released a lead REST API on June 20, 2014 so be sure to check developers.marketo.com
+for another lead management integration possibility.
 
 ## Authors
 David Santoso and [Grant Birchmeier](https://github.com/gbirchmeier).

data/lib/markety/lead.rb

@@ -13,6 +13,7 @@ module Markety
     end
 
     def ==(other)
+      other.is_a?(Lead) &&
       @attributes==other.send(:attributes) &&
       @idnum==other.idnum &&
       @email==other.email &&

data/lib/markety/version.rb

@@ -1,3 +1,3 @@
 module Markety
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end

data/spec/markety/lead_spec.rb

@@ -5,7 +5,6 @@ module Markety
   IDNUM    = 93480938
   
   
-
   describe Lead do
     it "should store the idnum" do
       lead_record = Lead.new(email:EMAIL, idnum:IDNUM)
@@ -25,7 +24,13 @@ module Markety
       lead_record2.set_attribute('favourite color', 'red')
       lead_record2.set_attribute('age', '100')
 
-      lead_record1.should == lead_record2
+      (lead_record1==lead_record2).should be true
+
+      lead_record2.set_attribute('age', '200')
+      (lead_record1==lead_record2).should be false
+
+      # issue 21
+      (lead_record1==123).should be false
     end
 
     it "should store when attributes are set" do
@@ -99,5 +104,6 @@ module Markety
 
       actual.should == expected
     end
+
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: markety
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - David Santoso