marketing_api 0.0.1 → 0.0.2

data/README.md

@@ -3,16 +3,9 @@ marketing_api_gem
 
 The gem is used as a remote API (using Net::HTTP) for the service called marketing (https://github.com/fess89/marketing). 
 
-Installation
-------------
-
-mkdir marketing_api_gem
-
-cd marketing_api_gem
-
-git clone https://github.com/fess89/marketing_api_gem .
-
-rake build
+Installation for production
+---------------------------
+gem install marketing_api
 
 Installation for testing
 ------------------------
@@ -22,19 +15,15 @@ cd marketing_api_gem
 
 git clone https://github.com/fess89/marketing_api_gem .
 
-Then alternatively:
-
-rake dev (this doesn't work for me)
-
-or 
+rake build
 
 gem install rspec
 
 gem install webmock
 
-rake build
-
-rake (this runs tests)
+Testing
+-------
+rake 
 
 
 

data/Rakefile

@@ -3,7 +3,7 @@ task :build do
 	#getting gem info
 	gemspec = eval(File.read("marketing_api.gemspec"))
 	system "gem build marketing_api.gemspec"
-	#system "gem install marketing_api-#{gemspec.version.to_s}.gem --no-ri --no-rdoc"
+	system "gem install marketing_api-#{gemspec.version.to_s}.gem --no-ri --no-rdoc"
 end
 
 #installation for development purposes

data/marketing_api.gemspec

@@ -2,29 +2,29 @@ $:.push File.expand_path("../lib", __FILE__)
 require 'marketing_api'
 
 Gem::Specification.new do |s|
-  	s.name          = 'marketing_api'
-  	s.version       = '0.0.1'
-  	s.date          = '2013-07-02'
-  	s.summary       = "Working with Marketing class by means of remote API"
-    	s.description   = "Test task given by Alexander Simonov"
-  	s.authors       = ["Oleksii Chyrkov"]
-  	s.email         = 'chyrkov@kth.se'
+  s.name          = 'marketing_api'
+  s.version       = '0.0.2'
+  s.date          = '2013-07-02'
+  s.summary       = "Working with Marketing class by means of remote API"
+  s.description   = "Test task given by Alexander Simonov"
+  s.authors       = ["Oleksii Chyrkov"]
+  s.email         = 'chyrkov@kth.se'
 	s.homepage      = ""
 	  
 	s.files         = `git ls-files`.split("\n")
-    	s.test_files    = `git ls-files -- spec/*`.split("\n")
-    	s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-    	s.require_paths = ["lib"]
+  s.test_files    = `git ls-files -- spec/*`.split("\n")
+  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  s.require_paths = ["lib"]
 
-  	s.license      = "MIT"
-  	s.platform     = Gem::Platform::RUBY
+  s.license      = "MIT"
+  s.platform     = Gem::Platform::RUBY
 
-  	#json is needed to interact with the remote API
-	s.add_runtime_dependency "json"
+  #json is needed to interact with the remote API
+  s.add_runtime_dependency "json"
 
-	#rspec is only for testing
-	s.add_development_dependency "rspec", "~> 2.13.0" 
+  #rspec is only for testing
+  s.add_development_dependency "rspec", "~> 2.13.0" 
 	
-	#so is webmock
-	s.add_development_dependency "webmock"
+  #so is webmock
+  s.add_development_dependency "webmock"
 end

data/spec/api_spec.rb

@@ -10,29 +10,35 @@ describe MarketingAPI, "#marketing_remote_api" do
 
 	success_reply = 
 	{
-		"id"=>21, "email"=>"chyrkov@kth.se", 
-		"mobile"=>"380632721593", "first_name"=>"Oleksii", 
-		"last_name"=>"Chyrkov", "permission_type"=>"one-time", 
-		"channel"=>"sms", "company_name"=>"Apple", 
-		"message"=>"Found optin", "code"=>200
+		"id" => 21, "email" => "chyrkov@kth.se", 
+		"mobile" => "380632721593", "first_name" => "Oleksii", 
+		"last_name" => "Chyrkov", "permission_type" => "one-time", 
+		"channel" => "sms", "company_name" => "Apple", 
+		"message" => "Found optin", "code" => 200
 	}
 
 	not_found_reply = 
 	{
-		"code"=> 404, 
-		"message"=>"Optin not found"
+		"code" => 404, 
+		"message" => "Optin not found"
 	}
 
 	bad_request_reply = 
 	{
-		"code"=> 401, 
-		"message"=>"Bad request"
+		"code" => 401, 
+		"message" =>"Bad request"
 	}
 
 	already_exists_reply = 
 	{
-		"code"=> 302, 
-		"message"=>"Bad request"
+		"code" => 302, 
+		"message" =>"Bad request"
+	}
+
+	internal_error_reply = 
+	{
+		"code" => 503,
+		"message" => "Internal server error"
 	}
 
 	params = 
@@ -181,4 +187,19 @@ describe MarketingAPI, "#marketing_remote_api" do
 		api.update_optin(params.to_json).should eq(nil)
 	end
 
+	it "should return nil when a create request returns 503 Internal Server Error" do
+		stub_request(:any, api.server+":80/create").to_return(:status => 503, :body => internal_error_reply)
+		api.create_optin(params.to_json).should eq(nil)
+	end
+
+	it "should return nil when an update request returns 503 Internal Server Error" do
+		stub_request(:any, api.server+":80/update").to_return(:status => 503, :body => internal_error_reply)
+		api.update_optin(params.to_json).should eq(nil)
+	end
+
+	it "should return nil when a deactivate request returns 503 Internal Server Error" do
+		stub_request(:any, api.server+":80/deactivate/#{params[:id]}").to_return(:status => 503, :body => internal_error_reply)
+		api.deactivate_optin(params[:id]).should eq(nil)
+	end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: marketing_api
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -72,6 +72,7 @@ files:
 - Rakefile
 - bin/marketing_api.rb
 - lib/marketing_api.rb
+- marketing_api-0.0.1.gem
 - marketing_api.gemspec
 - spec/api_spec.rb
 - spec/spec_helper.rb