markbridge 0.1.0 → 0.1.2

data/lib/markbridge/parsers/bbcode/tokens/tag_end_token.rb

@@ -7,14 +7,10 @@ module Markbridge
       class TagEndToken < Token
         attr_reader :tag
 
-        def initialize(tag:, pos: 0, source: nil)
+        def initialize(tag:, pos:, source:)
           super(pos:, source:)
           @tag = tag.freeze
         end
-
-        def inspect
-          "#<TagEndToken [/#{tag}]>"
-        end
       end
     end
   end

data/lib/markbridge/parsers/bbcode/tokens/tag_start_token.rb

@@ -7,16 +7,11 @@ module Markbridge
       class TagStartToken < Token
         attr_reader :tag, :attrs
 
-        def initialize(tag:, attrs: {}, pos: 0, source: nil)
+        def initialize(tag:, attrs:, pos:, source:)
           super(pos:, source:)
           @tag = tag.freeze
           @attrs = attrs.freeze
         end
-
-        def inspect
-          attrs_str = attrs.empty? ? "" : " #{attrs.inspect}"
-          "#<TagStartToken [#{tag}]#{attrs_str}>"
-        end
       end
     end
   end

data/lib/markbridge/parsers/bbcode/tokens/text_token.rb

@@ -7,16 +7,10 @@ module Markbridge
       class TextToken < Token
         attr_reader :text
 
-        def initialize(text:, pos: 0)
+        def initialize(text:, pos:)
           super(pos:, source: text)
           @text = text.freeze
         end
-
-        alias source text
-
-        def inspect
-          "#<TextToken #{text.inspect}>"
-        end
       end
     end
   end

data/lib/markbridge/parsers/bbcode/tokens/token.rb

@@ -6,7 +6,7 @@ module Markbridge
       class Token
         attr_reader :pos, :source
 
-        def initialize(pos: 0, source: nil)
+        def initialize(pos:, source:)
           @pos = pos
           @source = source
         end

data/lib/markbridge/parsers/bbcode.rb

@@ -25,6 +25,7 @@ require_relative "bbcode/handlers/raw_handler"
 # Handlers
 require_relative "bbcode/handlers/align_handler"
 require_relative "bbcode/handlers/attachment_handler"
+require_relative "bbcode/handlers/code_handler"
 require_relative "bbcode/handlers/color_handler"
 require_relative "bbcode/handlers/email_handler"
 require_relative "bbcode/handlers/image_handler"
@@ -35,6 +36,9 @@ require_relative "bbcode/handlers/self_closing_handler"
 require_relative "bbcode/handlers/simple_handler"
 require_relative "bbcode/handlers/size_handler"
 require_relative "bbcode/handlers/spoiler_handler"
+require_relative "bbcode/handlers/table_handler"
+require_relative "bbcode/handlers/table_row_handler"
+require_relative "bbcode/handlers/table_cell_handler"
 require_relative "bbcode/handlers/url_handler"
 
 # Parser components

data/lib/markbridge/parsers/html/handler_registry.rb

@@ -27,50 +27,38 @@ module Markbridge
         # Create the default handler registry with common HTML tags
         # @return [HandlerRegistry]
         def self.default
-          registry = new
-
-          # Simple formatting handlers
-          registry.register(%w[b strong], Handlers::SimpleHandler.new(AST::Bold))
-          registry.register(%w[i em], Handlers::SimpleHandler.new(AST::Italic))
-          registry.register(%w[s strike del], Handlers::SimpleHandler.new(AST::Strikethrough))
-          registry.register("u", Handlers::SimpleHandler.new(AST::Underline))
-          registry.register("sup", Handlers::SimpleHandler.new(AST::Superscript))
-          registry.register("sub", Handlers::SimpleHandler.new(AST::Subscript))
-
-          # Code handlers (raw content)
-          registry.register(%w[code pre tt], Handlers::RawHandler.new(AST::Code))
-
-          # Link and image handlers
-          registry.register("a", Handlers::UrlHandler.new)
-          registry.register("img", Handlers::ImageHandler.new)
-
-          # Blockquote handler
-          registry.register("blockquote", Handlers::QuoteHandler.new)
-
-          # Void elements - use simple inline handlers
-          registry.register(
-            "br",
-            lambda do |element:, parent:|
-              parent << AST::LineBreak.new
-              nil # Return nil - void element, no children
-            end,
-          )
-          registry.register(
-            "hr",
-            lambda do |element:, parent:|
-              parent << AST::HorizontalRule.new
-              nil # Return nil - void element, no children
-            end,
-          )
-
-          # List handlers
-          registry.register(%w[ul ol], Handlers::ListHandler.new)
-          registry.register("li", Handlers::ListItemHandler.new)
-
-          # Paragraph handler (transparent - doesn't create AST node)
-          registry.register("p", Handlers::ParagraphHandler.new)
-
-          registry
+          new.tap do |registry|
+            registry.register(%w[b strong], Handlers::SimpleHandler.new(AST::Bold))
+            registry.register(%w[i em], Handlers::SimpleHandler.new(AST::Italic))
+            registry.register(%w[s strike del], Handlers::SimpleHandler.new(AST::Strikethrough))
+            registry.register("u", Handlers::SimpleHandler.new(AST::Underline))
+            registry.register("sup", Handlers::SimpleHandler.new(AST::Superscript))
+            registry.register("sub", Handlers::SimpleHandler.new(AST::Subscript))
+            registry.register(%w[code pre tt], Handlers::RawHandler.new(AST::Code))
+            registry.register("a", Handlers::UrlHandler.new)
+            registry.register("img", Handlers::ImageHandler.new)
+            registry.register("blockquote", Handlers::QuoteHandler.new)
+            registry.register(
+              "br",
+              lambda do |element:, parent:|
+                parent << AST::LineBreak.new
+                nil
+              end,
+            )
+            registry.register(
+              "hr",
+              lambda do |element:, parent:|
+                parent << AST::HorizontalRule.new
+                nil
+              end,
+            )
+            registry.register(%w[ul ol], Handlers::ListHandler.new)
+            registry.register("li", Handlers::ListItemHandler.new)
+            registry.register("table", Handlers::TableHandler.new)
+            registry.register("tr", Handlers::TableRowHandler.new)
+            registry.register(%w[td th], Handlers::TableCellHandler.new)
+            registry.register("p", Handlers::ParagraphHandler.new)
+          end
         end
 
         # Build a registry from the default configuration with optional customization

data/lib/markbridge/parsers/html/handlers/base_handler.rb

@@ -11,9 +11,6 @@ module Markbridge
           # @param parent [AST::Element] the parent AST node
           # @return [AST::Element, nil] the created element if children should be processed, nil otherwise
           def process(element:, parent:)
-            node = element # Alias for compatibility
-            # Default: do nothing, subclasses override
-            nil
           end
 
           # The element class created by this handler

data/lib/markbridge/parsers/html/handlers/image_handler.rb

@@ -26,12 +26,9 @@ module Markbridge
 
           private
 
-          # Convert dimension to positive integer or nil
           def sanitize_dimension(value)
-            return nil if value.nil?
-
             dim = value.to_i
-            dim.positive? ? dim : nil
+            dim if dim.positive?
           end
         end
       end

data/lib/markbridge/parsers/html/handlers/table_cell_handler.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module Markbridge
+  module Parsers
+    module HTML
+      module Handlers
+        # Handler for table cell tags (<td>, <th>)
+        class TableCellHandler < BaseHandler
+          def initialize
+            @element_class = AST::TableCell
+          end
+
+          def process(element:, parent:)
+            ast_element = AST::TableCell.new(header: element.name.downcase == "th")
+            parent << ast_element
+            ast_element
+          end
+
+          attr_reader :element_class
+        end
+      end
+    end
+  end
+end

data/lib/markbridge/parsers/html/handlers/table_handler.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module Markbridge
+  module Parsers
+    module HTML
+      module Handlers
+        # Handler for table tags (<table>)
+        class TableHandler < BaseHandler
+          def initialize
+            @element_class = AST::Table
+          end
+
+          def process(element:, parent:)
+            ast_element = AST::Table.new
+            parent << ast_element
+            ast_element
+          end
+
+          attr_reader :element_class
+        end
+      end
+    end
+  end
+end

data/lib/markbridge/parsers/html/handlers/table_row_handler.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module Markbridge
+  module Parsers
+    module HTML
+      module Handlers
+        # Handler for table row tags (<tr>)
+        class TableRowHandler < BaseHandler
+          def initialize
+            @element_class = AST::TableRow
+          end
+
+          def process(element:, parent:)
+            ast_element = AST::TableRow.new
+            parent << ast_element
+            ast_element
+          end
+
+          attr_reader :element_class
+        end
+      end
+    end
+  end
+end

data/lib/markbridge/parsers/html/parser.rb

@@ -5,6 +5,11 @@ module Markbridge
     module HTML
       # Parses HTML into an AST using Nokogiri
       class Parser
+        # Tags whose contents should be dropped entirely (not emitted as text).
+        # These are raw-text/metadata elements whose children are either CSS,
+        # JavaScript, or document metadata that shouldn't appear in output.
+        IGNORED_TAGS = %w[style script head title noscript template].freeze
+
         attr_reader :unknown_tags
 
         # Create a new parser with optional custom handlers
@@ -26,8 +31,12 @@ module Markbridge
         def parse(input)
           @unknown_tags.clear
 
-          # Parse HTML with Nokogiri
-          doc = Nokogiri::HTML5.fragment(input)
+          # Parse HTML with Nokogiri. Using the generic HTML (HTML4) parser rather
+          # than HTML5 because Nokogiri::HTML5 is not available on JRuby
+          # (see sparklemotion/nokogiri#2227). Table support treats thead/tbody/tfoot
+          # as transparent, so the parse-tree difference (HTML5 auto-inserts tbody,
+          # HTML4 does not) has no effect on the AST.
+          doc = Nokogiri::HTML.fragment(input)
 
           # Create root AST document
           document = AST::Document.new
@@ -63,15 +72,16 @@ module Markbridge
         # @param node [Nokogiri::XML::Text]
         # @param parent [AST::Element]
         def process_text_node(node, parent)
-          text = node.text
-          parent << AST::Text.new(text) unless text.empty?
+          parent << AST::Text.new(node.text)
         end
 
         # Process an element node
         # @param node [Nokogiri::XML::Element]
         # @param parent [AST::Element]
         def process_element_node(node, parent)
-          tag_name = node.name.downcase
+          tag_name = node.name
+          return if IGNORED_TAGS.include?(tag_name)
+
           handler = @handlers[tag_name]
 
           if handler
@@ -95,18 +105,9 @@ module Markbridge
         # @param node [Nokogiri::XML::Element]
         # @param parent [AST::Element]
         def handle_unknown_tag(node, parent)
-          @unknown_tags[node.name.downcase] += 1
+          @unknown_tags[node.name] += 1
           process_children(node, parent)
         end
-
-        # Check if an element is a void element (self-closing)
-        # @param tag_name [String]
-        # @return [Boolean]
-        def void_element?(tag_name)
-          %w[area base br col embed hr img input link meta param source track wbr].include?(
-            tag_name.downcase,
-          )
-        end
       end
     end
   end

data/lib/markbridge/parsers/html.rb

@@ -17,6 +17,9 @@ require_relative "html/handlers/list_handler"
 require_relative "html/handlers/list_item_handler"
 require_relative "html/handlers/quote_handler"
 require_relative "html/handlers/paragraph_handler"
+require_relative "html/handlers/table_handler"
+require_relative "html/handlers/table_row_handler"
+require_relative "html/handlers/table_cell_handler"
 
 # Parser components
 require_relative "html/handler_registry"