markbridge 0.1.0 → 0.1.1

data/lib/markbridge/renderers/discourse/tags/table_row_tag.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module Markbridge
+  module Renderers
+    module Discourse
+      module Tags
+        # Tag for rendering table rows (passthrough - renders children only)
+        # The TableTag handles rows directly; this is a safety net for standalone rendering.
+        class TableRowTag < Tag
+          def render(element, interface)
+            child_context = interface.with_parent(element)
+            interface.render_children(element, context: child_context)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/markbridge/renderers/discourse/tags/table_tag.rb

@@ -0,0 +1,124 @@
+# frozen_string_literal: true
+
+module Markbridge
+  module Renderers
+    module Discourse
+      module Tags
+        # Tag for rendering tables as Markdown pipe tables with HTML fallback
+        class TableTag < Tag
+          def render(element, interface)
+            child_context = interface.with_parent(element)
+            rows_data = extract_rows(element, interface, child_context)
+
+            return "" if rows_data.empty?
+
+            if markdown_compatible?(rows_data, interface)
+              render_markdown(rows_data)
+            else
+              render_html(rows_data)
+            end
+          end
+
+          private
+
+          # Extract rendered cell data from each row
+          # @return [Array<Hash>] array of {cells: [{content:, header:}], ...}
+          def extract_rows(element, interface, child_context)
+            element.children.filter_map do |child|
+              next unless child.is_a?(AST::TableRow)
+
+              cells =
+                child.children.filter_map do |cell|
+                  next unless cell.is_a?(AST::TableCell)
+
+                  cell_context = child_context.with_parent(child)
+                  content = interface.render_children(cell, context: cell_context).strip
+                  { content:, header: cell.header? }
+                end
+
+              { cells: } unless cells.empty?
+            end
+          end
+
+          # Check if the table can be rendered as Markdown
+          def markdown_compatible?(rows_data, interface)
+            return false if rows_data.empty?
+            return false if interface.has_parent?(AST::Table)
+
+            cell_count = rows_data.first[:cells].length
+            rows_data.all? do |row|
+              row[:cells].length == cell_count &&
+                row[:cells].none? { |c| c[:content].include?("\n") }
+            end
+          end
+
+          # Render as Markdown pipe table
+          def render_markdown(rows_data)
+            header_idx = rows_data.index { |r| r[:cells].all? { |c| c[:header] } }
+            header_row = header_idx ? rows_data[header_idx] : rows_data.first
+            data_rows =
+              (
+                if header_idx
+                  rows_data[0...header_idx] + rows_data[(header_idx + 1)..]
+                else
+                  rows_data[1..]
+                end
+              )
+
+            col_count = header_row[:cells].length
+            lines = []
+            lines << format_row(header_row[:cells])
+            lines << "| #{(["---"] * col_count).join(" | ")} |"
+            data_rows.each { |row| lines << format_row(row[:cells]) }
+
+            "\n\n#{lines.join("\n")}\n\n"
+          end
+
+          # Format a single row as a Markdown pipe row
+          def format_row(cells)
+            # Pipe characters in cell content are already escaped by the markdown escaper
+            "| #{cells.map { |c| c[:content] }.join(" | ")} |"
+          end
+
+          # Render as HTML table
+          def render_html(rows_data)
+            has_header = rows_data.any? { |r| r[:cells].any? { |c| c[:header] } }
+            lines = ["<table>"]
+
+            if has_header
+              header_rows, body_rows = rows_data.partition { |r| r[:cells].all? { |c| c[:header] } }
+
+              unless header_rows.empty?
+                lines << "<thead>"
+                header_rows.each { |row| lines << html_row(row, force_header: true) }
+                lines << "</thead>"
+              end
+
+              unless body_rows.empty?
+                lines << "<tbody>"
+                body_rows.each { |row| lines << html_row(row) }
+                lines << "</tbody>"
+              end
+            else
+              rows_data.each { |row| lines << html_row(row) }
+            end
+
+            lines << "</table>"
+            "\n\n#{lines.join("\n")}\n\n"
+          end
+
+          # Render a single HTML table row
+          def html_row(row, force_header: false)
+            cells_html =
+              row[:cells].map do |cell|
+                tag = (cell[:header] || force_header) ? "th" : "td"
+                "<#{tag}>#{cell[:content]}</#{tag}>"
+              end
+
+            "<tr>#{cells_html.join}</tr>"
+          end
+        end
+      end
+    end
+  end
+end

data/lib/markbridge/renderers/discourse/tags/upload_tag.rb

@@ -29,7 +29,7 @@ module Markbridge
         #     end
         #   end
         class UploadTag < Tag
-          def render(element, interface)
+          def render(element, _interface)
             # Return raw Markdown if available, otherwise reconstruct
             return element.raw if element.raw
 

data/lib/markbridge/renderers/discourse.rb

@@ -30,6 +30,9 @@ require_relative "discourse/tags/spoiler_tag"
 require_relative "discourse/tags/strikethrough_tag"
 require_relative "discourse/tags/subscript_tag"
 require_relative "discourse/tags/superscript_tag"
+require_relative "discourse/tags/table_tag"
+require_relative "discourse/tags/table_row_tag"
+require_relative "discourse/tags/table_cell_tag"
 require_relative "discourse/tags/underline_tag"
 require_relative "discourse/tags/url_tag"
 

data/lib/markbridge/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Markbridge
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/markbridge.rb

@@ -16,13 +16,8 @@ module Markbridge
     # @param handlers [HandlerRegistry, nil] custom handler registry or use default
     # @return [AST::Document]
     def parse_bbcode(input, handlers: nil)
-      raise ArgumentError, "input cannot be nil" if input.nil?
-
-      input = input.to_s # Coerce to string
       handlers ||= default_handlers
-
-      parser = Parsers::BBCode::Parser.new(handlers:)
-      parser.parse(input)
+      parse_with(Parsers::BBCode::Parser, input, handlers:)
     end
 
     # Convert BBCode to Discourse Markdown
@@ -31,17 +26,8 @@ module Markbridge
     # @param tag_library [TagLibrary, nil] custom tag library or use default
     # @return [String] Markdown output
     def bbcode_to_markdown(input, handlers: nil, tag_library: nil)
-      raise ArgumentError, "input cannot be nil" if input.nil?
-
-      handlers ||= default_handlers
-      tag_library ||= default_tag_library
-
       ast = parse_bbcode(input, handlers:)
-      renderer = build_renderer(tag_library:)
-
-      # Clean up output
-      result = renderer.render(ast)
-      cleanup_markdown(result)
+      render_to_markdown(ast, tag_library:)
     end
 
     # Parse HTML to AST
@@ -49,13 +35,8 @@ module Markbridge
     # @param handlers [HandlerRegistry, nil] custom handler registry or use default
     # @return [AST::Document]
     def parse_html(input, handlers: nil)
-      raise ArgumentError, "input cannot be nil" if input.nil?
-
-      input = input.to_s # Coerce to string
       handlers ||= default_html_handlers
-
-      parser = Parsers::HTML::Parser.new(handlers:)
-      parser.parse(input)
+      parse_with(Parsers::HTML::Parser, input, handlers:)
     end
 
     # Convert HTML to Discourse Markdown
@@ -64,17 +45,8 @@ module Markbridge
     # @param tag_library [TagLibrary, nil] custom tag library or use default
     # @return [String] Markdown output
     def html_to_markdown(input, handlers: nil, tag_library: nil)
-      raise ArgumentError, "input cannot be nil" if input.nil?
-
-      handlers ||= default_html_handlers
-      tag_library ||= default_tag_library
-
       ast = parse_html(input, handlers:)
-      renderer = build_renderer(tag_library:)
-
-      # Clean up output
-      result = renderer.render(ast)
-      cleanup_markdown(result)
+      render_to_markdown(ast, tag_library:)
     end
 
     # Parse s9e/TextFormatter XML to AST
@@ -82,13 +54,8 @@ module Markbridge
     # @param handlers [Parsers::TextFormatter::HandlerRegistry, nil] custom handler registry or use default
     # @return [AST::Document]
     def parse_text_formatter_xml(input, handlers: nil)
-      raise ArgumentError, "input cannot be nil" if input.nil?
-
-      input = input.to_s
       handlers ||= default_text_formatter_handlers
-
-      parser = Parsers::TextFormatter::Parser.new(handlers:)
-      parser.parse(input)
+      parse_with(Parsers::TextFormatter::Parser, input, handlers:)
     end
 
     # Convert s9e/TextFormatter XML to Discourse Markdown
@@ -97,16 +64,8 @@ module Markbridge
     # @param tag_library [TagLibrary, nil] custom tag library or use default
     # @return [String] Markdown output
     def text_formatter_xml_to_markdown(input, handlers: nil, tag_library: nil)
-      raise ArgumentError, "input cannot be nil" if input.nil?
-
-      handlers ||= default_text_formatter_handlers
-      tag_library ||= default_tag_library
-
       ast = parse_text_formatter_xml(input, handlers:)
-      renderer = build_renderer(tag_library:)
-
-      result = renderer.render(ast)
-      cleanup_markdown(result)
+      render_to_markdown(ast, tag_library:)
     end
 
     # Parse MediaWiki wikitext to AST
@@ -125,15 +84,8 @@ module Markbridge
     # @param tag_library [TagLibrary, nil] custom tag library or use default
     # @return [String] Markdown output
     def mediawiki_to_markdown(input, tag_library: nil)
-      raise ArgumentError, "input cannot be nil" if input.nil?
-
-      tag_library ||= default_tag_library
-
       ast = parse_mediawiki(input)
-      renderer = build_renderer(tag_library:)
-
-      result = renderer.render(ast)
-      cleanup_markdown(result)
+      render_to_markdown(ast, tag_library:)
     end
 
     # Get default handler registry
@@ -183,6 +135,19 @@ module Markbridge
 
     private
 
+    def parse_with(parser_class, input, handlers:)
+      raise ArgumentError, "input cannot be nil" if input.nil?
+
+      parser = parser_class.new(handlers:)
+      parser.parse(input.to_s)
+    end
+
+    def render_to_markdown(ast, tag_library: nil)
+      tag_library ||= default_tag_library
+      renderer = build_renderer(tag_library:)
+      cleanup_markdown(renderer.render(ast))
+    end
+
     def build_renderer(tag_library:)
       escaper =
         Renderers::Discourse::MarkdownEscaper.new(

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: markbridge
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Discourse Team
@@ -47,6 +47,7 @@ files:
 - lib/markbridge/ast/strikethrough.rb
 - lib/markbridge/ast/subscript.rb
 - lib/markbridge/ast/superscript.rb
+- lib/markbridge/ast/table.rb
 - lib/markbridge/ast/text.rb
 - lib/markbridge/ast/underline.rb
 - lib/markbridge/ast/upload.rb
@@ -75,6 +76,9 @@ files:
 - lib/markbridge/parsers/bbcode/handlers/simple_handler.rb
 - lib/markbridge/parsers/bbcode/handlers/size_handler.rb
 - lib/markbridge/parsers/bbcode/handlers/spoiler_handler.rb
+- lib/markbridge/parsers/bbcode/handlers/table_cell_handler.rb
+- lib/markbridge/parsers/bbcode/handlers/table_handler.rb
+- lib/markbridge/parsers/bbcode/handlers/table_row_handler.rb
 - lib/markbridge/parsers/bbcode/handlers/url_handler.rb
 - lib/markbridge/parsers/bbcode/parser.rb
 - lib/markbridge/parsers/bbcode/parser_state.rb
@@ -96,6 +100,9 @@ files:
 - lib/markbridge/parsers/html/handlers/quote_handler.rb
 - lib/markbridge/parsers/html/handlers/raw_handler.rb
 - lib/markbridge/parsers/html/handlers/simple_handler.rb
+- lib/markbridge/parsers/html/handlers/table_cell_handler.rb
+- lib/markbridge/parsers/html/handlers/table_handler.rb
+- lib/markbridge/parsers/html/handlers/table_row_handler.rb
 - lib/markbridge/parsers/html/handlers/url_handler.rb
 - lib/markbridge/parsers/html/parser.rb
 - lib/markbridge/parsers/media_wiki.rb
@@ -112,6 +119,7 @@ files:
 - lib/markbridge/parsers/text_formatter/handlers/list_handler.rb
 - lib/markbridge/parsers/text_formatter/handlers/quote_handler.rb
 - lib/markbridge/parsers/text_formatter/handlers/simple_handler.rb
+- lib/markbridge/parsers/text_formatter/handlers/table_cell_handler.rb
 - lib/markbridge/parsers/text_formatter/handlers/url_handler.rb
 - lib/markbridge/parsers/text_formatter/parser.rb
 - lib/markbridge/processors.rb
@@ -154,6 +162,9 @@ files:
 - lib/markbridge/renderers/discourse/tags/strikethrough_tag.rb
 - lib/markbridge/renderers/discourse/tags/subscript_tag.rb
 - lib/markbridge/renderers/discourse/tags/superscript_tag.rb
+- lib/markbridge/renderers/discourse/tags/table_cell_tag.rb
+- lib/markbridge/renderers/discourse/tags/table_row_tag.rb
+- lib/markbridge/renderers/discourse/tags/table_tag.rb
 - lib/markbridge/renderers/discourse/tags/underline_tag.rb
 - lib/markbridge/renderers/discourse/tags/upload_tag.rb
 - lib/markbridge/renderers/discourse/tags/url_tag.rb