marc 0.0.5 → 0.0.6

data/lib/marc/marc21.rb

@@ -76,6 +76,8 @@ module MARC
             # get the byte offsets from the record directory
             directory = marc[LEADER_LENGTH..base_address-1]
 
+            throw "invalid directory in record" if directory == nil
+
             # the number of fields in the record corresponds to 
             # how many directory entries there are
             num_fields = directory.length / DIRECTORY_ENTRY_LENGTH

data/lib/marc/reader.rb

@@ -76,8 +76,13 @@ module MARC
 
         def each 
             @handle.each_line(MARC::MARC21::END_OF_RECORD) do |raw| 
-                record = MARC::Record.new_from_marc(raw, :forgiving => true)
-                yield record 
+                begin
+                    record = MARC::Record.new_from_marc(raw, :forgiving => true)
+                    yield record 
+                rescue StandardError => e
+                    # caught exception just keep barrelling along
+                    # TODO add logging
+                end
             end
         end
 

data/test/tc_reader.rb

@@ -14,25 +14,25 @@ class ReaderTest < Test::Unit::TestCase
         reader = MARC::ForgivingReader.new('test/batch.dat')
         count = 0
         reader.each { count += 1 }
-        assert_equal(count, 10)
+        assert_equal(10, count)
     end
 
     def test_search
         reader = MARC::Reader.new('test/batch.dat')
         records = reader.find_all { |r| r =~ /Perl/ }
-        assert_equal(records.length,10)
+        assert_equal(10, records.length)
 
         reader = MARC::Reader.new('test/batch.dat')
         records = reader.find_all { |r| r['245'] =~ /Perl/ }
-        assert_equal(records.length,10)
+        assert_equal(10, records.length)
 
         reader = MARC::Reader.new('test/batch.dat')
         records = reader.find_all { |r| r['245']['a'] =~ /Perl/ }
-        assert_equal(records.length,10)
+        assert_equal(10, records.length)
 
         reader = MARC::Reader.new('test/batch.dat')
         records = reader.find_all { |r| r =~ /Foo/ }
-        assert_equal(records.length,0)
+        assert_equal(0, records.length)
     end
 
 end

metadata

@@ -3,7 +3,7 @@ rubygems_version: 0.8.11
 specification_version: 1
 name: marc
 version: !ruby/object:Gem::Version 
-  version: 0.0.5
+  version: 0.0.6
 date: 2005-10-18 00:00:00 -05:00
 summary: A ruby library for working with Machine Readable Cataloging
 require_paths: