marc 0.0.4 → 0.0.5

data/lib/marc/field.rb

@@ -39,10 +39,12 @@ module MARC
         #         ['a', 'Consilience :'],['b','the unity of knowledge ',
         #         ['c', 'by Edward O. Wilson.'] )
 
-        def initialize(tag, i1=nil, i2=nil, *subfields)
+        def initialize(tag, i1=' ', i2=' ', *subfields)
             @tag = tag 
-            @indicator1 = i1
-            @indicator2 = i2
+            # can't allow nil to be passed in or else it'll 
+            # screw us up later when we try to encode
+            @indicator1 = i1 == nil ? ' ' : i1
+            @indicator2 = i2 == nil ? ' ' : i2
             @subfields = []
 
             # must use MARC::ControlField for tags < 010

data/lib/marc/marc21.rb

@@ -22,7 +22,7 @@ module MARC
 
                 # encode the field
                 field_data = ''
-                if field.class == MARC::Field
+                if field.class == MARC::Field 
                     field_data = field.indicator1 + field.indicator2 
                     for s in field.subfields
                         field_data += SUBFIELD_INDICATOR + s.code + s.value
@@ -125,6 +125,10 @@ module MARC
                     # get all subfields
                     subfields = field_data.split(SUBFIELD_INDICATOR)
 
+                    # must have at least 2 elements (indicators, and 1 subfield)
+                    # TODO some sort of logging?
+                    next if subfields.length() < 2
+
                     # get indicators
                     indicators = subfields.shift()
                     field.indicator1 = indicators[0,1]

data/lib/marc/subfield.rb

@@ -3,9 +3,11 @@ module MARC
     class Subfield
         attr_accessor :code, :value
 
-        def initialize(code,value)
-            @code = code
-            @value = value
+        def initialize(code='' ,value='')
+            # can't allow code of value to be nil
+            # or else it'll screw us up later on
+            @code = code == nil ? '' : code
+            @value = value == nil ? '' : value
         end
 
         def ==(other)

metadata

@@ -3,7 +3,7 @@ rubygems_version: 0.8.11
 specification_version: 1
 name: marc
 version: !ruby/object:Gem::Version 
-  version: 0.0.4
+  version: 0.0.5
 date: 2005-10-18 00:00:00 -05:00
 summary: A ruby library for working with Machine Readable Cataloging
 require_paths: