maquina-components 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 870cc289944a0b16196e5e259398cbdabf0ca1dd998bf2a178967898a3d1a57e
-  data.tar.gz: db3daba76341084ee6e096fd2186cebdcf594b6faee992be2c9e62e4b5781eed
+  metadata.gz: a908d12ac4b955850c1c9cf41cab32bbc12d4687d68fad543b43c74fc4f678d6
+  data.tar.gz: 83fa5e89747cd635883e93e6e47a034b64f59633f3b2207a9e9ae7e3aa5aad35
 SHA512:
-  metadata.gz: a1934e3230c028e772cbaf0a0276a21fbb6f8ea406e76c355fdfc29587b445619a717a2d7f69a388a65afbcdef5236e59495072192845993a3079c944b0ca59c
-  data.tar.gz: 6c29f68c06d96157c4402ff03f1594aac41a748480d464c678bd995d10aa49ba055f759674786d666a1fb8b0f146fc76243a95171b146c88e82aa88d42df644c
+  metadata.gz: 903deaa1e5cdb313f8ae2b71a7e59d1c0608926d2951fc66aba2eb787d0e94763379dcfbe2e828c21e001e344f8dff474f5961e31e8c3f06592d13d558f6f61c
+  data.tar.gz: 9b62919d2c5bbabeba0842af06a2b3d24d576f3f307dd198e43119790b0bce36c0b0cc3108006c3f10cb5e6e02340d426baa01ca76a567f0800b805b748cd8d4

data/lib/maquina_components/doctor.rb

@@ -54,6 +54,13 @@ module MaquinaComponents
     # Assigning a data URI to one of the five mark properties IS the 0.6.0
     # pattern, so it must not be reported as a restated rule.
     MARK_TOKEN_ASSIGNMENT = /--(?:checkbox-mark|checkbox-indeterminate|radio-mark|switch-thumb|select-chevron)-image\s*:/
+    RESTATED_SVG_SUGGESTION =
+      "0.6.0 exposes these marks as overridable custom properties:\n" \
+      "--checkbox-mark-image, --checkbox-indeterminate-image, --radio-mark-image,\n" \
+      "--switch-thumb-image, --select-chevron-image. Assign your SVG to the token\n" \
+      "instead of restating the engine's rule."
+    # A component hook in markup: data-component="..." or a helper's component: key.
+    MARKUP_COMPONENT_HOOK = /data-component=|\bcomponent:\s*[:"']/
     RADIUS_DECL = /(?:border-radius\s*:|@apply[^;{}]*\brounded(?:-[a-z0-9\[\].\/-]+)?\b)/
     SHADOW_DECL = /(?:box-shadow\s*:|@apply[^;{}]*\b(?:shadow|ring)(?:-[a-z0-9\[\].\/-]+)?\b)/
     FOCUS_SELECTOR = /:focus(-visible|-within)?\b/
@@ -238,6 +245,13 @@ module MaquinaComponents
 
       return unless component_selector?(chain)
 
+      # Only here, under a component selector, does an SVG restate an engine
+      # mark. Anywhere else it is the app's own artwork -- Rails' actiontext.css
+      # carries fifteen for the Trix editor.
+      if SVG_DATA_URI.match?(declaration) && !MARK_TOKEN_ASSIGNMENT.match?(declaration)
+        add(path, index, declaration, :breaking, "restated-svg-uri", RESTATED_SVG_SUGGESTION)
+      end
+
       if RADIUS_DECL.match?(declaration)
         add(path, index, declaration, :review, "hardcoded-radius",
           "0.6.0 reads --control-radius / --surface-radius / --mark-radius / --pill-radius.\n" \
@@ -319,20 +333,16 @@ module MaquinaComponents
           "Use the value form of the variant: data-[active=true]:... - the bare\n" \
           "data-[active] variant relies on an attribute 0.6.0 no longer emits when false.")
       end
-
-      if SVG_DATA_URI.match?(line) && !MARK_TOKEN_ASSIGNMENT.match?(line)
-        add(path, index, line, :breaking, "restated-svg-uri",
-          "0.6.0 exposes these marks as overridable custom properties:\n" \
-          "--checkbox-mark-image, --checkbox-indeterminate-image, --radio-mark-image,\n" \
-          "--switch-thumb-image, --select-chevron-image. Assign your SVG to the token\n" \
-          "instead of restating the engine's rule.")
-      end
     end
 
     def scan_markup(path)
       read(path).each_with_index do |line, index|
         scan_shared(path, index, line)
 
+        if SVG_DATA_URI.match?(line) && MARKUP_COMPONENT_HOOK.match?(line)
+          add(path, index, line, :breaking, "restated-svg-uri", RESTATED_SVG_SUGGESTION)
+        end
+
         # Cross-file signals for check_invalid_without_aria.
         @aria_invalid_seen ||= ARIA_INVALID.match?(line)
         if ERROR_PART.match?(line) || FIELD_WITH_ERRORS.match?(line)

data/lib/maquina_components/version.rb

@@ -1,3 +1,3 @@
 module MaquinaComponents
-  VERSION = "0.7.2"
+  VERSION = "0.7.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: maquina-components
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - Mario Alberto Chávez