mangopay 3.24.0 → 3.24.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7321bd891306f53afcbd49ecb871a872f7899d2ee039688392b076ee64c45142
-  data.tar.gz: c93e03ce101e31b67def7784e6a1d9490ca4cf5d4254f312f6cda02d32f528ec
+  metadata.gz: c227169098718116d4d2473a9e9f5373c5556a89a1bc851b304093fd6e8ff511
+  data.tar.gz: b925a267ad094eb69801beafb04904c95852820837d158298d2c8b49506be8fb
 SHA512:
-  metadata.gz: 889df791bf8d890fedbaca69373b91f7f14bb332b9bd2bda09524bfe8d5438c04c0189aea216627c097ccfb1453c1b8f5f4fcb53f6c90d328c04b143e47b75bb
-  data.tar.gz: 91c75bf32947a0eb9023d309164a5e416fb80744ca9516da1843b51dff4fdf01b7136c3c3489a3d50aecfa868c735c7f65330eebfe8f1e9ee37cbbaf79ad98de
+  metadata.gz: 88c78792b4aff5d84ebc7c0687cf11b12f974507e09bec368a28101ca169520e3269353536af528669f37305fc0030c414e61754ea1c8f0fb4c7130b09639efd
+  data.tar.gz: c122b794f79e18718d833359d58d0ca6dd4fce57a21195eaae2130a275a0279d138d21939fe02ca754073bfc249f22676212cb7e435553c0cb6a21bfe9edef3a

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## [3.24.1] - 2024-04-10
+### Fixed
+
+- #249 Improve error handling when logging is enabled
+- #226 MultiJson::ParseError is thrown on HTTP error 5XX
+
 ## [3.24.0] - 2024-04-02
 ### Added
 

data/lib/mangopay/version.rb

@@ -1,3 +1,3 @@
 module MangoPay
-  VERSION = '3.24.0'
+  VERSION = '3.24.1'
 end

data/lib/mangopay.rb

@@ -214,7 +214,13 @@ module MangoPay
       raise MangoPay::ResponseError.new(uri, '408', {'Message' => 'Request Timeout'}) if res.nil?
 
       # decode json data
-      data = res.body.to_s.empty? ? {} : JSON.load(res.body.to_s)
+      begin
+        data = res.body.to_s.empty? ? {} : JSON.load(res.body.to_s)
+      rescue MultiJson::ParseError
+        details = {}
+        details['Message'] = res.body
+        raise MangoPay::ResponseError.new(uri, res.code, details)
+      end
 
       unless res.is_a?(Net::HTTPOK)
         raise MangoPay::ResponseError.new(uri, res.code, data)
@@ -298,12 +304,17 @@ module MangoPay
         res
       ensure
         line = "#{log_severity(res)} #{line}"
+        if time.nil?
+          time_log = "[Unknown ms]"
+        else
+          time_log = "[#{(time * 1000).round(1)}ms]"
+        end
         if res.nil?
           params = ''
-          line += "\n  [#{(time * 1000).round(1)}ms] 408 Request Timeout #{params}\n"
+          line += "\n  #{time_log} 408 Request Timeout #{params}\n"
         else
           params = FilterParameters.response(res.body)
-          line += "\n  [#{(time * 1000).round(1)}ms] #{res.code} #{params}\n"
+          line += "\n  #{time_log} #{res.code} #{params}\n"
         end
         logger.info { line }
       end

data/spec/mangopay/card_registration_spec.rb

@@ -6,7 +6,6 @@ describe MangoPay::CardRegistration do
     it 'creates a new card registration' do
       created = new_card_registration
       expect(created['Id']).not_to be_nil
-      expect(created['Id'].to_i).to be > 0
       expect(created['AccessKey']).not_to be_nil
       expect(created['PreregistrationData']).not_to be_nil
       expect(created['CardRegistrationURL']).not_to be_nil
@@ -51,7 +50,6 @@ describe MangoPay::CardRegistration do
 
       # card id filled-in...
       expect(card_id).not_to be_nil
-      expect(card_id.to_i).to be > 0
 
       # ...and points to existing (newly created) card
       card = MangoPay::Card.fetch(card_id)

data/spec/mangopay/preauthorization_spec.rb

@@ -7,7 +7,6 @@ describe MangoPay::PreAuthorization do
       cardreg = new_card_registration_completed
       created = new_card_preauthorization
       expect(created['Id']).not_to be_nil
-      expect(created['Id'].to_i).to be > 0
       expect(created['CardId']).to eq(cardreg['CardId'])
       expect(created['AuthorId']).to eq(new_natural_user["Id"])
       expect(created['PayInId']).to be_nil

data/spec/mangopay/user_spec.rb

@@ -144,7 +144,6 @@ describe MangoPay::User do
         fetched = MangoPay::Card.fetch(card['CardId'])
 
         expect(fetched['Id']).not_to be_nil
-        expect(fetched['Id'].to_i).to be > 0
         expect(fetched['UserId']).to eq(new_natural_user["Id"])
         expect(fetched['Currency']).to eq('EUR')
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mangopay
 version: !ruby/object:Gem::Version
-  version: 3.24.0
+  version: 3.24.1
 platform: ruby
 authors:
 - Geoffroy Lorieux
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-04-02 00:00:00.000000000 Z
+date: 2024-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json