mangadex 5.3.1.1 → 5.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2c3906abcda03214729faefa84f1f28cf7685a56bb31d2759a75728c2dfe8633
-  data.tar.gz: 8ad9182042f2e00bd2d796d1278fbdd6ba3413ef66cd8c2c9946d2e79f5c9dc4
+  metadata.gz: 166fb230b0125992e5168515129718a28f7d545c3c1cb07f9bc81e837ad8c2c7
+  data.tar.gz: cf310df080bb7fdce3df2fd885aa478de4ae050272e58d97ce6fdbe0b60459af
 SHA512:
-  metadata.gz: d5e8f6bb17f8b565fd5b9068089282370c5f6b88d2707331ceeabbd35a7372f937c9a8e71ee41fe6c32b249950ed8908a429456d65369610ee1976b50329122a
-  data.tar.gz: d4e78fc2cae3bdc612b2cf739d989a5590e2a95fe6256dfc2cc5c9120dd07a727d2557dc9ae9461b16e080c0bb8950e8562333679c0cef7f569e4c6d5c917b9e
+  metadata.gz: 4babccf80e64908e70f612d5afb152b00fef108c827cbfc75a273478ee2f1230b6b2366318bab5a3fadb3b2025e0e7a64bed88746c04484d18a9c1a62a241e2a
+  data.tar.gz: aebcdeed93c99b1beb9e4723e8371875c21da6629311270cbf2b6ca5c58c55b0dca39e8a222bcd886180ee7b1059e40853948f90a25553da4dea8f1d261b4f44

data/.github/workflows/ruby.yml

@@ -0,0 +1,36 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Ruby
+
+on:
+  push:
+    branches: [culture]
+  pull_request:
+    branches: [culture]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ["2.7", "3.0"]
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+        # change this to (see https://github.com/ruby/setup-ruby#versioning):
+        # uses: ruby/setup-ruby@v1
+        uses: ruby/setup-ruby@473e4d8fe5dd94ee328fdfca9f8c9c7afc9dae5e
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Run tests
+        run: bundle exec rspec
+      - name: Run sorbet typecheck
+        run: bundle exec srb tc

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mangadex (5.3.1)
+    mangadex (5.3.2)
       activesupport (~> 6.1)
       psych (~> 4.0.1)
       rest-client (~> 2.1)
@@ -16,11 +16,16 @@ GEM
       minitest (>= 5.1)
       tzinfo (~> 2.0)
       zeitwerk (~> 2.3)
+    addressable (2.8.0)
+      public_suffix (>= 2.0.2, < 5.0)
     coderay (1.1.3)
     concurrent-ruby (1.1.9)
+    crack (0.4.5)
+      rexml
     diff-lcs (1.4.4)
     domain_name (0.5.20190701)
       unf (>= 0.0.5, < 1.0.0)
+    hashdiff (1.0.1)
     http-accept (1.7.0)
     http-cookie (1.0.4)
       domain_name (~> 0.5)
@@ -31,17 +36,30 @@ GEM
       mime-types-data (~> 3.2015)
     mime-types-data (3.2021.0901)
     minitest (5.14.4)
+    mustermann (1.1.1)
+      ruby2_keywords (~> 0.0.1)
     netrc (0.11.0)
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
     psych (4.0.1)
-    rake (10.5.0)
+    public_suffix (4.0.6)
+    rack (2.2.3)
+    rack-protection (2.1.0)
+      rack
+    rake (13.0.6)
+    request_interceptor (1.0.0)
+      activesupport (>= 4.0)
+      rack
+      sinatra
+      smart_properties (~> 1.0)
+      webmock (~> 3.0)
     rest-client (2.1.0)
       http-accept (>= 1.7.0, < 2.0)
       http-cookie (>= 1.0.2, < 2.0)
       mime-types (>= 1.16, < 4.0)
       netrc (~> 0.8)
+    rexml (3.2.5)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)
       rspec-expectations (~> 3.10.0)
@@ -55,16 +73,28 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-support (3.10.2)
+    ruby2_keywords (0.0.5)
+    sinatra (2.1.0)
+      mustermann (~> 1.0)
+      rack (~> 2.2)
+      rack-protection (= 2.1.0)
+      tilt (~> 2.0)
+    smart_properties (1.16.3)
     sorbet (0.5.9152)
       sorbet-static (= 0.5.9152)
-    sorbet-runtime (0.5.9152)
+    sorbet-runtime (0.5.9161)
     sorbet-static (0.5.9152-universal-darwin-20)
     sorbet-static (0.5.9152-x86_64-linux)
+    tilt (2.0.10)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.8)
+    webmock (3.14.0)
+      addressable (>= 2.8.0)
+      crack (>= 0.3.2)
+      hashdiff (>= 0.4.0, < 2.0.0)
     zeitwerk (2.4.2)
 
 PLATFORMS
@@ -75,7 +105,8 @@ DEPENDENCIES
   bundler (~> 2.2.19)
   mangadex!
   pry
-  rake (~> 10.0)
+  rake (~> 13.0)
+  request_interceptor (~> 1.0.0)
   rspec (~> 3.0)
   sorbet
 

data/README.md

@@ -1,3 +1,5 @@
+[![Ruby](https://github.com/thedrummeraki/mangadex/actions/workflows/ruby.yml/badge.svg)](https://github.com/thedrummeraki/mangadex/actions/workflows/ruby.yml)<a href="https://rubygems.org/gems/mangadex"><img src="https://badgen.net/rubygems/v/mangadex" /></a>
+
 # Mangadex
 
 Welcome to `mangadex`, your next favourite Ruby gem for interacting with [Mangadex](https://mangadex.org).
@@ -20,7 +22,7 @@ Or install it yourself as:
 
 ## Usage
 
-Please note that I tried my best to follow Mangadex's naming conventions for [their documentation](https://api.mangadex.org).
+Please note that I tried my best to follow Mangadex's naming conventions for [their documentation](https://api.mangadex.org). Track the progress [here in an issue](https://github.com/thedrummeraki/mangadex/issues/5).
 To find out how to use the gem, you're welcome to [check this out](lib/mangadex).
 
 ## Development

data/lib/mangadex/api/context.rb

@@ -2,52 +2,89 @@
 module Mangadex
   module Api
     class Context
+      extend T::Sig
+
       @@user = nil
+      @@version = nil
+      @@force_raw_requests = nil
 
-      class << self
-        def user
-          @@user&.with_valid_session
-        end
+      sig { returns(T.nilable(String)) }
+      def self.version
+        return @@version unless @@version.nil?
 
-        def user=(user)
-          if user.is_a?(Mangadex::Api::User)
-            @@user = user
-          elsif user.is_a?(Mangadex::User)
-            @@user = Mangadex::Api::User.new(
-              user.id,
-              data: user,
-            )
-          elsif user.is_a?(Hash)
-            user = user.with_indifferent_access
-
-            @@user = Mangadex::Api::User.new(
-              user[:mangadex_user_id],
-              session: user[:session],
-              refresh: user[:refresh],
-            )
-          elsif user.nil?
-            @@user = nil
-          else
-            raise ArgumentError, "Must be an instance of #{Mangadex::Api::User}, #{Mangadex::User} or Hash"
-          end
-        end
+        @@version = Mangadex::Api::Version.check_mangadex_version
+      end
 
-        def with_user(user)
-          current_user = @@user
+      sig { returns(T.nilable(Mangadex::Api::User)) }
+      def self.user
+        @@user&.with_valid_session
+      end
+
+      sig { params(user: T.nilable(T.any(Hash, Mangadex::Api::User, Mangadex::User))).void }
+      def self.user=(user)
+        if user.is_a?(Mangadex::Api::User)
           @@user = user
-          response = yield
-          @@user = current_user
-          response
-        ensure
-          @@user = current_user
+        elsif user.is_a?(Mangadex::User)
+          @@user = Mangadex::Api::User.new(
+            user.id,
+            data: user,
+          )
+        elsif user.is_a?(Hash)
+          user = user.with_indifferent_access
+
+          @@user = Mangadex::Api::User.new(
+            user[:mangadex_user_id],
+            session: user[:session],
+            refresh: user[:refresh],
+          )
+        elsif user.nil?
+          @@user = nil
         end
+      end
 
-        def without_user
-          with_user(nil) do
+      sig { params(user: T.nilable(T.any(Hash, Mangadex::Api::User, Mangadex::User)), block: T.proc.returns(T.untyped)).returns(T.untyped) }
+      def self.with_user(user, &block)
+        current_user = @@user
+        @@user = user
+        response = yield
+        @@user = current_user
+        response
+      ensure
+        @@user = current_user
+      end
+
+      sig { params(block: T.proc.returns(T.untyped)).returns(T.untyped) }
+      def self.without_user(&block)
+        with_user(nil) do
+          yield
+        end
+      end
+
+      def self.force_raw_requests(&block)
+        if block_given?
+          temp_force_raw_requests do
             yield
           end
+        else
+          !!@@force_raw_requests
         end
       end
+
+      def self.force_raw_requests=(value)
+        @@force_raw_requests = value
+      end
+
+      private
+
+      def self.temp_force_raw_requests(&block)
+        current_force_raw_requests = @@force_raw_requests
+        @@force_raw_requests = true
+        response = yield
+        @@force_raw_requests = current_force_raw_requests
+        response
+      ensure
+        @@force_raw_requests = current_force_raw_requests
+      end
     end
   end
 end

data/lib/mangadex/api/response.rb

@@ -7,6 +7,7 @@ module Mangadex
 
       attr_accessor :result, :response, :errors, :data
       attr_accessor :limit, :offset, :total
+      attr_accessor :raw_data
 
       def self.attributes_to_inspect
         %i(result errors limit offset total data)
@@ -40,6 +41,14 @@ module Mangadex
         end
       end
 
+      def errored?
+        Array(errors).any?
+      end
+
+      def as_json(*)
+        Hash(raw_data)
+      end
+
       private
 
       def self.coerce_errors(data)
@@ -56,6 +65,7 @@ module Mangadex
               )
             end
           ),
+          raw_data: data,
         )
       end
 
@@ -71,6 +81,7 @@ module Mangadex
           result: data['result'],
           response: data['response'],
           data: klass.from_data(data['data'] || data),
+          raw_data: data,
         )
       end
 
@@ -93,12 +104,9 @@ module Mangadex
               end
             )
           ),
+          raw_data: data,
         )
       end
-
-      def errored?
-        Array(errors).any?
-      end
     end
   end
 end

data/lib/mangadex/api/user.rb

@@ -2,9 +2,12 @@
 module Mangadex
   module Api
     class User
+      extend T::Sig
+
       attr_accessor :mangadex_user_id, :session, :refresh, :session_valid_until
       attr_reader :data
 
+      sig { params(mangadex_user_id: String, session: T.nilable(String), refresh: T.nilable(String), data: T.untyped).void }
       def initialize(mangadex_user_id, session: nil, refresh: nil, data: nil)
         raise ArgumentError, 'Missing mangadex_user_id' if mangadex_user_id.to_s.empty?
 
@@ -15,9 +18,9 @@ module Mangadex
         @data = data
       end
 
-      # nil: Nothing happened, no need to refresh the token
       # true: The tokens were successfully refreshed
       # false: Error: refresh token empty or could not refresh the token on the server
+      sig { returns(T::Boolean) }
       def refresh!
         return false if refresh.nil?
 
@@ -33,6 +36,7 @@ module Mangadex
         true
       end
 
+      sig { returns(Mangadex::Api::User) }
       def with_valid_session
         session_expired? && refresh!
         self
@@ -40,6 +44,7 @@ module Mangadex
         self
       end
 
+      sig { returns(T::Boolean) }
       def session_expired?
         @session_valid_until.nil? || @session_valid_until <= Time.now
       end

data/lib/mangadex/api/version_checker.rb

@@ -0,0 +1,31 @@
+# typed: true
+require "psych"
+
+module Mangadex
+  module Api
+    class Version
+      extend T::Sig
+
+      sig { returns(T.nilable(String)) }
+      def self.check_mangadex_version
+        puts("Checking Mangadex's latest API version...")
+        version = Psych.load(
+          RestClient.get(
+            'https://api.mangadex.org/api.yaml',
+          ).body,
+        ).dig('info', 'version')
+
+        if version != Mangadex::Version::STRING
+          warn(
+            "[Warning] This gem is compatible with #{Mangadex::Version::STRING} but it looks like Mangadex is at #{version}",
+            "[Warning] Check out #{Mangadex::Internal::Request::BASE_URI} for more information.",
+          )
+        end
+
+        version
+      rescue => error
+        nil
+      end
+    end
+  end
+end

data/lib/mangadex/api.rb

@@ -1,5 +1,5 @@
 # typed: strict
-require_relative "api/version"
+require_relative "api/version_checker"
 require_relative "api/context"
 require_relative "api/response"
 require_relative "api/user"

data/lib/mangadex/auth.rb

@@ -1,56 +1,60 @@
 # typed: false
 module Mangadex
   class Auth
-    class << self
-      def login(username, password)
-        response = Mangadex::Internal::Request.post(
-          '/auth/login',
-          payload: {
-            username: username,
-            password: password,
-          },
-        )
-        return response if response.is_a?(Mangadex::Api::Response) && response.errored?
-
-        session = response.dig('token', 'session')
-        refresh = response.dig('token', 'refresh')
-
-        mangadex_user = Mangadex::Internal::Request.get('/user/me', headers: { Authorization: session })
+    extend T::Sig
+
+    sig { params(username: String, password: String).returns(T.any(T::Boolean, Mangadex::Api::Response)) }
+    def self.login(username, password)
+      response = Mangadex::Internal::Request.post(
+        '/auth/login',
+        payload: {
+          username: username,
+          password: password,
+        },
+      )
+      return response if response.is_a?(Mangadex::Api::Response) && response.errored?
+
+      session = response.dig('token', 'session')
+      refresh = response.dig('token', 'refresh')
+
+      mangadex_user = Mangadex::Internal::Request.get('/user/me', headers: { Authorization: session })
+
+      user = Mangadex::Api::User.new(
+        mangadex_user.data.id,
+        session: session,
+        refresh: refresh,
+        data: mangadex_user.data,
+      )
+      Mangadex::Api::Context.user = user
+      !user.session_expired?
+    end
 
-        user = Mangadex::Api::User.new(
-          mangadex_user.data.id,
-          session: session,
-          refresh: refresh,
-          data: mangadex_user.data,
+    sig { returns(Hash) }
+    def self.check_token
+      JSON.parse(
+        Mangadex::Internal::Request.get(
+          '/auth/check',
+          raw: true,
         )
-        Mangadex::Api::Context.user = user
-        !user.session_expired?
-      end
-
-      def check_token
-        JSON.parse(
-          Mangadex::Internal::Request.get(
-            '/auth/check',
-            raw: true,
-          )
-        )
-      end
+      )
+    end
 
-      def logout
-        return true if Mangadex::Api::Context.user.nil?
+    sig { returns(T.any(T::Boolean, Mangadex::Api::Response)) }
+    def self.logout
+      return true if Mangadex::Api::Context.user.nil?
 
-        response = Mangadex::Internal::Request.post(
-          '/auth/logout',
-        )
-        return reponse if response.is_a?(Mangadex::Api::Response) && response.errored?
+      response = Mangadex::Internal::Request.post(
+        '/auth/logout',
+      )
+      return reponse if response.is_a?(Mangadex::Api::Response) && response.errored?
 
-        Mangadex::Api::Context.user = nil
-        true
-      end
+      Mangadex::Api::Context.user = nil
+      true
+    end
 
-      def refresh_token
-        !(Mangadex::Api::Context.user&.refresh!).nil?
-      end
+    sig { returns(T::Boolean) }
+    def self.refresh_token
+      !(Mangadex::Api::Context.user&.refresh!).nil?
     end
   end
 end

data/lib/mangadex/author.rb

@@ -4,7 +4,24 @@ require_relative 'mangadex_object'
 
 module Mangadex
   class Author < MangadexObject
-    has_attributes :name, :image_url, :biography, :version, :created_at, :updated_at
+    has_attributes \
+      :name,
+      :image_url,
+      :biography,
+      :twitter,
+      :pixiv,
+      :melon_book,
+      :fan_box,
+      :booth,
+      :nicovideo,
+      :skeb,
+      :fantia,
+      :tumblr,
+      :youtube,
+      :website,
+      :version,
+      :created_at,
+      :updated_at
 
     # List all authors.
     # Path: +GET /author+
@@ -49,6 +66,8 @@ module Mangadex
     # @return [Mangadex::Api::Response] with a entity of author
     sig { params(id: String, args: T::Api::Arguments).returns(Mangadex::Api::Response[Author]) }
     def self.get(id, **args)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.get(
         format('/author/%{id}', id: id),
         Mangadex::Internal::Definition.validate(args, {
@@ -64,6 +83,8 @@ module Mangadex
     # @return [Mangadex::Api::Response] with a entity of author
     sig { params(id: String, args: T::Api::Arguments).returns(Mangadex::Api::Response[Author]) }
     def self.update(id, **args)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.put(
         format('/author/%{id}', id: id),
         payload: Mangadex::Internal::Definition.validate(args, {
@@ -81,6 +102,8 @@ module Mangadex
     # @return [Hash]
     sig { params(id: String).returns(Hash) }
     def self.delete(id)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.delete(
         format('/author/%{id}', id: id)
       )
@@ -90,6 +113,10 @@ module Mangadex
       [:name]
     end
 
+    class << self
+      alias_method :view, :get
+    end
+
     # Indicates if this is an artist
     #
     # @return [Boolean] whether this is an artist or not.

data/lib/mangadex/chapter.rb

@@ -31,6 +31,8 @@ module Mangadex
 
     sig { params(id: String, args: T::Api::Arguments).returns(Mangadex::Api::Response[Chapter]) }
     def self.get(id, **args)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.get(
         '/chapter/%{id}' % {id: id},
         Mangadex::Internal::Definition.validate(args, {
@@ -41,6 +43,8 @@ module Mangadex
 
     sig { params(id: String, args: T::Api::Arguments).returns(Mangadex::Api::Response[Chapter]) }
     def self.update(id, **args)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.put(
         '/chapter/%{id}' % {id: id},
         payload: Mangadex::Internal::Definition.validate(args, {
@@ -56,11 +60,17 @@ module Mangadex
 
     sig { params(id: String).returns(Hash) }
     def self.delete(id)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.delete(
         '/chapter/%{id}' % {id: id},
       )
     end
 
+    class << self
+      alias_method :view, :get
+    end
+
     sig { returns(String) }
     def title
       attributes&.title.presence || chapter.presence && "Chapter #{chapter}" || "N/A"

data/lib/mangadex/content_rating.rb

@@ -64,7 +64,7 @@ module Mangadex
 
     private
 
-    sig { params(value: T.any(T::Api::Text, T::Api::ContentRating)).void }
+    sig { params(value: T.any(T::Api::Text, T::Api::ContentRating)).returns(T.any(T::Api::Text, T::Api::ContentRating)) }
     def ensure_value!(value)
       return value if value.is_a?(ContentRating)
       return value if VALUES.include?(value)

data/lib/mangadex/cover_art.rb

@@ -47,6 +47,8 @@ module Mangadex
 
     sig { params(id: String, args: T::Api::Arguments).returns(Mangadex::Api::Response[CoverArt]) }
     def self.get(id, **args)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.get(
         '/cover/%{id}' % {id: id},
         Mangadex::Internal::Definition.validate(args, {
@@ -57,6 +59,8 @@ module Mangadex
 
     sig { params(id: String, args: T::Api::Arguments).returns(Mangadex::Api::Response[CoverArt]) }
     def self.edit(id, **args)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.put(
         '/cover/%{id}' % {id: id},
         Mangadex::Internal::Definition.validate(args, {
@@ -69,11 +73,18 @@ module Mangadex
 
     sig { params(id: String).returns(Hash) }
     def self.delete(id)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.delete(
         '/cover/%{id}' % {id: id},
       )
     end
 
+    class << self
+      alias_method :view, :get
+      alias_method :update, :edit
+    end
+
     sig { params(size: T::Api::Text).returns(T.nilable(String)) }
     def image_url(size: :small)
       return unless manga.present?

data/lib/mangadex/custom_list.rb

@@ -24,6 +24,8 @@ module Mangadex
 
     sig { params(id: String).returns(Mangadex::Api::Response[CustomList]) }
     def self.get(id)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.get(
         '/list/%{id}' % {id: id},
       )
@@ -31,6 +33,8 @@ module Mangadex
 
     sig { params(id: String, args: T::Api::Arguments).returns(Mangadex::Api::Response[CustomList]) }
     def self.update(id, **args)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.put(
         '/list/%{id}' % {id: id},
         payload: Mangadex::Internal::Definition.validate(args, {
@@ -44,6 +48,8 @@ module Mangadex
 
     sig { params(id: String).returns(T::Boolean) }
     def self.delete(id)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.delete(
         '/list/%{id}' % {id: id},
       )
@@ -51,6 +57,8 @@ module Mangadex
 
     sig { params(id: String, args: T::Api::Arguments).returns(Mangadex::Api::Response[Chapter]) }
     def self.feed(id, **args)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.get(
         '/list/%{id}/feed' % {id: id},
         Mangadex::Internal::Definition.chapter_list(args),
@@ -59,6 +67,8 @@ module Mangadex
 
     sig { params(id: String, list_id: String).returns(T::Boolean) }
     def self.add_manga(id, list_id:)
+      Mangadex::Internal::Definition.must(id)
+
       response = Mangadex::Internal::Request.post(
         '/manga/%{id}/list/%{list_id}' % {id: id, list_id: list_id},
       )
@@ -71,6 +81,8 @@ module Mangadex
 
     sig { params(id: String, list_id: String).returns(T::Boolean) }
     def self.remove_manga(id, list_id:)
+      Mangadex::Internal::Definition.must(id)
+
       response = Mangadex::Internal::Request.delete(
         '/manga/%{id}/list/%{list_id}' % {id: id, list_id: list_id},
       )
@@ -94,6 +106,8 @@ module Mangadex
 
     sig { params(user_id: String, args: T::Api::Arguments).returns(Mangadex::Api::Response[CustomList]) }
     def self.user_list(user_id, **args)
+      Mangadex::Internal::Definition.must(user_id)
+
       Mangadex::Internal::Request.get(
         '/user/%{id}/list' % {id: user_id},
         Mangadex::Internal::Definition.validate(args, {
@@ -103,6 +117,11 @@ module Mangadex
       )
     end
 
+    class << self
+      alias_method :view, :get
+      alias_method :edit, :update
+    end
+
     sig { params(id: String).returns(T::Boolean) }
     def add_manga(id)
       Mangadex::CustomList.add_manga(id, list_id: self.id)

data/lib/mangadex/internal/definition.rb

@@ -120,6 +120,19 @@ module Mangadex
           )
         end
 
+        def must(*args)
+          args = args.each_with_index.map do |arg, index|
+            ["arg_at_position_#{index}".to_sym, arg]
+          end.to_h
+
+          definition = args.keys.map do |key|
+            [key, { required: true }]
+          end.to_h
+
+          validate(args, definition)
+          args.values
+        end
+
         def validate(args, definition)
           args = Hash(args).with_indifferent_access
           definition = Hash(definition).with_indifferent_access
@@ -144,7 +157,7 @@ module Mangadex
           if errors.any?
             error_message = errors.map do |error|
               if error[:extra]
-                "params[:#{error[:extra]}] does not exist and cannot be passed to this request"
+                "paalidate_required!rams[:#{error[:extra]}] does not exist and cannot be passed to this request"
               elsif error[:message]
                 error[:message]
               else

data/lib/mangadex/internal/request.rb

@@ -62,13 +62,15 @@ module Mangadex
         end_time = Time.now
         elapsed_time = ((end_time - start_time) * 1000).to_i
         puts("[#{self.class.name}] took #{elapsed_time} ms")
+        
+        raw_request = raw || Mangadex::Api::Context.force_raw_requests
 
-        if @response.body
-          raw ? @response.body : Mangadex::Api::Response.coerce(JSON.parse(@response.body))
+        if (body = @response.body)
+          raw_request ? try_json(body) : Mangadex::Api::Response.coerce(try_json(body))
         end
       rescue RestClient::Exception => error
-        if error.response.body
-          raw ? error.response.body : Mangadex::Api::Response.coerce(JSON.parse(error.response.body))
+        if (body = error.response.body)
+          raw_request ? try_json(body) : Mangadex::Api::Response.coerce(JSON.parse(body)) rescue raise error
         else
           raise error
         end
@@ -116,6 +118,12 @@ module Mangadex
 
         raise "Invalid method: #{method}. Must be one of: #{ALLOWED_METHODS}"
       end
+
+      def try_json(body)
+        JSON.parse(body)
+      rescue JSON::ParserError
+        body
+      end
     end
   end
 end

data/lib/mangadex/internal/with_attributes.rb

@@ -11,7 +11,8 @@ module Mangadex
           :id,
           :type,
           :attributes,
-          :relationships
+          :relationships,
+          :related_type
       
       class_methods do
         USING_ATTRIBUTES = {}
@@ -30,7 +31,7 @@ module Mangadex
           self.name.split('::').last.underscore
         end
 
-        def from_data(data)
+        def from_data(data, related_type: nil)
           base_class_name = self.name.gsub('::', '_')
           klass_name = self.name
           target_attributes_class_name = "#{base_class_name}_Attributes"
@@ -65,6 +66,7 @@ module Mangadex
             id: data['id'],
             type: data['type'] || self.type,
             attributes: attributes,
+            related_type: related_type,
           }
 
           initialize_hash.merge!({relationships: relationships}) if relationships.present?
@@ -110,6 +112,13 @@ module Mangadex
             else
               super
             end
+          elsif !related_type.nil?
+            return super unless method_name.end_with?("?")
+
+            looking_for_related = method_name.to_s.split("?").first
+            return super unless Mangadex::Relationship::RELATED_VALUES.include?(looking_for_related)
+
+            related_type == looking_for_related
           else
             super
           end

data/lib/mangadex/manga.rb

@@ -66,6 +66,8 @@ module Mangadex
 
     sig { params(id: String, args: T::Api::Arguments).returns(T::Api::MangaResponse) }
     def self.view(id, **args)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.get(
         '/manga/%{id}' % {id: id},
         Mangadex::Internal::Definition.validate(args, {
@@ -76,6 +78,8 @@ module Mangadex
 
     sig { params(id: String).returns(T.any(Hash, Mangadex::Api::Response)) }
     def self.unfollow(id)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.delete(
         '/manga/%{id}/follow' % {id: id},
       )
@@ -83,6 +87,8 @@ module Mangadex
 
     sig { params(id: String).returns(T.any(Hash, Mangadex::Api::Response)) }
     def self.follow(id)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.post(
         '/manga/%{id}/follow' % {id: id},
       )
@@ -90,6 +96,8 @@ module Mangadex
 
     sig { params(id: String, args: T::Api::Arguments).returns(T::Api::ChapterResponse) }
     def self.feed(id, **args)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.get(
         '/manga/%{id}/feed' % {id: id},
         Mangadex::Internal::Definition.chapter_list(args),
@@ -128,6 +136,8 @@ module Mangadex
 
     sig { params(id: String).returns(T::Api::GenericResponse) }
     def self.reading_status(id)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.get(
         '/manga/%{id}/status' % {id: id},
       )
@@ -135,6 +145,8 @@ module Mangadex
 
     sig { params(id: String, status: String).returns(T::Api::GenericResponse) }
     def self.update_reading_status(id, status)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.post(
         '/manga/%{id}/status' % {id: id},
         payload: Mangadex::Internal::Definition.validate({status: status}, {
@@ -149,11 +161,15 @@ module Mangadex
     # Untested API endpoints
     sig { params(id: String, args: T::Api::Arguments).returns(T::Api::MangaResponse) }
     def self.update(id, **args)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.put('/manga/%{id}' % {id: id}, payload: args)
     end
 
     sig { params(id: String).returns(Hash) }
     def self.delete(id)
+      Mangadex::Internal::Definition.must(id)
+
       Mangadex::Internal::Request.delete(
         '/manga/%{id}' % {id: id},
       )
@@ -169,6 +185,8 @@ module Mangadex
 
     class << self
       alias_method :aggregate, :volumes_and_chapters
+      alias_method :get, :view
+      alias_method :edit, :update
     end
 
     sig { returns(T.nilable(ContentRating)) }

data/lib/mangadex/relationship.rb

@@ -1,33 +1,45 @@
 # typed: false
 module Mangadex
   class Relationship < MangadexObject
-    attr_accessor :id, :type, :attributes
+    attr_accessor :id, :type, :related, :attributes
+
+    RELATED_VALUES = %w(
+      monochrome
+      main_story
+      adapted_from
+      based_on
+      prequel
+      side_story
+      doujinshi
+      same_franchise
+      shared_universe
+      sequel
+      spin_off
+      alternate_story
+      preserialization
+      colored
+      serialization
+    ).freeze
 
     class << self
       def from_data(data)
         data = data.with_indifferent_access
         klass = class_for_relationship_type(data['type'])
 
-        return klass.from_data(data) if klass && data['attributes']&.any?
+        if klass && data['attributes']&.any?
+          return klass.from_data(data, related_type: data['related'])
+        end
 
         new(
           id: data['id'],
           type: data['type'],
           attributes: OpenStruct.new(data['attributes']),
+          related: data['related'],
         )
       end
 
       private
 
-      def build_attributes(data)
-        klass = class_for_relationship_type(data['type'])
-        if klass.present?
-          klass.from_data(data)
-        else
-          OpenStruct.new(data['attributes'])
-        end
-      end
-
       def class_for_relationship_type(type)
         module_parts = self.name.split('::')
         module_name = module_parts.take(module_parts.size - 1).join('::')
@@ -39,8 +51,18 @@ module Mangadex
       end
     end
 
-    def inspect
-      "#<#{self.class} id=#{id.inspect} type=#{type.inspect}>"
+    def self.attributes_to_inspect
+      [:id, :type, :related]
+    end
+
+    
+    def method_missing(value)
+      return super unless value.end_with?("?")
+
+      looking_for_related = value.to_s.split("?").first
+      return super unless RELATED_VALUES.include?(looking_for_related)
+
+      !related.nil? && related == looking_for_related
     end
   end
 end

data/lib/mangadex/scanlation_group.rb

@@ -3,6 +3,7 @@ module Mangadex
   class ScanlationGroup < MangadexObject
     has_attributes \
       :name,
+      :alt_names,
       :website,
       :irc_channel,
       :irc_server,
@@ -47,6 +48,8 @@ module Mangadex
       end
 
       def view(id)
+        Mangadex::Internal::Definition.must(id)
+
         Mangadex::Internal::Request.get(
           '/group/%{id}' % {id: id},
           Mangadex::Internal::Definition.validate(args, {
@@ -91,6 +94,11 @@ module Mangadex
       end
     end
 
+    class << self
+      alias_method :get, :view
+      alias_method :edit, :update
+    end
+
     def self.inspect_attributes
       self.attributes - [:version, :created_at, :updated_at]
     end

data/lib/mangadex/sorbet.rb

@@ -17,7 +17,8 @@ module T
     MangaResponse = T.type_alias do
       T.any(
         Mangadex::Api::Response[Mangadex::Manga],
-        Mangadex::Api::Response[T::Array[Mangadex::Manga]]
+        Mangadex::Api::Response[T::Array[Mangadex::Manga]],
+        Hash,
       )
     end
     ChapterResponse = T.type_alias do

data/lib/mangadex/upload.rb

@@ -28,6 +28,8 @@ module Mangadex
       alias_method :begin, :start
 
       def upload_images(upload_session_id)
+        Mangadex::Internal::Definition.must(upload_session_id)
+
         Mangadex::Internal::Request.post(
           '/upload/%{upload_session_id}' % {upload_session_id: upload_session_id},
           payload: Mangadex::Internal::Definition.validate(args, {
@@ -37,6 +39,8 @@ module Mangadex
       end
 
       def abandon(upload_session_id)
+        Mangadex::Internal::Definition.must(upload_session_id)
+
         Mangadex::Internal::Request.delete(
           '/upload/%{upload_session_id}' % {upload_session_id: upload_session_id},
         )
@@ -44,6 +48,8 @@ module Mangadex
       alias_method :stop, :abandon
 
       def commit(upload_session_id, **args)
+        Mangadex::Internal::Definition.must(upload_session_id)
+
         Mangadex::Internal::Request.post(
           '/upload/%{upload_session_id}/commit' % {upload_session_id: upload_session_id},
           payload: Mangadex::Internal::Definition.validate(args, {
@@ -54,6 +60,8 @@ module Mangadex
       end
 
       def delete_uploaded_image(upload_session_id, upload_session_file_id)
+        Mangadex::Internal::Definition.must(upload_session_id)
+
         Mangadex::Internal::Request.delete(
           '/upload/%{upload_session_id}/%{upload_session_file_id}' % {
             upload_session_id: upload_session_id,
@@ -63,6 +71,8 @@ module Mangadex
       end
 
       def delete_uploaded_images(upload_session_id, upload_session_file_ids)
+        Mangadex::Internal::Definition.must(upload_session_id)
+
         Mangadex::Internal::Request.delete(
           '/upload/%{upload_session_id}' % {upload_session_id: upload_session_id},
           payload: Array(upload_session_file_id),

data/lib/mangadex/user.rb

@@ -30,6 +30,8 @@ module Mangadex
 
     sig { params(id: String).returns(T::Boolean) }
     def self.follows_group(id)
+      Mangadex::Internal::Definition.must(id)
+
       data = Mangadex::Internal::Request.get(
         '/user/follows/group/%{id}' % {id: id},
         raw: true,
@@ -55,6 +57,8 @@ module Mangadex
 
     sig { params(id: String).returns(T::Boolean) }
     def self.follows_user(id)
+      Mangadex::Internal::Definition.must(id)
+
       return if Mangadex::Api::Context.user.nil?
 
       data = Mangadex::Internal::Request.get(
@@ -83,6 +87,8 @@ module Mangadex
 
     sig { params(id: String).returns(T::Boolean) }
     def self.follows_manga(id)
+      Mangadex::Internal::Definition.must(id)
+
       return if Mangadex::Api::Context.user.nil?
 
       data = Mangadex::Internal::Request.get(

data/lib/mangadex/version.rb

@@ -1,4 +1,12 @@
-# typed: strict
+# typed: false
 module Mangadex
-  VERSION = "5.3.1.1"
+  module Version
+    MAJOR = "5"
+    MINOR = "3"
+    TINY = "3"
+    PATCH = nil
+
+    STRING = [MAJOR, MINOR, TINY].compact.join('.')
+    FULL = [MAJOR, MINOR, TINY, PATCH].compact.join('.')
+  end
 end

data/mangadex.gemspec

@@ -5,7 +5,7 @@ require "mangadex/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "mangadex"
-  spec.version       = Mangadex::VERSION
+  spec.version       = Mangadex::Version::FULL
   spec.authors       = ["Akinyele Cafe-Febrissy"]
   spec.email         = ["me@akinyele.ca"]
 
@@ -28,8 +28,9 @@ Gem::Specification.new do |spec|
   spec.add_dependency "sorbet-runtime"
 
   spec.add_development_dependency "bundler", "~> 2.2.19"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "request_interceptor", "~> 1.0.0"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "sorbet"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mangadex
 version: !ruby/object:Gem::Version
-  version: 5.3.1.1
+  version: 5.3.3
 platform: ruby
 authors:
 - Akinyele Cafe-Febrissy
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-09-22 00:00:00.000000000 Z
+date: 2021-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: psych
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -108,6 +108,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: request_interceptor
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -143,6 +157,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rspec"
 - ".ruby-version"
@@ -162,7 +177,7 @@ files:
 - lib/mangadex/api/context.rb
 - lib/mangadex/api/response.rb
 - lib/mangadex/api/user.rb
-- lib/mangadex/api/version.rb
+- lib/mangadex/api/version_checker.rb
 - lib/mangadex/artist.rb
 - lib/mangadex/auth.rb
 - lib/mangadex/author.rb

data/lib/mangadex/api/version.rb

@@ -1,23 +0,0 @@
-# typed: true
-require "psych"
-
-module Mangadex
-  module Api
-    VERSION = -> do
-      version = Psych.load(
-        RestClient.get(
-          'https://api.mangadex.org/api.yaml',
-        ).body,
-      ).dig('info', 'version')
-
-      if version != Mangadex::VERSION
-        warn(
-          "[Warning] This gem is compatible with #{Mangadex::VERSION} but it looks like Mangadex is at #{version}",
-          "[Warning] Check out #{Mangadex::Internal::Request::BASE_URI} for more information.",
-        )
-      end
-
-      version
-    end.call
-  end
-end