mandrill-rails 1.0.2 → 1.1.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YmQ2MDY0YjM3NjJmMjgxOTAyOWE2Y2JkZjYzMjA1MmY0MDAxNmZmNg==
+    M2JlYTA0MzljZWVlNzAzZTNkNzdiMmJkMjEzNTZhNjkyMjIxNzVhZQ==
   data.tar.gz: !binary |-
-    ZThjYmEyZTM5NDdjOGIzMWVlYzgwZjNlZDNkYzY2YTY3MGJjZjliNg==
+    OGJmZWEwMTI3MzA2MWQ4YjA3MzYwNWIwNTRiMjk4NmI0ODk2M2IxYg==
 SHA512:
   metadata.gz: !binary |-
-    YThjYTM1NTA4MDVkNzMzY2I1YjNjZjU3YTEyNzJkODcwOGJhZmZmMjNjYThm
-    YTRiNDAyZGUzZmVjNTYyODQ0MDdiODllNWVhYjE0ZDI1YTI3NTcwYzhmYTYw
-    M2ZmYWFhNGM3OWMxZTkxNzZhYjE3ZTU4YmM1MThiYTEzZDQ1YjE=
+    N2E3N2ZlZDE1MzMyMzM4ODA2M2IyOTVkMzc5NjdiNmVmMDE4Y2UxYWYwOTQ5
+    Mzc2ZGQyNDRiMjBhZGViMWE2MGQ1MGY2OTdhZTA3N2UwMDNhMWI5MGUyM2M5
+    YTdkOWNmNWJmYmVjZTgzMzIyMjBjNTkxN2E4OTk5NmMwOTBiYjQ=
   data.tar.gz: !binary |-
-    MWU3YWI2ODc4ZGQ3YTdkYzM1NTdiOTcxZTg2OGRlZDJhMDZmYmEzNGI3Nzhj
-    MzYwMGQ3OWZhNThjYzg2YmVmMzExNmQ5MDBjYzExNjAwZDhkYzU2ZTczZjAy
-    NjQ4NjkwYTNmM2YwOGY3YTlkOTY0Y2EzNDBkODZhMzViNWFlNmY=
+    MzM3OGI2NDhmOGM3ZDkwYWYxY2Y3ZmQ5YzczYTZlMGMxMDk1ZDU3MWZhZDAy
+    Mjc2ZDU4ZWE5M2I1ZjI2YTM5YmIzYzRiZGQzYWQ2NGViZWI5YWM4N2M3MjEx
+    NGQ1MjQ0ZmI2ZjA0YTFhZWYyMGRiNTAzMDNhYmU5NWUwYmQ1OGM=

data/lib/mandrill-rails.rb

@@ -5,4 +5,5 @@ require 'active_support/core_ext'
 
 require "mandrill-rails/version"
 require 'mandrill/web_hook'
+require 'mandrill-rails/errors'
 require 'mandrill-rails/web_hook_processor'

data/lib/mandrill-rails/errors.rb

@@ -0,0 +1,4 @@
+module Mandrill::Rails::Errors
+  Base                = Class.new(StandardError)
+  MissingEventHandler = Class.new(Base)
+end

data/lib/mandrill-rails/version.rb

@@ -3,5 +3,5 @@ module Mandrill
   end
 end
 unless defined?(Mandrill::Rails::VERSION)
-  Mandrill::Rails::VERSION = "1.0.2"
+  Mandrill::Rails::VERSION = "1.1.0"
 end

data/lib/mandrill/web_hook/event_decorator.rb

@@ -42,6 +42,11 @@ class Mandrill::WebHook::EventDecorator < Hash
     msg['_version']
   end
 
+  # Returns, if pre-configured, the metadata.
+  def metadata
+    msg['metadata']||{}
+  end
+
   # Returns the reply-to ID.
   # Applicable events: inbound
   def in_reply_to

data/lib/mandrill/web_hook/processor.rb

@@ -21,12 +21,13 @@ class Mandrill::WebHook::Processor
     mandrill_events.each do |raw_payload|
       event_payload = wrap_payload(raw_payload)
       handler = "handle_#{event_payload.event_type}".to_sym
-      if callback_host && callback_host.respond_to?(handler)
+      if callback_host && callback_host.respond_to?(handler, true)
         callback_host.send(handler,event_payload)
       elsif self.respond_to?(handler)
         self.send(handler,event_payload)
       else
-        # TODO raise an error
+        raise Mandrill::Rails::Errors::MissingEventHandler,
+          "Expected handler method `#{handler}` for event type `#{event_payload.event_type}`"
       end
     end
   end

data/spec/mandrill/web_hook/processor_spec.rb

@@ -20,18 +20,67 @@ describe Mandrill::WebHook::Processor do
       end
     end
     context "with callback host" do
-      let(:callback_host) do
-        host = double()
-        host.stub(:handle_inbound)
-        host
+      shared_examples_for 'pass event payload to the handler' do
+
       end
+
+      let(:callback_host) { callback_host_class.new }
       let(:processor) { processor_class.new(params,callback_host) }
       let(:event1) { { "event" => "inbound" } }
       let(:event2) { { "event" => "inbound" } }
       let(:params) { { "mandrill_events" => [event1,event2].to_json } }
-      it "should pass event payload to the handler" do
-        callback_host.should_receive(:handle_inbound).twice
-        processor.run!
+
+      context "with handler method as public" do
+        let(:callback_host_class) do
+          Class.new do
+            public
+
+            def handle_inbound; end
+          end
+        end
+
+        it "should pass event payload to the handler" do
+          callback_host.should_receive(:handle_inbound).twice
+          processor.run!
+        end
+      end
+      context "with handler method as protected" do
+        let(:callback_host_class) do
+          Class.new do
+            protected
+
+            def handle_inbound; end
+          end
+        end
+
+        it "should pass event payload to the handler" do
+          callback_host.should_receive(:handle_inbound).twice
+          processor.run!
+        end
+      end
+      context "with handler method as private" do
+        let(:callback_host_class) do
+          Class.new do
+            private
+
+            def handle_inbound; end
+          end
+        end
+
+        it "should pass event payload to the handler" do
+          callback_host.should_receive(:handle_inbound).twice
+          processor.run!
+        end
+      end
+    end
+    context "without handler method" do
+      let(:event1) { { "event" => "inbound" } }
+      let(:event2) { { "event" => "inbound" } }
+      let(:params) { { "mandrill_events" => [event1,event2].to_json } }
+
+      it "raises error on run!" do
+        expect { processor.run! }
+        .to raise_error(Mandrill::Rails::Errors::MissingEventHandler)
       end
     end
   end
@@ -79,4 +128,4 @@ describe Mandrill::WebHook::Processor do
     it { should eql(expected_signature) }
   end
 
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mandrill-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Paul Gallagher
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-20 00:00:00.000000000 Z
+date: 2015-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -110,6 +110,7 @@ files:
 - README.rdoc
 - Rakefile
 - lib/mandrill-rails.rb
+- lib/mandrill-rails/errors.rb
 - lib/mandrill-rails/version.rb
 - lib/mandrill-rails/web_hook_processor.rb
 - lib/mandrill/web_hook.rb
@@ -158,7 +159,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Provides webhook processing and event decoration to make using Mandrill with