manageiq-smartstate 0.6.2 → 0.7.0

data/lib/fs/iso9660/boot_sector.rb

@@ -1,11 +1,12 @@
 require 'fs/iso9660/util'
-
 require 'sys-uname'
 require 'binary_struct'
-require 'util/miq-unicode'
+require 'miq_unicode'
 
 module Iso9660
   class BootSector
+    using ManageIQ::UnicodeString
+
     # Universal Volume Descriptor ID.
     DESCRIPTOR_ID = "CD001"
 

data/lib/fs/iso9660/directory_entry.rb

@@ -1,10 +1,11 @@
 require 'fs/iso9660/util'
 require 'fs/iso9660/rock_ridge'
-
 require 'binary_struct'
-require 'util/miq-unicode'
+require 'miq_unicode'
 
 module Iso9660
+  using ManageIQ::UnicodeString
+
   # FlagBits: FB_
   FB_HIDDEN     = 0x01  # 0 if not hidden.
   FB_DIRECTORY  = 0x02  # 0 if file.

data/lib/fs/iso9660/rock_ridge.rb

@@ -1,7 +1,9 @@
 require 'binary_struct'
-require 'util/miq-unicode'
+require 'miq_unicode'
 
 module Iso9660
+  using ManageIQ::UnicodeString
+
   # SUSP extensions are present if the first two characters of the SUA of
   # the first directory entry are "SP". After SUSP is identified, if the
   # first two characters of any directory entry's SUA are "RR" a Rock Ridge

data/lib/fs/ntfs/attrib_attribute_list.rb

@@ -1,8 +1,10 @@
 require 'fs/ntfs/utils'
 require 'binary_struct'
-require 'util/miq-unicode'
+require 'miq_unicode'
 
 module NTFS
+  using ManageIQ::UnicodeString
+
   #
   # ATTR_LIST_ENTRY - Attribute: Attribute list (0x20).
   #

data/lib/fs/ntfs/attrib_file_name.rb

@@ -1,10 +1,12 @@
 require 'fs/ntfs/utils'
 require 'util/win32/nt_util'
 require 'binary_struct'
-require 'util/miq-unicode'
+require 'miq_unicode'
 require 'fs/ntfs/attrib_standard_information'
 
 module NTFS
+  using ManageIQ::UnicodeString
+
   #
   # FILE_NAME_ATTR - Attribute: Filename (0x30)
   #

data/lib/fs/ntfs/attrib_header.rb

@@ -1,9 +1,11 @@
 require 'binary_struct'
-require 'util/miq-unicode'
+require 'miq_unicode'
 require 'fs/ntfs/utils'
 require 'fs/ntfs/attrib_type'
 
 module NTFS
+  using ManageIQ::UnicodeString
+
   # Standard attribute header.
   # Each attribute begins with one of these.
   STANDARD_ATTRIBUTE_HEADER = BinaryStruct.new([

data/lib/fs/ntfs/attrib_index_root.rb

@@ -1,10 +1,12 @@
 require 'binary_struct'
-require 'util/miq-unicode'
+require 'miq_unicode'
 require 'fs/ntfs/index_node_header'
 require 'fs/ntfs/directory_index_node'
 require 'fs/ntfs/index_record_header'
 
 module NTFS
+  using ManageIQ::UnicodeString
+
   #
   # INDEX_ROOT - Attribute: Index root (0x90).
   #

data/lib/fs/ntfs/attrib_volume_name.rb

@@ -1,6 +1,8 @@
-require 'util/miq-unicode'
+require 'miq_unicode'
 
 module NTFS
+  using ManageIQ::UnicodeString
+
   #
   # VOLUME_NAME - Attribute: Volume name (0x60).
   #

data/lib/manageiq/smartstate/util.rb

@@ -13,6 +13,24 @@ module ManageIQ
       rescue
         return uri_path
       end
+
+      def self.base24_decode(byte_array)
+        digits = %w(B C D F G H J K M P Q R T V W X Y 2 3 4 6 7 8 9)
+        out = " " * 29
+        out.length.downto(0) do |i|
+          if i.modulo(6) == 0
+            out[i, 1] = "-"
+          else
+            map_index = 0
+            15.downto(0) do |j|
+              byte_value = (map_index << 8) | byte_array[j]
+              byte_array[j], map_index = byte_value.divmod(24)
+              out[i, 1] = digits[map_index]
+            end
+          end
+        end
+        out[1..-1]
+      end
     end
   end
 end

data/lib/manageiq/smartstate/version.rb

@@ -1,5 +1,5 @@
 module ManageIQ
   module Smartstate
-    VERSION = "0.6.2".freeze
+    VERSION = "0.7.0".freeze
   end
 end

data/lib/metadata/VmConfig/GetNativeCfg.rb

@@ -1,12 +1,10 @@
 require 'util/miq-xml'
-require 'util/runcmd'
 require 'metadata/VmConfig/VmConfig'
+require 'awesome_spawn'
 
 class GetNativeCfg
-  LSHW = "lshw"
-
   def self.new
-    lshwXml = MiqUtil.runcmd("#{LSHW} -xml")
+    lshwXml = AwesomeSpawn.run!("lshw", :params => ["-xml"], :combined_output => true).output
     nodeHash = Hash.new { |h, k| h[k] = [] }
     doc = MiqXml.load(lshwXml)
     doc.find_match("//node").each { |n| nodeHash[n.attributes["id"].split(':', 2)[0]] << n }

data/lib/metadata/VmConfig/VmConfig.rb

@@ -1,6 +1,6 @@
 require 'pathname'
 require 'metadata/VMMount/VMMount'
-require 'util/miq-unicode'
+require 'miq_unicode'
 require 'util/miq-xml'
 require 'VMwareWebService/MiqVimInventory'
 require 'timeout'
@@ -8,6 +8,8 @@ require 'util/miq-extensions'
 require 'VMwareWebService/MiqVimBroker'
 
 class VmConfig
+  using ManageIQ::UnicodeString
+
   attr_reader :configFile
 
   def initialize(filename)

data/lib/metadata/VmConfig/cfgConfig.rb

@@ -1,4 +1,8 @@
+require 'miq_unicode'
+
 module CfgConfig
+  using ManageIQ::UnicodeString
+
   def convert(filename)
     @convertText = ""
     $log.debug "Processing Windows Configuration file [#{filename}]"

data/lib/metadata/VmConfig/xmlConfig.rb

@@ -1,5 +1,5 @@
 require 'util/miq-xml'
-require 'util/runcmd'
+require 'awesome_spawn'
 
 module XmlConfig
   def convert(filename)
@@ -12,9 +12,9 @@ module XmlConfig
       if Sys::Platform::IMPL == :linux
         begin
           # First check to see if the command is available
-          MiqUtil.runcmd("virsh list")
+          AwesomeSpawn.run!("virsh", :params => ["list"])
           begin
-            xml_data = MiqUtil.runcmd("virsh dumpxml #{File.basename(filename, ".*")}")
+            xml_data = AwesomeSpawn.run!("virsh", :params => ["dumpxml", File.basename(filename, ".*")], :combined_output => true).output
           rescue => err
             $log.error "#{err}\n#{err.backtrace.join("\n")}"
           end

data/lib/metadata/linux/MiqRpmPackages.rb

@@ -1,11 +1,13 @@
 require 'binary_struct'
 require 'util/miq-hash_struct'
 require 'db/MiqBdb/MiqBdb'
-require 'util/miq-unicode'
+require 'miq_unicode'
 
 # RPM Specification located at: http://jrpm.sourceforge.net/rpmspec/index.html
 
 class MiqRpmPackages
+  using ManageIQ::UnicodeString
+
   #
   # The data types we support.
   #

data/lib/metadata/util/win32/Win32Accounts.rb

@@ -2,8 +2,11 @@
 
 require 'util/miq-xml'
 require 'enumerator'
+require 'miq_unicode'
 
 module MiqWin32
+  using ManageIQ::UnicodeString
+
   class Accounts
     attr_reader :users, :groups
 

data/lib/metadata/util/win32/Win32EventLog.rb

@@ -19,13 +19,15 @@ require 'digest/md5'
 
 # Common utilities.
 require 'binary_struct'
-require 'util/miq-unicode'
+require 'miq_unicode'
 require 'util/miq-xml'
 require 'util/miq-exception'
 
 require 'metadata/util/event_log_filter'
 
 class Win32EventLog
+  using ManageIQ::UnicodeString
+
   # Standard file log names
   SYSTEM_LOGS = %w(Application System Security)
   BUFFER_READ_SIZE = 10485760  # 10 MB buffer

data/lib/metadata/util/win32/Win32Software.rb

@@ -251,11 +251,13 @@ module MiqWin32
     end
 
     def self.DecodeProductKey(product_key)
-      return if product_key.blank? || product_key.length < 67
-      y = []; product_key.split(",")[52..67].each { |b| y << b.hex }
-      return MIQEncode.base24Decode(y)
+      parts = product_key.to_s.split(",")
+      return if parts.length < 67
+
+      ManageIQ::Smartstate::Util.base24_decode(parts[52..67].map(&:hex))
     rescue => err
       $log.error "MIQ(DecodeProductKey): [#{err}]"
+      nil
     end
 
     private

data/lib/metadata/util/win32/fleece_hives.rb

@@ -92,14 +92,6 @@ class FleeceHives
     xmlCol
   end
 
-  def self.DecodeProductKey(product_key)
-    return if product_key.blank? || product_key.length < 67
-    y = []; product_key.split(",")[52..67].each { |b| y << b.hex }
-    return MIQEncode.base24Decode(y)
-  rescue => err
-    $log.error "MIQ(OS-DecodeProductKey): [#{err}]"
-  end
-
   def self.collectProductKeys(_xml, xmlCol, regHnd)
     prodKeys = MIQRexml.findElement("software/productkeys", xmlCol.root)
     regHnd.digitalProductKeys.each do |e|

data/lib/metadata/util/win32/ms-registry.rb

@@ -1,7 +1,7 @@
 # encoding: US-ASCII
 
 require 'binary_struct'
-require 'util/miq-unicode'
+require 'miq_unicode'
 require 'enumerator'
 require 'util/miq-xml'
 require 'util/xml/xml_hash'
@@ -13,6 +13,8 @@ DEBUG_LOG_PERFORMANCE = false
 DEBUG_FILE_READS = false
 
 class MSRegHive
+  using ManageIQ::UnicodeString
+
   attr_reader :fileLoadTime, :fileParseTime, :digitalProductKeys, :xmlNode
 
   # Size of the HBIN data (as well as initiale REGF) segments

data/lib/metadata/util/win32/peheader.rb

@@ -1,9 +1,8 @@
 # encoding: US-ASCII
 
 require 'stringio'
-
 require 'binary_struct'
-require 'util/miq-unicode'
+require 'miq_unicode'
 
 # Notes:
 #       The peheader object member 'icons' is an array of icons in the file. Sub 0 is the application
@@ -12,6 +11,8 @@ require 'util/miq-unicode'
 #       to open them and display each resolution contained in the icon (if more than one).
 
 class PEheader
+  using ManageIQ::UnicodeString
+
   IMAGE_NT_SIGNATURE = "PE\0\0"
   IMAGE_DOS_SIGNATURE = "MZ"
 

data/lib/miq_unicode.rb

@@ -0,0 +1,45 @@
+module ManageIQ
+  module UnicodeString
+    refine String do
+      def UnicodeToUtf8
+        dup.UnicodeToUtf8!
+      end
+
+      def UnicodeToUtf8!
+        force_encoding("UTF-16LE").encode!("UTF-8")
+      end
+
+      def Utf8ToUnicode
+        dup.Utf8ToUnicode!
+      end
+
+      def Utf8ToUnicode!
+        force_encoding("UTF-8").encode!("UTF-16LE")
+      end
+
+      def AsciiToUtf8
+        dup.AsciiToUtf8!
+      end
+
+      def AsciiToUtf8!
+        force_encoding("ISO-8859-1").encode!("UTF-8")
+      end
+
+      def Utf8ToAscii
+        dup.Utf8ToAscii!
+      end
+
+      def Utf8ToAscii!
+        force_encoding("UTF-8").encode!("ISO-8859-1")
+      end
+
+      def Ucs2ToAscii
+        dup.Ucs2ToAscii!
+      end
+
+      def Ucs2ToAscii!
+        force_encoding("UTF-16LE").encode!("ISO-8859-1")
+      end
+    end
+  end
+end

data/manageiq-smartstate.gemspec

@@ -21,6 +21,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "activesupport"
+  spec.add_dependency "awesome_spawn",      "~> 1.5"
   spec.add_dependency "azure-armrest",      "~> 0.9"
   spec.add_dependency "binary_struct",      "~> 2.1"
   spec.add_dependency "iniparse"
@@ -33,13 +34,12 @@ Gem::Specification.new do |spec|
   spec.add_dependency "vmware_web_service", "~>2.0"
 
   spec.add_development_dependency "bundler"
+  spec.add_development_dependency "camcorder"
+  spec.add_development_dependency "codeclimate-test-reporter", "~> 1.0.0"
+  spec.add_development_dependency "manageiq-style"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "camcorder"
+  spec.add_development_dependency "simplecov"
   spec.add_development_dependency "vcr", "~>3.0.2"
   spec.add_development_dependency "webmock", "~>2.3.1"
-  spec.add_development_dependency "simplecov"
-  spec.add_development_dependency "rubocop"
-  spec.add_development_dependency "codeclimate-test-reporter", "~> 1.0.0"
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: manageiq-smartstate
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.7.0
 platform: ruby
 authors:
 - ManageIQ Developers
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-10-21 00:00:00.000000000 Z
+date: 2021-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: awesome_spawn
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.5'
 - !ruby/object:Gem::Dependency
   name: azure-armrest
   requirement: !ruby/object:Gem::Requirement
@@ -179,7 +193,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: camcorder
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -193,21 +207,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 1.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
-  name: camcorder
+  name: manageiq-style
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -221,33 +235,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: vcr
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.2
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.0.2
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: webmock
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.1
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.1
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -263,33 +277,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: vcr
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.0.2
 - !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 2.3.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 2.3.1
 description: ManageIQ SmartState Analysis
 email:
 executables: []
@@ -390,7 +404,6 @@ files:
 - lib/disk/modules/miq_dummy_disk.rb
 - lib/disk/modules/vhdx_bat_entry.rb
 - lib/disk/test.rb
-- lib/fs/MetakitFS/MetakitFS.rb
 - lib/fs/MiqFS/FsProbe.rb
 - lib/fs/MiqFS/MiqFS.rb
 - lib/fs/MiqFS/modules/AUFSProbe.rb
@@ -560,6 +573,7 @@ files:
 - lib/metadata/util/win32/Win32Software.rb
 - lib/metadata/util/win32/Win32System.rb
 - lib/metadata/util/win32/boot_info_win.rb
+- lib/metadata/util/win32/decode.rb
 - lib/metadata/util/win32/fleece_hives.rb
 - lib/metadata/util/win32/ms-registry.rb
 - lib/metadata/util/win32/peheader.rb
@@ -567,6 +581,7 @@ files:
 - lib/metadata/util/win32/system_path_win.rb
 - lib/metadata/util/win32/versioninfo.rb
 - lib/miq_tempfile.rb
+- lib/miq_unicode.rb
 - lib/tasks/azure.rake
 - log/.gitkeep
 - manageiq-smartstate.gemspec