manageiq-loggers 1.0.1 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d411d75a73f5d47de3de8080101e168c99265168eb34beef036a173955aa9823
-  data.tar.gz: '06163649ad33e5964c5d06f3ab369a1fa0e2fd9cf08d71ca70d0a14da6978420'
+  metadata.gz: 2a32bea06f89fab47efe8276e4a6bb8847a4bb319d5f720a0fefa8b8e4af84df
+  data.tar.gz: 9bb69c8569b7cd7c1f412ef61ee2b5b1c720ed8749b11bff4cb7d374c8db75ed
 SHA512:
-  metadata.gz: 84de0b21346b0bc7d805ee5987e6575eee4e7f2b405dea90454d5f41443b0b9ec80282fad209c26b3dbd63f9d69c18159eae5e65b1aac7f3722adf1685da6358
-  data.tar.gz: 52d917bf352a7df54e4993d043a7b9dd1f53e79f4c55456759dc3e850f9d66e30c49fb40cfa90e5b293099a00e03600cbb6ff11e0cc9ed82370a7ee94f4d592e
+  metadata.gz: 3bcc952f60b915db50ca50fb798d78ee80554849a6f36026550d235a4365f2ebba1908ec82a5035a529bdda56299a98196811e7bb29e815919a814f758bc39ad
+  data.tar.gz: aa68849ecdc51297a67e256e35b6cc894e0ed5d1a9a369997e28a2f5791ac8f4411aac8cf72a2fee3cd596ddcb38a1eda6a959b34e2b5c78a5cfb4a130221632

data/.github/workflows/ci.yaml

@@ -0,0 +1,33 @@
+name: CI
+
+on:
+  push:
+  pull_request:
+  schedule:
+  - cron: '0 0 * * 0'
+
+jobs:
+  ci:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version:
+        - '2.6'
+        - '2.7'
+        - '3.0'
+    env:
+      CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true
+      timeout-minutes: 30
+    - name: Run tests
+      run: bundle exec rake
+    - name: Report code coverage
+      if: ${{ github.ref == 'refs/heads/master' && matrix.ruby-version == '3.0' }}
+      continue-on-error: true
+      uses: paambaati/codeclimate-action@v5

data/.rspec

@@ -1,4 +1,3 @@
---format progress
+--require spec_helper
 --color
 --order random
---require spec_helper

data/.whitesource

@@ -0,0 +1,3 @@
+{
+  "settingsInheritedFrom": "ManageIQ/whitesource-config@master"
+}

data/CHANGELOG.md

@@ -5,6 +5,23 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+## [1.1.1] - 2023-12-13
+### Fixed
+- Fix Journald::Formatter's arguments list [(#61)](https://github.com/ManageIQ/manageiq-loggers/pull/61)
+- Fix missing ActiveSupport::Logger.broadcast [(#62)](https://github.com/ManageIQ/manageiq-loggers/pull/62)
+
+### Changed
+- Update actions/checkout version to v4 [(#60)](https://github.com/ManageIQ/manageiq-loggers/pull/60)
+- Update GitHub Actions versions [(#59)](https://github.com/ManageIQ/manageiq-loggers/pull/59)
+
+## [1.1.0] - 2022-11-14
+### Changed
+- Split out JSON logger from Container logger [(#49)](https://github.com/ManageIQ/manageiq-loggers/pull/49)
+- Allow passing the CloudWatch logger's configuration as kwargs [(#50)](https://github.com/ManageIQ/manageiq-loggers/pull/50)
+
+### Fixed
+- Remove timestamp whitespace in container logger formatter [(#47)](https://github.com/ManageIQ/manageiq-loggers/pull/47)
+
 ## [1.0.1] - 2021-01-05
 ### Fixed
 - Fix require issue when used with Rails 7 [(#42)](https://github.com/ManageIQ/manageiq-loggers/pull/42)
@@ -75,7 +92,9 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [0.1.0] - 2019-01-08
 
-[Unreleased]: https://github.com/ManageIQ/manageiq-loggers/compare/v1.0.1...master
+[Unreleased]: https://github.com/ManageIQ/manageiq-loggers/compare/v1.1.1...master
+[1.1.1]: https://github.com/ManageIQ/manageiq-loggers/compare/v1.1.0...v1.1.1
+[1.1.0]: https://github.com/ManageIQ/manageiq-loggers/compare/v1.0.1...v1.1.0
 [1.0.1]: https://github.com/ManageIQ/manageiq-loggers/compare/v1.0.0...v1.0.1
 [1.0.0]: https://github.com/ManageIQ/manageiq-loggers/compare/v0.8.0...v1.0.0
 [0.8.0]: https://github.com/ManageIQ/manageiq-loggers/compare/v0.7.0...v0.8.0

data/Gemfile

@@ -1,6 +1,4 @@
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
-
 # Specify your gem's dependencies in manageiq-loggers.gemspec
 gemspec

data/README.md

@@ -1,9 +1,8 @@
 # ManageIQ::Loggers
 
-[![Build Status](https://app.travis-ci.com/ManageIQ/manageiq-loggers.svg?branch=master)](https://app.travis-ci.com/ManageIQ/manageiq-loggers)
+[![CI](https://github.com/ManageIQ/manageiq-loggers/actions/workflows/ci.yaml/badge.svg)](https://github.com/ManageIQ/manageiq-loggers/actions/workflows/ci.yaml)
 [![Maintainability](https://api.codeclimate.com/v1/badges/8d3c9bf77c45a024166b/maintainability)](https://codeclimate.com/github/ManageIQ/manageiq-loggers/maintainability)
 [![Test Coverage](https://api.codeclimate.com/v1/badges/8d3c9bf77c45a024166b/test_coverage)](https://codeclimate.com/github/ManageIQ/manageiq-loggers/test_coverage)
-[![Security](https://hakiri.io/github/ManageIQ/manageiq-loggers/master.svg)](https://hakiri.io/github/ManageIQ/manageiq-loggers/master)
 
 Loggers for ManageIQ projects
 

data/lib/manageiq/loggers/cloud_watch.rb

@@ -7,19 +7,19 @@ module ManageIQ
     class CloudWatch < Base
       NAMESPACE_FILE = "/var/run/secrets/kubernetes.io/serviceaccount/namespace".freeze
 
-      def self.new(*args)
-        access_key_id     = ENV["CW_AWS_ACCESS_KEY_ID"].presence
-        secret_access_key = ENV["CW_AWS_SECRET_ACCESS_KEY"].presence
-        log_group_name    = ENV["CLOUD_WATCH_LOG_GROUP"].presence
-        log_stream_name   = ENV["HOSTNAME"].presence
+      def self.new(*args, access_key_id: nil, secret_access_key: nil, log_group: nil, log_stream: nil)
+        access_key_id     ||= ENV["CW_AWS_ACCESS_KEY_ID"].presence
+        secret_access_key ||= ENV["CW_AWS_SECRET_ACCESS_KEY"].presence
+        log_group         ||= ENV["CLOUD_WATCH_LOG_GROUP"].presence
+        log_stream        ||= ENV["HOSTNAME"].presence
 
         container_logger = ManageIQ::Loggers::Container.new
-        return container_logger unless access_key_id && secret_access_key && log_group_name && log_stream_name
+        return container_logger unless access_key_id && secret_access_key && log_group && log_stream
 
         require 'cloudwatchlogger'
 
         creds = {:access_key_id => access_key_id, :secret_access_key => secret_access_key}
-        cloud_watch_logdev = CloudWatchLogger::Client.new(creds, log_group_name, log_stream_name)
+        cloud_watch_logdev = CloudWatchLogger::Client.new(creds, log_group, log_stream)
         super(cloud_watch_logdev).tap { |logger| logger.extend(ActiveSupport::Logger.broadcast(container_logger)) }
       end
 

data/lib/manageiq/loggers/container.rb

@@ -1,79 +1,14 @@
 module ManageIQ
   module Loggers
-    class Container < Base
-      def initialize(logdev = STDOUT, *args)
+    class Container < JSONLogger
+      def initialize(logdev = $stdout, *_, **_)
         logdev.sync = true # Don't buffer container log output
-
         super
-
-        self.formatter = Formatter.new
       end
 
       def filename
         "STDOUT"
       end
-
-      class Formatter < Base::Formatter
-        SEVERITY_MAP = {
-          "DEBUG"   => "debug",
-          "INFO"    => "info",
-          "WARN"    => "warning",
-          "ERROR"   => "err",
-          "FATAL"   => "crit",
-          "UNKNOWN" => "unknown"
-          # Others that don't match up: alert emerg notice trace
-        }.freeze
-
-        def initialize
-          super
-          require 'json'
-        end
-
-        def call(severity, time, progname, msg)
-          # From https://github.com/ViaQ/elasticsearch-templates/releases -> Downloads -> *.asciidoc
-          # NOTE: These values are in a specific order for easier human readbility via STDOUT
-          payload = {
-            :@timestamp => format_datetime(time),
-            :hostname   => hostname,
-            :pid        => $PROCESS_ID,
-            :tid        => thread_id,
-            :service    => progname,
-            :level      => translate_error(severity),
-            :message    => prefix_task_id(msg2str(msg)),
-            :request_id => request_id
-            # :tags => "tags string",
-          }.compact
-          JSON.generate(payload) << "\n"
-        rescue Encoding::UndefinedConversionError
-          raise unless msg.encoding == Encoding::ASCII_8BIT
-
-          msg.force_encoding("UTF-8")
-          retry
-        end
-
-        private
-
-        def hostname
-          @hostname ||= ENV["HOSTNAME"]
-        end
-
-        def thread_id
-          Thread.current.object_id.to_s(16)
-        end
-
-        def translate_error(level)
-          SEVERITY_MAP[level] || "unknown"
-        end
-
-        def request_id
-          Thread.current[:request_id] || Thread.current[:current_request]&.request_id.tap do |request_id|
-            if request_id
-              require "active_support/deprecation"
-              ActiveSupport::Deprecation.warn("Usage of `Thread.current[:current_request]&.request_id` will be deprecated in version 0.5.0. Please switch to `Thread.current[:request_id]` to log request_id automatically.")
-            end
-          end
-        end
-      end
     end
   end
 end

data/lib/manageiq/loggers/journald.rb

@@ -39,7 +39,7 @@ module ManageIQ
           end
         end
 
-        message = formatter.call(format_severity(severity), progname, message)
+        message = formatter.call(format_severity(severity), nil, progname, message)
         caller_object = caller_locations(3, 1).first
 
         Systemd::Journal.message(
@@ -69,7 +69,7 @@ module ManageIQ
       end
 
       class Formatter < Base::Formatter
-        def call(severity, progname, msg)
+        def call(severity, _time, progname, msg)
           msg = prefix_task_id(msg2str(msg)).truncate(Base::MAX_LOG_LINE_LENGTH)
           "%5s -- %s: %s\n" % [severity, progname, msg]
         end

data/lib/manageiq/loggers/json_logger.rb

@@ -0,0 +1,77 @@
+module ManageIQ
+  module Loggers
+    class JSONLogger < Base
+     def initialize(*_, **_)
+        super
+        self.formatter = Formatter.new
+      end
+
+      class Formatter < Base::Formatter
+        SEVERITY_MAP = {
+          "DEBUG"   => "debug",
+          "INFO"    => "info",
+          "WARN"    => "warning",
+          "ERROR"   => "err",
+          "FATAL"   => "crit",
+          "UNKNOWN" => "unknown"
+          # Others that don't match up: alert emerg notice trace
+        }.freeze
+
+        def initialize
+          super
+          require 'json'
+        end
+
+        def call(severity, time, progname, msg)
+          # From https://github.com/ViaQ/elasticsearch-templates/releases -> Downloads -> *.asciidoc
+          # NOTE: These values are in a specific order for easier human readbility via STDOUT
+          payload = {
+            :@timestamp => format_datetime(time),
+            :hostname   => hostname,
+            :pid        => $PROCESS_ID,
+            :tid        => thread_id,
+            :service    => progname,
+            :level      => translate_error(severity),
+            :message    => prefix_task_id(msg2str(msg)),
+            :request_id => request_id
+            # :tags => "tags string",
+          }.compact
+          JSON.generate(payload) << "\n"
+        rescue Encoding::UndefinedConversionError
+          raise unless msg.encoding == Encoding::ASCII_8BIT
+
+          msg.force_encoding("UTF-8")
+          retry
+        end
+
+        private
+
+        def format_datetime(*)
+          super.rstrip
+        end
+
+        def hostname
+          @hostname ||= ENV["HOSTNAME"]
+        end
+
+        def thread_id
+          Thread.current.object_id.to_s(16)
+        end
+
+        def translate_error(level)
+          SEVERITY_MAP[level] || "unknown"
+        end
+
+        def request_id
+          Thread.current[:request_id] || Thread.current[:current_request]&.request_id.tap do |request_id|
+            if request_id
+              require "active_support"
+              require "active_support/deprecation"
+              ActiveSupport::Deprecation.warn("Usage of `Thread.current[:current_request]&.request_id` will be deprecated in version 0.5.0. Please switch to `Thread.current[:request_id]` to log request_id automatically.")
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/manageiq/loggers/version.rb

@@ -1,5 +1,5 @@
 module ManageIQ
   module Loggers
-    VERSION = "1.0.1".freeze
+    VERSION = "1.1.1".freeze
   end
 end

data/lib/manageiq/loggers.rb

@@ -1,5 +1,8 @@
 require "manageiq/loggers/base"
+require "manageiq/loggers/json_logger"
+
 require "manageiq/loggers/cloud_watch"
 require "manageiq/loggers/container"
 require "manageiq/loggers/journald"
+
 require "manageiq/loggers/version"

data/manageiq-loggers.gemspec

@@ -1,4 +1,3 @@
-
 lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "manageiq/loggers/version"
@@ -22,7 +21,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "activesupport",     ">= 5.0"
+  spec.add_runtime_dependency "activesupport",     ">= 5.0", "< 7.1"
   spec.add_runtime_dependency "manageiq-password", "< 2"
 
   spec.add_development_dependency "bundler"
@@ -30,6 +29,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "manageiq-style"
   spec.add_development_dependency "rake", ">= 12.3.3"
   spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "simplecov", ">= 0.21.2"
   spec.add_development_dependency "systemd-journal" if RbConfig::CONFIG['host_os'] =~ /linux/i
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: manageiq-loggers
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.1
 platform: ruby
 authors:
 - ManageIQ Authors
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-01-05 00:00:00.000000000 Z
+date: 2023-12-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -17,6 +17,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -24,6 +27,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: manageiq-password
   requirement: !ruby/object:Gem::Requirement
@@ -110,6 +116,20 @@ dependencies:
         version: '3.0'
 - !ruby/object:Gem::Dependency
   name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.21.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.21.2
+- !ruby/object:Gem::Dependency
+  name: systemd-journal
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -129,12 +149,13 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
+- ".github/workflows/ci.yaml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_cc.yml"
 - ".rubocop_local.yml"
-- ".travis.yml"
+- ".whitesource"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -148,6 +169,7 @@ files:
 - lib/manageiq/loggers/cloud_watch.rb
 - lib/manageiq/loggers/container.rb
 - lib/manageiq/loggers/journald.rb
+- lib/manageiq/loggers/json_logger.rb
 - lib/manageiq/loggers/version.rb
 - manageiq-loggers.gemspec
 homepage: https://github.com/ManageIQ/manageiq-loggers
@@ -169,7 +191,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.4.20
 signing_key:
 specification_version: 4
 summary: Loggers for ManageIQ projects

data/.travis.yml

@@ -1,14 +0,0 @@
----
-language: ruby
-dist: bionic
-cache: bundler
-rvm:
-- 2.6.8
-- 2.7.4
-- 3.0.2
-before_script:
-- curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
-- chmod +x ./cc-test-reporter
-- "./cc-test-reporter before-build"
-after_script:
-- "./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT"