manageiq-api-client 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2cf72edce682a6dd72ea4e953b17db64d99cd5c32c9d768f1d41bf8c4b09b888
-  data.tar.gz: 1b2df1d7796fa18e4d20c00355b6505566dac1bd5454ca70b71ed80204832ec7
+  metadata.gz: 6403e45890ae054ae7a12596ab68ad0dbe0e03861f2e700fd5079c5af9d69529
+  data.tar.gz: 7cbe8890af71641ea6ec6b6b8374b719bc425b79eec850161f43d32ca544c1d4
 SHA512:
-  metadata.gz: 9591e051844cf72bcd26df553c0e4c745b7a430111cdbc3c5e5ef3e0aa25a3b78d3a9479b3821f8a1e9d1055c3256f2b8bd9c352ed34656a35cb0c58e4a60e94
-  data.tar.gz: ae40d2fefa9a9dcd234b0f158c2dd2dec3440c0c2ddf72143bb176eb221736c14b153aa10093e801e4210e36b648071c95f2b30bd71d8d1e6a1eec4c1a9f7f4c
+  metadata.gz: d61707917158f04f8d4ac00c3cf46c1d6e89c8b75b74a8a9ab8536c1df6f9c54f5430ecf416e8e2b9062d4b79452d22536824185acdc5feedc65772c2c239135
+  data.tar.gz: 8476cecd2949d77e0d2809e124f513f36fa612cf6fff5715ed6f398176f8bd8dd4e36ce196f4f4994e5f9196475e4dcc98e5744bcbd03e2fc71b07e339b10b5f

data/.codeclimate.yml

@@ -12,5 +12,5 @@ plugins:
   rubocop:
     enabled: true
     config: ".rubocop_cc.yml"
-    channel: rubocop-0-82
+    channel: rubocop-1-56-3
 version: '2'

data/.github/workflows/ci.yaml

@@ -12,12 +12,12 @@ jobs:
     strategy:
       matrix:
         ruby-version:
-        - '2.6'
-        - '2.7'
         - '3.0'
+        - '3.1'
         rails-version:
         - '6.0'
         - '6.1'
+        - '7.0'
     env:
       TEST_RAILS_VERSION: ${{ matrix.rails-version }}
       CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
@@ -34,4 +34,4 @@ jobs:
     - name: Report code coverage
       if: ${{ github.ref == 'refs/heads/master' && matrix.ruby-version == '3.0' && matrix.rails-version == '6.1' }}
       continue-on-error: true
-      uses: paambaati/codeclimate-action@v5
+      uses: paambaati/codeclimate-action@v6

data/CHANGELOG.md

@@ -6,6 +6,20 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+## [0.5.0] - 2024-05-13
+### Changed
+- Support faraday 1.0 and 2.0 [[#124]](https://github.com/ManageIQ/manageiq-api-client/pull/124)
+- Upgrade faraday from 1.0 to 2.0 [[#122]](https://github.com/ManageIQ/manageiq-api-client/pull/122)
+- Revert "drop activesupport dependency" [[#119]](https://github.com/ManageIQ/manageiq-api-client/pull/119)
+
+### Fixed
+- Raise exceptions on empty responses [[#121]](https://github.com/ManageIQ/manageiq-api-client/pull/121)
+
+## [0.4.1] - 2024-03-06
+### Added
+- Drop active_support and more_core_extensions dependency [[#115]](https://github.com/ManageIQ/manageiq-api-client/pull/115)
+- Add rails 7 support [[#114]](https://github.com/ManageIQ/manageiq-api-client/pull/114)
+
 ## [0.4.0] - 2023-10-16
 ### Added
 - Add Bearer token support [[#113]](https://github.com/ManageIQ/manageiq-api-client/pull/113)
@@ -65,7 +79,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Add CHANGELOG.md
 - Update README with simple instructions reflecting the query interface.
 
-[Unreleased]: https://github.com/ManageIQ/manageiq-api-client/compare/v0.4.0...HEAD
+[Unreleased]: https://github.com/ManageIQ/manageiq-api-client/compare/v0.5.0...HEAD
+[0.5.0]: https://github.com/ManageIQ/manageiq-api-client/compare/v0.4.1...v0.5.0
+[0.4.1]: https://github.com/ManageIQ/manageiq-api-client/compare/v0.4.0...v0.4.1
 [0.4.0]: https://github.com/ManageIQ/manageiq-api-client/compare/v0.3.7...v0.4.0
 [0.3.7]: https://github.com/ManageIQ/manageiq-api-client/compare/v0.3.6...v0.3.7
 [0.3.6]: https://github.com/ManageIQ/manageiq-api-client/compare/v0.3.5...v0.3.6

data/Gemfile

@@ -7,9 +7,14 @@ gemspec
 dev_gemfile = File.expand_path("Gemfile.dev.rb", __dir__)
 eval_gemfile(dev_gemfile) if File.exist?(dev_gemfile)
 
-case ENV['TEST_RAILS_VERSION']
-when "6.0"
-  gem "activesupport", "~>6.0.4"
-when "6.1"
-  gem "activesupport", "~>6.1.4"
-end
+minimum_version =
+  case ENV['TEST_RAILS_VERSION']
+  when "6.0"
+    "~>6.0.4"
+  when "7.0"
+    "~>7.0.8"
+  else
+    "~>6.1.4"
+  end
+
+gem "activesupport", minimum_version

data/lib/manageiq/api/client/client.rb

@@ -1,6 +1,7 @@
 module ManageIQ
   module API
     class Client
+      extend Forwardable
       attr_reader :client_options
       attr_reader :logger
       attr_reader :url
@@ -62,7 +63,7 @@ module ManageIQ
         load_definitions
       end
 
-      delegate :get, :post, :put, :patch, :delete, :options, :error, :to => :connection
+      def_delegators :connection, :get, :post, :put, :patch, :delete, :options, :error
 
       private
 

data/lib/manageiq/api/client/connection.rb

@@ -2,6 +2,8 @@ module ManageIQ
   module API
     class Client
       class Connection
+        extend Forwardable
+
         attr_reader :url
         attr_reader :authentication
         attr_reader :client
@@ -9,7 +11,7 @@ module ManageIQ
         attr_reader :response
         attr_reader :error
 
-        delegate :url, :authentication, :to => :client
+        def_delegators :client, :url, :authentication
 
         API_PREFIX = "/api".freeze
         CONTENT_TYPE = "application/json".freeze
@@ -58,12 +60,12 @@ module ManageIQ
         end
 
         def api_path(path)
-          if path.to_s.starts_with?(url.to_s)
+          if path.to_s.start_with?(url.to_s)
             path.to_s
           elsif path.to_s.blank?
             URI.join(url, API_PREFIX).to_s
           else
-            URI.join(url, path.to_s.starts_with?(API_PREFIX) ? path.to_s : "#{API_PREFIX}/#{path}").to_s
+            URI.join(url, path.to_s.start_with?(API_PREFIX) ? path.to_s : "#{API_PREFIX}/#{path}").to_s
           end
         end
 
@@ -74,10 +76,17 @@ module ManageIQ
             faraday.options.open_timeout = @connection_options[:open_timeout] if @connection_options[:open_timeout]
             faraday.options.timeout      = @connection_options[:timeout]      if @connection_options[:timeout]
             faraday.response(:logger, client.logger)
-            faraday.use FaradayMiddleware::FollowRedirects, :limit => 3, :standards_compliant => true
-            faraday.adapter(Faraday.default_adapter) # make requests with Net::HTTP
+            faraday.response(:follow_redirects, :limit => 3, :standards_compliant => true)
+            # make requests with Net::HTTP
+            faraday.adapter(Faraday.default_adapter)
             if authentication.token.blank? && authentication.miqtoken.blank? && authentication.bearer_token.blank?
-              faraday.basic_auth(authentication.user, authentication.password)
+              if faraday.respond_to?(:basic_auth)
+                # faraday 1.0
+                faraday.basic_auth(authentication.user, authentication.password)
+              else
+                # faraday 2.0
+                faraday.request(:authorization, :basic, authentication.user, authentication.password)
+              end
             end
           end
         end
@@ -105,11 +114,11 @@ module ManageIQ
 
         def check_response
           if response.status == 404
-            message = json_response.fetch_path("error", "message") || json_response["error"]
+            message = json_response["error"].kind_of?(String) ? json_response["error"] : json_response.dig("error", "message")
             raise ManageIQ::API::Client::ResourceNotFound, message
           elsif response.status >= 400
             @error = ManageIQ::API::Client::Error.new(response.status, json_response)
-            raise @error.message
+            raise ManageIQ::API::Client::Exception, @error.message || "Empty Response"
           end
         end
       end

data/lib/manageiq/api/client/resource.rb

@@ -2,6 +2,7 @@ module ManageIQ
   module API
     class Client
       class Resource
+        extend Forwardable
         include ActionMixin
 
         CUSTOM_INSPECT_EXCLUSIONS = [:@collection].freeze
@@ -21,7 +22,7 @@ module ManageIQ
         attr_reader :collection
         attr_reader :actions
 
-        delegate :client, :to => :collection
+        def_delegators :collection, :client
 
         def initialize(collection, resource_hash)
           raise "Cannot instantiate a Resource directly" if instance_of?(Resource)

data/lib/manageiq/api/client/version.rb

@@ -1,7 +1,7 @@
 module ManageIQ
   module API
     class Client
-      VERSION = "0.4.0".freeze
+      VERSION = "0.5.0".freeze
     end
   end
 end

data/lib/manageiq/api/client.rb

@@ -1,10 +1,9 @@
 require "active_support"
 require "active_support/core_ext"
 require "faraday"
-require "faraday_middleware"
+require "faraday/follow_redirects"
+require 'forwardable'
 require "json"
-require "more_core_extensions/all"
-require "pp"
 require "query_relation"
 
 require "manageiq/api/client/client"

data/manageiq-api-client.gemspec

@@ -23,11 +23,10 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activesupport", ">= 5.0", "< 7.0"
-  spec.add_dependency "faraday", "~> 1.0"
-  spec.add_dependency "faraday_middleware", "~> 1.0"
+  spec.add_dependency "activesupport", ">= 6.0", "<7.1"
+  spec.add_dependency "faraday", ">= 1.0", "< 3.0"
+  spec.add_dependency "faraday-follow_redirects"
   spec.add_dependency "json", "~> 2.3"
-  spec.add_dependency "more_core_extensions"
   spec.add_dependency "query_relation"
 
   spec.add_development_dependency "bundler"

data/renovate.json

@@ -0,0 +1,6 @@
+{
+  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
+  "extends": [
+    "config:recommended"
+  ]
+}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: manageiq-api-client
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Alberto Bellotti
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-10-16 00:00:00.000000000 Z
+date: 2024-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -17,48 +17,54 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: faraday_middleware
+  name: faraday-follow_redirects
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
@@ -73,20 +79,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.3'
-- !ruby/object:Gem::Dependency
-  name: more_core_extensions
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: query_relation
   requirement: !ruby/object:Gem::Requirement
@@ -233,6 +225,7 @@ files:
 - lib/manageiq/api/client/version.rb
 - lib/manageiq_api_client.rb
 - manageiq-api-client.gemspec
+- renovate.json
 homepage: http://github.com/ManageIQ/manageiq-api-client
 licenses:
 - MIT
@@ -252,7 +245,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
+rubygems_version: 3.3.27
 signing_key:
 specification_version: 4
 summary: ManageIQ API Client