make_voteable 0.1.0 → 0.1.1

data/lib/make_voteable/version.rb

@@ -1,3 +1,3 @@
 module MakeVoteable
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/make_voteable/voter.rb

@@ -40,6 +40,8 @@ module MakeVoteable
         voteable.save
         voting.save
       end
+
+      true
     end
 
     # Up votes the +voteable+, but doesn't raise an error if the votelable was already up voted.
@@ -47,8 +49,11 @@ module MakeVoteable
     def up_vote!(voteable)
       begin
         up_vote(voteable)
+        success = true
       rescue Exceptions::AlreadyVotedError
+        success = false
       end
+      success
     end
 
     # Down vote a +voteable+.
@@ -79,6 +84,8 @@ module MakeVoteable
         voteable.save
         voting.save
       end
+
+      true
     end
 
     # Down votes the +voteable+, but doesn't raise an error if the votelable was already down voted.
@@ -86,8 +93,11 @@ module MakeVoteable
     def down_vote!(voteable)
       begin
         down_vote(voteable)
+        success = true
       rescue Exceptions::AlreadyVotedError
+        success = false
       end
+      success
     end
 
     # Clears an already done vote on a +voteable+.
@@ -112,6 +122,8 @@ module MakeVoteable
         voteable.save
         voting.destroy
       end
+
+      true
     end
 
     # Clears an already done vote on a +voteable+, but doesn't raise an error if
@@ -119,8 +131,11 @@ module MakeVoteable
     def unvote!(voteable)
       begin
         unvote(voteable)
+        success = true
       rescue Exceptions::NotVotedError
+        success = false
       end
+      success
     end
 
     # Returns true if the voter voted for the +voteable+.
@@ -134,6 +149,7 @@ module MakeVoteable
     def up_voted?(voteable)
       check_voteable(voteable)
       voting = fetch_voting(voteable)
+      return false if voting.nil?
       return true if voting.has_attribute?(:up_vote) && voting.up_vote
       false
     end
@@ -142,6 +158,7 @@ module MakeVoteable
     def down_voted?(voteable)
       check_voteable(voteable)
       voting = fetch_voting(voteable)
+      return false if voting.nil?
       return true if voting.has_attribute?(:up_vote) && !voting.up_vote
       false
     end

data/make_voteable.gemspec

@@ -14,10 +14,10 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = ">= 1.3.6"
   s.rubyforge_project         = "make_voteable"
 
-  s.add_dependency "activerecord", "~> 3.0.0"
+  s.add_dependency "activerecord", "~> 3.0"
   s.add_development_dependency "bundler", "~> 1.0.0"
   s.add_development_dependency "rspec", "~> 2.5.0"
-  s.add_development_dependency "database_cleaner", "0.6.7.RC"
+  s.add_development_dependency "database_cleaner", "0.6.7"
   s.add_development_dependency "sqlite3-ruby", "~> 1.3.0"
   s.add_development_dependency "generator_spec", "~> 0.8.2"
 

data/spec/lib/make_voteable_spec.rb

@@ -17,11 +17,11 @@ describe "Make Voteable" do
   end
 
   it "should get correct vote summary" do
-    @voter.up_vote(@voteable)
+    @voter.up_vote(@voteable).should == true
     @voteable.votes.should == 1
-    @voter.down_vote(@voteable)
+    @voter.down_vote(@voteable).should == true
     @voteable.votes.should == -1
-    @voter.unvote(@voteable)
+    @voter.unvote(@voteable).should == true
     @voteable.votes.should == 0
   end
 
@@ -83,7 +83,9 @@ describe "Make Voteable" do
 
     it "should only allow a voter to up vote a voteable once without raising an error" do
       @voter.up_vote!(@voteable)
-      lambda { @voter.up_vote!(@voteable) }.should_not raise_error(MakeVoteable::Exceptions::AlreadyVotedError)
+      lambda {
+        @voter.up_vote!(@voteable).should == false
+      }.should_not raise_error(MakeVoteable::Exceptions::AlreadyVotedError)
       MakeVoteable::Voting.count.should == 1
     end
 
@@ -155,7 +157,9 @@ describe "Make Voteable" do
 
     it "should only allow a voter to down vote a voteable once without raising an error" do
       @voter.down_vote!(@voteable)
-      lambda { @voter.down_vote!(@voteable) }.should_not raise_error(MakeVoteable::Exceptions::AlreadyVotedError)
+      lambda {
+        @voter.down_vote!(@voteable).should == false
+      }.should_not raise_error(MakeVoteable::Exceptions::AlreadyVotedError)
       MakeVoteable::Voting.count.should == 1
     end
 
@@ -219,7 +223,9 @@ describe "Make Voteable" do
     end
 
     it "should not raise error if voter didn't vote for the voteable and unvote! is called" do
-      lambda { @voter.unvote!(@voteable) }.should_not raise_error(MakeVoteable::Exceptions::NotVotedError)
+      lambda {
+        @voter.unvote!(@voteable).should == false
+      }.should_not raise_error(MakeVoteable::Exceptions::NotVotedError)
     end
 
     it "should raise an error for an invalid voteable" do

metadata

@@ -2,7 +2,7 @@
 name: make_voteable
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors: 
 - Kai Schlamp
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-16 00:00:00 +02:00
+date: 2011-07-25 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -21,7 +21,7 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        version: 3.0.0
+        version: "3.0"
   type: :runtime
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
@@ -54,7 +54,7 @@ dependencies:
     requirements: 
     - - "="
       - !ruby/object:Gem::Version 
-        version: 0.6.7.RC
+        version: 0.6.7
   type: :development
   version_requirements: *id004
 - !ruby/object:Gem::Dependency