make_voteable 0.0.2 → 0.1.0

data/.gitignore

@@ -1,5 +1,4 @@
 Gemfile.lock
-nbproject/*
 pkg/*
 doc/*
 *.gem

data/README.rdoc

@@ -26,7 +26,7 @@ also add +up_votes+ and +down_votes+ columns to the voter (e.g. User) and voteab
 
 migrate the database
 
-  rails db:migrate
+  rake db:migrate
 
 == Usage
 
@@ -90,6 +90,14 @@ migrate the database
   # Returns true if the question was down voted by the user, false otherwise
   user.down_voted?(question)
 
+  # Access votings through voter
+  voting = user.votings.first
+  voting.up_vote? # true if up vote, false if down vote
+
+  # Access votings through voteable
+  voting = question.votings.first
+  voting.up_vote? # true if up vote, false if down vote
+
 == Testing
 
 MakeVoteable uses RSpec for testing and has a rake task for executing the provided specs

data/Rakefile

@@ -3,3 +3,5 @@ Bundler::GemHelper.install_tasks
 
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec)
+
+task :default => :spec

data/lib/make_voteable/exceptions.rb

@@ -4,29 +4,25 @@ module MakeVoteable
       attr_reader :up_vote
 
       def initialize(up_vote)
-        @up_vote = up_vote
-      end
-      
-      def message
-        if @up_vote
-          vote = "up voted"
+        vote = if up_vote
+          "up voted"
         else
-          vote = "down voted"
+          "down voted"
         end
 
-        "The voteable was already #{vote} by the voter."
+        super "The voteable was already #{vote} by the voter."
       end
     end
 
     class NotVotedError < StandardError
-      def message
-        "The voteable was not voted by the voter."
+      def initialize
+        super "The voteable was not voted by the voter."
       end
     end
 
     class InvalidVoteableError < StandardError
-      def message
-        "Invalid voteable."
+      def initialize
+        super "Invalid voteable."
       end
     end
   end

data/lib/make_voteable/version.rb

@@ -1,3 +1,3 @@
 module MakeVoteable
-  VERSION = "0.0.2"
+  VERSION = "0.1.0"
 end

data/lib/make_voteable/voteable.rb

@@ -2,6 +2,10 @@ module MakeVoteable
   module Voteable
     extend ActiveSupport::Concern
 
+    included do
+      has_many :votings, :class_name => "MakeVoteable::Voting", :as => :voteable
+    end
+
     module ClassMethods
       def voteable?
         true

data/lib/make_voteable/voter.rb

@@ -2,6 +2,10 @@ module MakeVoteable
   module Voter
     extend ActiveSupport::Concern
 
+    included do
+      has_many :votings, :class_name => "MakeVoteable::Voting", :as => :voter
+    end
+
     module ClassMethods
       def voter?
         true
@@ -18,21 +22,21 @@ module MakeVoteable
 
       if voting
         if voting.up_vote
-          raise MakeVoteable::Exceptions::AlreadyVotedError.new(true)
+          raise Exceptions::AlreadyVotedError.new(true)
         else
           voting.up_vote = true
           voteable.down_votes -= 1
-          self.down_votes -= 1 if self.has_attribute?(:down_votes)
+          self.down_votes -= 1 if has_attribute?(:down_votes)
         end
       else
         voting = Voting.create(:voteable => voteable, :voter => self, :up_vote => true)
       end
 
       voteable.up_votes += 1
-      self.up_votes += 1 if self.has_attribute?(:up_votes)
+      self.up_votes += 1 if has_attribute?(:up_votes)
 
-      MakeVoteable::Voting.transaction do
-        self.save
+      Voting.transaction do
+        save
         voteable.save
         voting.save
       end
@@ -43,7 +47,7 @@ module MakeVoteable
     def up_vote!(voteable)
       begin
         up_vote(voteable)
-      rescue MakeVoteable::Exceptions::AlreadyVotedError
+      rescue Exceptions::AlreadyVotedError
       end
     end
 
@@ -57,21 +61,21 @@ module MakeVoteable
 
       if voting
         unless voting.up_vote
-          raise MakeVoteable::Exceptions::AlreadyVotedError.new(false)
+          raise Exceptions::AlreadyVotedError.new(false)
         else
           voting.up_vote = false
           voteable.up_votes -= 1
-          self.up_votes -= 1 if self.has_attribute?(:up_votes)
+          self.up_votes -= 1 if has_attribute?(:up_votes)
         end
       else
         voting = Voting.create(:voteable => voteable, :voter => self, :up_vote => false)
       end
 
       voteable.down_votes += 1
-      self.down_votes += 1 if self.has_attribute?(:down_votes)
+      self.down_votes += 1 if has_attribute?(:down_votes)
 
-      MakeVoteable::Voting.transaction do
-        self.save
+      Voting.transaction do
+        save
         voteable.save
         voting.save
       end
@@ -82,7 +86,7 @@ module MakeVoteable
     def down_vote!(voteable)
       begin
         down_vote(voteable)
-      rescue MakeVoteable::Exceptions::AlreadyVotedError
+      rescue Exceptions::AlreadyVotedError
       end
     end
 
@@ -93,18 +97,18 @@ module MakeVoteable
 
       voting = fetch_voting(voteable)
 
-      raise MakeVoteable::Exceptions::NotVotedError unless voting
+      raise Exceptions::NotVotedError unless voting
 
       if voting.up_vote
         voteable.up_votes -= 1
-        self.up_votes -= 1 if self.has_attribute?(:up_votes)
+        self.up_votes -= 1 if has_attribute?(:up_votes)
       else
         voteable.down_votes -= 1
-        self.down_votes -= 1 if self.has_attribute?(:down_votes)
+        self.down_votes -= 1 if has_attribute?(:down_votes)
       end
 
-      MakeVoteable::Voting.transaction do
-        self.save
+      Voting.transaction do
+        save
         voteable.save
         voting.destroy
       end
@@ -115,7 +119,7 @@ module MakeVoteable
     def unvote!(voteable)
       begin
         unvote(voteable)
-      rescue MakeVoteable::Exceptions::NotVotedError
+      rescue Exceptions::NotVotedError
       end
     end
 
@@ -153,7 +157,7 @@ module MakeVoteable
     end
 
     def check_voteable(voteable)
-      raise MakeVoteable::Exceptions::InvalidVoteableError unless voteable.class.voteable?
+      raise Exceptions::InvalidVoteableError unless voteable.class.voteable?
     end
   end
 end

data/make_voteable.gemspec

@@ -14,11 +14,12 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = ">= 1.3.6"
   s.rubyforge_project         = "make_voteable"
 
-  s.add_dependency "activerecord", ">= 3.0.0"
-  s.add_development_dependency "bundler", ">= 1.0.0"
-  s.add_development_dependency "rspec", ">= 2.0.0"
-  s.add_development_dependency "database_cleaner", "0.5.2"
-  s.add_development_dependency "sqlite3-ruby", ">= 1.3.0"
+  s.add_dependency "activerecord", "~> 3.0.0"
+  s.add_development_dependency "bundler", "~> 1.0.0"
+  s.add_development_dependency "rspec", "~> 2.5.0"
+  s.add_development_dependency "database_cleaner", "0.6.7.RC"
+  s.add_development_dependency "sqlite3-ruby", "~> 1.3.0"
+  s.add_development_dependency "generator_spec", "~> 0.8.2"
 
   s.files        = `git ls-files`.split("\n")
   s.executables  = `git ls-files`.split("\n").map{|f| f =~ /^bin\/(.*)/ ? $1 : nil}.compact

data/spec/generators/make_voteable_generator_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+require 'action_controller'
+require 'generator_spec/test_case'
+require 'generators/make_voteable/make_voteable_generator'
+
+describe MakeVoteableGenerator do
+  include GeneratorSpec::TestCase
+  destination File.expand_path("/tmp", __FILE__)
+  tests MakeVoteableGenerator
+
+  before do
+    prepare_destination
+    run_generator
+  end
+
+  specify do
+    destination_root.should have_structure {
+      directory "db" do
+        directory "migrate" do
+          migration "create_make_voteable_tables" do
+            contains "class CreateMakeVoteableTables"
+            contains "create_table :votings"
+          end
+        end
+      end
+    }
+  end
+end

data/spec/lib/make_voteable_spec.rb

@@ -25,6 +25,34 @@ describe "Make Voteable" do
     @voteable.votes.should == 0
   end
 
+  it "voteable should have up vote votings" do
+    @voteable.votings.length.should == 0
+    @voter.up_vote(@voteable)
+    @voteable.votings.reload.length.should == 1
+    @voteable.votings[0].up_vote?.should be_true
+  end
+
+  it "voter should have up vote votings" do
+    @voter.votings.length.should == 0
+    @voter.up_vote(@voteable)
+    @voter.votings.reload.length.should == 1
+    @voter.votings[0].up_vote?.should be_true
+  end
+
+  it "voteable should have down vote votings" do
+    @voteable.votings.length.should == 0
+    @voter.down_vote(@voteable)
+    @voteable.votings.reload.length.should == 1
+    @voteable.votings[0].up_vote?.should be_false
+  end
+
+  it "voter should have down vote votings" do
+    @voter.votings.length.should == 0
+    @voter.down_vote(@voteable)
+    @voter.votings.reload.length.should == 1
+    @voter.votings[0].up_vote?.should be_false
+  end
+
   describe "up vote" do
     it "should increase up votes of voteable by one" do
       @voteable.up_votes.should == 0

data/spec/spec_helper.rb

@@ -27,12 +27,8 @@ RSpec.configure do |config|
   config.mock_with :rspec
 
   config.before(:suite) do
-    DatabaseCleaner.strategy = :transaction
-    DatabaseCleaner.clean_with(:truncation)
-  end
-
-  config.before(:each) do
-    DatabaseCleaner.start
+    DatabaseCleaner.strategy = :truncation
+    DatabaseCleaner.clean
   end
 
   config.after(:each) do

metadata

@@ -1,13 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: make_voteable
 version: !ruby/object:Gem::Version 
-  hash: 27
   prerelease: 
-  segments: 
-  - 0
-  - 0
-  - 2
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors: 
 - Kai Schlamp
@@ -15,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-10 00:00:00 +01:00
+date: 2011-06-16 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -24,13 +19,8 @@ dependencies:
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 3
-        - 0
-        - 0
         version: 3.0.0
   type: :runtime
   version_requirements: *id001
@@ -40,13 +30,8 @@ dependencies:
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
-        hash: 23
-        segments: 
-        - 1
-        - 0
-        - 0
         version: 1.0.0
   type: :development
   version_requirements: *id002
@@ -56,14 +41,9 @@ dependencies:
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
-        hash: 15
-        segments: 
-        - 2
-        - 0
-        - 0
-        version: 2.0.0
+        version: 2.5.0
   type: :development
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
@@ -74,12 +54,7 @@ dependencies:
     requirements: 
     - - "="
       - !ruby/object:Gem::Version 
-        hash: 15
-        segments: 
-        - 0
-        - 5
-        - 2
-        version: 0.5.2
+        version: 0.6.7.RC
   type: :development
   version_requirements: *id004
 - !ruby/object:Gem::Dependency 
@@ -88,16 +63,22 @@ dependencies:
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
-        hash: 27
-        segments: 
-        - 1
-        - 3
-        - 0
         version: 1.3.0
   type: :development
   version_requirements: *id005
+- !ruby/object:Gem::Dependency 
+  name: generator_spec
+  prerelease: false
+  requirement: &id006 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        version: 0.8.2
+  type: :development
+  version_requirements: *id006
 description: A user-centric voting extension for Rails 3 applications.
 email: 
 - schlamp@gmx.de
@@ -124,6 +105,7 @@ files:
 - make_voteable.gemspec
 - spec/database.yml
 - spec/database.yml.sample
+- spec/generators/make_voteable_generator_spec.rb
 - spec/lib/make_voteable_spec.rb
 - spec/models.rb
 - spec/schema.rb
@@ -142,25 +124,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 23
-      segments: 
-      - 1
-      - 3
-      - 6
       version: 1.3.6
 requirements: []
 
 rubyforge_project: make_voteable
-rubygems_version: 1.4.2
+rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
 summary: Rails 3 voting extension